Repository navigation
test(website): cover the Re-shoot take caption - #20736
mariana953 wants to merge 1 commit into
Conversation
The caption under the picture names the take the reader is standing on and says nothing while they are aiming. Both halves were unguarded: the suite selected takes and read their buttons, but never the caption. Carried forward from #19423, which had this case and 496 commits of drift around it, rewritten against the component as it stands.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since cf1ec2e64810320ee6a6338dfb47a24fa84fcf37
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-20736.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-74phnz2k0-comfyui.vercel.app Last updated: 2026-10-10T20:54:43Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20736 +/- ##
==========================================
- Coverage 86.07% 85.95% -0.13%
==========================================
Files 3632 3528 -104
Lines 173392 170162 -3230
Branches 47846 46744 -1102
==========================================
- Hits 149242 146257 -2985
+ Misses 22143 22053 -90
+ Partials 2007 1852 -155
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
Carries forward the one live case from #19423, which is closed: the e2e half of that PR was already on
main, and the branch had 496 commits of drift around a single unit test. This writes that test fresh against the component as it stands.The caption under the picture names the take the reader is standing on and says nothing while they are aiming. Both halves were unguarded — the suite selects takes and reads their buttons, but never read the caption.
Review Focus
ReshootStudio.test.ts.Verification
ReshootStudio.test.ts9/9. Mutation-tested so the case is not vacuous:''instead oftakeLabel(current, locale)currentfalls back to the last take instead of clearingeslint and oxfmt clean.
Generated by Claude Code