Skip to content

test(website): cover the Re-shoot take caption - #20736

Open
mariana953 wants to merge 1 commit into
mainfrom
mariana/reshoot-take-caption
Open

mariana953 wants to merge 1 commit into
mainfrom
mariana/reshoot-take-caption

Conversation

@mariana953

Copy link
Copy Markdown
Contributor

Summary

Carries forward the one live case from #19423, which is closed: the e2e half of that PR was already on main, and the branch had 496 commits of drift around a single unit test. This writes that test fresh against the component as it stands.

The caption under the picture names the take the reader is standing on and says nothing while they are aiming. Both halves were unguarded — the suite selects takes and reads their buttons, but never read the caption.

Review Focus

  • Nothing ships to a visitor. One case in ReshootStudio.test.ts.

Verification

ReshootStudio.test.ts 9/9. Mutation-tested so the case is not vacuous:

mutation in the component result
the caption renders '' instead of takeLabel(current, locale) 1 failed, this case alone
current falls back to the last take instead of clearing 2 failed, this case among them

eslint and oxfmt clean.


Generated by Claude Code

The caption under the picture names the take the reader is standing on
and says nothing while they are aiming. Both halves were unguarded: the
suite selected takes and read their buttons, but never the caption.

Carried forward from #19423, which had this case and 496 commits of
drift around it, rewritten against the component as it stands.
@mariana953
mariana953 requested a review from a team October 10, 2026 20:52
@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since cf1ec2e64810320ee6a6338dfb47a24fa84fcf37

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-20736.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-74phnz2k0-comfyui.vercel.app

Last updated: 2026-10-10T20:54:43Z for e6d66c7

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f3ccf50d-e8ba-4106-a751-299413ef229c

📥 Commits

Reviewing files that changed from the base of the PR and between cf1ec2e and e6d66c7.


📒 Files selected for processing (1)
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootStudio.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.



📝 Walkthrough

Walkthrough

Adds a test that checks the take caption after selecting a take and after selecting Aim.

Changes

Reshoot take caption

Layer / File(s) Summary
Verify take caption states
apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootStudio.test.ts
The test checks that the selected take’s name and angle appear in the caption, then checks that the caption is empty after selecting Aim.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: drjkl


Merge Risk: ⚪ Minimal · up to e6d66

This change adds regression coverage for the selected-take caption and its empty state after Aim, without changing visitor-facing behavior. No actionable merge-blocking risk was identified.

Architecture Summary

Architecture risk: 🔵 Low · up to e6d66

The change affects 1 system.

Changed systems: apps/website

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — apps/website (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootStudio.test.ts: Adds a test that renders a take, selects it and expects its name and angle in the caption, then selects Aim and expects the caption to be empty.

Pre-merge checks | Passed 7
✅ Passed checks (7 passed)
Check name Status Explanation
Title check Passed The title is concise, specific, and accurately describes the added test coverage for the Re-shoot take caption.
Description check Passed The description includes the required Summary and Verification sections. It explains the tested behavior, scope, test results, mutation testing, and linting results.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes Passed The title and commit subject use test language, not bug-fix language. The only changed file is under apps/website, which the check explicitly excludes from failure. The PR description also explains th…
Website End-To-End Regression Coverage Passed The PR changes only apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootStudio.test.ts. The diff adds test coverage and does not change website runtime behavior. The check excludes …
Adr Compliance For Entity/Litegraph Changes Passed The pull request changes only apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootStudio.test.ts. No changed path is under src/lib/litegraph/, src/ecs/, or related to graph enti…

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR


🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #20736      +/-   ##
==========================================
- Coverage   86.07%   85.95%   -0.13%     
==========================================
  Files        3632     3528     -104     
  Lines      173392   170162    -3230     
  Branches    47846    46744    -1102     
==========================================
- Hits       149242   146257    -2985     
+ Misses      22143    22053      -90     
+ Partials     2007     1852     -155     
Flag Coverage Δ
billing-web-unit ?
website-unit 80.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 104 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant