Repository navigation
test(website): hold the phone card to the peek it promises - #20735
mariana953 wants to merge 1 commit into
Conversation
The touch case measured the peek at the Pixel 5's 393px, where a flat 288px card leaves 42px over anyway, so the width cap that case depends on could drift out without a test noticing. It now measures at 320, where the cap is the only thing between the row and no hint at all, and asserts the shape rather than a number: a whole card before the cut one, and only a slice of that one showing. Removing the cap makes the first card the cut one at 280 of 288 and fails it.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since cf1ec2e64810320ee6a6338dfb47a24fa84fcf37
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-20735.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-6tktxznds-comfyui.vercel.app Last updated: 2026-10-10T20:12:28Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20735 +/- ##
==========================================
- Coverage 86.07% 85.95% -0.13%
==========================================
Files 3632 3528 -104
Lines 173392 170162 -3230
Branches 47846 46744 -1102
==========================================
- Hits 149242 146257 -2985
+ Misses 22143 22053 -90
+ Partials 2007 1852 -155
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
Follow-up to #20333, which dropped the shelf arrows on touch and left the cut-off next card as the only hint that a row scrolls, holding that hint at 48px with a width cap in
card-layout.ts. The cap shipped; the test that holds it did not. @webshepherd-bot named the gap on that PR, which was already in the merge queue, so it comes separately rather than costing a re-queue.The touch case measured at the Pixel 5's 393px, where a flat 288px card leaves 42px over on its own, so the cap could have been deleted without a test noticing. It now measures at 320px, where the cap is the only thing between the row and no hint at all, and asserts the shape rather than a number: a whole card before the cut one, and only a slice of that one showing.
Review Focus
@mobilecase gains a viewport and three assertions.Verification
Mutation-tested against a production build at 320px, restoring the flat card the cap replaced:
models-row-arrows.spec.tsis 3/3 across[desktop]and[mobile]; eslint and oxfmt are clean.Generated by Claude Code