Skip to content

test(website): hold the phone card to the peek it promises - #20735

Open
mariana953 wants to merge 1 commit into
mainfrom
mariana/hub-peek-guard
Open

mariana953 wants to merge 1 commit into
mainfrom
mariana/hub-peek-guard

Conversation

@mariana953

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #20333, which dropped the shelf arrows on touch and left the cut-off next card as the only hint that a row scrolls, holding that hint at 48px with a width cap in card-layout.ts. The cap shipped; the test that holds it did not. @webshepherd-bot named the gap on that PR, which was already in the merge queue, so it comes separately rather than costing a re-queue.

The touch case measured at the Pixel 5's 393px, where a flat 288px card leaves 42px over on its own, so the cap could have been deleted without a test noticing. It now measures at 320px, where the cap is the only thing between the row and no hint at all, and asserts the shape rather than a number: a whole card before the cut one, and only a slice of that one showing.

Review Focus

  • Nothing ships to a visitor here. One @mobile case gains a viewport and three assertions.

Verification

Mutation-tested against a production build at 320px, restoring the flat card the cap replaced:

cut card showing verdict
with the cap index 1 48 of 212px passes
cap removed index 0 — the first card 280 of 288px, no second card at all fails

models-row-arrows.spec.ts is 3/3 across [desktop] and [mobile]; eslint and oxfmt are clean.


Generated by Claude Code

The touch case measured the peek at the Pixel 5's 393px, where a flat
288px card leaves 42px over anyway, so the width cap that case depends
on could drift out without a test noticing.

It now measures at 320, where the cap is the only thing between the row
and no hint at all, and asserts the shape rather than a number: a whole
card before the cut one, and only a slice of that one showing. Removing
the cap makes the first card the cut one at 280 of 288 and fails it.
@mariana953
mariana953 requested a review from a team October 10, 2026 20:10
@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since cf1ec2e64810320ee6a6338dfb47a24fa84fcf37

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-20735.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-6tktxznds-comfyui.vercel.app

Last updated: 2026-10-10T20:12:28Z for e21a9b3

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 88cd7118-2d42-444b-8c12-3b1b91b8cfaa

📥 Commits

Reviewing files that changed from the base of the PR and between cf1ec2e and e21a9b3.


📒 Files selected for processing (1)
  • apps/website/e2e/models-row-arrows.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.



📝 Walkthrough

Walkthrough

The mobile model-row test now uses a 320-pixel viewport. It checks that the card at the row’s right edge has a preceding card and is only partially visible.

Changes

Mobile row visibility

Layer / File(s) Summary
Mobile viewport assertions
apps/website/e2e/models-row-arrows.spec.ts
The test sets the viewport width to 320 pixels, finds the card intersecting the row’s right edge, and checks that a preceding card exists and the visible portion is greater than zero but less than the card’s width.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: maanilverma


Merge Risk: ⚪ Minimal · up to e21a9

This change only strengthens the mobile model-row test, and the inspected page-load path does not reveal a concrete merge-blocking issue.

Architecture Summary

Architecture risk: 🔵 Low · up to e21a9

The change affects 1 system.

Changed systems: apps/website

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — apps/website (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in apps/website/e2e/models-row-arrows.spec.ts: The mobile test now uses a 320-pixel viewport and finds the card intersecting the row’s right edge. It verifies that a card precedes it and that the visible portion is greater than zero but less than the card’s width, replacing the previous assertion that any positive peek existed. The comments also describe why the width cap matters at this viewport.

Pre-merge checks | Passed 7
✅ Passed checks (7 passed)
Check name Status Explanation
Title check Passed The title clearly identifies a website test change for the mobile card-row peek behavior.
Description check Passed The description includes a clear Summary and detailed Verification section with test scope, mutation-test results, and linting results.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes Passed The title and commit subject do not use the specified bug-fix language. The PR changes only apps/website/e2e/models-row-arrows.spec.ts, which is covered by the stated apps/website exception.
Website End-To-End Regression Coverage Passed The pull request changes only apps/website/e2e/models-row-arrows.spec.ts. It does not change website runtime files under apps/website/src/ or apps/website/public/, so this check does not apply.
Adr Compliance For Entity/Litegraph Changes Passed PASS: The pull request changes only apps/website/e2e/models-row-arrows.spec.ts. This path is outside src/lib/litegraph/, src/ecs/, and the listed graph-entity areas. The ADR compliance check doe…

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR


🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #20735      +/-   ##
==========================================
- Coverage   86.07%   85.95%   -0.13%     
==========================================
  Files        3632     3528     -104     
  Lines      173392   170162    -3230     
  Branches    47846    46744    -1102     
==========================================
- Hits       149242   146257    -2985     
+ Misses      22143    22053      -90     
+ Partials     2007     1852     -155     
Flag Coverage Δ
billing-web-unit ?
website-unit 80.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 104 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant