Repository navigation
feat(website): use the Secondary outline button for the three Hub links - #20731
mariana953 wants to merge 14 commits into
Conversation
Browse all models, Clear filters and View on GitHub each drew their own border, radius and hover. They now use the shared Secondary outline variant, keeping the GitHub mark and the external-link arrow through the button's prepend and append slots.
Comment |
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 68608bcbb6d9f956aa9233402d7800853d399c47
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-20731.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-qdvvtpa83-comfyui.vercel.app Last updated: 2026-10-13T21:21:23Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20731 +/- ##
==========================================
- Coverage 86.35% 85.78% -0.57%
==========================================
Files 3666 3479 -187
Lines 175100 168564 -6536
Branches 48308 44030 -4278
==========================================
- Hits 151201 144600 -6601
- Misses 21883 22106 +223
+ Partials 2016 1858 -158
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 712 files with indirect coverage changes 🚀 New features to boost your workflow:
|
) ## Summary Applies the design review of the Hub as a whole (Models, Workflows and Apps tabs, the app landing pages and the Hub cards) so it reads consistently with the rest of comfy.org: the shelves, cards and labels. - The shelves' paging arrows stay where they are on main, straddling the row edge and revealed on hover or focus, so "See all (N)" keeps the row heading to itself. - Both arrows stay mounted while the row overflows and the spent one is dimmed and marked `aria-disabled`, instead of unmounting. Paging to an end therefore keeps the focus the reader is standing on, and the hand-over logic it needed is gone. The row still takes focus when the cards stop overflowing and the arrows go with them. A spent arrow also takes `pointer-events-none`, so the 18px it straddles goes back to the card underneath. - The sticky toolbar on all three tabs paints the page colour out to the viewport edges, so a shelf scrolling under it no longer shows its paging arrows beside the search field. It paints with a zero-width `border-image` rather than a `clip-path`: on desktop the use-case panel renders inside the toolbar, and a clip cut it to 8px of its 251px. The declaration is one named utility, `bleed-page-band`, beside the other paint tricks in `global.css`. - The provider mark moves from the bottom to the top of every card artwork, beside the kind badge. The support notice takes the corner it left. - App cards carry the same mark as workflow cards, and the same inner spacing and title size. - The composed task pill reads in sentence case ("Image to image"), matching every other label on the page. The filter sheet's "Model" tab reads "Models", beside "Categories". ## Review Focus - `bleed-page-band` declares `border-style: solid` itself rather than relying on Tailwind's preflight, since `border-image` paints nothing when the style is `none`. - The row arrows still straddle the row edge by 18px, so where the band covers them they remain clickable while invisible. That is unchanged from main; pulling them inside the row is a change to the shelf's look and is held for the designer rather than folded in here. - Buttons are out of this PR: "Browse all" and "View on GitHub" keep their current styling. They move to the proposed Secondary variants (Comfy-Org#20560) in Comfy-Org#20731. - The home page carousel is **not** in this PR. An earlier revision padded its text block on phones so the slide title cleared the arrow pair; that overlap is how the carousel already ships on main, not something the Hub work introduced, so the change and its 390px check were reverted out. - `CardRow`'s tests for the old unmount-and-hand-over behaviour are rewritten to the new contract rather than removed: a spent arrow is marked, not removed, keeps focus, and does not page. `models-row-arrows.spec.ts` covers the keyboard case and the recovered hit target in the browser. - The app card's mark shows "C" at rest because the icon set has no square Comfy mark; on hover it opens to "Comfy app". This is what the Hub's mixed grid already shows for an app. A square mark would need a new asset. - Not in this PR, with what was found: - The cut-off element on the app page: the row's arrows are not clipped at any width (measured at 1440 and 1280), and the only clipping found is the last card of a scrolling shelf, which is the shelf's peek. Needs the reviewer's screenshot. - Card outlines: neither app nor workflow cards carry one on main, so there was nothing to match. Adding one to both is a new decision. - The top badges on the app pages are unchanged on purpose. - The Use Cases filter works: the sheet opens with its five categories and counts and narrows the catalogue. Nothing was found to fix. - The Apps tab on the workflows page is gated by `workshop-apps-enabled`, which has been at 100% for everyone since 2026-09-30. ## Verification - `pnpm test:unit src/components/workshop src/lib/workshop` in `apps/website`: 89 files, 910 tests, all passing. - `pnpm typecheck:website`, eslint and oxfmt are clean. - Browser tests against a production build: `workshop.spec.ts` and `models-row-arrows.spec.ts`, 37 of 39 passing on desktop. The two failures are `Model playground › restores sign-in …` and `… API tab highlights snippets …`, which assert against the staging Cloud host (`testapi.comfy.org`) that a local build has no credentials for; both are green in CI. - The new `the use-case panel stays reachable under the stuck toolbar` case discriminates: measured on this build, the panel is 251px tall and its last option hit-tests to itself and clicks through. With the `clip-path` band restored over the same build, 243px of the panel become unreachable and the click times out. - Cross-browser: the zero-width `border-image` was verified in Chromium only. Safari and Firefox are unverified here. Preview: https://comfy-website-preview-pr-20333.vercel.app/hub/workflows/ (also /hub/models/ and /hub/apps/) --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: webshepherd-bot <webshepherd@comfy.org> Co-authored-by: GitHub Action <action@github.com>
The website stories belong in the website Storybook, which is not on main yet. This change keeps only the two new variants; the story follows once that Storybook has a home.
A faint tint read as no response at all. On hover it now fills warm white with ink text, the same way the yellow outline fills yellow.
…riana/hub-buttons-secondary
… default height Browse all is a CTA, so it carries no arrow. View on GitHub keeps its external arrow and moves to the 40px size, where the shared radius stops reading as a pill.
…st for Button - outline: a 1.5px yellow border, and hover tints the fill instead of turning it solid yellow, so the main action stays the only yellow fill. - ghost: uppercase and bold like every other CTA variant. - Every CTA variant shrinks to 97% while pressed, and the primary darkens. - Disabled buttons drop to 40% opacity.
…secondary variants
…fy-Org#20560) ## Summary Adds opt-in `secondary` (warm-white fill, ink text) and `secondaryOutline` (warm-white border, fills on hover) variants to the website `Button`, each with a pressed state that keeps ink text on the canvas fill. `ghost` becomes uppercase/bold like every other variant and gains the same pressed state. `default`, `outline`, link variants and the disabled state are unchanged; designers adopt the new variants per call site, starting with Comfy-Org#20731 on Hub pages. Only visible change on existing pages: the single `ghost` caller (Done in the Cinematic Studio palette editor) now renders uppercase. ## Verification - Pre-commit format, lint, server-facts and `typecheck:website` passed locally; website build, unit and E2E run in CI. - `secondary`/`secondaryOutline` have no callers yet, so pages other than the palette editor render identically to main. - Pressed `secondaryOutline` sets `active:text-primary-comfy-ink` so the canvas fill never pairs with warm-white text on touch or keyboard presses (review feedback). Not yet visually verified in a browser; Comfy-Org#20731 exercises the variants on real pages. --------- Co-authored-by: Claude <noreply@anthropic.com>
Summary
Adopts the
secondaryOutlinevariant (merged in #20560) on the three Hub links that were held out of #20333.WorkshopModelsGrid.vue. Browse all is a CTA, so it drops its chevron.cinematic-studio/AppRepoLink.vue, which stops hand-rolling the border, radius and hover. It keeps the GitHub mark and the external-link arrow (↗ marks external links) through the button's#prepend/#appendslots.Visible effects:
Verification
pnpm test:unitoverWorkshopModelsGrid,AppRepoLinkandModelsCatalogue: 58 passing./hub/models/,/hub/models/?q=…and/hub/apps/cinematic-studio/, at rest and on hover.