Repository navigation
[backport cloud/1.56] feat(agent): run starter prompt set experiment (#20272) - #20677
Conversation
- evaluate `agent-starter-prompt-set` from authenticated remote config with fail-closed control behavior - render a Cloud-only treatment set while preserving the existing control copy - keep both arms on the same locale eligibility rule; unsupported locales, QA overrides, and pre-auth surfaces emit no experiment assignment - carry the rendered assignment through exposure, click, and attributed-send telemetry - consume the generated `/api/features` contract from merged Cloud PR Comfy-Org/cloud#12257 - 95 focused Vitest tests pass across seven Agent assignment, panel, composer, prompt, and store files - app typecheck and browser-suite typecheck pass - treatment Playwright path passes locally against the branch (`1 passed`, 6.6s): `/api/features` → treatment render → exposure → attributed send - screenshot fixture passes for control/treatment at docked and maximized widths (`2 passed`, 7.7s) - pre-push knip/fallow gate reports no issues in changed files | Arm | Docked panel | Maximized panel | | --- | --- | --- | | Control |  |  | | Treatment |  |  | PostHog experiment 469318 is already running. The pre-deploy interval is not a valid treatment period because the Cloud assignment field was not implemented. After this PR deploys, smoke-check both variants and use the first compatible custom exposure, retaining client/Cloud version evidence, as the experiment analysis boundary. Open PRs Comfy-Org#18384 and Comfy-Org#18427 filter prompt slots by index. If either rebases onto this experiment, it must apply visibility per arm and report the visible `prompt_count`, because a slot carries different copy in control and treatment. --------- Co-authored-by: GitHub Action <action@github.com>
🎭 Playwright: ✅ 2202 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-09T20:28:43.269Z",
"gitSha": "009c7dd5eee1201729d92de798533a6a250b3a4e",
"branch": "backport-20272-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.7709999999774,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.59900000000005,
"heapDeltaBytes": 527400,
"heapUsedBytes": 68367220,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.68,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2018.1720000000496,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.79,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.06299999999993,
"heapDeltaBytes": -3200604,
"heapUsedBytes": 58949284,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.344,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.1550000000211,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.172,
"layouts": 12,
"layoutDurationMs": 4.472,
"taskDurationMs": 778.872,
"heapDeltaBytes": -2243080,
"heapUsedBytes": 64823276,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 148.76500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.9390000000076,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.196,
"layouts": 12,
"layoutDurationMs": 4.601,
"taskDurationMs": 764.4830000000001,
"heapDeltaBytes": -2072788,
"heapUsedBytes": 66024156,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 146.353,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.4210000000248,
"styleRecalcs": 29,
"styleRecalcDurationMs": 8.721,
"layouts": 6,
"layoutDurationMs": 1.272,
"taskDurationMs": 325.832,
"heapDeltaBytes": 3167692,
"heapUsedBytes": 69018228,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.462,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.3850000000411,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.039,
"layouts": 6,
"layoutDurationMs": 1.219,
"taskDurationMs": 330.89399999999995,
"heapDeltaBytes": 3792992,
"heapUsedBytes": 71752404,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.475000000000007,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846145,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 722.4970000000326,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.392999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.20399999999995,
"heapDeltaBytes": -6375728,
"heapUsedBytes": 60785324,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 166.952,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667441860465132,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 680.1309999999603,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.6900000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.778,
"heapDeltaBytes": -7458900,
"heapUsedBytes": 60877028,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 166.14000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1126.6200000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 783.497,
"heapDeltaBytes": 38864688,
"heapUsedBytes": 108072996,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 59.05000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 500,
"frameDurationMs": 33.329411764705874,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1108.3490000000893,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 774.1550000000001,
"heapDeltaBytes": 15468764,
"heapUsedBytes": 84647432,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 60.512999999999984,
"eventListeners": 0,
"totalBlockingTimeMs": 493,
"frameDurationMs": 33.839393939393936,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.5689999999645,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.575,
"heapDeltaBytes": 18715068,
"heapUsedBytes": 104704640,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 149.373,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.8759999999329,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.87499999999983,
"heapDeltaBytes": 17677772,
"heapUsedBytes": 99738212,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 141.41499999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9193.353000000003,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6940000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8283.241,
"heapDeltaBytes": 10659680,
"heapUsedBytes": 94632312,
"domNodes": -142,
"jsHeapTotalBytes": -10358784,
"scriptDurationMs": 6687.84,
"eventListeners": -74,
"totalBlockingTimeMs": 405,
"frameDurationMs": 31.774740484429064,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7863.280000000032,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.0819999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7151.647,
"heapDeltaBytes": 7814612,
"heapUsedBytes": 92169596,
"domNodes": -142,
"jsHeapTotalBytes": -13504512,
"scriptDurationMs": 5971.291,
"eventListeners": -78,
"totalBlockingTimeMs": 113,
"frameDurationMs": 30.308108108108105,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8243.719999999996,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.33500000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7596.485,
"heapDeltaBytes": 994472,
"heapUsedBytes": 85621296,
"domNodes": -142,
"jsHeapTotalBytes": -11407360,
"scriptDurationMs": 6136.657999999999,
"eventListeners": -74,
"totalBlockingTimeMs": 117,
"frameDurationMs": 30.047445255474454,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8032.899000000043,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.4480000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7407.402999999999,
"heapDeltaBytes": 407924,
"heapUsedBytes": 85249444,
"domNodes": -142,
"jsHeapTotalBytes": -11145216,
"scriptDurationMs": 5979.355,
"eventListeners": -74,
"totalBlockingTimeMs": 88,
"frameDurationMs": 30.250188679245287,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "large-graph-idle",
"durationMs": 2015.5320000000074,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.4250000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.492,
"heapDeltaBytes": -7921712,
"heapUsedBytes": 77133452,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 32.597,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2010.4199999999537,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.535999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.91499999999985,
"heapDeltaBytes": -11215112,
"heapUsedBytes": 68432332,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 32.99999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2216.3419999999974,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.823,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1482.0960000000002,
"heapDeltaBytes": -18971400,
"heapUsedBytes": 69986324,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 796.5759999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2259.0529999999944,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.235999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1526.499,
"heapDeltaBytes": -18111984,
"heapUsedBytes": 71787884,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 831.0809999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592592592593,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3582.86099999998,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.825,
"layouts": 60,
"layoutDurationMs": 15.377,
"taskDurationMs": 1620.8549999999998,
"heapDeltaBytes": 1261192,
"heapUsedBytes": 69727964,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 786.022,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66588785046729,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3552.4339999999484,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.907999999999998,
"layouts": 60,
"layoutDurationMs": 15.608999999999998,
"taskDurationMs": 1638.8559999999998,
"heapDeltaBytes": 1305880,
"heapUsedBytes": 70066800,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 781.698,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3071.327999999994,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.993999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1854.241,
"heapDeltaBytes": 8413612,
"heapUsedBytes": 77500112,
"domNodes": 0,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 1001.2460000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756830601092897,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3119.2649999999276,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.809000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1839.72,
"heapDeltaBytes": 8152148,
"heapUsedBytes": 78037756,
"domNodes": 0,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 990.2290000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755675675675672,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2014.9410000000216,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.9780000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.19599999999997,
"heapDeltaBytes": -11679068,
"heapUsedBytes": 69288004,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 31.586999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.3700000000044,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3859999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.3310000000001,
"heapDeltaBytes": -9610012,
"heapUsedBytes": 80408408,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.357,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.4960000000215,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.337999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.422,
"heapDeltaBytes": -11961672,
"heapUsedBytes": 57770044,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 151.236,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.6280000000006,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.43600000000004,
"heapDeltaBytes": -11943340,
"heapUsedBytes": 57566256,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 141.252,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.984000000008,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.984999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.049,
"heapDeltaBytes": 1129308,
"heapUsedBytes": 71081528,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.103,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.916999999964,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.9050000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.7050000000001,
"heapDeltaBytes": 1034040,
"heapUsedBytes": 70601348,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.43,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.3459999999782,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.732999999999997,
"layouts": 16,
"layoutDurationMs": 5.823,
"taskDurationMs": 728.516,
"heapDeltaBytes": -6137440,
"heapUsedBytes": 63999284,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 103.829,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.2180000000917,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.488999999999997,
"layouts": 16,
"layoutDurationMs": 6.12,
"taskDurationMs": 719.1460000000001,
"heapDeltaBytes": -6014984,
"heapUsedBytes": 63822672,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 104.19399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823533,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.599000000041,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.594,
"layouts": 5,
"layoutDurationMs": 13.280000000000003,
"taskDurationMs": 884.0360000000001,
"heapDeltaBytes": 3361460,
"heapUsedBytes": 96966524,
"domNodes": 14227,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 28.129999999999995,
"eventListeners": 2463,
"totalBlockingTimeMs": 118,
"frameDurationMs": 18.94794520547945,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8222.214000000007,
"styleRecalcs": 251,
"styleRecalcDurationMs": 39.132,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5237.297,
"heapDeltaBytes": 7905872,
"heapUsedBytes": 96562556,
"domNodes": 0,
"jsHeapTotalBytes": 1015808,
"scriptDurationMs": 2623.5600000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69979633401222,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8220.074999999952,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.869,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5250.947,
"heapDeltaBytes": 9691096,
"heapUsedBytes": 95752132,
"domNodes": 0,
"jsHeapTotalBytes": 1540096,
"scriptDurationMs": 2607.236,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666056910569107,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18306.821000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17481.979000000003,
"heapDeltaBytes": -39939568,
"heapUsedBytes": 180884176,
"domNodes": -3046,
"jsHeapTotalBytes": 8990720,
"scriptDurationMs": 305.587,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.82486956521739,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 17949.166999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17288.356,
"heapDeltaBytes": -42494008,
"heapUsedBytes": 184461228,
"domNodes": -3045,
"jsHeapTotalBytes": 12603392,
"scriptDurationMs": 287.861,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.812199312714778,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 21982.511999999984,
"styleRecalcs": 172,
"styleRecalcDurationMs": 20.740999999999953,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21578.315,
"heapDeltaBytes": -42959364,
"heapUsedBytes": 184536120,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 858.6049999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 40,
"frameDurationMs": 40.33467889908256,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 22363.04800000005,
"styleRecalcs": 173,
"styleRecalcDurationMs": 23.144,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21985.984,
"heapDeltaBytes": -60146656,
"heapUsedBytes": 167230376,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 903.595,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.12015065913371,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6392.665000000023,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.19700000000002,
"layouts": 20,
"layoutDurationMs": 26.518,
"taskDurationMs": 6295.652999999999,
"heapDeltaBytes": -8085160,
"heapUsedBytes": 209597048,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 116.941,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.20813953488371,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6536.6319999999405,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.64499999999997,
"layouts": 20,
"layoutDurationMs": 25.916999999999994,
"taskDurationMs": 6440.7519999999995,
"heapDeltaBytes": 434492,
"heapUsedBytes": 214425692,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 117.23899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 6,
"frameDurationMs": 39.35542168674698,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9414.65199999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8944.874000000002,
"heapDeltaBytes": -42114064,
"heapUsedBytes": 180279768,
"domNodes": -3045,
"jsHeapTotalBytes": 1941504,
"scriptDurationMs": 147.98799999999994,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.92412587412587,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9452.548999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8973.847000000002,
"heapDeltaBytes": -41750832,
"heapUsedBytes": 180627136,
"domNodes": -3045,
"jsHeapTotalBytes": 2727936,
"scriptDurationMs": 142.03099999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.8111111111111,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 123.03899999994883,
"styleRecalcs": 9,
"styleRecalcDurationMs": 13.002,
"layouts": 3,
"layoutDurationMs": 1.961,
"taskDurationMs": 85.91199999999999,
"heapDeltaBytes": 3892468,
"heapUsedBytes": 69322004,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.363999999999997,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.675000000000068,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 485.83499999995183,
"styleRecalcs": 21,
"styleRecalcDurationMs": 18.252,
"layouts": 4,
"layoutDurationMs": 1.964,
"taskDurationMs": 123.394,
"heapDeltaBytes": 5780592,
"heapUsedBytes": 71160200,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.743000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 939.9419999999736,
"styleRecalcs": 78,
"styleRecalcDurationMs": 111.292,
"layouts": 76,
"layoutDurationMs": 26.332,
"taskDurationMs": 921.063,
"heapDeltaBytes": 18460624,
"heapUsedBytes": 89987404,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 372.303,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66491228070175,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 969.2320000000336,
"styleRecalcs": 78,
"styleRecalcDurationMs": 114.86200000000001,
"layouts": 76,
"layoutDurationMs": 27.359,
"taskDurationMs": 939.573,
"heapDeltaBytes": 18723488,
"heapUsedBytes": 85595752,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 376.713,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663793103448278,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1470.0709999999617,
"styleRecalcs": 78,
"styleRecalcDurationMs": 285.71000000000004,
"layouts": 76,
"layoutDurationMs": 31.695,
"taskDurationMs": 1456.445,
"heapDeltaBytes": 8665916,
"heapUsedBytes": 114110092,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 487.129,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.539999999999985,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1409.0489999999818,
"styleRecalcs": 78,
"styleRecalcDurationMs": 277.648,
"layouts": 76,
"layoutDurationMs": 30.428,
"taskDurationMs": 1386.784,
"heapDeltaBytes": -19049456,
"heapUsedBytes": 108426168,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 444.481,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.93291139240507,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.56 #20677 +/- ##
=============================================
Coverage ? 85.89%
=============================================
Files ? 2479
Lines ? 141401
Branches ? 38486
=============================================
Hits ? 121458
Misses ? 19560
Partials ? 383
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: Approve. This is a faithful backport of #20272, with identical hunks in all 21 files.
I compared against #20272's merge commit 2df273eba61476df129984a423cd686634622d3a. Every file carries the source's added and removed lines:
- the telemetry registry, providers and types
starterPromptSet.ts,starterPrompts.ts,EmptyState.vue,AgentPanel.vue,AgentPanelRoot.vueanduseComposer.ts- the locale strings
- all unit tests, plus
agentStarterPromptExperiment.spec.tsandagentPanelMocks.ts
The one cherry-pick conflict, in the useComposer.test.ts imports, resolves to the source's lines exactly. No adaptation was needed. The generated 'agent-starter-prompt-set' features field that the experiment reads is already on cloud/1.56.
Checks: the touched Vitest files pass locally at this head (271 tests), and pnpm typecheck:browser passes. Hosted CI at 89e180b is green, including lint-and-format, lint-pr / typecheck, test and e2e-status.
Summary
Backports #20272 to
cloud/1.56.Changes
Review Focus
The only cherry-pick conflict was in
useComposer.test.ts. The resolution preserves the 1.56 branch'sComposerAttachmenttype import and adds #20272'sstarterPromptAttributionvalue import.Validation:
pnpm typecheckpassed