Skip to content

[backport cloud/1.54] fix Agent-inserted node outputs (PM-2037) - #20658

Closed
christian-byrne wants to merge 2 commits into
cloud/1.54from
christian/backport-20601-cloud-1.54-manual
Closed

christian-byrne wants to merge 2 commits into
cloud/1.54from
christian/backport-20601-cloud-1.54-manual

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #20601 to cloud/1.54.

The automated backport conflicted only in src/stores/previewExposureStore.test.ts. This uses the same delimiter-bearing locator expectation already reviewed and merged in cloud/1.55 #20654; the product/source diff is otherwise the source squash commit.

Source: #20601
Sibling: #20654

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned) agent Comfy Agent product, integration, tests or product documentation labels Oct 9, 2026
@christian-byrne
christian-byrne requested a review from a team as a code owner October 9, 2026 17:44
@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned) agent Comfy Agent product, integration, tests or product documentation labels Oct 9, 2026
@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 9, 2026 6:35pm UTC
billing-web-test Ignored Ignored Oct 9, 2026 6:35pm UTC

Request Review

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1993 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1972 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/09/2026, 06:37:22 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 156ms TBT · 99.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.5 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.7 MB heap
vue-large-graph-pan: · 57.2 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 49ms TBT · 181.5 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 162ms TBT · 170.0 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 163.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 518ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 59.2 MB
canvas-idle: DOM nodes -141
canvas-idle: event listeners -196
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 27ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 870ms
canvas-mouse-sweep: script duration 140ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.0 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -195
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 388ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 73.4 MB
canvas-zoom-sweep: DOM nodes 75
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 443ms
dom-widget-clipping: script duration 150ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 63.6 MB
dom-widget-clipping: DOM nodes 16
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 630ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 78.0 MB
large-graph-idle: DOM nodes -283
large-graph-idle: event listeners -194
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1472ms
large-graph-pan: script duration 714ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 68.9 MB
large-graph-pan: DOM nodes -278
large-graph-pan: event listeners -94
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 16ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 70
large-graph-zoom: task duration 1661ms
large-graph-zoom: script duration 705ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 85.6 MB
large-graph-zoom: DOM nodes -247
large-graph-zoom: event listeners -190
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1637ms
legacy-node-drag: script duration 822ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 79.6 MB
legacy-node-drag: DOM nodes -134
legacy-node-drag: event listeners 187
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 595ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 75.8 MB
minimap-idle: DOM nodes -283
minimap-idle: event listeners -194
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 465ms
subgraph-dom-widget-clipping: script duration 146ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 62.5 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 8
subgraph-idle: task duration 532ms
subgraph-idle: script duration 11ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 63.2 MB
subgraph-idle: DOM nodes -299
subgraph-idle: event listeners -241
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 916ms
subgraph-mouse-sweep: script duration 110ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 66.4 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -241
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 983ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 156ms
subgraph-transition-enter: heap used 99.3 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 46ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5679ms
viewport-pan-sweep: script duration 2572ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 76.5 MB
viewport-pan-sweep: DOM nodes -284
viewport-pan-sweep: event listeners -176
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14252ms
vue-large-graph-idle: script duration 258ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.7 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14933
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 21ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 140
vue-large-graph-pan: task duration 17479ms
vue-large-graph-pan: script duration 899ms
vue-large-graph-pan: TBT 49ms
vue-large-graph-pan: heap used 181.5 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14930
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 71ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5225ms
vue-node-resize-workload: script duration 112ms
vue-node-resize-workload: TBT 162ms
vue-node-resize-workload: heap used 170.0 MB
vue-node-resize-workload: DOM nodes -8070
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7218ms
vue-zoom-out-idle: script duration 136ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 163.2 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -14
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 2
workflow-execution: style recalc count 7
workflow-execution: task duration 74ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.3 MB
workflow-execution: DOM nodes 109
workflow-execution: event listeners 34
Raw data
{
  "timestamp": "2026-10-09T18:46:39.558Z",
  "gitSha": "bfa735111c3bce8145124ea5584de8a1414bcbc0",
  "branch": "christian/backport-20601-cloud-1.54-manual",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2079.9939999999424,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.29,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 580.3580000000001,
      "heapDeltaBytes": -12732684,
      "heapUsedBytes": 58429896,
      "domNodes": 1,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.778,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2033.6819999999989,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.618999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.47900000000004,
      "heapDeltaBytes": -5350392,
      "heapUsedBytes": 65748904,
      "domNodes": -282,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 6.896000000000003,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1843.0339999999887,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 27.901,
      "layouts": 14,
      "layoutDurationMs": 4.225,
      "taskDurationMs": 900.875,
      "heapDeltaBytes": -412996,
      "heapUsedBytes": 73375532,
      "domNodes": -280,
      "jsHeapTotalBytes": 4489216,
      "scriptDurationMs": 143.041,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1800.9660000000167,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 25.391000000000002,
      "layouts": 14,
      "layoutDurationMs": 4.167,
      "taskDurationMs": 838.534,
      "heapDeltaBytes": -6114048,
      "heapUsedBytes": 67185328,
      "domNodes": -284,
      "jsHeapTotalBytes": 4489216,
      "scriptDurationMs": 136.214,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1734.6670000000586,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.891,
      "layouts": 6,
      "layoutDurationMs": 1.2580000000000002,
      "taskDurationMs": 405.751,
      "heapDeltaBytes": 4231024,
      "heapUsedBytes": 76060880,
      "domNodes": 73,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 15.255,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1734.2220000000452,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.888,
      "layouts": 6,
      "layoutDurationMs": 1.3800000000000001,
      "taskDurationMs": 371.0399999999999,
      "heapDeltaBytes": 4535092,
      "heapUsedBytes": 77939764,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 12.93,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 614.2060000000811,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 6.312,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.21799999999996,
      "heapDeltaBytes": -7511700,
      "heapUsedBytes": 66736668,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 140.737,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 714.9799999999686,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.808000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 478.39200000000005,
      "heapDeltaBytes": -7541820,
      "heapUsedBytes": 66647464,
      "domNodes": 14,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 159.43099999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2076.8699999999853,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 8.666,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 674.5620000000001,
      "heapDeltaBytes": -7581580,
      "heapUsedBytes": 72994940,
      "domNodes": -279,
      "jsHeapTotalBytes": -2064384,
      "scriptDurationMs": 39.259,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2030.1559999998062,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.509999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 584.6099999999999,
      "heapDeltaBytes": 12930992,
      "heapUsedBytes": 90512600,
      "domNodes": -286,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 31.887999999999998,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2151.984999999968,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.559000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1453.125,
      "heapDeltaBytes": 275740,
      "heapUsedBytes": 66718288,
      "domNodes": -271,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 714.313,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2245.390999999927,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.100999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1490.026,
      "heapDeltaBytes": -352288,
      "heapUsedBytes": 77683716,
      "domNodes": -284,
      "jsHeapTotalBytes": 3002368,
      "scriptDurationMs": 712.714,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3935.230000000047,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 17.491999999999997,
      "layouts": 60,
      "layoutDurationMs": 15.167,
      "taskDurationMs": 1799.633,
      "heapDeltaBytes": 8344304,
      "heapUsedBytes": 87325532,
      "domNodes": -263,
      "jsHeapTotalBytes": 2514944,
      "scriptDurationMs": 760.27,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3385.926000000154,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.895999999999997,
      "layouts": 60,
      "layoutDurationMs": 12.035,
      "taskDurationMs": 1521.3790000000001,
      "heapDeltaBytes": 9353076,
      "heapUsedBytes": 92094944,
      "domNodes": -230,
      "jsHeapTotalBytes": -1015808,
      "scriptDurationMs": 649.102,
      "eventListeners": -186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2989.1549999999825,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 8.193999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1794.6119999999999,
      "heapDeltaBytes": 13515668,
      "heapUsedBytes": 96341392,
      "domNodes": 8,
      "jsHeapTotalBytes": 6184960,
      "scriptDurationMs": 897.3209999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2309.841000000006,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 5.497999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1478.6040000000003,
      "heapDeltaBytes": 3167356,
      "heapUsedBytes": 70593008,
      "domNodes": -275,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 747.5039999999999,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2026.3249999999289,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.491000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 618.7700000000001,
      "heapDeltaBytes": -12938004,
      "heapUsedBytes": 66073016,
      "domNodes": -282,
      "jsHeapTotalBytes": -892928,
      "scriptDurationMs": 35.92099999999999,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2022.754999999961,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.263999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 570.776,
      "heapDeltaBytes": 13704368,
      "heapUsedBytes": 92845380,
      "domNodes": -283,
      "jsHeapTotalBytes": -2203648,
      "scriptDurationMs": 33.24100000000001,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 740.0549999999839,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 12.940999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 492.449,
      "heapDeltaBytes": -10580312,
      "heapUsedBytes": 65442236,
      "domNodes": 18,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 151.179,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 699.1299999999683,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.990000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 436.971,
      "heapDeltaBytes": -10543284,
      "heapUsedBytes": 65610476,
      "domNodes": 20,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 141.449,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2037.8180000000157,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.7040000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 566.89,
      "heapDeltaBytes": -7749652,
      "heapUsedBytes": 65405452,
      "domNodes": -300,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 12.763,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.9769999999826,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.338000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 496.761,
      "heapDeltaBytes": -8129892,
      "heapUsedBytes": 67155464,
      "domNodes": -298,
      "jsHeapTotalBytes": 4489216,
      "scriptDurationMs": 9.886999999999999,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1817.4809999999297,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 33.76,
      "layouts": 18,
      "layoutDurationMs": 6.615000000000001,
      "taskDurationMs": 1019.9200000000002,
      "heapDeltaBytes": -9140968,
      "heapUsedBytes": 64225908,
      "domNodes": -296,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 122.585,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1757.5420000000577,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 24.986999999999995,
      "layouts": 18,
      "layoutDurationMs": 4.05,
      "taskDurationMs": 811.816,
      "heapDeltaBytes": -1043636,
      "heapUsedBytes": 74952980,
      "domNodes": -298,
      "jsHeapTotalBytes": 5537792,
      "scriptDurationMs": 98.137,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.209000000108,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 30.649999999999995,
      "layouts": 16,
      "layoutDurationMs": 13.486,
      "taskDurationMs": 982.9470000000002,
      "heapDeltaBytes": 21061480,
      "heapUsedBytes": 104109884,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 33.394000000000005,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 156,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9068.12500000001,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 44.178999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5596.072,
      "heapDeltaBytes": 948552,
      "heapUsedBytes": 78421452,
      "domNodes": -282,
      "jsHeapTotalBytes": 3526656,
      "scriptDurationMs": 2558.147,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8639.851000000135,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 47.105000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5762.345,
      "heapDeltaBytes": 4155012,
      "heapUsedBytes": 81989624,
      "domNodes": -285,
      "jsHeapTotalBytes": -667648,
      "scriptDurationMs": 2585.274,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14933.469999999943,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14299.292999999998,
      "heapDeltaBytes": -46961800,
      "heapUsedBytes": 182920408,
      "domNodes": -8068,
      "jsHeapTotalBytes": -3420160,
      "scriptDurationMs": 247.137,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14815.742,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14205.060000000001,
      "heapDeltaBytes": -48323844,
      "heapUsedBytes": 177169668,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16527360,
      "scriptDurationMs": 269.238,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17826.71599999992,
      "styleRecalcs": 139,
      "styleRecalcDurationMs": 20.394999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17486.612,
      "heapDeltaBytes": -39282664,
      "heapUsedBytes": 190339316,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17809408,
      "scriptDurationMs": 904.432,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 43,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17870.34100000005,
      "styleRecalcs": 140,
      "styleRecalcDurationMs": 21.348000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17472.154000000002,
      "heapDeltaBytes": -15579432,
      "heapUsedBytes": 190288284,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10473472,
      "scriptDurationMs": 894.0870000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 54,
      "frameDurationMs": 17.216666666666665,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5323.487999999998,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 68.34000000000002,
      "layouts": 20,
      "layoutDurationMs": 24.29300000000001,
      "taskDurationMs": 5257.802000000001,
      "heapDeltaBytes": -46938668,
      "heapUsedBytes": 181777400,
      "domNodes": -8068,
      "jsHeapTotalBytes": 9523200,
      "scriptDurationMs": 98.17300000000002,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 184,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5321.2630000000445,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.067,
      "layouts": 20,
      "layoutDurationMs": 25.820999999999998,
      "taskDurationMs": 5191.748,
      "heapDeltaBytes": -49446724,
      "heapUsedBytes": 174769272,
      "domNodes": -8072,
      "jsHeapTotalBytes": 458752,
      "scriptDurationMs": 125.37399999999998,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 140,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7628.043999999932,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7465.712999999999,
      "heapDeltaBytes": -11099984,
      "heapUsedBytes": 178702328,
      "domNodes": 0,
      "jsHeapTotalBytes": -18087936,
      "scriptDurationMs": 130.51800000000003,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7172.620000000052,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6970.483999999999,
      "heapDeltaBytes": -5941308,
      "heapUsedBytes": 163640772,
      "domNodes": 0,
      "jsHeapTotalBytes": -9961472,
      "scriptDurationMs": 141.89700000000005,
      "eventListeners": -15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 119.8540000000321,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 16.201,
      "layouts": 2,
      "layoutDurationMs": 0.9780000000000001,
      "taskDurationMs": 84.294,
      "heapDeltaBytes": 3065388,
      "heapUsedBytes": 72669488,
      "domNodes": 112,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.987000000000001,
      "eventListeners": 35,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 97.26599999999053,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 12.411,
      "layouts": 1,
      "layoutDurationMs": 0.397,
      "taskDurationMs": 63.61899999999999,
      "heapDeltaBytes": 3015976,
      "heapUsedBytes": 74763560,
      "domNodes": 106,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.622000000000001,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51174 76654 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@github-actions
github-actions Bot requested a review from thedatalife October 9, 2026 17:44
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: fa04f9bd-30f9-4bb4-bca3-c1c9e00fe168

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@datadog-official

This comment has been minimized.

@christian-byrne
christian-byrne force-pushed the christian/backport-20601-cloud-1.54-manual branch from a7bda8a to ac16fc4 Compare October 9, 2026 18:28
@christian-byrne
christian-byrne requested review from dante01yoon and removed request for thedatalife October 9, 2026 18:28
@christian-byrne
christian-byrne enabled auto-merge (squash) October 9, 2026 18:28
@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #20658   +/-   ##
=============================================
  Coverage              ?   84.19%           
=============================================
  Files                 ?     2132           
  Lines                 ?   128754           
  Branches              ?    35007           
=============================================
  Hits                  ?   108399           
  Misses                ?    20174           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.76% <77.27%> (?)
unit 79.67% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...atform/workflow/management/stores/workflowStore.ts 94.30% <100.00%> (ø)
...erer/extensions/vueNodes/components/LGraphNode.vue 85.56% <100.00%> (ø)
src/types/nodeIdentification.ts 99.07% <100.00%> (ø)
src/utils/graphTraversalUtil.ts 99.39% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Closing because the core/cloud 1.54 trains are retired as of 2026-10-09. Any still-applicable change should be carried to the current 1.55 and 1.56 targets instead.

auto-merge was automatically disabled October 9, 2026 19:05

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants