Repository navigation
[backport cloud/1.56] FE-3345 feat(auth): show the SSO-required notice inline on Cloud sign-in pages - #20656
Conversation
…-in pages (#20647) ## Summary On /cloud/login and /cloud/signup, an `sso_required` refusal now shows inline on the page with the brand components, instead of the shared app-styled dialog. Everywhere else in the app keeps the dialog. - Fixes FE-3345 - Thread (bug-bash item 6): https://comfy-organization.slack.com/archives/C0C6V3NUXPU/p1791495895999409 ## Why Deep's design nit from the staging bug bash: the SSO-required dialog on the sign-in page doesn't look like the rest of the page. As Christian noted, the sign-in pages use the brand design system, but the shared modal service renders in the app design system. #20590 (FE-3326) fixed the white dialog, but it is still not brand. Option (1) from the thread (inline notice with brand components) was posted for Alex and Christian to object to. ## Root cause `presentSsoRequired` always opens the shared dialog. That dialog only has the app design system, so the brand sign-in pages had no way to show the refusal in their own styling. ## How - `useSsoRequiredInlineHost()` (`ssoRequiredInline.ts`): a page that calls it becomes the place the refusal is shown. `useCloudAuthPage` calls it, so the login and signup pages are hosts. - While a host is mounted, `presentSsoRequired` stores the context there instead of opening the dialog. It keeps the same merge rules: each caller only adds what it knows. - Without a host, it opens the dialog as before. - `CloudSsoRequiredNotice.vue`: the brand `Message` (warning) plus a `brand-solid` "Continue with SSO" button, the same components the SSO entry form uses. - The continue logic (sign out of Firebase, then go to the refusing org's SSO start, or to the SSO entry when there's no email) moves from `SsoRequiredDialogContent` into `useContinueWithSso`. The dialog and the notice share it. - The login page hides its own "Continue with SSO" entry button while the notice shows, so there is one way on. ## AS IS / TO BE | | AS IS | TO BE | | --- | --- | --- | | /cloud/login, Google sign-in refused `sso_required` | <img src="https://gist.githubusercontent.com/dante01yoon/5ea450f493bcd0a2ea384e3c104dbab3/raw/1144fb34aa07161f893959f411e0062b04debf47/20647-login-as-is.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/5ea450f493bcd0a2ea384e3c104dbab3/raw/1144fb34aa07161f893959f411e0062b04debf47/20647-login-to-be.png" width="420"> | | /cloud/signup, same refusal | <img src="https://gist.githubusercontent.com/dante01yoon/5ea450f493bcd0a2ea384e3c104dbab3/raw/1144fb34aa07161f893959f411e0062b04debf47/20647-signup-as-is.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/5ea450f493bcd0a2ea384e3c104dbab3/raw/1144fb34aa07161f893959f411e0062b04debf47/20647-signup-to-be.png" width="420"> | The refusal was triggered locally with a mocked `sso_required` refusal (`presentSsoRequired({ email, organizationId })`, as `onAuthSuccess` calls it, with `sso_enabled` on). ## Verification - `ssoRequiredInline.test.ts`: - With an auth page mounted, refusals show on the page and merge, and no dialog opens. - After the page unmounts, the dialog opens again. - With the flag off, nothing shows. - `CloudLoginView.test.ts`: the three refused-sign-in cases now assert the inline notice, a single "Continue with SSO" button and no dialog. - `SsoRequiredDialogContent.test.ts`: unchanged, and still passes against the extracted composable. - `vitest run src/platform/auth src/platform/cloud/onboarding src/composables/auth`: 825 passed.
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport of #20647.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since bb2105cf4f2127703ef34f993f483252818ec40a
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2202 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-09T17:52:43.817Z",
"gitSha": "598a82c1d51b858845acb299c58050235e440914",
"branch": "backport-20647-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2016.2320000000022,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.9839999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.60999999999996,
"heapDeltaBytes": 457676,
"heapUsedBytes": 68447056,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.742000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2020.7800000000589,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.131000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.55999999999995,
"heapDeltaBytes": 467612,
"heapUsedBytes": 69391288,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.655999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1769.927999999993,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.974,
"layouts": 12,
"layoutDurationMs": 4.029000000000001,
"taskDurationMs": 850.649,
"heapDeltaBytes": -2128292,
"heapUsedBytes": 65666568,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 162.932,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1751.305000000002,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.410999999999998,
"layouts": 12,
"layoutDurationMs": 4.157,
"taskDurationMs": 832.6199999999999,
"heapDeltaBytes": -2190616,
"heapUsedBytes": 65963744,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 167.729,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.4159999999902,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.786999999999997,
"layouts": 6,
"layoutDurationMs": 1.4950000000000003,
"taskDurationMs": 388.706,
"heapDeltaBytes": 4112092,
"heapUsedBytes": 71536936,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.62299999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.001999999985,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.375,
"layouts": 6,
"layoutDurationMs": 1.345,
"taskDurationMs": 355.01300000000003,
"heapDeltaBytes": 3845652,
"heapUsedBytes": 71596228,
"domNodes": 53,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 12.125999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 732.2110000000066,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.774000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.789,
"heapDeltaBytes": -6789736,
"heapUsedBytes": 61335092,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 169.489,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 727.5210000000243,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.356000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.5640000000001,
"heapDeltaBytes": -6446988,
"heapUsedBytes": 60544544,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 168.186,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1219.4170000000213,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 908.736,
"heapDeltaBytes": 38605976,
"heapUsedBytes": 107455184,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 71.88,
"eventListeners": 0,
"totalBlockingTimeMs": 588,
"frameDurationMs": 35.782352941176455,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1204.4439999999668,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 834.5010000000001,
"heapDeltaBytes": 38598232,
"heapUsedBytes": 108162768,
"domNodes": 0,
"jsHeapTotalBytes": 1736704,
"scriptDurationMs": 71.35600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 566,
"frameDurationMs": 35.294117647058826,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 873.1219999999666,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.9519999999999,
"heapDeltaBytes": 16155544,
"heapUsedBytes": 103633748,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 178.64399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 25.491176470588258,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 889.2060000000583,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.4629999999993,
"heapDeltaBytes": -8167620,
"heapUsedBytes": 79547112,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 182.23799999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 229,
"frameDurationMs": 25.237142857142835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11315.410999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10373.189,
"heapDeltaBytes": 14501144,
"heapUsedBytes": 99758188,
"domNodes": -142,
"jsHeapTotalBytes": -921600,
"scriptDurationMs": 8729.651,
"eventListeners": -78,
"totalBlockingTimeMs": 1771,
"frameDurationMs": 34.81938461538462,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10756.600999999933,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9769.505000000001,
"heapDeltaBytes": 3226632,
"heapUsedBytes": 88508972,
"domNodes": -142,
"jsHeapTotalBytes": -1970176,
"scriptDurationMs": 8108.311000000001,
"eventListeners": -78,
"totalBlockingTimeMs": 1460,
"frameDurationMs": 33.38416149068323,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10268.358000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9330.123,
"heapDeltaBytes": -527540,
"heapUsedBytes": 84409696,
"domNodes": -142,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 7699.0740000000005,
"eventListeners": -78,
"totalBlockingTimeMs": 906,
"frameDurationMs": 32.4882911392405,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10144.7169999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9219.933,
"heapDeltaBytes": -14011228,
"heapUsedBytes": 70622052,
"domNodes": -142,
"jsHeapTotalBytes": -7999488,
"scriptDurationMs": 7591.233,
"eventListeners": -74,
"totalBlockingTimeMs": 1137,
"frameDurationMs": 32.84660194174757,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2024.1300000000138,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.631000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.0750000000002,
"heapDeltaBytes": -9865200,
"heapUsedBytes": 78884076,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 40.38700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2021.2639999999737,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.348,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.269,
"heapDeltaBytes": -10450748,
"heapUsedBytes": 77819764,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 37.76799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2915.5150000000276,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.578,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1691.748,
"heapDeltaBytes": -18958260,
"heapUsedBytes": 70523092,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 881.486,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666091954022985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2596.6339999999946,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.255,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1637.2659999999998,
"heapDeltaBytes": 10458964,
"heapUsedBytes": 88382748,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 859.071,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666025641025644,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3874.572999999998,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.11,
"layouts": 60,
"layoutDurationMs": 14.65,
"taskDurationMs": 1773.219,
"heapDeltaBytes": 1486652,
"heapUsedBytes": 69629196,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 827.3889999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66551724137931,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3599.758999999949,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.119,
"layouts": 60,
"layoutDurationMs": 14.040000000000001,
"taskDurationMs": 1643.9479999999999,
"heapDeltaBytes": 1580148,
"heapUsedBytes": 70461924,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 775.934,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3188.3210000000304,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.664,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2002.186,
"heapDeltaBytes": 17943348,
"heapUsedBytes": 85722324,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 1054.301,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84232804232804,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3151.9439999999577,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.357999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1949.7709999999997,
"heapDeltaBytes": 17814228,
"heapUsedBytes": 87474384,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 1029.54,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84385026737968,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2015.2219999999943,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.396,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.152,
"heapDeltaBytes": -11107920,
"heapUsedBytes": 70286872,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 37.267,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2022.5080000000162,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.764,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.62000000000006,
"heapDeltaBytes": 13416376,
"heapUsedBytes": 81109076,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.54,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 647.8240000000142,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.689000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.23,
"heapDeltaBytes": -12614616,
"heapUsedBytes": 58415968,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 151.229,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102578,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 659.4609999999648,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.276000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.58699999999993,
"heapDeltaBytes": -12338948,
"heapUsedBytes": 58512660,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 147.3,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.5790000000075,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.202000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.68800000000005,
"heapDeltaBytes": 1029088,
"heapUsedBytes": 71113120,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.249,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.4789999999894,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.3180000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.87499999999994,
"heapDeltaBytes": 1006772,
"heapUsedBytes": 70188544,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.958000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1703.8629999999557,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.422,
"layouts": 16,
"layoutDurationMs": 5.72,
"taskDurationMs": 790.673,
"heapDeltaBytes": -5916420,
"heapUsedBytes": 64826336,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 118.326,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.1759999999613,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.076999999999998,
"layouts": 16,
"layoutDurationMs": 5.422,
"taskDurationMs": 785.624,
"heapDeltaBytes": -6034460,
"heapUsedBytes": 64054324,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 117.18400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1403.4669999999778,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.928000000000004,
"layouts": 5,
"layoutDurationMs": 14.738000000000001,
"taskDurationMs": 966.0810000000002,
"heapDeltaBytes": 1146336,
"heapUsedBytes": 96446040,
"domNodes": 14227,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 28.798000000000005,
"eventListeners": 2463,
"totalBlockingTimeMs": 133,
"frameDurationMs": 19.404109589041095,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9510.84400000002,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.830000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5985.914,
"heapDeltaBytes": -19076388,
"heapUsedBytes": 69342836,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2901.9469999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659649122807,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9009.906,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.802,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5941.439,
"heapDeltaBytes": -11580048,
"heapUsedBytes": 77217368,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 3012.058,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.697031539888684,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18509.568000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17666.868000000002,
"heapDeltaBytes": -34596780,
"heapUsedBytes": 179123668,
"domNodes": -3045,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 299.709,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.70530821917808,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 18524.95399999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17421.108,
"heapDeltaBytes": -34657476,
"heapUsedBytes": 180173892,
"domNodes": -3045,
"jsHeapTotalBytes": 4886528,
"scriptDurationMs": 278.053,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.171548821548825,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 22605.669999999976,
"styleRecalcs": 179,
"styleRecalcDurationMs": 20.67100000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22215.431,
"heapDeltaBytes": -15758464,
"heapUsedBytes": 197576016,
"domNodes": -3045,
"jsHeapTotalBytes": 7991296,
"scriptDurationMs": 866.981,
"eventListeners": -14915,
"totalBlockingTimeMs": 29,
"frameDurationMs": 41.572977941176475,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 22427.277000000002,
"styleRecalcs": 179,
"styleRecalcDurationMs": 21.66000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22046.677000000003,
"heapDeltaBytes": -46714128,
"heapUsedBytes": 175129688,
"domNodes": -3045,
"jsHeapTotalBytes": 1155072,
"scriptDurationMs": 877.213,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.742644320297956,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 6471.447000000012,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.66100000000002,
"layouts": 20,
"layoutDurationMs": 22.835999999999995,
"taskDurationMs": 6331.406,
"heapDeltaBytes": 752484,
"heapUsedBytes": 222730436,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 110.146,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.03764705882353,
"p95FrameDurationMs": 83.19999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 6436.7260000000215,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.78100000000005,
"layouts": 20,
"layoutDurationMs": 23.745,
"taskDurationMs": 6315.683000000001,
"heapDeltaBytes": 1045544,
"heapUsedBytes": 214442688,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 109.35,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.185549132947976,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9211.198999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8828.673999999999,
"heapDeltaBytes": -27955828,
"heapUsedBytes": 184637880,
"domNodes": -3045,
"jsHeapTotalBytes": 13684736,
"scriptDurationMs": 145.32500000000005,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.347959183673467,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9392.170999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8779.523,
"heapDeltaBytes": -27878500,
"heapUsedBytes": 179621016,
"domNodes": -3044,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 145.11899999999994,
"eventListeners": -14907,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.91496598639456,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "workflow-execution",
"durationMs": 450.429999999983,
"styleRecalcs": 15,
"styleRecalcDurationMs": 16.892,
"layouts": 4,
"layoutDurationMs": 2.1479999999999997,
"taskDurationMs": 116.04700000000001,
"heapDeltaBytes": 5585052,
"heapUsedBytes": 64044756,
"domNodes": 102,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.671999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 128.64799999999832,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.082999999999998,
"layouts": 3,
"layoutDurationMs": 1.8039999999999998,
"taskDurationMs": 84.62600000000003,
"heapDeltaBytes": 3785684,
"heapUsedBytes": 69787640,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.8120000000000065,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.433333333333394,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 843.2219999999688,
"styleRecalcs": 78,
"styleRecalcDurationMs": 99.26400000000001,
"layouts": 76,
"layoutDurationMs": 25.729,
"taskDurationMs": 818.3190000000001,
"heapDeltaBytes": 17553888,
"heapUsedBytes": 83575360,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 328.571,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 945.7710000000361,
"styleRecalcs": 78,
"styleRecalcDurationMs": 106.17,
"layouts": 76,
"layoutDurationMs": 26.547,
"taskDurationMs": 920.476,
"heapDeltaBytes": 18778832,
"heapUsedBytes": 83476916,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 385.85999999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1408.3919999999353,
"styleRecalcs": 78,
"styleRecalcDurationMs": 268.866,
"layouts": 76,
"layoutDurationMs": 29.242,
"taskDurationMs": 1388.157,
"heapDeltaBytes": 8159836,
"heapUsedBytes": 114652272,
"domNodes": 76,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 459.29400000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.931645569620258,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1575.0639999999976,
"styleRecalcs": 78,
"styleRecalcDurationMs": 296.096,
"layouts": 76,
"layoutDurationMs": 36.596,
"taskDurationMs": 1537.471,
"heapDeltaBytes": 8819292,
"heapUsedBytes": 114588196,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 514.587,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.07469879518071,
"p95FrameDurationMs": 33.29999999999927
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.56 #20656 +/- ##
=============================================
Coverage ? 82.96%
=============================================
Files ? 2369
Lines ? 125981
Branches ? 38413
=============================================
Hits ? 104518
Misses ? 21056
Partials ? 407
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #20647 to
cloud/1.56Automatically created by backport workflow.