Repository navigation
[backport core/1.56] FE-3345 feat(auth): show the SSO-required notice inline on Cloud sign-in pages - #20655
Conversation
…-in pages (#20647) ## Summary On /cloud/login and /cloud/signup, an `sso_required` refusal now shows inline on the page with the brand components, instead of the shared app-styled dialog. Everywhere else in the app keeps the dialog. - Fixes FE-3345 - Thread (bug-bash item 6): https://comfy-organization.slack.com/archives/C0C6V3NUXPU/p1791495895999409 ## Why Deep's design nit from the staging bug bash: the SSO-required dialog on the sign-in page doesn't look like the rest of the page. As Christian noted, the sign-in pages use the brand design system, but the shared modal service renders in the app design system. #20590 (FE-3326) fixed the white dialog, but it is still not brand. Option (1) from the thread (inline notice with brand components) was posted for Alex and Christian to object to. ## Root cause `presentSsoRequired` always opens the shared dialog. That dialog only has the app design system, so the brand sign-in pages had no way to show the refusal in their own styling. ## How - `useSsoRequiredInlineHost()` (`ssoRequiredInline.ts`): a page that calls it becomes the place the refusal is shown. `useCloudAuthPage` calls it, so the login and signup pages are hosts. - While a host is mounted, `presentSsoRequired` stores the context there instead of opening the dialog. It keeps the same merge rules: each caller only adds what it knows. - Without a host, it opens the dialog as before. - `CloudSsoRequiredNotice.vue`: the brand `Message` (warning) plus a `brand-solid` "Continue with SSO" button, the same components the SSO entry form uses. - The continue logic (sign out of Firebase, then go to the refusing org's SSO start, or to the SSO entry when there's no email) moves from `SsoRequiredDialogContent` into `useContinueWithSso`. The dialog and the notice share it. - The login page hides its own "Continue with SSO" entry button while the notice shows, so there is one way on. ## AS IS / TO BE | | AS IS | TO BE | | --- | --- | --- | | /cloud/login, Google sign-in refused `sso_required` | <img src="https://gist.githubusercontent.com/dante01yoon/5ea450f493bcd0a2ea384e3c104dbab3/raw/1144fb34aa07161f893959f411e0062b04debf47/20647-login-as-is.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/5ea450f493bcd0a2ea384e3c104dbab3/raw/1144fb34aa07161f893959f411e0062b04debf47/20647-login-to-be.png" width="420"> | | /cloud/signup, same refusal | <img src="https://gist.githubusercontent.com/dante01yoon/5ea450f493bcd0a2ea384e3c104dbab3/raw/1144fb34aa07161f893959f411e0062b04debf47/20647-signup-as-is.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/5ea450f493bcd0a2ea384e3c104dbab3/raw/1144fb34aa07161f893959f411e0062b04debf47/20647-signup-to-be.png" width="420"> | The refusal was triggered locally with a mocked `sso_required` refusal (`presentSsoRequired({ email, organizationId })`, as `onAuthSuccess` calls it, with `sso_enabled` on). ## Verification - `ssoRequiredInline.test.ts`: - With an auth page mounted, refusals show on the page and merge, and no dialog opens. - After the page unmounts, the dialog opens again. - With the flag off, nothing shows. - `CloudLoginView.test.ts`: the three refused-sign-in cases now assert the inline notice, a single "Continue with SSO" button and no dialog. - `SsoRequiredDialogContent.test.ts`: unchanged, and still passes against the extracted composable. - `vitest run src/platform/auth src/platform/cloud/onboarding src/composables/auth`: 825 passed.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e35621c5f73722dca2ee0cb0bf4f0c25ecf1802c
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2202 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-09T17:51:58.048Z",
"gitSha": "6bb8bc13912c776f4f2f9e9ca8b968e02aaa66eb",
"branch": "backport-20647-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.3340000000244,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.524,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.589,
"heapDeltaBytes": 578816,
"heapUsedBytes": 69251308,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.134000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2016.4230000000316,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.568,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.28200000000004,
"heapDeltaBytes": -3212288,
"heapUsedBytes": 58496524,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.901999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1811.6410000000087,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.942,
"layouts": 12,
"layoutDurationMs": 4.6899999999999995,
"taskDurationMs": 798.6000000000001,
"heapDeltaBytes": -2058764,
"heapUsedBytes": 65895192,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 162.738,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1724.1169999999784,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.307000000000002,
"layouts": 12,
"layoutDurationMs": 4.114999999999999,
"taskDurationMs": 781.575,
"heapDeltaBytes": -2107924,
"heapUsedBytes": 66198116,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 161.67,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.4900000000403,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.455999999999998,
"layouts": 6,
"layoutDurationMs": 1.336,
"taskDurationMs": 336.645,
"heapDeltaBytes": 4087516,
"heapUsedBytes": 71822760,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.122,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.3550000000305,
"styleRecalcs": 32,
"styleRecalcDurationMs": 8.600999999999999,
"layouts": 6,
"layoutDurationMs": 1.079,
"taskDurationMs": 319.1329999999999,
"heapDeltaBytes": 25858256,
"heapUsedBytes": 80511964,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.421,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 689.4530000000145,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.7719999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.175,
"heapDeltaBytes": -7107572,
"heapUsedBytes": 61622616,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.942,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926843,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 663.7039999999388,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.9880000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.4189999999999,
"heapDeltaBytes": -6784908,
"heapUsedBytes": 61293148,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 160.776,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1159.4820000000254,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 815.9939999999999,
"heapDeltaBytes": 15957908,
"heapUsedBytes": 84913752,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 67.721,
"eventListeners": 0,
"totalBlockingTimeMs": 531,
"frameDurationMs": 34.31176470588234,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1127.582000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 792.3970000000002,
"heapDeltaBytes": 11466756,
"heapUsedBytes": 94459616,
"domNodes": 0,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 68.472,
"eventListeners": 0,
"totalBlockingTimeMs": 511,
"frameDurationMs": 34.34242424242422,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 864.3369999999777,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.89999999999964,
"heapDeltaBytes": 17673256,
"heapUsedBytes": 105113272,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 163.67399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 24.76285714285711,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.4629999999479,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.0859999999997,
"heapDeltaBytes": 17259240,
"heapUsedBytes": 104976724,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 160.861,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10465.69999999997,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.057999999999999025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9514.211,
"heapDeltaBytes": -16424700,
"heapUsedBytes": 68500936,
"domNodes": -142,
"jsHeapTotalBytes": -7999488,
"scriptDurationMs": 7880.72,
"eventListeners": -78,
"totalBlockingTimeMs": 1308,
"frameDurationMs": 34.203594771241825,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9219.927000000098,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8170000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8430.903,
"heapDeltaBytes": -16338316,
"heapUsedBytes": 67791292,
"domNodes": -142,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 6926.713,
"eventListeners": -78,
"totalBlockingTimeMs": 606,
"frameDurationMs": 32.510211267605634,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9561.556999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8753.333999999999,
"heapDeltaBytes": -11823996,
"heapUsedBytes": 73043412,
"domNodes": -142,
"jsHeapTotalBytes": -9572352,
"scriptDurationMs": 7251.125,
"eventListeners": -78,
"totalBlockingTimeMs": 835,
"frameDurationMs": 32.592491467576785,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9527.539000000048,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6370000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8740.706,
"heapDeltaBytes": -11768724,
"heapUsedBytes": 73132380,
"domNodes": -142,
"jsHeapTotalBytes": -8523776,
"scriptDurationMs": 7198.389,
"eventListeners": -74,
"totalBlockingTimeMs": 859,
"frameDurationMs": 32.47849829351536,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "large-graph-idle",
"durationMs": 2008.8830000000257,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.83,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.692,
"heapDeltaBytes": -9592808,
"heapUsedBytes": 79157808,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.69699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.8360000000503,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.124999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.6429999999999,
"heapDeltaBytes": -7414568,
"heapUsedBytes": 77900892,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.37800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2277.082000000007,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.991999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1533.0849999999998,
"heapDeltaBytes": -20594732,
"heapUsedBytes": 68998448,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 818.298,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.788235294117644,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2276.886999999988,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.062,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1536.9910000000002,
"heapDeltaBytes": -20450356,
"heapUsedBytes": 69209080,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 821.77,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.788970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3537.6789999999687,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.206999999999999,
"layouts": 60,
"layoutDurationMs": 14.038,
"taskDurationMs": 1607.682,
"heapDeltaBytes": 1239296,
"heapUsedBytes": 69941812,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 766.5999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666350710900474,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3550.2199999999675,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.387,
"layouts": 60,
"layoutDurationMs": 13.492,
"taskDurationMs": 1605.4379999999999,
"heapDeltaBytes": 821072,
"heapUsedBytes": 69964664,
"domNodes": 24,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 765.6449999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665566037735847,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3079.3670000000475,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.697,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1859.5740000000003,
"heapDeltaBytes": 9212352,
"heapUsedBytes": 77772860,
"domNodes": 0,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 982.0100000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757377049180324,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3089.8200000000315,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.151999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1891.12,
"heapDeltaBytes": 17742096,
"heapUsedBytes": 101474740,
"domNodes": 0,
"jsHeapTotalBytes": 1503232,
"scriptDurationMs": 999.947,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756521739130434,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.0730000000012,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.05,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.02200000000005,
"heapDeltaBytes": 13735896,
"heapUsedBytes": 82050544,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.571,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.4040000000605,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.776,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.50500000000005,
"heapDeltaBytes": -8958392,
"heapUsedBytes": 80529948,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.44200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 599.6030000000019,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.986000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.88,
"heapDeltaBytes": -11722868,
"heapUsedBytes": 57667008,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 147.102,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.7940000000217,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.441999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.68600000000004,
"heapDeltaBytes": -12654204,
"heapUsedBytes": 57496540,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 142.427,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888906,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2019.6540000000027,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.409999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.979,
"heapDeltaBytes": 1062820,
"heapUsedBytes": 71131796,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.633000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.2409999999745,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.135000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.21000000000004,
"heapDeltaBytes": 1018068,
"heapUsedBytes": 71798380,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.316000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.019000000002,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.672,
"layouts": 16,
"layoutDurationMs": 5.774,
"taskDurationMs": 755.503,
"heapDeltaBytes": -6394756,
"heapUsedBytes": 64137228,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 114.49799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.8590000000222,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.755,
"layouts": 16,
"layoutDurationMs": 5.911,
"taskDurationMs": 741.1460000000001,
"heapDeltaBytes": 16704788,
"heapUsedBytes": 78837984,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.77599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.1550000000698,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.262999999999998,
"layouts": 5,
"layoutDurationMs": 14.386999999999997,
"taskDurationMs": 910.4980000000003,
"heapDeltaBytes": 3203960,
"heapUsedBytes": 96913092,
"domNodes": 14227,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.944,
"eventListeners": 2463,
"totalBlockingTimeMs": 129,
"frameDurationMs": 19.36756756756755,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8237.83000000003,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5422.683,
"heapDeltaBytes": -18166160,
"heapUsedBytes": 70503732,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 2707.771,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659229208925,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8425.398000000087,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.081999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5527.492,
"heapDeltaBytes": -15514336,
"heapUsedBytes": 73364500,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2804.1969999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699007936507936,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18112.763000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17215.816,
"heapDeltaBytes": -40567680,
"heapUsedBytes": 181114492,
"domNodes": -3045,
"jsHeapTotalBytes": 630784,
"scriptDurationMs": 280.254,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.652961082910323,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 17806.997000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16972.089999999997,
"heapDeltaBytes": -38759912,
"heapUsedBytes": 179695844,
"domNodes": -3045,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 300.207,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.55917667238422,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 21525.523000000023,
"styleRecalcs": 171,
"styleRecalcDurationMs": 18.42800000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21055.646000000004,
"heapDeltaBytes": -20398728,
"heapUsedBytes": 192568472,
"domNodes": -3046,
"jsHeapTotalBytes": 7290880,
"scriptDurationMs": 906.169,
"eventListeners": -14915,
"totalBlockingTimeMs": 50,
"frameDurationMs": 38.69748201438849,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21267.165999999976,
"styleRecalcs": 173,
"styleRecalcDurationMs": 18.563999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20848.096999999998,
"heapDeltaBytes": -36641564,
"heapUsedBytes": 176180988,
"domNodes": -3045,
"jsHeapTotalBytes": 7360512,
"scriptDurationMs": 905.766,
"eventListeners": -14915,
"totalBlockingTimeMs": 19,
"frameDurationMs": 38.11093189964158,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6189.749000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.49899999999998,
"layouts": 20,
"layoutDurationMs": 23.14100000000001,
"taskDurationMs": 6096.518999999999,
"heapDeltaBytes": 175744,
"heapUsedBytes": 214153248,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 105.114,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.167283950617296,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6397.0979999999145,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.42499999999997,
"layouts": 20,
"layoutDurationMs": 24.508000000000003,
"taskDurationMs": 6292.637,
"heapDeltaBytes": 1211048,
"heapUsedBytes": 222920456,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 107.38799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.207558139534875,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8764.527999999927,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8482.911,
"heapDeltaBytes": -33735140,
"heapUsedBytes": 179759312,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 179.643,
"eventListeners": -14915,
"totalBlockingTimeMs": 3,
"frameDurationMs": 30.275432525951565,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8646.690999999919,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8418.628,
"heapDeltaBytes": -33729196,
"heapUsedBytes": 180507828,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 142.47500000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.768620689655176,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 143.3799999999792,
"styleRecalcs": 11,
"styleRecalcDurationMs": 15.056,
"layouts": 4,
"layoutDurationMs": 2.024,
"taskDurationMs": 93.50400000000003,
"heapDeltaBytes": 4042860,
"heapUsedBytes": 69686120,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.315000000000005,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 114.20700000007855,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.993,
"layouts": 3,
"layoutDurationMs": 1.377,
"taskDurationMs": 79.286,
"heapDeltaBytes": 3763936,
"heapUsedBytes": 70187272,
"domNodes": 94,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.221,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65714285714278,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 800.4909999999654,
"styleRecalcs": 78,
"styleRecalcDurationMs": 96.228,
"layouts": 76,
"layoutDurationMs": 23.838,
"taskDurationMs": 769.807,
"heapDeltaBytes": 17163848,
"heapUsedBytes": 81346696,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 310.94,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664583333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 870.995999999991,
"styleRecalcs": 78,
"styleRecalcDurationMs": 100.525,
"layouts": 76,
"layoutDurationMs": 25.568,
"taskDurationMs": 832.468,
"heapDeltaBytes": 17927604,
"heapUsedBytes": 83093584,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 345.13300000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1365.7290000001012,
"styleRecalcs": 78,
"styleRecalcDurationMs": 252.3,
"layouts": 76,
"layoutDurationMs": 27.975,
"taskDurationMs": 1347.2300000000002,
"heapDeltaBytes": 8603540,
"heapUsedBytes": 115272448,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 449.33099999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.29746835443038,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1420.8340000000135,
"styleRecalcs": 78,
"styleRecalcDurationMs": 266.505,
"layouts": 76,
"layoutDurationMs": 29.15,
"taskDurationMs": 1404.606,
"heapDeltaBytes": 8322016,
"heapUsedBytes": 115139772,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 476.15200000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.14430379746835,
"p95FrameDurationMs": 33.29999999999927
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport of #20647.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.56 #20655 +/- ##
==========================================
Coverage 85.84% 85.84%
==========================================
Files 2466 2469 +3
Lines 140971 141001 +30
Branches 38343 38353 +10
==========================================
+ Hits 121021 121047 +26
- Misses 19569 19572 +3
- Partials 381 382 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #20647 to
core/1.56Automatically created by backport workflow.