Repository navigation
[backport cloud/1.56] FE-3346 fix(billing-web): offer Continue with SSO when the shared session is refused sso_required - #20653
Conversation
…sion is refused sso_required (#20649) ## Summary With the unified web session on, billing-web now offers "Continue with SSO" when creating the shared session is refused `sso_required`. Before, that path showed a generic error and a Retry that failed the same way. - Fixes FE-3346 - Follow-up to #20632 (FE-3342). CodeRabbit's Major finding there was right; we had called it out of scope. ## Why An SSO-held account that signs in on billing-web with Google, GitHub or a password, with the unified session on, never gets "Continue with SSO". It sees "something went wrong" and a Retry that can never succeed. ## Root cause - ingest's Firebase auth runs the SSO gate before `POST /api/auth/session` (`firebase_auth.go` → `sso_gate.go`). Session creation therefore answers 403 `{code: "sso_required", organization_id}`. - account-core's `classifyWebSessionFailure` maps it to `SSO_REQUIRED` but drops `organization_id`. - `unifiedBillingSession.creationFailureCode` turns every non-401 creation failure into `TOKEN_EXCHANGE_FAILED`. - `signInPort.failure` only reads the workspace resolution, which never ran because no session was created. - So `sessionFailureCode` and `ssoOrganizationId` stayed undefined, and `useSsoRequiredRefusal` never fired. ## How - account-core: `WebSessionFailure` gets an optional `organizationId`, which `classifyWebSessionFailure` fills from an `sso_required` body. - billing-web `unifiedBillingSession`: - `creationRefusal` keeps `SSO_REQUIRED` (and its organization) instead of bucketing it. - The refusal is held in `creationFailure` until a session holds or someone signs in. - `signInPort.failure` reports the workspace refusal first, then the creation refusal. - Nothing else changes: the sign-in page already shows Continue with SSO for `SSO_REQUIRED` from #20632. ## AS IS / TO BE | | AS IS | TO BE | | --- | --- | --- | | Unified session on, SSO-held account signs in with Google/email | <img src="https://gist.githubusercontent.com/dante01yoon/5ea450f493bcd0a2ea384e3c104dbab3/raw/ce9c3acb448972fc2d896ce37ee3e8767c632173/20649-as-is.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/5ea450f493bcd0a2ea384e3c104dbab3/raw/ce9c3acb448972fc2d896ce37ee3e8767c632173/20649-to-be.png" width="420"> | The `POST /api/auth/session` 403 `sso_required` refusal (and the rest of Cloud and Firebase) was mocked locally, with the unified session on and no existing session. ## Verification - `webSession.test.ts`: an `sso_required` refusal keeps `organization_id`. - `unifiedBillingSession.test.ts`: a 403 `sso_required` on `POST /api/auth/session` resolves `establish` to `SSO_REQUIRED` and reports `failure` with and without an organization. - account-core `src/core` (1243) and billing-web `src/session src/auth src/views` (498) pass.
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3ef1b1dbe88424aa16f394c6501657cbbce697e4
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2202 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-09T16:38:26.841Z",
"gitSha": "03c373016d736de3306d351b98872bdcda1c6765",
"branch": "backport-20649-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.5770000000502,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.7880000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.797,
"heapDeltaBytes": 819136,
"heapUsedBytes": 68922988,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.963999999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2020.1899999999569,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.986999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.367,
"heapDeltaBytes": 559844,
"heapUsedBytes": 68782252,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.467000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1893.3339999999816,
"styleRecalcs": 76,
"styleRecalcDurationMs": 19.014000000000003,
"layouts": 12,
"layoutDurationMs": 4.6160000000000005,
"taskDurationMs": 907.081,
"heapDeltaBytes": -2205960,
"heapUsedBytes": 64856560,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 182.57600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666371681415924,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1804.394000000002,
"styleRecalcs": 74,
"styleRecalcDurationMs": 18.540999999999997,
"layouts": 12,
"layoutDurationMs": 4.768,
"taskDurationMs": 838.5569999999999,
"heapDeltaBytes": -2477204,
"heapUsedBytes": 65614852,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 172.21,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.8210000000336,
"styleRecalcs": 29,
"styleRecalcDurationMs": 11.655000000000003,
"layouts": 6,
"layoutDurationMs": 1.3179999999999998,
"taskDurationMs": 427.5679999999999,
"heapDeltaBytes": 4057788,
"heapUsedBytes": 72151320,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 17.691,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1700.4099999999198,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.101,
"layouts": 6,
"layoutDurationMs": 1.326,
"taskDurationMs": 375.51,
"heapDeltaBytes": 96768,
"heapUsedBytes": 61785036,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.761,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 781.1870000000454,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.778000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.3689999999999,
"heapDeltaBytes": 14822964,
"heapUsedBytes": 75090676,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 180.70000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 716.6280000000143,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.449,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.963,
"heapDeltaBytes": -7778800,
"heapUsedBytes": 59410672,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 170.02200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069753,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1283.0989999999929,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1002.604,
"heapDeltaBytes": 15710544,
"heapUsedBytes": 85669652,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 76.679,
"eventListeners": 0,
"totalBlockingTimeMs": 650,
"frameDurationMs": 37.7441176470588,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1140.3480000000172,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 813.49,
"heapDeltaBytes": 15194488,
"heapUsedBytes": 85559260,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 65.269,
"eventListeners": 0,
"totalBlockingTimeMs": 522,
"frameDurationMs": 34.339393939393936,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 875.5920000000401,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.0140000000004,
"heapDeltaBytes": 17705252,
"heapUsedBytes": 104944452,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 184.76300000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 242,
"frameDurationMs": 25.979411764705862,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 912.1959999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.76000000000045,
"heapDeltaBytes": 17767760,
"heapUsedBytes": 105598436,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 179.129,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 25.461111111111123,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10619.673999999975,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.5190000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9753.247,
"heapDeltaBytes": -15078284,
"heapUsedBytes": 69902332,
"domNodes": -142,
"jsHeapTotalBytes": -7475200,
"scriptDurationMs": 8296.821999999998,
"eventListeners": -78,
"totalBlockingTimeMs": 1716,
"frameDurationMs": 36.932404181184666,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8642.723000000045,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.541999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7991.842000000001,
"heapDeltaBytes": -678140,
"heapUsedBytes": 84116372,
"domNodes": -142,
"jsHeapTotalBytes": -12193792,
"scriptDurationMs": 6752.328,
"eventListeners": -78,
"totalBlockingTimeMs": 837,
"frameDurationMs": 34.810483870967744,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10333.856999999967,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.08099999999999948,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9381.142,
"heapDeltaBytes": -9633068,
"heapUsedBytes": 68348460,
"domNodes": -142,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 7670.219,
"eventListeners": -74,
"totalBlockingTimeMs": 1113,
"frameDurationMs": 33.01246006389776,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10165.974000000006,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.07099999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9297.139000000001,
"heapDeltaBytes": 19935544,
"heapUsedBytes": 97966288,
"domNodes": -142,
"jsHeapTotalBytes": -1970176,
"scriptDurationMs": 7754.793,
"eventListeners": -78,
"totalBlockingTimeMs": 1272,
"frameDurationMs": 33.832,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-graph-idle",
"durationMs": 2040.1360000000182,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.070999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 653.0509999999999,
"heapDeltaBytes": -10474800,
"heapUsedBytes": 78595580,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 39.425000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2022.320000000036,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.1739999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.4379999999999,
"heapDeltaBytes": -9805388,
"heapUsedBytes": 78813316,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.894,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3105.3100000000313,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.144000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1864.029,
"heapDeltaBytes": -19654356,
"heapUsedBytes": 70339188,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 975.7769999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2390.928000000031,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.548,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1593.0069999999998,
"heapDeltaBytes": -20892672,
"heapUsedBytes": 69660280,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 836.1299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665734265734272,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4040.2619999999843,
"styleRecalcs": 71,
"styleRecalcDurationMs": 16.185,
"layouts": 60,
"layoutDurationMs": 16.146,
"taskDurationMs": 1892.6399999999999,
"heapDeltaBytes": 1626700,
"heapUsedBytes": 69936880,
"domNodes": 24,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 889.7750000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3857.2280000000774,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.159999999999998,
"layouts": 60,
"layoutDurationMs": 15.643,
"taskDurationMs": 1775.8990000000001,
"heapDeltaBytes": -19035272,
"heapUsedBytes": 68687300,
"domNodes": 24,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 835.4060000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66623376623377,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3267.2729999999888,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.052999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2143.3869999999997,
"heapDeltaBytes": 17615768,
"heapUsedBytes": 86699976,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 1117.956,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.838860103626942,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3140.688999999952,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.147,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1915.038,
"heapDeltaBytes": 8204864,
"heapUsedBytes": 76782824,
"domNodes": 0,
"jsHeapTotalBytes": 1503232,
"scriptDurationMs": 1015.8000000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.754545454545458,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.5539999999992,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.9210000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.385,
"heapDeltaBytes": -8939564,
"heapUsedBytes": 81134968,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 39.99199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.3929999999891,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.1400000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.447,
"heapDeltaBytes": -10375356,
"heapUsedBytes": 78718604,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 39.47099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 720.2960000000189,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.992000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.06800000000004,
"heapDeltaBytes": -11686332,
"heapUsedBytes": 58140892,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 152.07399999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 641.0609999999224,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.477,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.41,
"heapDeltaBytes": -12405832,
"heapUsedBytes": 58606572,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 144.06999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684193,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.2360000000253,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.414000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.128,
"heapDeltaBytes": 1041620,
"heapUsedBytes": 71091372,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.078999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.6189999999397,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.1009999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.313,
"heapDeltaBytes": 1038452,
"heapUsedBytes": 70563056,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.030000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.5680000000239,
"styleRecalcs": 78,
"styleRecalcDurationMs": 20.852,
"layouts": 16,
"layoutDurationMs": 6.567,
"taskDurationMs": 889.8899999999999,
"heapDeltaBytes": -6424720,
"heapUsedBytes": 63762028,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 129.03799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1713.7169999999742,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.842,
"layouts": 16,
"layoutDurationMs": 5.692000000000001,
"taskDurationMs": 781.3779999999999,
"heapDeltaBytes": -6268744,
"heapUsedBytes": 63234832,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 118.19399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1436.4140000000134,
"styleRecalcs": 16,
"styleRecalcDurationMs": 31.711000000000002,
"layouts": 5,
"layoutDurationMs": 15.306999999999997,
"taskDurationMs": 1037.2799999999997,
"heapDeltaBytes": 3249520,
"heapUsedBytes": 94584464,
"domNodes": 14227,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 35.011,
"eventListeners": 2463,
"totalBlockingTimeMs": 149,
"frameDurationMs": 19.863013698630137,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 10316.843999999946,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.038000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6286.807000000001,
"heapDeltaBytes": -18832548,
"heapUsedBytes": 69617872,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 3054.6349999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665857605177994,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9321.65400000008,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.527,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6002.621,
"heapDeltaBytes": -19017068,
"heapUsedBytes": 69792612,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2932.1200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.695878136200715,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14180.329000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13287.946999999998,
"heapDeltaBytes": -29395744,
"heapUsedBytes": 184088544,
"domNodes": -3045,
"jsHeapTotalBytes": 9195520,
"scriptDurationMs": 254.377,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.215555555555554,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 18506.586000000083,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17544.055,
"heapDeltaBytes": -44124052,
"heapUsedBytes": 179731744,
"domNodes": -3045,
"jsHeapTotalBytes": 2465792,
"scriptDurationMs": 301.707,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.676883561643834,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 22379.302999999993,
"styleRecalcs": 178,
"styleRecalcDurationMs": 22.409999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21955.552,
"heapDeltaBytes": -37414000,
"heapUsedBytes": 176021896,
"domNodes": -3045,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 894.2090000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 29,
"frameDurationMs": 41.22007366482505,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 22082.992999999988,
"styleRecalcs": 177,
"styleRecalcDurationMs": 19.498000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21595.16,
"heapDeltaBytes": -28350672,
"heapUsedBytes": 184807716,
"domNodes": -3046,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 877.9699999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 19,
"frameDurationMs": 40.11963636363637,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6568.049999999971,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.23500000000003,
"layouts": 20,
"layoutDurationMs": 25.788000000000004,
"taskDurationMs": 6419.09,
"heapDeltaBytes": 14763244,
"heapUsedBytes": 223179880,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 117.54599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.27900552486188,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6255.557999999951,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.52100000000002,
"layouts": 20,
"layoutDurationMs": 24.106,
"taskDurationMs": 6154.09,
"heapDeltaBytes": -13119868,
"heapUsedBytes": 214145056,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 104.58200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.861176470588234,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9382.969000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8862.259,
"heapDeltaBytes": -27706284,
"heapUsedBytes": 181130160,
"domNodes": -3045,
"jsHeapTotalBytes": 7622656,
"scriptDurationMs": 166.57100000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.486241610738247,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8870.888000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8512.097000000002,
"heapDeltaBytes": -33850524,
"heapUsedBytes": 180052236,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 136.85000000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.554333333333332,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 126.82600000005095,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.382,
"layouts": 3,
"layoutDurationMs": 1.792,
"taskDurationMs": 94.39,
"heapDeltaBytes": 3829580,
"heapUsedBytes": 70002916,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.826999999999995,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66249999999991,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 108.60800000000381,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.427999999999997,
"layouts": 4,
"layoutDurationMs": 1.8139999999999998,
"taskDurationMs": 86.566,
"heapDeltaBytes": 3814216,
"heapUsedBytes": 70448864,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.874999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.43333333333324,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 897.734000000014,
"styleRecalcs": 78,
"styleRecalcDurationMs": 101.973,
"layouts": 76,
"layoutDurationMs": 25.991,
"taskDurationMs": 867.7660000000001,
"heapDeltaBytes": 18095988,
"heapUsedBytes": 84040252,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 357.558,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 812.3329999999669,
"styleRecalcs": 78,
"styleRecalcDurationMs": 95.414,
"layouts": 76,
"layoutDurationMs": 24.174,
"taskDurationMs": 773.3709999999999,
"heapDeltaBytes": 17149132,
"heapUsedBytes": 83078084,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 312.228,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1425.0729999999976,
"styleRecalcs": 78,
"styleRecalcDurationMs": 267.90999999999997,
"layouts": 76,
"layoutDurationMs": 29.692,
"taskDurationMs": 1407.56,
"heapDeltaBytes": 8757136,
"heapUsedBytes": 114569712,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 478.921,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.916250000000012,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1405.458000000067,
"styleRecalcs": 78,
"styleRecalcDurationMs": 274.10499999999996,
"layouts": 76,
"layoutDurationMs": 29.152,
"taskDurationMs": 1376.9930000000002,
"heapDeltaBytes": 8145308,
"heapUsedBytes": 114815920,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 450.717,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.181818181818183,
"p95FrameDurationMs": 33.30000000000109
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #20653 +/- ##
=============================================
Coverage ? 82.66%
=============================================
Files ? 3407
Lines ? 153748
Branches ? 44037
=============================================
Hits ? 127095
Misses ? 24640
Partials ? 2013
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport of #20649; same files as main.
Backport of #20649 to
cloud/1.56Automatically created by backport workflow.