Repository navigation
[backport core/1.56] FE-3346 fix(billing-web): offer Continue with SSO when the shared session is refused sso_required - #20652
Conversation
…sion is refused sso_required (#20649) ## Summary With the unified web session on, billing-web now offers "Continue with SSO" when creating the shared session is refused `sso_required`. Before, that path showed a generic error and a Retry that failed the same way. - Fixes FE-3346 - Follow-up to #20632 (FE-3342). CodeRabbit's Major finding there was right; we had called it out of scope. ## Why An SSO-held account that signs in on billing-web with Google, GitHub or a password, with the unified session on, never gets "Continue with SSO". It sees "something went wrong" and a Retry that can never succeed. ## Root cause - ingest's Firebase auth runs the SSO gate before `POST /api/auth/session` (`firebase_auth.go` → `sso_gate.go`). Session creation therefore answers 403 `{code: "sso_required", organization_id}`. - account-core's `classifyWebSessionFailure` maps it to `SSO_REQUIRED` but drops `organization_id`. - `unifiedBillingSession.creationFailureCode` turns every non-401 creation failure into `TOKEN_EXCHANGE_FAILED`. - `signInPort.failure` only reads the workspace resolution, which never ran because no session was created. - So `sessionFailureCode` and `ssoOrganizationId` stayed undefined, and `useSsoRequiredRefusal` never fired. ## How - account-core: `WebSessionFailure` gets an optional `organizationId`, which `classifyWebSessionFailure` fills from an `sso_required` body. - billing-web `unifiedBillingSession`: - `creationRefusal` keeps `SSO_REQUIRED` (and its organization) instead of bucketing it. - The refusal is held in `creationFailure` until a session holds or someone signs in. - `signInPort.failure` reports the workspace refusal first, then the creation refusal. - Nothing else changes: the sign-in page already shows Continue with SSO for `SSO_REQUIRED` from #20632. ## AS IS / TO BE | | AS IS | TO BE | | --- | --- | --- | | Unified session on, SSO-held account signs in with Google/email | <img src="https://gist.githubusercontent.com/dante01yoon/5ea450f493bcd0a2ea384e3c104dbab3/raw/ce9c3acb448972fc2d896ce37ee3e8767c632173/20649-as-is.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/5ea450f493bcd0a2ea384e3c104dbab3/raw/ce9c3acb448972fc2d896ce37ee3e8767c632173/20649-to-be.png" width="420"> | The `POST /api/auth/session` 403 `sso_required` refusal (and the rest of Cloud and Firebase) was mocked locally, with the unified session on and no existing session. ## Verification - `webSession.test.ts`: an `sso_required` refusal keeps `organization_id`. - `unifiedBillingSession.test.ts`: a 403 `sso_required` on `POST /api/auth/session` resolves `establish` to `SSO_REQUIRED` and reports `failure` with and without an organization. - account-core `src/core` (1243) and billing-web `src/session src/auth src/views` (498) pass.
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a02a637983049f4d08b54e439a470cc50e7a639b
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2200 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-09T16:36:27.873Z",
"gitSha": "f4bbbd7a769cdd689ebcbd2527dca8fb9a7462e6",
"branch": "backport-20649-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2011.6580000000113,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.079,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.34200000000004,
"heapDeltaBytes": -3200660,
"heapUsedBytes": 58938848,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.153999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.6049999999886,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.614,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.44199999999995,
"heapDeltaBytes": 614220,
"heapUsedBytes": 69046768,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.279000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.5409999999956,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.199,
"layouts": 12,
"layoutDurationMs": 3.6409999999999996,
"taskDurationMs": 633.484,
"heapDeltaBytes": -2416600,
"heapUsedBytes": 66735516,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 120.69200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1777.6029999999992,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.056,
"layouts": 12,
"layoutDurationMs": 4.526,
"taskDurationMs": 749.691,
"heapDeltaBytes": -2135508,
"heapUsedBytes": 65153924,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 142.558,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.560000000034,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.575999999999999,
"layouts": 6,
"layoutDurationMs": 1.3619999999999999,
"taskDurationMs": 305.713,
"heapDeltaBytes": 4099772,
"heapUsedBytes": 71890760,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.065,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.546000000013,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.825,
"layouts": 6,
"layoutDurationMs": 1.1030000000000002,
"taskDurationMs": 283.6569999999999,
"heapDeltaBytes": 4128884,
"heapUsedBytes": 72447952,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.440999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 574.0959999999404,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.542000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.598,
"heapDeltaBytes": -6762184,
"heapUsedBytes": 61633804,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 135.981,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 563.1619999999202,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.83,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.66099999999994,
"heapDeltaBytes": -6456484,
"heapUsedBytes": 61418920,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 138.484,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 998.8489999999501,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 634.294,
"heapDeltaBytes": 11855368,
"heapUsedBytes": 91484556,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 47.788,
"eventListeners": 0,
"totalBlockingTimeMs": 379,
"frameDurationMs": 30.303030303030305,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1062.3159999998961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 745.2149999999999,
"heapDeltaBytes": 15597628,
"heapUsedBytes": 86137260,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 48.89,
"eventListeners": 0,
"totalBlockingTimeMs": 439,
"frameDurationMs": 31.37058823529413,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 801.7429999999877,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.5149999999998,
"heapDeltaBytes": 18405004,
"heapUsedBytes": 104260184,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 128.04000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 162,
"frameDurationMs": 22.857142857142858,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 775.6220000001122,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.8209999999998,
"heapDeltaBytes": 16700580,
"heapUsedBytes": 103453004,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 130.26500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 165,
"frameDurationMs": 23.03823529411768,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6938.591999999971,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9380000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6234.668999999999,
"heapDeltaBytes": -11622656,
"heapUsedBytes": 73292792,
"domNodes": -142,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 4986.076,
"eventListeners": -78,
"totalBlockingTimeMs": 74,
"frameDurationMs": 26.06390977443609,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7539.416999999958,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.6679999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6694.715999999999,
"heapDeltaBytes": -16043420,
"heapUsedBytes": 69151196,
"domNodes": -143,
"jsHeapTotalBytes": -9310208,
"scriptDurationMs": 5346.016,
"eventListeners": -82,
"totalBlockingTimeMs": 38,
"frameDurationMs": 24.806600660066007,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6422.582000000034,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.981000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5920.523,
"heapDeltaBytes": 291604,
"heapUsedBytes": 84870060,
"domNodes": -142,
"jsHeapTotalBytes": -8523776,
"scriptDurationMs": 4769.196999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 37,
"frameDurationMs": 25.461904761904762,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7717.176999999992,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9259999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6843.441000000001,
"heapDeltaBytes": -1739836,
"heapUsedBytes": 83444672,
"domNodes": -142,
"jsHeapTotalBytes": -7475200,
"scriptDurationMs": 5503.790999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 52,
"frameDurationMs": 25.98114478114478,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2008.246999999983,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.9190000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.674,
"heapDeltaBytes": -9612464,
"heapUsedBytes": 79782136,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.86,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.6740000001555,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.8579999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.561,
"heapDeltaBytes": -7580852,
"heapUsedBytes": 78287616,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 35.87800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2139.6179999999276,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.797,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1252.18,
"heapDeltaBytes": -19374072,
"heapUsedBytes": 70441832,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 682.0500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66640625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2140.77599999996,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.049,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1266.048,
"heapDeltaBytes": -18654684,
"heapUsedBytes": 68167448,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 662.779,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66640625,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3235.082000000034,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.588000000000001,
"layouts": 60,
"layoutDurationMs": 13.584,
"taskDurationMs": 1377.692,
"heapDeltaBytes": 26171508,
"heapUsedBytes": 94948220,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 668.9959999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666494845360827,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3220.735999999988,
"styleRecalcs": 74,
"styleRecalcDurationMs": 14.617,
"layouts": 60,
"layoutDurationMs": 13.889000000000001,
"taskDurationMs": 1369.982,
"heapDeltaBytes": 1888892,
"heapUsedBytes": 69512224,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 644.353,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528497409326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2384.990000000016,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.256,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1633.706,
"heapDeltaBytes": 4584012,
"heapUsedBytes": 74218680,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 876.1239999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78380281690141,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2393.880999999965,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.0619999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1595.047,
"heapDeltaBytes": 4967868,
"heapUsedBytes": 74040820,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 848.218,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.783098591549294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.2759999999053,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.712,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.2910000000001,
"heapDeltaBytes": -8709672,
"heapUsedBytes": 81511376,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.775,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2025.3109999998742,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6020000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.76500000000004,
"heapDeltaBytes": -9143464,
"heapUsedBytes": 80849624,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 32.71700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 532.2790000000168,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.916999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.88300000000004,
"heapDeltaBytes": -11684716,
"heapUsedBytes": 58325156,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 117.899,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 531.3510000000861,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.085,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 341.60799999999995,
"heapDeltaBytes": -11664488,
"heapUsedBytes": 58058168,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 126.254,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.4109999999573,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0900000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.56399999999996,
"heapDeltaBytes": 1381608,
"heapUsedBytes": 71937604,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.348000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2014.274000000114,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.818000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.05400000000003,
"heapDeltaBytes": 1022052,
"heapUsedBytes": 70537028,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.217999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.3710000000228,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.326999999999996,
"layouts": 16,
"layoutDurationMs": 5.013,
"taskDurationMs": 606.593,
"heapDeltaBytes": -6001436,
"heapUsedBytes": 64834996,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 93.379,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.358999999944,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.499,
"layouts": 16,
"layoutDurationMs": 4.909999999999999,
"taskDurationMs": 631.0590000000001,
"heapDeltaBytes": -6003512,
"heapUsedBytes": 64191628,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 93.557,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1351.5219999999317,
"styleRecalcs": 17,
"styleRecalcDurationMs": 25.341999999999995,
"layouts": 5,
"layoutDurationMs": 11.528,
"taskDurationMs": 909.6950000000002,
"heapDeltaBytes": 1306560,
"heapUsedBytes": 94498516,
"domNodes": 14227,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 29.671000000000003,
"eventListeners": 2463,
"totalBlockingTimeMs": 94,
"frameDurationMs": 18.72054794520547,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8162.048000000027,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.286,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4650.378,
"heapDeltaBytes": -17819556,
"heapUsedBytes": 70580800,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2359.0550000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666122448979593,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8166.637999999921,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.643,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4726.179999999999,
"heapDeltaBytes": -17547984,
"heapUsedBytes": 71132424,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 2379.852,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591836734694,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14872.936000000096,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14536.673,
"heapDeltaBytes": -36382940,
"heapUsedBytes": 181996768,
"domNodes": -3045,
"jsHeapTotalBytes": 9457664,
"scriptDurationMs": 228.58100000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.49928698752228,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 14952.358999999888,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14551.612000000003,
"heapDeltaBytes": -45897860,
"heapUsedBytes": 181551704,
"domNodes": -3045,
"jsHeapTotalBytes": 8933376,
"scriptDurationMs": 228.83700000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.83913824057451,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 18554.959999999937,
"styleRecalcs": 135,
"styleRecalcDurationMs": 18.706,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18266.89,
"heapDeltaBytes": -53576220,
"heapUsedBytes": 183541576,
"domNodes": -3045,
"jsHeapTotalBytes": 1941504,
"scriptDurationMs": 847.729,
"eventListeners": -14915,
"totalBlockingTimeMs": 33,
"frameDurationMs": 35.70384615384615,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18128.17700000005,
"styleRecalcs": 136,
"styleRecalcDurationMs": 17.036999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17854.305999999997,
"heapDeltaBytes": -35509488,
"heapUsedBytes": 175210700,
"domNodes": -3045,
"jsHeapTotalBytes": 8441856,
"scriptDurationMs": 743.087,
"eventListeners": -14915,
"totalBlockingTimeMs": 3,
"frameDurationMs": 34.1165725047081,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5562.915000000089,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.16799999999998,
"layouts": 20,
"layoutDurationMs": 26.006,
"taskDurationMs": 5480.959000000001,
"heapDeltaBytes": -8073384,
"heapUsedBytes": 214447708,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 97.418,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.839053254437864,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 5415.085999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.947,
"layouts": 20,
"layoutDurationMs": 23.42000000000001,
"taskDurationMs": 5295.230000000001,
"heapDeltaBytes": -13035712,
"heapUsedBytes": 200984036,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 88.944,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.9508875739645,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7670.116000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7492.618,
"heapDeltaBytes": -27474576,
"heapUsedBytes": 181454420,
"domNodes": -3045,
"jsHeapTotalBytes": 8421376,
"scriptDurationMs": 123.12999999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.67617328519856,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7639.778999999862,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7367.887999999999,
"heapDeltaBytes": -21776764,
"heapUsedBytes": 181742264,
"domNodes": -3045,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 124.75599999999993,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.16370106761566,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 472.0439999999826,
"styleRecalcs": 17,
"styleRecalcDurationMs": 16.313000000000002,
"layouts": 4,
"layoutDurationMs": 1.8219999999999998,
"taskDurationMs": 126.83400000000003,
"heapDeltaBytes": 5807004,
"heapUsedBytes": 70962628,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.907999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 465.3659999999036,
"styleRecalcs": 21,
"styleRecalcDurationMs": 18.997,
"layouts": 4,
"layoutDurationMs": 2.6510000000000002,
"taskDurationMs": 111.705,
"heapDeltaBytes": 5752388,
"heapUsedBytes": 71487436,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.995000000000003,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 749.1880000000037,
"styleRecalcs": 78,
"styleRecalcDurationMs": 99.036,
"layouts": 76,
"layoutDurationMs": 25.267999999999997,
"taskDurationMs": 721.646,
"heapDeltaBytes": -15671432,
"heapUsedBytes": 69950180,
"domNodes": 76,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 274.89,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444456,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 647.4860000000717,
"styleRecalcs": 78,
"styleRecalcDurationMs": 91.114,
"layouts": 76,
"layoutDurationMs": 22.923,
"taskDurationMs": 620.513,
"heapDeltaBytes": -16701672,
"heapUsedBytes": 69151968,
"domNodes": 76,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 227.443,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1298.9889999998923,
"styleRecalcs": 78,
"styleRecalcDurationMs": 268.504,
"layouts": 76,
"layoutDurationMs": 27.787,
"taskDurationMs": 1280.762,
"heapDeltaBytes": 8415836,
"heapUsedBytes": 115685628,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 384.504,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1167.7280000001247,
"styleRecalcs": 78,
"styleRecalcDurationMs": 253.842,
"layouts": 76,
"layoutDurationMs": 26.156,
"taskDurationMs": 1142.56,
"heapDeltaBytes": 12742908,
"heapUsedBytes": 133899828,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 335.95599999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.908695652173925,
"p95FrameDurationMs": 16.700000000000728
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.56 #20652 +/- ##
=============================================
- Coverage 85.85% 85.11% -0.75%
=============================================
Files 2466 3508 +1042
Lines 140967 168779 +27812
Branches 36372 44290 +7918
=============================================
+ Hits 121024 143649 +22625
- Misses 19562 23142 +3580
- Partials 381 1988 +1607
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1043 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport of #20649; same files as main.
Backport of #20649 to
core/1.56Automatically created by backport workflow.