Repository navigation
[backport cloud/1.56] FE-3342 fix(billing-web): offer Continue with SSO on an sso_required refusal - #20644
Conversation
…refusal (#20632) **Why.** An account an SSO organization holds that signs in on billing-web with Google, GitHub or email, from a checkout link with no live shared session, is refused with "This account can't manage billing for that workspace." and a link back to the product. It has no way to sign in with SSO. **Root cause.** account-core already reports this refusal as its own code, `SSO_REQUIRED`. `SignInView.vue` maps it to the `ACCESS_DENIED` copy in `WORKSPACE_REFUSAL_COPY`, and billing-web has no SSO path. **How.** Behind `sso_enabled`: - account-core: the token exchange's `SSO_REQUIRED` failure now carries `organizationId` from the refusal body (the same field `ssoRequiredOrganizationId` reads). `fetchCloudFeatures` also carries `sso_enabled`, exposed as `resolveSsoEnabled`, which uses the same shared anonymous `/api/features` fetch as `resolveWebSessionProbe`. - billing-web: the sign-in port reports the refusal (`code` plus `organizationId`) instead of only the code. `useSsoRequiredRefusal` reads `sso_enabled` and the signed-in email only after an `SSO_REQUIRED` refusal. When the flag is on, `SignInView` shows the main app's "Your organization requires single sign-on" copy under billing-web's own `auth.sso` keys, plus a primary **Continue with SSO** button (design-system `buttonVariants`). The button signs out of Firebase, then does a full-page navigation to `ssoStartUrl` on the Cloud origin. It targets the refusing organization when one is named and falls back to the account email. - `ACCESS_DENIED` and `WORKSPACE_NOT_FOUND` are unchanged. With the flag off, or with neither an organization nor an email to start SSO for, `SSO_REQUIRED` keeps today's copy. **Non-obvious: `return_to`.** ingest's `/api/auth/sso/start` (`sso.SafeReturnTo`) and account-core's `ssoStartUrl` only accept a same-origin path. A billing-web URL would be reduced to `/`, so the checkout itself cannot resume after SSO. `return_to` is therefore the product's return path from the entry link (e.g. `/?settings=plan-credits`), or `/` when there is none. Resuming the billing-web checkout would need a cross-origin `return_to` allowlist in ingest. E2E coverage for this fix lives in `apps/billing-web/e2e/sign-in.spec.ts` (billing-web's own Playwright suite), not `browser_tests/`. | | AS IS | TO BE | | --- | --- | --- | | `SSO_REQUIRED`, `sso_enabled` on | <img src="https://gist.githubusercontent.com/dante01yoon/5ea450f493bcd0a2ea384e3c104dbab3/raw/40c795bcdeeae5aaad6a0e1f530ed8bca8068362/20632-as-is.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/5ea450f493bcd0a2ea384e3c104dbab3/raw/40c795bcdeeae5aaad6a0e1f530ed8bca8068362/20632-to-be.png" width="420"> | | `SSO_REQUIRED`, `sso_enabled` off | Same as the AS IS above | Unchanged: same as AS IS | - Unit: `SignInView.test.ts` covers SSO copy and Continue with SSO for an organization-named refusal, an email-only refusal and a refusal without an entry link (exact `ssoStartUrl` asserted, Firebase signed out first). It also covers no action without an organization or email, staying on the page when sign-out fails, and the flag off keeping the workspace refusal. `session.test.ts` covers `organizationId` on an `sso_required` 403. `configSource.test.ts` and `index.test.ts` table-drive `sso_enabled` alongside `web_session_probe`. - `pnpm exec vitest run` on billing-web `src/auth src/session src/config src/views/SignInView.test.ts src/App.test.ts src/router.test.ts`: 230 passed. account-core session/configSource/index: 197 passed. - E2E: new `sign-in.spec.ts` case. Mocked `/features` has `sso_enabled: true` and the mint returns 403 `sso_required` with `organization_id`. After an email sign-in, Continue with SSO lands on `https://testcloud.comfy.org/api/auth/sso/start?email=…&organization=org_e2e&return_to=/?settings=plan-credits`. Full billing-web Playwright suite: 150 passed. - Typecheck: billing-web, account-core and app all ran via the pre-commit hook. (cherry picked from commit a15cc51)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 695715cdc0fd04dd071c9069ff85419bb88e44f5
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2202 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-09T15:08:20.022Z",
"gitSha": "60bc64d905a12f83cc43a858a0cd5cf901d413ad",
"branch": "backport-20632-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.169000000019,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.9429999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 342.45099999999996,
"heapDeltaBytes": 572576,
"heapUsedBytes": 69134440,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.686999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2014.2349999999851,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.314,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.47800000000007,
"heapDeltaBytes": 645720,
"heapUsedBytes": 68553452,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.93,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1691.219999999987,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.229,
"layouts": 12,
"layoutDurationMs": 3.21,
"taskDurationMs": 585.758,
"heapDeltaBytes": -2470076,
"heapUsedBytes": 65634324,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 105.95100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.5209999999797,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.826000000000002,
"layouts": 12,
"layoutDurationMs": 3.477,
"taskDurationMs": 607.642,
"heapDeltaBytes": -2106920,
"heapUsedBytes": 66146612,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 111.77000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667326732673274,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1711.464000000035,
"styleRecalcs": 29,
"styleRecalcDurationMs": 7.599999999999999,
"layouts": 6,
"layoutDurationMs": 1.003,
"taskDurationMs": 272.66,
"heapDeltaBytes": 3760380,
"heapUsedBytes": 72238716,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.304,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.6799999999403,
"styleRecalcs": 31,
"styleRecalcDurationMs": 7.693999999999999,
"layouts": 6,
"layoutDurationMs": 1.2439999999999998,
"taskDurationMs": 284.461,
"heapDeltaBytes": 4060360,
"heapUsedBytes": 71918408,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.320000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 532.747000000029,
"styleRecalcs": 16,
"styleRecalcDurationMs": 2.678,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.22999999999996,
"heapDeltaBytes": -9396308,
"heapUsedBytes": 59713680,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 121.95599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665624999999977,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 546.8190000000277,
"styleRecalcs": 16,
"styleRecalcDurationMs": 2.8539999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.67800000000005,
"heapDeltaBytes": -7385180,
"heapUsedBytes": 61523840,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 124.117,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1049.2459999999824,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 688.2869999999999,
"heapDeltaBytes": 15432832,
"heapUsedBytes": 86130624,
"domNodes": 0,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 45.22600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 441,
"frameDurationMs": 31.815151515151506,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1012.1039999999084,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 656.3100000000001,
"heapDeltaBytes": 38607620,
"heapUsedBytes": 108042180,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 46.35200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 401,
"frameDurationMs": 30.806060606060615,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 749.1259999999897,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.0920000000001,
"heapDeltaBytes": 16856048,
"heapUsedBytes": 104789792,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 115.85399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 126,
"frameDurationMs": 22.055882352941165,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 749.8659999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.3990000000001,
"heapDeltaBytes": -8834544,
"heapUsedBytes": 78378264,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 113.40999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 130,
"frameDurationMs": 22.055882352941165,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7384.409000000005,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.681000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6512.461,
"heapDeltaBytes": 25999436,
"heapUsedBytes": 95812088,
"domNodes": -142,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 5408.142,
"eventListeners": -70,
"totalBlockingTimeMs": 137,
"frameDurationMs": 28.505791505791507,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6333.845999999994,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9670000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5550.968,
"heapDeltaBytes": -3959784,
"heapUsedBytes": 80790276,
"domNodes": -142,
"jsHeapTotalBytes": -9572352,
"scriptDurationMs": 4531.117,
"eventListeners": -74,
"totalBlockingTimeMs": 40,
"frameDurationMs": 25.3324,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6822.818999999981,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9190000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6283.716,
"heapDeltaBytes": 12184392,
"heapUsedBytes": 96487204,
"domNodes": -142,
"jsHeapTotalBytes": -6426624,
"scriptDurationMs": 5016.830000000001,
"eventListeners": -78,
"totalBlockingTimeMs": 185,
"frameDurationMs": 27.048809523809524,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6304.538999999977,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.895,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5738.147,
"heapDeltaBytes": -11818628,
"heapUsedBytes": 72729956,
"domNodes": -142,
"jsHeapTotalBytes": -7737344,
"scriptDurationMs": 4465.731,
"eventListeners": -78,
"totalBlockingTimeMs": 28,
"frameDurationMs": 25.402419354838706,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2010.154,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.5269999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.24000000000007,
"heapDeltaBytes": -9973532,
"heapUsedBytes": 79472920,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 30.843999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.2619999999451,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.498,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.5,
"heapDeltaBytes": -9760484,
"heapUsedBytes": 79232300,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 30.084,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2124.75900000004,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1209.3419999999999,
"heapDeltaBytes": -19265580,
"heapUsedBytes": 70771364,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 612.08,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283467,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2136.0199999999168,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.846000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1208.904,
"heapDeltaBytes": -18835388,
"heapUsedBytes": 71102944,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 623.217,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3262.6319999999964,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.307999999999998,
"layouts": 60,
"layoutDurationMs": 13.424,
"taskDurationMs": 1307.08,
"heapDeltaBytes": -21253700,
"heapUsedBytes": 70000220,
"domNodes": 24,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 593.7479999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665641025641023,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3285.772999999949,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.319,
"layouts": 60,
"layoutDurationMs": 14.587,
"taskDurationMs": 1380.897,
"heapDeltaBytes": 864932,
"heapUsedBytes": 70064960,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 634.596,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666497461928934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2257.820000000038,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.393,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1421.1709999999998,
"heapDeltaBytes": 5175244,
"heapUsedBytes": 73432740,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 710.642,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.790298507462683,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2213.30300000011,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.951,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1446.392,
"heapDeltaBytes": 7264384,
"heapUsedBytes": 76018912,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 732.9359999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793893129770993,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.1699999999837,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.227,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.921,
"heapDeltaBytes": 14093000,
"heapUsedBytes": 82165120,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.30800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.5500000000757,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.216000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.94999999999993,
"heapDeltaBytes": -8602080,
"heapUsedBytes": 81827928,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.935999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 521.5089999999805,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.006999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 307.76300000000003,
"heapDeltaBytes": -12301560,
"heapUsedBytes": 58419556,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 103.77099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 505.6650000000218,
"styleRecalcs": 49,
"styleRecalcDurationMs": 4.817,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.47900000000004,
"heapDeltaBytes": -12628512,
"heapUsedBytes": 58200572,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 101.935,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.4009999999826,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.9709999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.366,
"heapDeltaBytes": 1051864,
"heapUsedBytes": 71823292,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.785999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.8269999999638,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.1210000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.57899999999995,
"heapDeltaBytes": 1016512,
"heapUsedBytes": 71118880,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.7090000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1686.2740000000258,
"styleRecalcs": 76,
"styleRecalcDurationMs": 11.767,
"layouts": 16,
"layoutDurationMs": 4.045999999999999,
"taskDurationMs": 540.798,
"heapDeltaBytes": 15395940,
"heapUsedBytes": 69839272,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 71.254,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.7820000000556,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.545,
"layouts": 16,
"layoutDurationMs": 4.711999999999999,
"taskDurationMs": 596.905,
"heapDeltaBytes": -6348560,
"heapUsedBytes": 64392440,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 79.645,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 916.7029999999841,
"styleRecalcs": 17,
"styleRecalcDurationMs": 24.065000000000005,
"layouts": 5,
"layoutDurationMs": 10.221,
"taskDurationMs": 751.2759999999998,
"heapDeltaBytes": -475232,
"heapUsedBytes": 92277868,
"domNodes": 14227,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 25.416999999999994,
"eventListeners": 2463,
"totalBlockingTimeMs": 119,
"frameDurationMs": 20.371111111111126,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8129.693000000032,
"styleRecalcs": 250,
"styleRecalcDurationMs": 25.372,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4110.417,
"heapDeltaBytes": -18218612,
"heapUsedBytes": 70443916,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 1967.8120000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665983606557376,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8151.106000000027,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.154,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4495.130999999999,
"heapDeltaBytes": -18923156,
"heapUsedBytes": 70180780,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2157.227,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665848670756645,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12803.387999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12103.326,
"heapDeltaBytes": -42441664,
"heapUsedBytes": 179853772,
"domNodes": -3045,
"jsHeapTotalBytes": 6434816,
"scriptDurationMs": 195.124,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.22636815920398,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-idle",
"durationMs": 13467.423000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12597.896999999999,
"heapDeltaBytes": -44683444,
"heapUsedBytes": 178575196,
"domNodes": -3045,
"jsHeapTotalBytes": -942080,
"scriptDurationMs": 201.093,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.08456486042693,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 15916.792999999983,
"styleRecalcs": 83,
"styleRecalcDurationMs": 13.832000000000011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15361.524000000001,
"heapDeltaBytes": -40493588,
"heapUsedBytes": 172553300,
"domNodes": -3045,
"jsHeapTotalBytes": 2117632,
"scriptDurationMs": 779.003,
"eventListeners": -14915,
"totalBlockingTimeMs": 47,
"frameDurationMs": 28.149469964664313,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 16227.170000000002,
"styleRecalcs": 101,
"styleRecalcDurationMs": 15.161999999999981,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15460.361,
"heapDeltaBytes": -51346084,
"heapUsedBytes": 175675860,
"domNodes": -3045,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 753.374,
"eventListeners": -14915,
"totalBlockingTimeMs": 3,
"frameDurationMs": 28.21059027777778,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 4634.060999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.108,
"layouts": 20,
"layoutDurationMs": 22.609000000000005,
"taskDurationMs": 4505.8589999999995,
"heapDeltaBytes": -17122616,
"heapUsedBytes": 208580116,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 79.785,
"eventListeners": 0,
"totalBlockingTimeMs": 1,
"frameDurationMs": 25.739444444444448,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 5171.820999999909,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.25900000000001,
"layouts": 20,
"layoutDurationMs": 23.583999999999993,
"taskDurationMs": 4994.798,
"heapDeltaBytes": 756796,
"heapUsedBytes": 217278560,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 92.154,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.025280898876403,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7044.641000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6607.455999999999,
"heapDeltaBytes": -33348556,
"heapUsedBytes": 179500692,
"domNodes": -3045,
"jsHeapTotalBytes": 630784,
"scriptDurationMs": 106.73300000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.21122112211221,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7052.0910000000185,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6633.686000000001,
"heapDeltaBytes": -32476604,
"heapUsedBytes": 179019992,
"domNodes": -3045,
"jsHeapTotalBytes": 630784,
"scriptDurationMs": 166.02,
"eventListeners": -14915,
"totalBlockingTimeMs": 13,
"frameDurationMs": 23.52173913043478,
"p95FrameDurationMs": 49.89999999999782
},
{
"name": "workflow-execution",
"durationMs": 474.4399999999587,
"styleRecalcs": 20,
"styleRecalcDurationMs": 18.313000000000002,
"layouts": 5,
"layoutDurationMs": 3.1290000000000004,
"taskDurationMs": 125.51500000000001,
"heapDeltaBytes": 6069476,
"heapUsedBytes": 71515168,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.392,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 104.74099999998998,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.547999999999998,
"layouts": 3,
"layoutDurationMs": 1.639,
"taskDurationMs": 67.413,
"heapDeltaBytes": 3672272,
"heapUsedBytes": 70044364,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.334000000000005,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142908,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 496.51699999992616,
"styleRecalcs": 78,
"styleRecalcDurationMs": 74.559,
"layouts": 76,
"layoutDurationMs": 17.09,
"taskDurationMs": 459.04100000000005,
"heapDeltaBytes": 13907968,
"heapUsedBytes": 95325996,
"domNodes": 76,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 168.91,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 446.5460000000121,
"styleRecalcs": 78,
"styleRecalcDurationMs": 71.036,
"layouts": 76,
"layoutDurationMs": 16.277,
"taskDurationMs": 414.78999999999996,
"heapDeltaBytes": -18442404,
"heapUsedBytes": 63913224,
"domNodes": 76,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 142.785,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962983,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 798.9469999999983,
"styleRecalcs": 78,
"styleRecalcDurationMs": 186.24599999999998,
"layouts": 76,
"layoutDurationMs": 16.993000000000002,
"taskDurationMs": 763.943,
"heapDeltaBytes": 4126908,
"heapUsedBytes": 109770364,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 219.49300000000002,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 844.0050000000383,
"styleRecalcs": 78,
"styleRecalcDurationMs": 189.62599999999998,
"layouts": 76,
"layoutDurationMs": 17.284999999999997,
"taskDurationMs": 807.457,
"heapDeltaBytes": -22432668,
"heapUsedBytes": 107118236,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 235.36399999999998,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.56 #20644 +/- ##
=============================================
Coverage ? 82.66%
=============================================
Files ? 3407
Lines ? 153727
Branches ? 44031
=============================================
Hits ? 127075
Misses ? 24638
Partials ? 2014
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation failed to run ( Evaluation budget remaining for this pull request: 99 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
Manual backport of #20632 to
cloud/1.56. The auto-backport hit a conflict.Why
The 1.56 release carries the SSO pilot. Without this fix, an account its SSO organization holds that signs in on billing-web sees "This account can't manage billing for that workspace" and has no way to reach SSO.
Root cause
billing-web treated a
sso_requiredmint refusal like any workspace refusal and had no SSO path. Details are in #20632.How
a15cc51).packages/account-core/src/firebase/index.test.ts.cloud/1.56still uses the localjsonFetch+vi.stubGlobalhelper instead of main'srespondToFetch.resolveWebSessionProbetest now also coversresolveSsoEnabledviadescribe.for.AS IS / TO BE
The behavior is the same as #20632:
SSO_REQUIRED,sso_enabledonVerification
These pass on this branch:
src/firebase,src/sso.test.tsandsrc/core: 1464 testssrc/views,src/sessionandsrc/authvue-tsc --noEmit