Repository navigation
[backport core/1.56] FE-3342 fix(billing-web): offer Continue with SSO on an sso_required refusal - #20643
Conversation
…refusal (#20632) **Why.** An account an SSO organization holds that signs in on billing-web with Google, GitHub or email, from a checkout link with no live shared session, is refused with "This account can't manage billing for that workspace." and a link back to the product. It has no way to sign in with SSO. **Root cause.** account-core already reports this refusal as its own code, `SSO_REQUIRED`. `SignInView.vue` maps it to the `ACCESS_DENIED` copy in `WORKSPACE_REFUSAL_COPY`, and billing-web has no SSO path. **How.** Behind `sso_enabled`: - account-core: the token exchange's `SSO_REQUIRED` failure now carries `organizationId` from the refusal body (the same field `ssoRequiredOrganizationId` reads). `fetchCloudFeatures` also carries `sso_enabled`, exposed as `resolveSsoEnabled`, which uses the same shared anonymous `/api/features` fetch as `resolveWebSessionProbe`. - billing-web: the sign-in port reports the refusal (`code` plus `organizationId`) instead of only the code. `useSsoRequiredRefusal` reads `sso_enabled` and the signed-in email only after an `SSO_REQUIRED` refusal. When the flag is on, `SignInView` shows the main app's "Your organization requires single sign-on" copy under billing-web's own `auth.sso` keys, plus a primary **Continue with SSO** button (design-system `buttonVariants`). The button signs out of Firebase, then does a full-page navigation to `ssoStartUrl` on the Cloud origin. It targets the refusing organization when one is named and falls back to the account email. - `ACCESS_DENIED` and `WORKSPACE_NOT_FOUND` are unchanged. With the flag off, or with neither an organization nor an email to start SSO for, `SSO_REQUIRED` keeps today's copy. **Non-obvious: `return_to`.** ingest's `/api/auth/sso/start` (`sso.SafeReturnTo`) and account-core's `ssoStartUrl` only accept a same-origin path. A billing-web URL would be reduced to `/`, so the checkout itself cannot resume after SSO. `return_to` is therefore the product's return path from the entry link (e.g. `/?settings=plan-credits`), or `/` when there is none. Resuming the billing-web checkout would need a cross-origin `return_to` allowlist in ingest. E2E coverage for this fix lives in `apps/billing-web/e2e/sign-in.spec.ts` (billing-web's own Playwright suite), not `browser_tests/`. | | AS IS | TO BE | | --- | --- | --- | | `SSO_REQUIRED`, `sso_enabled` on | <img src="https://gist.githubusercontent.com/dante01yoon/5ea450f493bcd0a2ea384e3c104dbab3/raw/40c795bcdeeae5aaad6a0e1f530ed8bca8068362/20632-as-is.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/5ea450f493bcd0a2ea384e3c104dbab3/raw/40c795bcdeeae5aaad6a0e1f530ed8bca8068362/20632-to-be.png" width="420"> | | `SSO_REQUIRED`, `sso_enabled` off | Same as the AS IS above | Unchanged: same as AS IS | - Unit: `SignInView.test.ts` covers SSO copy and Continue with SSO for an organization-named refusal, an email-only refusal and a refusal without an entry link (exact `ssoStartUrl` asserted, Firebase signed out first). It also covers no action without an organization or email, staying on the page when sign-out fails, and the flag off keeping the workspace refusal. `session.test.ts` covers `organizationId` on an `sso_required` 403. `configSource.test.ts` and `index.test.ts` table-drive `sso_enabled` alongside `web_session_probe`. - `pnpm exec vitest run` on billing-web `src/auth src/session src/config src/views/SignInView.test.ts src/App.test.ts src/router.test.ts`: 230 passed. account-core session/configSource/index: 197 passed. - E2E: new `sign-in.spec.ts` case. Mocked `/features` has `sso_enabled: true` and the mint returns 403 `sso_required` with `organization_id`. After an email sign-in, Continue with SSO lands on `https://testcloud.comfy.org/api/auth/sso/start?email=…&organization=org_e2e&return_to=/?settings=plan-credits`. Full billing-web Playwright suite: 150 passed. - Typecheck: billing-web, account-core and app all ran via the pre-commit hook. (cherry picked from commit a15cc51)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4119bccb033b7e09888fe5033e82498d31176d1b
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2202 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-09T15:10:17.392Z",
"gitSha": "37ff90d301c0fcfa2d5f0c9de21500c42231d0ff",
"branch": "backport-20632-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.9179999999706,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.660000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.798,
"heapDeltaBytes": 629468,
"heapUsedBytes": 68009704,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.143,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.3399999999756,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.6169999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.74500000000006,
"heapDeltaBytes": 428500,
"heapUsedBytes": 65642940,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.032000000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1909.1039999999566,
"styleRecalcs": 75,
"styleRecalcDurationMs": 20.401000000000003,
"layouts": 12,
"layoutDurationMs": 4.7299999999999995,
"taskDurationMs": 882.1600000000001,
"heapDeltaBytes": -2151412,
"heapUsedBytes": 65392628,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 162.002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684207,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1826.9270000000688,
"styleRecalcs": 75,
"styleRecalcDurationMs": 19.573,
"layouts": 12,
"layoutDurationMs": 5.156,
"taskDurationMs": 870.477,
"heapDeltaBytes": -2117984,
"heapUsedBytes": 65452644,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 158.92600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665454545454544,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.4329999999627,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.158000000000001,
"layouts": 6,
"layoutDurationMs": 1.5800000000000003,
"taskDurationMs": 412.917,
"heapDeltaBytes": 4099324,
"heapUsedBytes": 71832580,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.777999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1735.0049999998873,
"styleRecalcs": 29,
"styleRecalcDurationMs": 10.492999999999999,
"layouts": 6,
"layoutDurationMs": 1.4259999999999997,
"taskDurationMs": 398.69,
"heapDeltaBytes": 4104460,
"heapUsedBytes": 71509196,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.033999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 755.6690000000117,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.7889999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.397,
"heapDeltaBytes": -6424504,
"heapUsedBytes": 61177236,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 167.443,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444435,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 745.1419999999871,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.5300000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.683,
"heapDeltaBytes": -8209876,
"heapUsedBytes": 56534252,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 170.353,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1200.8850000000848,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 897.9780000000001,
"heapDeltaBytes": 15920624,
"heapUsedBytes": 85007652,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 65.47900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 575,
"frameDurationMs": 36.36363636363637,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1181.1989999999923,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 872.2690000000001,
"heapDeltaBytes": 38971536,
"heapUsedBytes": 107933620,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 64.47899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 554,
"frameDurationMs": 34.8029411764706,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 833.268999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.4250000000004,
"heapDeltaBytes": 17667668,
"heapUsedBytes": 104659664,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 151.15500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 189,
"frameDurationMs": 23.805714285714306,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 827.0630000000665,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.20799999999997,
"heapDeltaBytes": 18728672,
"heapUsedBytes": 104863220,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 152.44299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 186,
"frameDurationMs": 23.805714285714306,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9506.309999999985,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06800000000000035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8543.873,
"heapDeltaBytes": -383660,
"heapUsedBytes": 84130536,
"domNodes": -142,
"jsHeapTotalBytes": -10358784,
"scriptDurationMs": 6756.286999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 510,
"frameDurationMs": 32.75724137931034,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9175.667000000089,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8423.976,
"heapDeltaBytes": -9618948,
"heapUsedBytes": 68369040,
"domNodes": -142,
"jsHeapTotalBytes": -13504512,
"scriptDurationMs": 6664.817,
"eventListeners": -74,
"totalBlockingTimeMs": 289,
"frameDurationMs": 32.97194244604316,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9216.42499999996,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.060000000000001025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8477.756,
"heapDeltaBytes": -11166604,
"heapUsedBytes": 74281984,
"domNodes": -143,
"jsHeapTotalBytes": -5902336,
"scriptDurationMs": 6721.813,
"eventListeners": -82,
"totalBlockingTimeMs": 444,
"frameDurationMs": 33.39239130434783,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8904.651000000058,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.42400000000000077,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8259.191,
"heapDeltaBytes": -9126608,
"heapUsedBytes": 68417452,
"domNodes": -142,
"jsHeapTotalBytes": -659456,
"scriptDurationMs": 6533.317999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 437,
"frameDurationMs": 33.33183520599251,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2015.0600000000622,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.0879999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.273,
"heapDeltaBytes": -7518248,
"heapUsedBytes": 77815500,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 34.61,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2037.3819999999796,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.5720000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.543,
"heapDeltaBytes": -7652236,
"heapUsedBytes": 77883520,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.43599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3112.934999999993,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.700000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1770.34,
"heapDeltaBytes": -7126476,
"heapUsedBytes": 78766256,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 902.1640000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665775401069524,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2967.379000000051,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.304000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1564.1949999999997,
"heapDeltaBytes": -19022916,
"heapUsedBytes": 70297832,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 863.521,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666292134831462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3991.8230000000676,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.515,
"layouts": 60,
"layoutDurationMs": 14.657,
"taskDurationMs": 1764.4969999999998,
"heapDeltaBytes": 1225280,
"heapUsedBytes": 69940596,
"domNodes": 24,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 807.619,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.735983263598325,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4016.939999999977,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.544,
"layouts": 60,
"layoutDurationMs": 14.676000000000002,
"taskDurationMs": 1762.948,
"heapDeltaBytes": 1177376,
"heapUsedBytes": 69927400,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 800.9649999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665975103734436,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3221.894999999904,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.725,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2108.822,
"heapDeltaBytes": 17968772,
"heapUsedBytes": 85715320,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 1065.008,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.752604166666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3128.898999999933,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.5329999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2013.118,
"heapDeltaBytes": -12973908,
"heapUsedBytes": 74324616,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 998.5290000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755376344086027,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2020.941999999991,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.465000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.1540000000001,
"heapDeltaBytes": 13772104,
"heapUsedBytes": 81863456,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.626000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2022.7399999998852,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.275000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.5910000000001,
"heapDeltaBytes": -9244364,
"heapUsedBytes": 80694536,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.595,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 723.1960000000299,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.561999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.13399999999996,
"heapDeltaBytes": -11695924,
"heapUsedBytes": 58243024,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 150.285,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 738.6689999999589,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.663999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.821,
"heapDeltaBytes": -11685380,
"heapUsedBytes": 58056620,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 146.863,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2012.5279999999748,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.3729999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.78799999999995,
"heapDeltaBytes": 969996,
"heapUsedBytes": 70534972,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.064000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.8180000000293,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.4830000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.9339999999999,
"heapDeltaBytes": 1089936,
"heapUsedBytes": 70620812,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.670999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1785.3489999999965,
"styleRecalcs": 78,
"styleRecalcDurationMs": 21.908,
"layouts": 16,
"layoutDurationMs": 6.954999999999999,
"taskDurationMs": 887.1070000000001,
"heapDeltaBytes": -5939636,
"heapUsedBytes": 64058796,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 114.43799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.5849999999964,
"styleRecalcs": 78,
"styleRecalcDurationMs": 19.637999999999995,
"layouts": 16,
"layoutDurationMs": 6.370999999999999,
"taskDurationMs": 871.1800000000001,
"heapDeltaBytes": -5964068,
"heapUsedBytes": 63994000,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 114.515,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.933999999983,
"styleRecalcs": 17,
"styleRecalcDurationMs": 26.884999999999998,
"layouts": 5,
"layoutDurationMs": 12.704999999999998,
"taskDurationMs": 958.647,
"heapDeltaBytes": 5119564,
"heapUsedBytes": 98594660,
"domNodes": 14227,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 33.259,
"eventListeners": 2463,
"totalBlockingTimeMs": 131,
"frameDurationMs": 19.143243243243248,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 11111.678999999982,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.964999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6125.9490000000005,
"heapDeltaBytes": -4471420,
"heapUsedBytes": 83822884,
"domNodes": 0,
"jsHeapTotalBytes": 1015808,
"scriptDurationMs": 2895.116,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66606606606607,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10838.270999999964,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.442,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6130.545,
"heapDeltaBytes": -8610360,
"heapUsedBytes": 80084672,
"domNodes": 0,
"jsHeapTotalBytes": 1015808,
"scriptDurationMs": 2883.1600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153847,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16668.003999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16118.427999999998,
"heapDeltaBytes": -36901504,
"heapUsedBytes": 184587152,
"domNodes": -3045,
"jsHeapTotalBytes": 7708672,
"scriptDurationMs": 262.381,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.86280276816609,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 16052.91000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15358.038,
"heapDeltaBytes": -33318936,
"heapUsedBytes": 179633320,
"domNodes": -3046,
"jsHeapTotalBytes": 5787648,
"scriptDurationMs": 249.56699999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.587366548042706,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 20208.163000000015,
"styleRecalcs": 142,
"styleRecalcDurationMs": 20.284000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19928.342,
"heapDeltaBytes": -15950496,
"heapUsedBytes": 191876468,
"domNodes": -3052,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 914.0970000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 28,
"frameDurationMs": 38.443047619047626,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 19814.301000000116,
"styleRecalcs": 150,
"styleRecalcDurationMs": 20.74500000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19541.421,
"heapDeltaBytes": -55853000,
"heapUsedBytes": 166660368,
"domNodes": -3045,
"jsHeapTotalBytes": 630784,
"scriptDurationMs": 898.5000000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 11,
"frameDurationMs": 36.69592592592593,
"p95FrameDurationMs": 83.20000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5835.82100000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.08800000000002,
"layouts": 20,
"layoutDurationMs": 27.983999999999995,
"taskDurationMs": 5742.192,
"heapDeltaBytes": 372992,
"heapUsedBytes": 214059484,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 101.602,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.62080924855492,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5959.527999999864,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.17899999999997,
"layouts": 20,
"layoutDurationMs": 26.815000000000005,
"taskDurationMs": 5892.351000000001,
"heapDeltaBytes": 3071464,
"heapUsedBytes": 217755880,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 104.193,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.71022727272727,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8353.761000000077,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8011.628,
"heapDeltaBytes": -24733244,
"heapUsedBytes": 180679908,
"domNodes": -3045,
"jsHeapTotalBytes": 5120000,
"scriptDurationMs": 131.96799999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.79206896551723,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8166.096000000152,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7838.870000000002,
"heapDeltaBytes": -16292412,
"heapUsedBytes": 186852412,
"domNodes": -3045,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 126.38500000000008,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.2100358422939,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 502.0279999999957,
"styleRecalcs": 23,
"styleRecalcDurationMs": 23.058000000000003,
"layouts": 5,
"layoutDurationMs": 2.535,
"taskDurationMs": 162.917,
"heapDeltaBytes": 6000140,
"heapUsedBytes": 71402612,
"domNodes": 129,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 17.459999999999997,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 509.22300000001997,
"styleRecalcs": 21,
"styleRecalcDurationMs": 17.876,
"layouts": 4,
"layoutDurationMs": 2.195,
"taskDurationMs": 142.52700000000002,
"heapDeltaBytes": 5675064,
"heapUsedBytes": 71386256,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.823999999999995,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.24137931034483,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1165.1130000000194,
"styleRecalcs": 78,
"styleRecalcDurationMs": 110.179,
"layouts": 76,
"layoutDurationMs": 33.619,
"taskDurationMs": 1144.0220000000002,
"heapDeltaBytes": 20154648,
"heapUsedBytes": 90033472,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 451.721,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.90869565217391,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1258.9249999998628,
"styleRecalcs": 78,
"styleRecalcDurationMs": 115.83699999999999,
"layouts": 76,
"layoutDurationMs": 34.102000000000004,
"taskDurationMs": 1222.843,
"heapDeltaBytes": 20296528,
"heapUsedBytes": 89555340,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 486.88100000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.6056338028169,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1558.840999999802,
"styleRecalcs": 78,
"styleRecalcDurationMs": 283.95799999999997,
"layouts": 76,
"layoutDurationMs": 31.633000000000003,
"taskDurationMs": 1528.07,
"heapDeltaBytes": 8450580,
"heapUsedBytes": 114671244,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 484.21000000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.620253164556964,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1538.812999999891,
"styleRecalcs": 78,
"styleRecalcDurationMs": 279.52900000000005,
"layouts": 76,
"layoutDurationMs": 31.281999999999996,
"taskDurationMs": 1510.45,
"heapDeltaBytes": 8458028,
"heapUsedBytes": 114264584,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 492.20799999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.408860759493663,
"p95FrameDurationMs": 33.399999999999636
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.56 #20643 +/- ##
=============================================
- Coverage 85.85% 85.11% -0.75%
=============================================
Files 2466 3508 +1042
Lines 140945 168754 +27809
Branches 36366 44285 +7919
=============================================
+ Hits 121010 143634 +22624
- Misses 19554 23131 +3577
- Partials 381 1989 +1608
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1036 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Manual backport of #20632 to
core/1.56. The auto-backport hit a conflict.Why
The 1.56 release carries the SSO pilot. Without this fix, an account its SSO organization holds that signs in on billing-web sees "This account can't manage billing for that workspace" and has no way to reach SSO.
Root cause
billing-web treated a
sso_requiredmint refusal like any workspace refusal and had no SSO path. Details are in #20632.How
a15cc51).packages/account-core/src/firebase/index.test.ts.core/1.56still uses the localjsonFetch+vi.stubGlobalhelper instead of main'srespondToFetch.resolveWebSessionProbetest now also coversresolveSsoEnabledviadescribe.for.AS IS / TO BE
The behavior is the same as #20632:
SSO_REQUIRED,sso_enabledonVerification
These pass on this branch:
src/firebase,src/sso.test.tsandsrc/core: 1464 testssrc/views,src/sessionandsrc/authvue-tsc --noEmit