Skip to content

feat(website): Cinematic Studio full screen on the shared editor, behind a flag - #20638

Draft
mariana953 wants to merge 22 commits into
mariana/editor-kitfrom
mariana/cinematic-fullscreen
Draft

mariana953 wants to merge 22 commits into
mariana/editor-kitfrom
mariana/cinematic-fullscreen

Conversation

@mariana953

@mariana953 mariana953 commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Cinematic Studio renders full screen on AppEditorShell when workshop-cinematic-fullscreen-enabled is on (staff only). With the flag off the page is unchanged. Built on the shared editor kit (#20630).

Changes

  • What:
    • CinematicStudioPage reads the flag; for Studio on the default side-panel layout it renders the new CinematicStudioEditor, otherwise today's components.
    • CinematicStudioEditor:
      • Header: Back, title, BETA, GitHub, account, and Download once the selected take is finished.
      • Floating panel on desktop, bottom sheet on phones (collapsed sheet shows model, scene and aspect ratio).
      • Generate, cancel, cost and credit flows in the panel footer via the existing CinematicGenerateAction.
      • Pickers open beside the panel on desktop, as a sheet on phones.
      • Keeps the leave guard, the busy check when switching apps, and palette editing.
      • Sets data-workshop-editor on <html> while mounted.
    • CinematicEditorStage: take bar (shot, model, download), take frame sized to the free space, skipped-credits summary, takes strip.
    • CinematicPanel is split into CinematicPanelFields and CinematicPanelRun; its props and events are unchanged.
    • SiteFooter hides under [data-workshop-editor] (one class).

Review Focus

  • Flag off must look and behave exactly as production.
  • Not carried into the shell yet: the lead paragraph, analytics on the header GitHub link and header Download (the take bar's download keeps output_download_clicked). Videos still use the native <video> as today.
  • At 1440 px the 280 px panel shortens the camera row values to chips.

Screenshots (if applicable)

Preview: https://comfy-website-preview-pr-20638.vercel.app/hub/apps/cinematic-studio/ (staff, flag workshop-cinematic-fullscreen-enabled)

…hind a flag

Behind workshop-cinematic-fullscreen-enabled, the side-panel layout renders
on AppEditorShell: floating shot settings on desktop, a bottom sheet on
phones, the take on the stage and its download in the header. The site
header, banner and footer hide while it is open. Flag off keeps today's page.
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 972607cb-ac82-4c6c-b204-9c9522fb25f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (21 changed files).

Kind Finding Where Usual remedy
Duplication 3-way clone apps/website/src/components/workshop/cinematic-studio/CinematicPanel.vue:89-99
apps/website/src/components/workshop/cinematic-studio/CinematicStudioEditor.vue:173-183
apps/website/src/components/workshop/cinematic-studio/CinematicStudioPanel.vue:146-156
Extract the shared fragment into one function the sites call.

Pre-existing findings are baselined in .fallow-baselines/ and are not your
responsibility — see ADR-DEVEX-LINT-0015.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 308203a7462146cc8411094d66c480c78a92f0e4

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-20638.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-rgqsmxqlr-comfyui.vercel.app

Last updated: 2026-10-13T03:01:44Z for bc4437d

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.53448% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...orkshop/cinematic-studio/CinematicStudioEditor.vue 89.23% 4 Missing and 3 partials ⚠️
...s/workshop/cinematic-studio/CinematicAppDetail.vue 93.54% 0 Missing and 2 partials ⚠️
...workshop/cinematic-studio/CinematicEditorStage.vue 89.47% 0 Missing and 2 partials ⚠️
...onents/workshop/cinematic-studio/reference-kind.ts 60.00% 0 Missing and 2 partials ⚠️
.../components/workshop/app-editor/AppEditorShell.vue 50.00% 0 Missing and 1 partial ⚠️
.../workshop/cinematic-studio/CinematicStudioPage.vue 96.15% 1 Missing ⚠️
@@                  Coverage Diff                   @@
##           mariana/editor-kit   #20638      +/-   ##
======================================================
+ Coverage               85.73%   85.76%   +0.03%     
======================================================
  Files                    3549     3552       +3     
  Lines                  169364   169952     +588     
  Branches                46465    46635     +170     
======================================================
+ Hits                   145200   145763     +563     
- Misses                  22284    22298      +14     
- Partials                 1880     1891      +11     
Flag Coverage Δ
website-unit 80.20% <93.53%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/components/common/SiteFooter.vue 95.45% <ø> (-4.55%) ⬇️
...nents/workshop/cinematic-studio/CinematicPanel.vue 100.00% <100.00%> (+1.85%) ⬆️
...workshop/cinematic-studio/CinematicPanelFields.vue 100.00% <100.00%> (ø)
...ts/workshop/cinematic-studio/CinematicPanelRun.vue 100.00% <100.00%> (ø)
...orkshop/cinematic-studio/CinematicStartingTile.vue 100.00% <100.00%> (ø)
...site/src/lib/workshop/cinematic-studio/starters.ts 100.00% <100.00%> (ø)
.../components/workshop/app-editor/AppEditorShell.vue 66.66% <50.00%> (+66.66%) ⬆️
.../workshop/cinematic-studio/CinematicStudioPage.vue 90.56% <96.15%> (+1.67%) ⬆️
...s/workshop/cinematic-studio/CinematicAppDetail.vue 93.54% <93.54%> (ø)
...workshop/cinematic-studio/CinematicEditorStage.vue 89.47% <89.47%> (ø)
... and 2 more

... and 90 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 9, 2026
… the panel

The video or first frame a clip starts from now sits alone above the model
and scene, on the editor kit source tile, instead of among the scene box
references. The ending frame and the character stay in the scene box. An
optional first frame can be removed from the tile; a required source video
can only be replaced. The site-page panel is unchanged.
@github-actions

Copy link
Copy Markdown
Contributor

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Oxfmt formatting

@github-actions

Copy link
Copy Markdown
Contributor

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Oxfmt formatting

@github-actions

Copy link
Copy Markdown
Contributor

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Oxfmt formatting

# Conflicts:
#	apps/website/src/components/workshop/cinematic-studio/CinematicStudioPage.vue
# Conflicts:
#	apps/website/src/components/workshop/cinematic-studio/CinematicStudioPage.vue
…e, and the starting input comes out with an X

This branch was previously deployed

1 inactive deployment
website-approval — f1d0e76f Deployed Oct 14, 2026 by mariana953 via fast-lane #1832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants