Repository navigation
feat(website): Cinematic Studio full screen on the shared editor, behind a flag - #20638
mariana953 wants to merge 22 commits into
Conversation
…hind a flag Behind workshop-cinematic-fullscreen-enabled, the side-panel layout renders on AppEditorShell: floating shot settings on desktop, a bottom sheet on phones, the take on the stage and its download in the header. The site header, banner and footer hide while it is open. Flag off keeps today's page.
…/cinematic-fullscreen
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (21 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 308203a7462146cc8411094d66c480c78a92f0e4
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-20638.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-rgqsmxqlr-comfyui.vercel.app Last updated: 2026-10-13T03:01:44Z for |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## mariana/editor-kit #20638 +/- ##
======================================================
+ Coverage 85.73% 85.76% +0.03%
======================================================
Files 3549 3552 +3
Lines 169364 169952 +588
Branches 46465 46635 +170
======================================================
+ Hits 145200 145763 +563
- Misses 22284 22298 +14
- Partials 1880 1891 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 90 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…/cinematic-fullscreen
… the panel The video or first frame a clip starts from now sits alone above the model and scene, on the editor kit source tile, instead of among the scene box references. The ending frame and the character stay in the scene box. An optional first frame can be removed from the tile; a required source video can only be replaced. The site-page panel is unchanged.
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
# Conflicts: # apps/website/src/components/workshop/cinematic-studio/CinematicStudioPage.vue
# Conflicts: # apps/website/src/components/workshop/cinematic-studio/CinematicStudioPage.vue
…nd lays the format row in two columns
…e, and the starting input comes out with an X
Summary
Cinematic Studio renders full screen on
AppEditorShellwhenworkshop-cinematic-fullscreen-enabledis on (staff only). With the flag off the page is unchanged. Built on the shared editor kit (#20630).Changes
CinematicStudioPagereads the flag; for Studio on the default side-panel layout it renders the newCinematicStudioEditor, otherwise today's components.CinematicStudioEditor:CinematicGenerateAction.data-workshop-editoron<html>while mounted.CinematicEditorStage: take bar (shot, model, download), take frame sized to the free space, skipped-credits summary, takes strip.CinematicPanelis split intoCinematicPanelFieldsandCinematicPanelRun; its props and events are unchanged.SiteFooterhides under[data-workshop-editor](one class).Review Focus
output_download_clicked). Videos still use the native<video>as today.Screenshots (if applicable)
Preview: https://comfy-website-preview-pr-20638.vercel.app/hub/apps/cinematic-studio/ (staff, flag
workshop-cinematic-fullscreen-enabled)