Skip to content

feat(website): Re-shoot full screen on the shared editor, behind a flag - #20637

Draft
mariana953 wants to merge 14 commits into
mariana/editor-kitfrom
mariana/reshoot-fullscreen
Draft

mariana953 wants to merge 14 commits into
mariana/editor-kitfrom
mariana/reshoot-fullscreen

Conversation

@mariana953

@mariana953 mariana953 commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Re-shoot renders full screen on AppEditorShell when workshop-reshoot-fullscreen-enabled is on (staff only). With the flag off the page is unchanged. Built on the shared editor kit (#20630).

Changes

  • What:
    • ReshootStudio reads the flag and renders the new ReshootEditor or today's layout. Both keep the same useReshoot state and leave dialog.
    • ReshootEditor:
      • Header: Back, title, BETA, GitHub, account, and Download once a take is done (follows the Generated / Original audio choice, same file names).
      • Before a pick: the stage shows upload, examples and the credit line.
      • After a pick: floating panel on desktop, bottom sheet on phones. The panel footer holds Generate / Try again, the price and free runs left.
      • Sets data-workshop-editor on <html> while mounted.
    • ReshootEditorStage: takes strip, aim viewport / take in EditorFrame (16:9, zoom), aim timeline, take caption. The stage's own fullscreen toggle only shows with the flag off.
    • ReshootEditorDock: Result / Warp guide / Source, Generated / Original audio, Use this angle again.
    • ReshootSide is split into ReshootSettings and ReshootRun so both layouts share the controls; flag-off rendering is unchanged.
    • SiteFooter hides under [data-workshop-editor] (one class).

Review Focus

  • Flag off must look and behave exactly as production.
  • Uploading a webm in the local preview never started the scene read with the flag on or off; the example worked. Possibly a local test-setup quirk, not investigated here.

Screenshots (if applicable)

Preview: https://comfy-website-preview-pr-20637.vercel.app/hub/apps/reshoot/ (staff, flag workshop-reshoot-fullscreen-enabled)

With workshop-reshoot-fullscreen-enabled on, Re-shoot renders on
AppEditorShell: header with download, floating settings panel or bottom
sheet, takes and stage in the middle, result views and sound in the dock.
The settings body and run footer are split out of ReshootSide so both
layouts share them; flag off keeps today's page layout.
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: e42d5642-047c-4522-8af8-43bc20b50a10

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 308203a7462146cc8411094d66c480c78a92f0e4

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-20637.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-pk5uzmayz-comfyui.vercel.app

Last updated: 2026-10-13T03:07:36Z for 093d208

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.58333% with 37 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...kshop/cinematic-studio/reshoot/ReshootSettings.vue 69.81% 13 Missing and 3 partials ⚠️
...orkshop/cinematic-studio/reshoot/ReshootEditor.vue 85.71% 4 Missing and 4 partials ⚠️
...s/workshop/cinematic-studio/reshoot/ReshootRun.vue 68.75% 2 Missing and 3 partials ⚠️
...cinematic-studio/reshoot/ReshootEditorSettings.vue 92.68% 0 Missing and 3 partials ⚠️
.../workshop/cinematic-studio/reshoot/ReshootPage.vue 92.30% 0 Missing and 2 partials ⚠️
...hop/cinematic-studio/reshoot/ReshootEditorDock.vue 91.66% 1 Missing ⚠️
...op/cinematic-studio/reshoot/ReshootEditorStage.vue 95.00% 0 Missing and 1 partial ⚠️
...orkshop/cinematic-studio/reshoot/ReshootStudio.vue 66.66% 0 Missing and 1 partial ⚠️
@@                  Coverage Diff                   @@
##           mariana/editor-kit   #20637      +/-   ##
======================================================
+ Coverage               85.73%   85.75%   +0.02%     
======================================================
  Files                    3549     3553       +4     
  Lines                  169364   169510     +146     
  Branches                46465    46497      +32     
======================================================
+ Hits                   145200   145371     +171     
+ Misses                  22284    22243      -41     
- Partials                 1880     1896      +16     
Flag Coverage Δ
website-unit 80.25% <84.58%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/components/common/SiteFooter.vue 95.45% <ø> (-4.55%) ⬇️
...orkshop/cinematic-studio/reshoot/ReshootAimRig.vue 90.47% <100.00%> (ø)
...orkshop/cinematic-studio/reshoot/ReshootFormat.vue 91.30% <ø> (ø)
.../workshop/cinematic-studio/reshoot/ReshootSide.vue 100.00% <100.00%> (+33.33%) ⬆️
...hop/cinematic-studio/reshoot/ReshootEditorDock.vue 91.66% <91.66%> (ø)
...op/cinematic-studio/reshoot/ReshootEditorStage.vue 95.00% <95.00%> (ø)
...orkshop/cinematic-studio/reshoot/ReshootStudio.vue 75.00% <66.66%> (-11.67%) ⬇️
.../workshop/cinematic-studio/reshoot/ReshootPage.vue 92.30% <92.30%> (ø)
...cinematic-studio/reshoot/ReshootEditorSettings.vue 92.68% <92.68%> (ø)
...s/workshop/cinematic-studio/reshoot/ReshootRun.vue 68.75% <68.75%> (ø)
... and 2 more

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 9, 2026
mariana953 and others added 4 commits October 9, 2026 18:49
…e prompt box

The clip sits alone at the top as the editor source tile with its length
chip; the optional prompt leaves the Advanced fold for one prompt box whose
placeholder carries the dialogue guidance; the seed joins the format bar at
the same 40px height; loose notes and the credit line leave the panel. The
page layout keeps its panel as it was.
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Oxfmt formatting

This branch was previously deployed

1 inactive deployment
website-approval — 0e61dbb2 Deployed Oct 14, 2026 by mariana953 via fast-lane #1852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants