Repository navigation
feat(website): Re-shoot full screen on the shared editor, behind a flag - #20637
mariana953 wants to merge 14 commits into
Conversation
With workshop-reshoot-fullscreen-enabled on, Re-shoot renders on AppEditorShell: header with download, floating settings panel or bottom sheet, takes and stage in the middle, result views and sound in the dock. The settings body and run footer are split out of ReshootSide so both layouts share them; flag off keeps today's page layout.
…/reshoot-fullscreen
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 308203a7462146cc8411094d66c480c78a92f0e4
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-20637.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-pk5uzmayz-comfyui.vercel.app Last updated: 2026-10-13T03:07:36Z for |
…/reshoot-fullscreen
…e prompt box The clip sits alone at the top as the editor source tile with its length chip; the optional prompt leaves the Advanced fold for one prompt box whose placeholder carries the dialogue guidance; the seed joins the format bar at the same 40px height; loose notes and the credit line leave the panel. The page layout keeps its panel as it was.
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
… with an X, back to the start
Summary
Re-shoot renders full screen on
AppEditorShellwhenworkshop-reshoot-fullscreen-enabledis on (staff only). With the flag off the page is unchanged. Built on the shared editor kit (#20630).Changes
ReshootStudioreads the flag and renders the newReshootEditoror today's layout. Both keep the sameuseReshootstate and leave dialog.ReshootEditor:data-workshop-editoron<html>while mounted.ReshootEditorStage: takes strip, aim viewport / take inEditorFrame(16:9, zoom), aim timeline, take caption. The stage's own fullscreen toggle only shows with the flag off.ReshootEditorDock: Result / Warp guide / Source, Generated / Original audio, Use this angle again.ReshootSideis split intoReshootSettingsandReshootRunso both layouts share the controls; flag-off rendering is unchanged.SiteFooterhides under[data-workshop-editor](one class).Review Focus
Screenshots (if applicable)
Preview: https://comfy-website-preview-pr-20637.vercel.app/hub/apps/reshoot/ (staff, flag
workshop-reshoot-fullscreen-enabled)