Skip to content

feat(website): Openjutsu full screen on the shared editor - #20636

Merged
comfyrob merged 27 commits into
rob/app-openjutsufrom
mariana/openjutsu-fullscreen
Oct 13, 2026
Merged

comfyrob merged 27 commits into
rob/app-openjutsufrom
mariana/openjutsu-fullscreen

Conversation

@mariana953

@mariana953 mariana953 commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Moves Openjutsu onto the shared full-screen editor (#20630) so it matches the other Workshop apps, and simplifies how a video goes in.

Changes

  • What:
    • OpenjutsuStudio builds on AppEditorShell: floating panel on desktop, bottom sheet on phones, header with Back, Download and the account.
    • The panel is always shown and holds Video, New character, Who to replace, Quality and Seed (on its own row so it is not cut off).
    • A new video is used at once from its start, up to 15 s; no trim step. Only a longer video gets a quiet line under it in the panel ("Using the first 15 s · Change"), and Change opens the trim dialog. An unreadable or too-short video still opens the dialog, which says why.
    • The video's name sits over its cover, with an X to take it out and "Undo remove video" at the bottom to put it back.
    • The site footer is hidden while an app is full screen, and on phones the settings sheet starts open.
    • With no video, the stage shows four examples (clips and characters in public/images/apps/openjutsu/examples). Picking one loads its clip, character and who to replace on the default settings (768p, random seed). Uploading lives in the panel; no drag and drop.
    • The stage uses the site VideoPlayer with its existing controls. While a take is running, EditorBusy shows the phase, the elapsed time and Cancel.
    • The result dock offers Compare / Result / Source / Use these settings. Compare plays both videos in sync under one control bar.
    • The footer shows "Swap character" with the real quote under it: free runs left, or the price. When the quote refuses a run, the button says why. Sign in and out of credits reuse CinematicGenerateAction.
    • Small shared changes: VideoPlayer gets a default slot over the picture, and EditorRun makes credits optional.
    • Includes the editor kit commits from feat(website): shared full-screen editor pieces for the Workshop apps #20630, so this diff shrinks once that merges.
  • Breaking: none. useOpenjutsu gains the auto-trim, remove and restore; lib/workshop/openjutsu/* and the transports are untouched.

Review Focus

  • A real cost chip needs useOpenjutsu to expose the price and the free runs left as separate values. Today they arrive as one string, so they show as a line under the button.
  • A failed take has no failure code, so the card can only show the message.
  • Takes carry no start time, so the elapsed time is counted from the first render.

Screenshots (if applicable)

Preview: https://comfy-website-preview-pr-20636.vercel.app


Generated by Claude Code

…ite player, a cost line and a synced compare

The app now runs in the full-screen editor: settings in the floating panel (bottom sheet on phones), the source or take on the stage in the site video player, phases with elapsed time and Cancel over the stage while a take renders, and a result dock with Compare, Result, Source and Use these settings. Compare splits the result and its source under one set of player controls, the source following the result's play state and time. The quote shows under Swap character; a run the quote refuses says why on the button. The video player takes a default slot over the picture, and the run button's credit chip is optional.
…eld reset, tile keyboard, pinch, cancellable mock job
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 266a295c-bbcf-4c0f-88ed-474ee8d45f8d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 74cd5292475e036fd69ccb46282ac1c1b1e6069d

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-20636.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-cztxu487e-comfyui.vercel.app

Last updated: 2026-10-13T15:38:00Z for 32750a9

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 9, 2026
Video row matches the other apps' source row with trim as an inline link,
the character upload uses the kit tiles, the seed gains the dice, the panel
waits for a video like the other apps, and the run footer uses the kit
button when the account has nothing to act on.
…: prompt box with reference buttons, quality menu
@codecov

codecov Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.20359% with 303 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../components/workshop/app-editor/AppEditorShell.vue 0.00% 34 Missing ⚠️
.../components/workshop/openjutsu/OpenjutsuStudio.vue 0.00% 29 Missing ⚠️
...onents/workshop/app-editor/EditorFloatingPanel.vue 0.00% 22 Missing ⚠️
...omponents/workshop/app-editor/EditorMenuButton.vue 0.00% 19 Missing ⚠️
...rc/components/workshop/app-editor/EditorOutput.vue 0.00% 17 Missing ⚠️
...src/components/workshop/app-editor/EditorEmpty.vue 0.00% 12 Missing ⚠️
...mponents/workshop/app-editor/EditorCollapsible.vue 0.00% 11 Missing ⚠️
...rc/components/workshop/app-editor/EditorSelect.vue 0.00% 11 Missing ⚠️
...c/components/workshop/app-editor/EditorCompare.vue 0.00% 8 Missing ⚠️
apps/website/src/composables/useEditorZoom.ts 89.18% 1 Missing and 7 partials ⚠️
... and 42 more

❌ Your patch check has failed because the patch coverage (61.20%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@                 Coverage Diff                  @@
##             rob/app-openjutsu   #20636   +/-   ##
====================================================
  Coverage                     ?   85.38%           
====================================================
  Files                        ?     3530           
  Lines                        ?   168419           
  Branches                     ?    45922           
====================================================
  Hits                         ?   143804           
  Misses                       ?    22700           
  Partials                     ?     1915           
Flag Coverage Δ
website-unit 79.28% <61.20%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...te/src/components/common/HeaderMain/HeaderMain.vue 89.04% <100.00%> (ø)
apps/website/src/components/common/SiteFooter.vue 95.45% <ø> (ø)
apps/website/src/components/common/VideoPlayer.vue 67.60% <ø> (ø)
...ebsite/src/components/workshop/WorkshopAccount.vue 100.00% <100.00%> (ø)
...mponents/workshop/app-editor/EditorColorPicker.vue 70.58% <100.00%> (ø)
.../components/workshop/app-editor/EditorDropZone.vue 100.00% <100.00%> (ø)
...omponents/workshop/app-editor/EditorIconButton.vue 100.00% <100.00%> (ø)
...c/components/workshop/app-editor/EditorPopover.vue 100.00% <ø> (ø)
...e/src/components/workshop/app-editor/EditorRun.vue 100.00% <100.00%> (ø)
...components/workshop/app-editor/EditorRunCancel.vue 100.00% <100.00%> (ø)
... and 75 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…nel in place

A new video is used at once from its start, up to 15 s. A longer one gets a
quiet line under the video in the panel with a Change link to the trim. The
panel is always shown, the video can be taken out with an X and put back, and
the empty stage asks for a video without drag and drop.
@datadog-official

This comment has been minimized.

…ad card

With no video, the stage shows four examples. Picking one loads its clip,
character and who to replace on the default settings. Uploading stays in the
panel.
@comfyrob
comfyrob merged commit b959292 into rob/app-openjutsu Oct 13, 2026
91 checks passed
@comfyrob
comfyrob deleted the mariana/openjutsu-fullscreen branch October 13, 2026 23:32
DrJKL pushed a commit to mcmerdith/ComfyUI_frontend that referenced this pull request Oct 19, 2026
…f-only flag (Comfy-Org#20965)

## Summary

Adds **Openjutsu**, a new Hub app at `/hub/apps/openjutsu`: swap the
person in a 5 to 15 second part of a video for the character in a single
image, keeping the scene, the camera and the clip's own sound. It shows
only where the PostHog flag `workshop-openjutsu-app-enabled` is on,
which today means Comfy staff only.

Resolves FE-3430 (ticket and design doc). Backend: BE-20545,
Comfy-Org/cloud#13014 (merged) and Comfy-Org/cloud#14161 (this
workflow's price and deployment).

What is in it:

- **The app** (`src/components/workshop/openjutsu`,
`src/lib/workshop/openjutsu`, `useOpenjutsu`): one state machine over
the Re-shoot transport, so the app proxy, the local dev proxy and the
in-page sample backend share one run path.
- **The workflow** (`openjutsu/2`, see
`apps/website/workflows/openjutsu/README.md`): Akatz Labs' H3 Character
Swap workflow, using their node pack, SAM 3.1 masking, and 124-frame
relay windows with 18 frames of history. It runs the v1.5 character LoRA
and the FL2V Turbo 8-step LoRA on a dedicated deployment. The graph is
generated from upstream's API file; the changes from upstream are listed
in the README.
- **Prompt:** every run sends the workflow's instruction with H3's
reference tags. The page's text box is optional extra direction:
character details, or a fix for the last take.
- **First-frame anchor** (`anchor.ts`): before the job, the page takes
the frame at the part's start and asks GPT Image 2.5 sunburst, at low
quality through Comfy Router with the visitor's sign-in, to put the
character into it, outfit included. The page uploads the result, and the
graph crops it to the prepared size. If this fails, or nobody is signed
in, the swap runs without an anchor. It is a separate Router charge,
which the note under Generate mentions.
- **Price:** per second by quality, 8 credits a second at 480p and 16 at
768p. It is read from `H3CharacterSwapPrepareVideo`, the same node and
values the app proxy prices (Comfy-Org/cloud#14161); a test ties
`price.ts` to the graph.
- **A reusable video trim popup**
(`src/components/workshop/video-trim`). It opens on every video a
visitor adds; examples load straight in.
- **The full-screen editor kit** (`src/components/workshop/app-editor`)
and the redesign built on it, by @mariana953, merged in from Comfy-Org#20636.
- **Registration:** route, catalogue entry, flag entry, app proxy ids,
and en and zh-CN copy. There is no zh-CN or ja page twin, matching the
other Hub app pages.

Known limits, recorded in `apps/website/workflows/openjutsu/HANDOFF.md`:

- **The flag is visibility only, not access control.** The proxy id is
public in the bundle, so anyone signed in can call the app proxy
directly; the catalog prices the graph from the node that sizes the run.
- **Order with the backend:** until Comfy-Org/cloud#14161 merges, the
app proxy prices Comfy-Org#13014's old graph, so this page's runs are refused. It
is staff-only either way, and `main` has no Openjutsu today, so either
order is safe.
- **Clips that open with no person in frame** (a fade from black, a
title card) fail at the mask step before generating.
- A run refused for credits is worded for an owner or a member through
the shared `studioGate`, the same derivation Re-shoot has, which
ADR-API-SERVER-FACTS-0042 wants moved to the backend.
- **This is large.** The editor kit under `app-editor` is self-contained
and can be split into its own PR if that helps review.

## Verification

- **Tests:** 188 Openjutsu unit tests pass. They cover the graph builder
(with and without an anchor), the run path including the anchor fallback
and a cancel, the price against the graph, the Router anchor request,
and the panel and run components. `pnpm typecheck:website`, knip and the
pre-commit lint and format pass. `e2e/openjutsu.spec.ts` and its fake
app proxy are updated for the new graph, price and Router call, but have
not been re-run locally since; CI is their first run.
- **Human QA,** local proxy against the deployment (`astro dev`,
unmetered on the app side): signed-in swaps at 480p with the Router
anchor. The anchor is made, uploaded and used, the result keeps the
character's full outfit from the first frame, and anchor-free runs
succeed. Measured costs are in `BENCHMARK.md`.
- **Not yet verified:** a swap through the staging app proxy with a
signed-in account (quote, charge, refusal). That waits on
Comfy-Org/cloud#14161.
- **Screenshots:** the page is behind the flag; the preview deployment
for this PR shows it to a staff account at `/hub/apps/openjutsu/`.

---------

Co-authored-by: Mariana Martinho <mariana@comfy.org>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was previously deployed

1 inactive deployment
website-approval — 32750a9e Deployed Oct 13, 2026 by mariana953 via fast-lane #833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants