Repository navigation
feat(website): Openjutsu full screen on the shared editor - #20636
Conversation
…, with the account in their header
… on listed dependencies
…ite player, a cost line and a synced compare The app now runs in the full-screen editor: settings in the floating panel (bottom sheet on phones), the source or take on the stage in the site video player, phases with elapsed time and Cancel over the stage while a take renders, and a result dock with Compare, Result, Source and Use these settings. Compare splits the result and its source under one set of player controls, the source following the result's play state and time. The quote shows under Swap character; a run the quote refuses says why on the button. The video player takes a default slot over the picture, and the run button's credit chip is optional.
…eld reset, tile keyboard, pinch, cancellable mock job
…load into smaller steps
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 74cd5292475e036fd69ccb46282ac1c1b1e6069d
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-20636.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-cztxu487e-comfyui.vercel.app Last updated: 2026-10-13T15:38:00Z for |
Video row matches the other apps' source row with trim as an inline link, the character upload uses the kit tiles, the seed gains the dice, the panel waits for a video like the other apps, and the run footer uses the kit button when the account has nothing to act on.
…ntil the app has its own repo
…: prompt box with reference buttons, quality menu
…one at the top of the panel
…nel in place A new video is used at once from its start, up to 15 s. A longer one gets a quiet line under the video in the panel with a Change link to the trim. The panel is always shown, the video can be taken out with an X and put back, and the empty stage asks for a video without drag and drop.
This comment has been minimized.
This comment has been minimized.
…ad card With no video, the stage shows four examples. Picking one loads its clip, character and who to replace on the default settings. Uploading stays in the panel.
…me the video will fill
…its quality options
…f-only flag (Comfy-Org#20965) ## Summary Adds **Openjutsu**, a new Hub app at `/hub/apps/openjutsu`: swap the person in a 5 to 15 second part of a video for the character in a single image, keeping the scene, the camera and the clip's own sound. It shows only where the PostHog flag `workshop-openjutsu-app-enabled` is on, which today means Comfy staff only. Resolves FE-3430 (ticket and design doc). Backend: BE-20545, Comfy-Org/cloud#13014 (merged) and Comfy-Org/cloud#14161 (this workflow's price and deployment). What is in it: - **The app** (`src/components/workshop/openjutsu`, `src/lib/workshop/openjutsu`, `useOpenjutsu`): one state machine over the Re-shoot transport, so the app proxy, the local dev proxy and the in-page sample backend share one run path. - **The workflow** (`openjutsu/2`, see `apps/website/workflows/openjutsu/README.md`): Akatz Labs' H3 Character Swap workflow, using their node pack, SAM 3.1 masking, and 124-frame relay windows with 18 frames of history. It runs the v1.5 character LoRA and the FL2V Turbo 8-step LoRA on a dedicated deployment. The graph is generated from upstream's API file; the changes from upstream are listed in the README. - **Prompt:** every run sends the workflow's instruction with H3's reference tags. The page's text box is optional extra direction: character details, or a fix for the last take. - **First-frame anchor** (`anchor.ts`): before the job, the page takes the frame at the part's start and asks GPT Image 2.5 sunburst, at low quality through Comfy Router with the visitor's sign-in, to put the character into it, outfit included. The page uploads the result, and the graph crops it to the prepared size. If this fails, or nobody is signed in, the swap runs without an anchor. It is a separate Router charge, which the note under Generate mentions. - **Price:** per second by quality, 8 credits a second at 480p and 16 at 768p. It is read from `H3CharacterSwapPrepareVideo`, the same node and values the app proxy prices (Comfy-Org/cloud#14161); a test ties `price.ts` to the graph. - **A reusable video trim popup** (`src/components/workshop/video-trim`). It opens on every video a visitor adds; examples load straight in. - **The full-screen editor kit** (`src/components/workshop/app-editor`) and the redesign built on it, by @mariana953, merged in from Comfy-Org#20636. - **Registration:** route, catalogue entry, flag entry, app proxy ids, and en and zh-CN copy. There is no zh-CN or ja page twin, matching the other Hub app pages. Known limits, recorded in `apps/website/workflows/openjutsu/HANDOFF.md`: - **The flag is visibility only, not access control.** The proxy id is public in the bundle, so anyone signed in can call the app proxy directly; the catalog prices the graph from the node that sizes the run. - **Order with the backend:** until Comfy-Org/cloud#14161 merges, the app proxy prices Comfy-Org#13014's old graph, so this page's runs are refused. It is staff-only either way, and `main` has no Openjutsu today, so either order is safe. - **Clips that open with no person in frame** (a fade from black, a title card) fail at the mask step before generating. - A run refused for credits is worded for an owner or a member through the shared `studioGate`, the same derivation Re-shoot has, which ADR-API-SERVER-FACTS-0042 wants moved to the backend. - **This is large.** The editor kit under `app-editor` is self-contained and can be split into its own PR if that helps review. ## Verification - **Tests:** 188 Openjutsu unit tests pass. They cover the graph builder (with and without an anchor), the run path including the anchor fallback and a cancel, the price against the graph, the Router anchor request, and the panel and run components. `pnpm typecheck:website`, knip and the pre-commit lint and format pass. `e2e/openjutsu.spec.ts` and its fake app proxy are updated for the new graph, price and Router call, but have not been re-run locally since; CI is their first run. - **Human QA,** local proxy against the deployment (`astro dev`, unmetered on the app side): signed-in swaps at 480p with the Router anchor. The anchor is made, uploaded and used, the result keeps the character's full outfit from the first frame, and anchor-free runs succeed. Measured costs are in `BENCHMARK.md`. - **Not yet verified:** a swap through the staging app proxy with a signed-in account (quote, charge, refusal). That waits on Comfy-Org/cloud#14161. - **Screenshots:** the page is behind the flag; the preview deployment for this PR shows it to a staff account at `/hub/apps/openjutsu/`. --------- Co-authored-by: Mariana Martinho <mariana@comfy.org> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Moves Openjutsu onto the shared full-screen editor (#20630) so it matches the other Workshop apps, and simplifies how a video goes in.
Changes
OpenjutsuStudiobuilds onAppEditorShell: floating panel on desktop, bottom sheet on phones, header with Back, Download and the account.public/images/apps/openjutsu/examples). Picking one loads its clip, character and who to replace on the default settings (768p, random seed). Uploading lives in the panel; no drag and drop.VideoPlayerwith its existing controls. While a take is running,EditorBusyshows the phase, the elapsed time and Cancel.CinematicGenerateAction.VideoPlayergets a default slot over the picture, andEditorRunmakescreditsoptional.useOpenjutsugains the auto-trim, remove and restore;lib/workshop/openjutsu/*and the transports are untouched.Review Focus
useOpenjutsuto expose the price and the free runs left as separate values. Today they arrive as one string, so they show as a line under the button.Screenshots (if applicable)
Preview: https://comfy-website-preview-pr-20636.vercel.app
Generated by Claude Code