Repository navigation
FE-3342 feat(billing-web): come back to the billing page after SSO - #20633
dante01yoon merged 1 commit into
Conversation
ssoStartUrl takes the calling app's origin and sends a returnTo on it whole, so billing-web's Continue with SSO returns to the sign-in page the customer left, which then resumes the checkout. Ingest keeps it only for an https origin it trusts with the web session (cloud#12679).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2840d0ec52c6cd585accff9b0758f9491855873f
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2249 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-09T11:23:58.816Z",
"gitSha": "570124cfabec7a8e990bb12ead7a6fa681b67d32",
"branch": "jaewon/fe-3342-sso-return-checkout",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.4919999999856,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.083999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.338,
"heapDeltaBytes": 5490612,
"heapUsedBytes": 61084336,
"domNodes": -218,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 8.283999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2039.166000000023,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.107999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.56,
"heapDeltaBytes": -42994796,
"heapUsedBytes": 61994984,
"domNodes": -215,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 9.636999999999997,
"eventListeners": -122,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.92899999989,
"styleRecalcs": 54,
"styleRecalcDurationMs": 14.634999999999998,
"layouts": 12,
"layoutDurationMs": 3.3620000000000005,
"taskDurationMs": 821.631,
"heapDeltaBytes": -42737324,
"heapUsedBytes": 56438384,
"domNodes": -237,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 154.025,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1801.7069999999649,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.022000000000002,
"layouts": 12,
"layoutDurationMs": 3.19,
"taskDurationMs": 888.79,
"heapDeltaBytes": -19811168,
"heapUsedBytes": 80319084,
"domNodes": -217,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 161.213,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1701.2190000000373,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.173,
"layouts": 3,
"layoutDurationMs": 0.675,
"taskDurationMs": 357.27699999999993,
"heapDeltaBytes": 6419632,
"heapUsedBytes": 63311112,
"domNodes": 47,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.338999999999997,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.70500000007,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.592999999999998,
"layouts": 3,
"layoutDurationMs": 0.7520000000000001,
"taskDurationMs": 272.265,
"heapDeltaBytes": 6422860,
"heapUsedBytes": 63048652,
"domNodes": 47,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.107,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 594.2440000000033,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.4199999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.51599999999996,
"heapDeltaBytes": 18181112,
"heapUsedBytes": 74650268,
"domNodes": -216,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 170.06099999999998,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 645.5099999999447,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.998999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.636,
"heapDeltaBytes": 17809860,
"heapUsedBytes": 74266548,
"domNodes": -215,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.63499999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684193,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1150.7250000000226,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 765.928,
"heapDeltaBytes": 15963200,
"heapUsedBytes": 98646184,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 69.55399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 522,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1142.0929999999316,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 828.9289999999999,
"heapDeltaBytes": 16841744,
"heapUsedBytes": 99428464,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 62.611,
"eventListeners": 0,
"totalBlockingTimeMs": 527,
"frameDurationMs": 34.84848484848485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.7179999999908,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.0790000000001,
"heapDeltaBytes": 20162324,
"heapUsedBytes": 109603832,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 160.676,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 893.2599999999411,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.1319999999996,
"heapDeltaBytes": 19511412,
"heapUsedBytes": 98714952,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 180.129,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10214.609999999993,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.33699999999999875,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9320.295,
"heapDeltaBytes": 23150576,
"heapUsedBytes": 95254792,
"domNodes": -140,
"jsHeapTotalBytes": -12455936,
"scriptDurationMs": 7933.217,
"eventListeners": -47,
"totalBlockingTimeMs": 1190,
"frameDurationMs": 32.74423076923077,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9631.430999999906,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8817.116,
"heapDeltaBytes": 3877816,
"heapUsedBytes": 87626192,
"domNodes": 0,
"jsHeapTotalBytes": -19136512,
"scriptDurationMs": 7158.119,
"eventListeners": 0,
"totalBlockingTimeMs": 663,
"frameDurationMs": 31.377850162866448,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9796.557000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8951.668,
"heapDeltaBytes": 17607080,
"heapUsedBytes": 95388108,
"domNodes": 0,
"jsHeapTotalBytes": -18350080,
"scriptDurationMs": 7301.835,
"eventListeners": 0,
"totalBlockingTimeMs": 664,
"frameDurationMs": 31.713915857605173,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9985.80000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9148.653,
"heapDeltaBytes": -917732,
"heapUsedBytes": 82335812,
"domNodes": 0,
"jsHeapTotalBytes": -20709376,
"scriptDurationMs": 7501.613,
"eventListeners": 0,
"totalBlockingTimeMs": 812,
"frameDurationMs": 31.393081761006282,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 214.9930000000495,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.846,
"layouts": 5,
"layoutDurationMs": 1.696,
"taskDurationMs": 158.76500000000001,
"heapDeltaBytes": 12046196,
"heapUsedBytes": 77931808,
"domNodes": 918,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.688,
"eventListeners": 202,
"totalBlockingTimeMs": 1,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-combo-open",
"durationMs": 215.83399999997255,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.620000000000005,
"layouts": 5,
"layoutDurationMs": 1.6560000000000001,
"taskDurationMs": 161.557,
"heapDeltaBytes": 12115472,
"heapUsedBytes": 78068828,
"domNodes": 918,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.708000000000002,
"eventListeners": 202,
"totalBlockingTimeMs": 1,
"frameDurationMs": 21.660000000000036,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2038.176999999905,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.390999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.0679999999999,
"heapDeltaBytes": -39480800,
"heapUsedBytes": 85350316,
"domNodes": -317,
"jsHeapTotalBytes": -2981888,
"scriptDurationMs": 33.725,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.80245901639344,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2070.194000000015,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.556,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 632.4250000000002,
"heapDeltaBytes": -39366668,
"heapUsedBytes": 84982000,
"domNodes": -313,
"jsHeapTotalBytes": -2981888,
"scriptDurationMs": 35.953,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2257.671000000073,
"styleRecalcs": 66,
"styleRecalcDurationMs": 5.904,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1549.7520000000002,
"heapDeltaBytes": 19975824,
"heapUsedBytes": 85254016,
"domNodes": -313,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 784.102,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79029850746269,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2372.7030000000013,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.066999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1617.6620000000003,
"heapDeltaBytes": 22970988,
"heapUsedBytes": 88630940,
"domNodes": -313,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 817.494,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666197183098593,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3436.040000000048,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.026000000000001,
"layouts": 60,
"layoutDurationMs": 9.202,
"taskDurationMs": 1458.9160000000004,
"heapDeltaBytes": 8912212,
"heapUsedBytes": 76695464,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 760.7830000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66553398058252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3569.603000000029,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.978000000000001,
"layouts": 60,
"layoutDurationMs": 9.58,
"taskDurationMs": 1536.889,
"heapDeltaBytes": 11958084,
"heapUsedBytes": 79681332,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 780.7189999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665887850467293,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2948.5819999999876,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.3629999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1739.963,
"heapDeltaBytes": 18287100,
"heapUsedBytes": 88938196,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 998.72,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.760795454545452,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3065.246000000002,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.295,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1800.428,
"heapDeltaBytes": 22617640,
"heapUsedBytes": 89776540,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1027.268,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75769230769231,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2014.2489999999498,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0040000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.6360000000001,
"heapDeltaBytes": -1891576,
"heapUsedBytes": 82470272,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 37.293,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2036.6410000000315,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7889999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.552,
"heapDeltaBytes": -40625720,
"heapUsedBytes": 86310608,
"domNodes": -333,
"jsHeapTotalBytes": -3244032,
"scriptDurationMs": 31.846000000000007,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.4059999999918,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.721000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.90700000000004,
"heapDeltaBytes": 13247352,
"heapUsedBytes": 70471144,
"domNodes": -235,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 144.511,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.218000000059,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.222000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.02399999999994,
"heapDeltaBytes": 13210504,
"heapUsedBytes": 69982592,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 141.986,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.9540000000316,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.0260000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.366,
"heapDeltaBytes": 5511916,
"heapUsedBytes": 62282180,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.99,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2045.078999999987,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.713,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.28599999999994,
"heapDeltaBytes": -38836676,
"heapUsedBytes": 62033704,
"domNodes": -235,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 9.297,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1794.5379999999886,
"styleRecalcs": 62,
"styleRecalcDurationMs": 18.845,
"layouts": 16,
"layoutDurationMs": 3.922,
"taskDurationMs": 862.8699999999999,
"heapDeltaBytes": 2477580,
"heapUsedBytes": 74608044,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 110.55400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.0939999999791,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.982,
"layouts": 16,
"layoutDurationMs": 4.436,
"taskDurationMs": 818.8539999999999,
"heapDeltaBytes": -20980308,
"heapUsedBytes": 80316740,
"domNodes": -235,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 109.105,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.4249999999802,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.193999999999992,
"layouts": 5,
"layoutDurationMs": 14.757999999999997,
"taskDurationMs": 1023.7869999999998,
"heapDeltaBytes": 32032524,
"heapUsedBytes": 110480084,
"domNodes": 14650,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 34.375,
"eventListeners": 2456,
"totalBlockingTimeMs": 139,
"frameDurationMs": 19.63424657534248,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 8800.882000000001,
"styleRecalcs": 249,
"styleRecalcDurationMs": 18.913,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5848.306,
"heapDeltaBytes": -41622496,
"heapUsedBytes": 83541620,
"domNodes": -313,
"jsHeapTotalBytes": -3313664,
"scriptDurationMs": 2790.5,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69753320683112,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8282.36400000003,
"styleRecalcs": 250,
"styleRecalcDurationMs": 19.392,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5073.524,
"heapDeltaBytes": -48335340,
"heapUsedBytes": 81918728,
"domNodes": -313,
"jsHeapTotalBytes": -2789376,
"scriptDurationMs": 2744.7870000000003,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699798387096774,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18785.457999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18201.469,
"heapDeltaBytes": -34402952,
"heapUsedBytes": 182530732,
"domNodes": -3046,
"jsHeapTotalBytes": 5263360,
"scriptDurationMs": 309.504,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.58093587521664,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 18956.519999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18390.105000000003,
"heapDeltaBytes": -35723964,
"heapUsedBytes": 183632932,
"domNodes": -3047,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 288.84,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.391794871794865,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-pan",
"durationMs": 23620.90400000011,
"styleRecalcs": 180,
"styleRecalcDurationMs": 15.994000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23169.449999999997,
"heapDeltaBytes": -41597320,
"heapUsedBytes": 189590380,
"domNodes": -3046,
"jsHeapTotalBytes": 5787648,
"scriptDurationMs": 866.017,
"eventListeners": -14913,
"totalBlockingTimeMs": 7,
"frameDurationMs": 43.6826247689464,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 16914.308000000005,
"styleRecalcs": 134,
"styleRecalcDurationMs": 10.831000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16380.937000000004,
"heapDeltaBytes": -28939532,
"heapUsedBytes": 190126896,
"domNodes": -3046,
"jsHeapTotalBytes": 9080832,
"scriptDurationMs": 869.144,
"eventListeners": -14913,
"totalBlockingTimeMs": 23,
"frameDurationMs": 30.534296028880867,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-node-resize-workload",
"durationMs": 6903.500000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.962,
"layouts": 20,
"layoutDurationMs": 24.098999999999997,
"taskDurationMs": 6789.554000000001,
"heapDeltaBytes": -2782308,
"heapUsedBytes": 215612804,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 117.98700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.88323699421965,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5021.83100000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.67099999999999,
"layouts": 20,
"layoutDurationMs": 24.810000000000013,
"taskDurationMs": 4915.409,
"heapDeltaBytes": 15316220,
"heapUsedBytes": 217082864,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 91.71600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.165697674418606,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9656.811999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9330.799,
"heapDeltaBytes": -33495788,
"heapUsedBytes": 183757340,
"domNodes": -3046,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 147.19500000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.2744827586207,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9557.141000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9233.444,
"heapDeltaBytes": -33758476,
"heapUsedBytes": 185465428,
"domNodes": -3046,
"jsHeapTotalBytes": 6459392,
"scriptDurationMs": 141.82900000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.81649484536082,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 149.42100000007486,
"styleRecalcs": 10,
"styleRecalcDurationMs": 14.824000000000002,
"layouts": 4,
"layoutDurationMs": 1.967,
"taskDurationMs": 110.14699999999996,
"heapDeltaBytes": 4310412,
"heapUsedBytes": 72510932,
"domNodes": 103,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.671,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 511.6930000000366,
"styleRecalcs": 15,
"styleRecalcDurationMs": 19.141000000000002,
"layouts": 4,
"layoutDurationMs": 1.6880000000000002,
"taskDurationMs": 195.62199999999996,
"heapDeltaBytes": -38592352,
"heapUsedBytes": 59242984,
"domNodes": -89,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 14.392,
"eventListeners": -36,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 812.637999999879,
"styleRecalcs": 77,
"styleRecalcDurationMs": 87.085,
"layouts": 76,
"layoutDurationMs": 15.990999999999998,
"taskDurationMs": 787.648,
"heapDeltaBytes": 17575772,
"heapUsedBytes": 95242408,
"domNodes": 77,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 325.618,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665306122448985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 864.8220000000038,
"styleRecalcs": 77,
"styleRecalcDurationMs": 87.662,
"layouts": 76,
"layoutDurationMs": 17.339,
"taskDurationMs": 838.939,
"heapDeltaBytes": 18124316,
"heapUsedBytes": 91813540,
"domNodes": 77,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 343.915,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667924528301896,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1421.5949999997974,
"styleRecalcs": 77,
"styleRecalcDurationMs": 257.548,
"layouts": 76,
"layoutDurationMs": 18.837,
"taskDurationMs": 1387.3029999999999,
"heapDeltaBytes": -19484044,
"heapUsedBytes": 116896568,
"domNodes": 77,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 465.129,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.693827160493836,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1575.3659999998035,
"styleRecalcs": 77,
"styleRecalcDurationMs": 279.652,
"layouts": 76,
"layoutDurationMs": 19.163,
"taskDurationMs": 1541.8110000000001,
"heapDeltaBytes": -19090980,
"heapUsedBytes": 117068736,
"domNodes": 77,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 543.082,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.075903614457843,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## jaewon/fe-3342-billing-web-sso #20633 +/- ##
=================================================================
Coverage 85.91% 85.91%
=================================================================
Files 3605 3605
Lines 172599 172609 +10
Branches 47581 45579 -2002
=================================================================
+ Hits 148280 148291 +11
Misses 22296 22296
+ Partials 2023 2022 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
After SSO, billing-web's "Continue with SSO" now brings the customer back to the billing page they left, so the checkout resumes. Before, they landed on Cloud and had to start the billing flow again.
Why: with #20632 alone, an SSO-held customer who signs in from a billing-web checkout comes back to the product (
/?settings=plan-credits), not to the checkout.Root cause:
ssoStartUrl(account-core) and ingest'sSafeReturnToboth only allowed a Cloud-origin path asreturn_to. cloud#12679 lets ingest keep an https URL on an origin it trusts with the web session (billing-web, platform).How:
ssoStartUrltakes an optionalappOrigin. AreturnToon that exact origin is sent whole; anything else still goes through the existing same-origin path check. Ingest makes the final call (https plusSESSION_TRUSTED_ORIGINS)./sign-in?returnTo=<entry>) and its own origin. After SSO the sign-in page finds the shared session and resumes the entry link./, so the customer lands on Cloud's root. Merge this after the deploy.AS IS / TO BE
No visual change; the difference is where SSO returns.
return_to=/?settings=plan-credits(Cloud)return_to=https://billing.comfy.org/sign-in?returnTo=…(back to the checkout)Verification
sso.test.ts: areturnToonappOriginis kept whole; one on another origin falls back to/(59 pass).SignInView.test.ts: the SSO start carries the sign-in page asreturn_to(31 pass; touched suites 416 pass).e2e/sign-in.spec.ts: Continue with SSO starts SSO withreturn_toset to the sign-in page (3 pass).