Repository navigation
fix: persist Vue boolean widget edits immediately - #20539
Conversation
📦 Bundle: 9.35 MB gzip 🔴 +64 BDetailsSummary
Category Glance App Entry Points — 4.84 kB (baseline 4.84 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.15 MB (baseline 2.15 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 2 unchanged Views & Navigation — 146 kB (baseline 146 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 669 kB (baseline 669 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 29 unchanged User & Accounts — 54.3 kB (baseline 54.3 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 14 unchanged Editors & Dialogs — 340 kB (baseline 340 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 12 unchanged UI Components — 211 kB (baseline 211 kB) • ⚪ 0 BReusable component library chunks Status: 24 unchanged Data & Services — 3.07 MB (baseline 3.07 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 22 unchanged Utilities & Hooks — 822 kB (baseline 822 kB) • 🔴 +162 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed / 54 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.8 MB (baseline 18.8 MB) • 🔴 +160 BBundles that do not match a named category
Status: 2 added / 2 removed / 344 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-10T03:44:25.236Z",
"gitSha": "14220225aaea97dca98e3d3feed5f2748cb24559",
"branch": "jaeone94/vue-toggle-persistence",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2053.389999999979,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.436999999999999,
"layouts": 12,
"layoutDurationMs": 3.6519999999999997,
"taskDurationMs": 460.401,
"heapDeltaBytes": -36490756,
"heapUsedBytes": 69011284,
"domNodes": -162,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 15.082,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2024.6409999999742,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.857000000000001,
"layouts": 12,
"layoutDurationMs": 2.9470000000000005,
"taskDurationMs": 327.92900000000003,
"heapDeltaBytes": -36626156,
"heapUsedBytes": 68923588,
"domNodes": -162,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 7.418999999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1728.7520000000427,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.889000000000003,
"layouts": 11,
"layoutDurationMs": 2.98,
"taskDurationMs": 695.292,
"heapDeltaBytes": -24949760,
"heapUsedBytes": 65005488,
"domNodes": -162,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 121.528,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1712.0199999999954,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.612,
"layouts": 12,
"layoutDurationMs": 2.9039999999999995,
"taskDurationMs": 566.5120000000001,
"heapDeltaBytes": -43213824,
"heapUsedBytes": 62664564,
"domNodes": -162,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 97.694,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689323,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.6550000000507,
"styleRecalcs": 18,
"styleRecalcDurationMs": 7.2219999999999995,
"layouts": 13,
"layoutDurationMs": 3.6670000000000007,
"taskDurationMs": 341.93600000000004,
"heapDeltaBytes": -38488984,
"heapUsedBytes": 67116204,
"domNodes": -115,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 14.304,
"eventListeners": -31,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.931999999977,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.711999999999999,
"layouts": 15,
"layoutDurationMs": 3.5639999999999996,
"taskDurationMs": 283.47,
"heapDeltaBytes": -38165184,
"heapUsedBytes": 68428712,
"domNodes": -115,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 10.131,
"eventListeners": -31,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 582.1500000000128,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.739999999999999,
"layouts": 12,
"layoutDurationMs": 3.3199999999999994,
"taskDurationMs": 405.255,
"heapDeltaBytes": -29934288,
"heapUsedBytes": 75673936,
"domNodes": -162,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 110.379,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 457.3649999999816,
"styleRecalcs": 17,
"styleRecalcDurationMs": 4.306000000000001,
"layouts": 13,
"layoutDurationMs": 3.134,
"taskDurationMs": 310.74199999999996,
"heapDeltaBytes": 5685284,
"heapUsedBytes": 110349616,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 103.98199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 857.6060000000325,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.67800000000005,
"heapDeltaBytes": 15307320,
"heapUsedBytes": 96850876,
"domNodes": 0,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 35.901999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 258,
"frameDurationMs": 26.260606060606072,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 855.3739999999834,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.23099999999994,
"heapDeltaBytes": 20919468,
"heapUsedBytes": 101355512,
"domNodes": 0,
"jsHeapTotalBytes": 1212416,
"scriptDurationMs": 33.111,
"eventListeners": 0,
"totalBlockingTimeMs": 252,
"frameDurationMs": 25.488235294117644,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 700.1220000000217,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 309.28200000000004,
"heapDeltaBytes": 20870972,
"heapUsedBytes": 94219872,
"domNodes": 0,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 99.28699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 93,
"frameDurationMs": 20.58529411764705,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 686.9040000000268,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 256.23899999999986,
"heapDeltaBytes": -8318576,
"heapUsedBytes": 105892268,
"domNodes": 0,
"jsHeapTotalBytes": 3411968,
"scriptDurationMs": 85.553,
"eventListeners": 0,
"totalBlockingTimeMs": 81,
"frameDurationMs": 20.097058823529416,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6579.375999999997,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7810000000000005,
"layouts": 3,
"layoutDurationMs": 0.8669999999999998,
"taskDurationMs": 5499.813999999999,
"heapDeltaBytes": 3975664,
"heapUsedBytes": 87971744,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 4220.8189999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 58,
"frameDurationMs": 20.266666666666666,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5768.794000000014,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8300000000000008,
"layouts": 3,
"layoutDurationMs": 0.6710000000000002,
"taskDurationMs": 4700.193,
"heapDeltaBytes": 5921292,
"heapUsedBytes": 89949616,
"domNodes": 0,
"jsHeapTotalBytes": -18874368,
"scriptDurationMs": 3808.953,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.076489028213167,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6333.084999999983,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9169999999999994,
"layouts": 3,
"layoutDurationMs": 0.7960000000000007,
"taskDurationMs": 5162.670999999999,
"heapDeltaBytes": -11832848,
"heapUsedBytes": 72418248,
"domNodes": 0,
"jsHeapTotalBytes": -19398656,
"scriptDurationMs": 3969.0660000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 2,
"frameDurationMs": 19.075301204819276,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5869.346000000007,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.0089999999999995,
"layouts": 3,
"layoutDurationMs": 0.7060000000000001,
"taskDurationMs": 4918.951,
"heapDeltaBytes": 4624992,
"heapUsedBytes": 88964288,
"domNodes": 0,
"jsHeapTotalBytes": -16777216,
"scriptDurationMs": 3897.872,
"eventListeners": 0,
"totalBlockingTimeMs": 6,
"frameDurationMs": 18.218633540372668,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 141.2939999999594,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.533999999999999,
"layouts": 12,
"layoutDurationMs": 2.933,
"taskDurationMs": 97.45300000000002,
"heapDeltaBytes": 12837340,
"heapUsedBytes": 84066384,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.499,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 136.84699999998884,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.144,
"layouts": 12,
"layoutDurationMs": 2.8770000000000002,
"taskDurationMs": 94.663,
"heapDeltaBytes": 12934728,
"heapUsedBytes": 82858664,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.275,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2003.5060000000158,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.398,
"layouts": 7,
"layoutDurationMs": 1.6879999999999997,
"taskDurationMs": 344.992,
"heapDeltaBytes": 3602656,
"heapUsedBytes": 71991340,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 25.692,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2044.4190000000617,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7150000000000003,
"layouts": 10,
"layoutDurationMs": 2.091,
"taskDurationMs": 332.615,
"heapDeltaBytes": -61169196,
"heapUsedBytes": 68640076,
"domNodes": -258,
"jsHeapTotalBytes": -3244032,
"scriptDurationMs": 21.964000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2260.551000000021,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.899000000000001,
"layouts": 8,
"layoutDurationMs": 2.8350000000000004,
"taskDurationMs": 1096.787,
"heapDeltaBytes": 701356,
"heapUsedBytes": 67306076,
"domNodes": -258,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 541.2900000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666176470588233,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2173.828999999955,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.9879999999999995,
"layouts": 8,
"layoutDurationMs": 1.722,
"taskDurationMs": 1029.017,
"heapDeltaBytes": 274588,
"heapUsedBytes": 67028180,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 531.749,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153843,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3326.293000000021,
"styleRecalcs": 73,
"styleRecalcDurationMs": 8.888,
"layouts": 67,
"layoutDurationMs": 11.56,
"taskDurationMs": 1112.691,
"heapDeltaBytes": 21034604,
"heapUsedBytes": 91927016,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 495.627,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3212.7199999999903,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.088999999999999,
"layouts": 66,
"layoutDurationMs": 10.803,
"taskDurationMs": 1078.5430000000001,
"heapDeltaBytes": 22633748,
"heapUsedBytes": 90371320,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 485.935,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66683937823834,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2418.1950000000256,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.4670000000000005,
"layouts": 7,
"layoutDurationMs": 1.888,
"taskDurationMs": 1255.3300000000002,
"heapDeltaBytes": 28034724,
"heapUsedBytes": 98417468,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 633.755,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66551724137931,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2244.4580000000087,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.7540000000000004,
"layouts": 6,
"layoutDurationMs": 1.3909999999999998,
"taskDurationMs": 1227.433,
"heapDeltaBytes": 1651540,
"heapUsedBytes": 69784276,
"domNodes": -172,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 618.1600000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791043,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2037.2280000000274,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.386,
"layouts": 9,
"layoutDurationMs": 2.4220000000000006,
"taskDurationMs": 393.00500000000005,
"heapDeltaBytes": -61611064,
"heapUsedBytes": 69456656,
"domNodes": -258,
"jsHeapTotalBytes": -5079040,
"scriptDurationMs": 27.199,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.576999999913,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8639999999999994,
"layouts": 8,
"layoutDurationMs": 1.474,
"taskDurationMs": 306.48100000000005,
"heapDeltaBytes": 3563220,
"heapUsedBytes": 70202036,
"domNodes": -258,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 24.79,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 441.0100000000057,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.802,
"layouts": 9,
"layoutDurationMs": 2.3409999999999997,
"taskDurationMs": 296.318,
"heapDeltaBytes": 16307604,
"heapUsedBytes": 74106432,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 100.43,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230772,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 441.7959999999539,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.597,
"layouts": 11,
"layoutDurationMs": 3.133,
"taskDurationMs": 312.77099999999996,
"heapDeltaBytes": -17716224,
"heapUsedBytes": 71938972,
"domNodes": -180,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 94.211,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2008.6379999999622,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.456000000000001,
"layouts": 10,
"layoutDurationMs": 2.6310000000000002,
"taskDurationMs": 385.64500000000004,
"heapDeltaBytes": 15606364,
"heapUsedBytes": 73373204,
"domNodes": -180,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.844,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2026.4990000000012,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.202000000000001,
"layouts": 11,
"layoutDurationMs": 2.732999999999999,
"taskDurationMs": 306.767,
"heapDeltaBytes": -34854652,
"heapUsedBytes": 72969720,
"domNodes": -180,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 7.298000000000001,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1737.667999999985,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.444000000000003,
"layouts": 11,
"layoutDurationMs": 2.749,
"taskDurationMs": 690.977,
"heapDeltaBytes": -45261568,
"heapUsedBytes": 62217148,
"domNodes": -180,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 98.76899999999999,
"eventListeners": -108,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.0129999999808,
"styleRecalcs": 78,
"styleRecalcDurationMs": 19.258999999999997,
"layouts": 12,
"layoutDurationMs": 2.771,
"taskDurationMs": 551.775,
"heapDeltaBytes": -46417972,
"heapUsedBytes": 61552852,
"domNodes": -180,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 80.858,
"eventListeners": -108,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 818.556000000001,
"styleRecalcs": 21,
"styleRecalcDurationMs": 18.014000000000003,
"layouts": 5,
"layoutDurationMs": 8.989,
"taskDurationMs": 600.2589999999999,
"heapDeltaBytes": 33794976,
"heapUsedBytes": 121308300,
"domNodes": 15956,
"jsHeapTotalBytes": 13504512,
"scriptDurationMs": 34.899,
"eventListeners": 3244,
"totalBlockingTimeMs": 66,
"frameDurationMs": 18.99302325581395,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9184.195999999985,
"styleRecalcs": 250,
"styleRecalcDurationMs": 24.445,
"layouts": 9,
"layoutDurationMs": 2.306,
"taskDurationMs": 4278.445,
"heapDeltaBytes": -45213800,
"heapUsedBytes": 83901056,
"domNodes": -258,
"jsHeapTotalBytes": -2527232,
"scriptDurationMs": 2058.969,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665880217785848,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8217.193999999949,
"styleRecalcs": 251,
"styleRecalcDurationMs": 22.647000000000002,
"layouts": 10,
"layoutDurationMs": 2.3689999999999998,
"taskDurationMs": 3637.2060000000006,
"heapDeltaBytes": -50402776,
"heapUsedBytes": 78789252,
"domNodes": -258,
"jsHeapTotalBytes": -3543040,
"scriptDurationMs": 1748.7679999999998,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16321.560999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15318.021,
"heapDeltaBytes": -32766524,
"heapUsedBytes": 263154420,
"domNodes": -3232,
"jsHeapTotalBytes": 25223168,
"scriptDurationMs": 213.12400000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.919145299145296,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "vue-large-graph-idle",
"durationMs": 16292.33899999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15335.567000000001,
"heapDeltaBytes": -18821192,
"heapUsedBytes": 268328880,
"domNodes": -3232,
"jsHeapTotalBytes": 14184448,
"scriptDurationMs": 227.706,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.720068027210885,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 18447.04900000005,
"styleRecalcs": 146,
"styleRecalcDurationMs": 13.665999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18097.858,
"heapDeltaBytes": -22744816,
"heapUsedBytes": 282012280,
"domNodes": -3232,
"jsHeapTotalBytes": 21082112,
"scriptDurationMs": 655.9110000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.666605839416064,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 14489.045000000033,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.2649999999999935,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13838.293999999998,
"heapDeltaBytes": -26361824,
"heapUsedBytes": 280637920,
"domNodes": -3232,
"jsHeapTotalBytes": 29278208,
"scriptDurationMs": 561.41,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.78330373001776,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4505.998999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 44.835999999999984,
"layouts": 20,
"layoutDurationMs": 20.08499999999999,
"taskDurationMs": 4326.463000000001,
"heapDeltaBytes": -6693684,
"heapUsedBytes": 285872424,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 72.58,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.27977528089888,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 5229.0680000000975,
"styleRecalcs": 20,
"styleRecalcDurationMs": 44.91500000000001,
"layouts": 20,
"layoutDurationMs": 18.020999999999994,
"taskDurationMs": 5132.952,
"heapDeltaBytes": -8837084,
"heapUsedBytes": 298601484,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 72.56199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.33652694610779,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7704.159000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7299.953999999998,
"heapDeltaBytes": -40139156,
"heapUsedBytes": 261187492,
"domNodes": -3232,
"jsHeapTotalBytes": 27582464,
"scriptDurationMs": 96.18700000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.012499999999996,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7790.316000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7430.551999999999,
"heapDeltaBytes": -2879932,
"heapUsedBytes": 283356180,
"domNodes": -3036,
"jsHeapTotalBytes": 27320320,
"scriptDurationMs": 96.35100000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.745360824742267,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 104.19200000001183,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.82,
"layouts": 6,
"layoutDurationMs": 1.5659999999999998,
"taskDurationMs": 87.862,
"heapDeltaBytes": 4494116,
"heapUsedBytes": 107801948,
"domNodes": 97,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 7.4559999999999995,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 502.87600000001476,
"styleRecalcs": 20,
"styleRecalcDurationMs": 12.666,
"layouts": 12,
"layoutDurationMs": 3.7869999999999995,
"taskDurationMs": 164.45,
"heapDeltaBytes": -43939664,
"heapUsedBytes": 59133420,
"domNodes": -61,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 8.124999999999998,
"eventListeners": -63,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 188.733999999954,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.816,
"layouts": 76,
"layoutDurationMs": 9.225999999999999,
"taskDurationMs": 148.008,
"heapDeltaBytes": 8652628,
"heapUsedBytes": 96458688,
"domNodes": 4,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 62.155,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363634,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 199.5600000000195,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.846,
"layouts": 76,
"layoutDurationMs": 9.771,
"taskDurationMs": 160.75300000000001,
"heapDeltaBytes": 8719448,
"heapUsedBytes": 99691364,
"domNodes": 4,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 69.105,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 226.58500000000004,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.433,
"layouts": 76,
"layoutDurationMs": 8.666,
"taskDurationMs": 190.93099999999998,
"heapDeltaBytes": -3717032,
"heapUsedBytes": 135818056,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 59.07,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 449.7350000000324,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.72,
"layouts": 76,
"layoutDurationMs": 14.936,
"taskDurationMs": 417.81600000000003,
"heapDeltaBytes": -222588,
"heapUsedBytes": 126913584,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.587,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18,
"p95FrameDurationMs": 33.40000000000009
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2261 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ef58ce612c30353dc24b2f95b4a075d826555f62
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20539 +/- ##
==========================================
+ Coverage 86.07% 86.86% +0.79%
==========================================
Files 3632 2583 -1049
Lines 173371 145169 -28202
Branches 45785 38497 -7288
==========================================
- Hits 149221 126099 -23122
+ Misses 22144 18684 -3460
+ Partials 2006 386 -1620
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1056 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @jaeone94.
✅ No high-signal findings.
Panel: 6/6 reviewers contributed findings.
|
@coderabbitai full review |
✅ Action performedFull review finished. |
jtydhr88
left a comment
There was a problem hiding this comment.
LGTM. Verified the root cause against changeTracker.ts: the global mouseup snapshot runs before the Switch flips on click, and for Enter, bindInput attaches a change listener to the focused <button> that never fires, so neither path captured the edit. Capturing right after the update mirrors WidgetSelectDefault, the value reaches the node synchronously through createWidgetUpdateHandler / setWidgetValue, and the earlier mouseup snapshot has no diff, so it's still a single undo entry. Read-only and re-clicking the active ToggleGroup item don't emit, so nothing extra is recorded.
Two optional nits:
- The draft-parsing block in the spec duplicates what
WorkflowHelper.waitForDraftPersistedandworkflowDraftForeignWindowSignInFixturealready do; a smallgetDraftWorkflows()helper onWorkflowHelperwould keep it in one place. localStorage.getItem(key)!could be a null check instead of a non-null assertion.
…20768) ## ELI5 The Boolean refresh tests now read saved drafts through one helper. This keeps the tests easier to maintain while preserving widget behavior. Follow-up to [Comfy-Org#20539, fix: persist Vue boolean widget edits immediately](Comfy-Org#20539), addressing the two optional nits in the approval review. ## Summary - Adopt the small `WorkflowHelper.getDraftWorkflows()` extraction for the Boolean assertion. Keep `waitForDraftPersisted()` key-only and the foreign-window sign-in fixture's shape checks: they verify different contracts, so broader unification would add unnecessary abstraction. - Replace `localStorage.getItem(key)!` with a null guard that skips a payload removed before it is read. - Narrow parsed payloads from `unknown` and validate workflows with the existing 0.4/1 schemas. Malformed or wrong-shaped data remains a test failure. - Reuse the Boolean workflow asset and real `Storage` for unit coverage of saved values, unrelated keys, absent/removed drafts, and invalid data. Changes are confined to test code. ## Verification - `pnpm test:unit browser_tests/fixtures/helpers/WorkflowHelper.test.ts src/renderer/extensions/vueNodes/widgets/components/WidgetToggleSwitch.test.ts --maxWorkers=1 --retry=0`: 32 passed. Two wrong-shape cases failed before validation was added. - `pnpm test:browser browser_tests/tests/vueNodes/widgets/widgetValuePersistence.spec.ts --config=playwright.chrome.config.ts --project=chromium --workers=1 --retries=0 --reporter=line --grep='toggle-only'`: 2 passed (click and Enter, followed by reload). - Self-review against `reviewing-unit-tests` and `yagni-test-review`: no findings. ## Provenance - **Authored by:** interactive session - **Verified:** `pnpm lint:unstaged:fix` passed. Enabled commit hooks passed staged formatting, type-aware lint, server-fact checks, and `pnpm typecheck:browser`; enabled pre-push `pnpm knip` and `pnpm fallow:audit` passed.
ELI5
Changing a Boolean switch in a Nodes 2.0 workflow should survive a browser refresh, even if it is the last thing you do. This records the edit immediately after the new value reaches the node.
Motivation
Found while validating #20307 — test: validate native LoRA stack assets and execution. The same failure reproduces on the stock Boolean node without DynamicGroup or subgraphs: the switch changes on click, after the global mouseup snapshot, so a toggle-only edit never reaches the saved draft.
Summary
Provenance
pnpm test:unit src/renderer/extensions/vueNodes/widgets/components/WidgetToggleSwitch.test.ts --maxWorkers=1: 24 passed; the two added cases failed before the fix. Targeted Playwright toggle-only cases: 2 failed before, 2 passed after. App/browser typechecks and staged lint/format checks passed through the commit hook; pre-push Knip and Fallow also passed.With both independent fixes applied locally to #20307 — test: validate native LoRA stack assets and execution, the two previously failing scenarios passed: model drop followed by native execution, and a two-level promoted toggle edited after draft reload. No backend pin is needed for this PR’s stock-node regression tests.
Test plan