Repository navigation
FE-3267 fix(auth): stop repeating a Desktop account's email as its name - #20536
Conversation
A Desktop host session carries no display name, so useCurrentUser used the email for both, and the account menu showed the same address twice. Leave the name unset, as for a Firebase account without one; the email still shows once.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6b0f2bd013fa16c33932085ba519cf8967b03fa7
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.35 MB gzip 🟢 -98 BDetailsSummary
Category Glance App Entry Points — 4.43 kB (baseline 4.43 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.14 MB (baseline 2.14 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 154 kB (baseline 154 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 5 unchanged Panels & Settings — 671 kB (baseline 671 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 19 unchanged User & Accounts — 54.4 kB (baseline 54.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 8 unchanged Editors & Dialogs — 325 kB (baseline 325 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 9 added / 9 removed / 4 unchanged UI Components — 201 kB (baseline 201 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 17 unchanged Data & Services — 3.07 MB (baseline 3.07 MB) • 🟢 -21 BStores, services, APIs, and repositories
Status: 18 added / 18 removed / 4 unchanged Utilities & Hooks — 812 kB (baseline 812 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 29 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.7 MB (baseline 18.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 87 added / 87 removed / 260 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-08T09:19:07.095Z",
"gitSha": "309cb77fe26f4cb0e8086d85a75150ce8a097705",
"branch": "jaewon/fe-3267-popover-email-once",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.6220000000126,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.9180000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.61800000000005,
"heapDeltaBytes": 8713232,
"heapUsedBytes": 73777944,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.544999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2014.946000000009,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.514,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.25499999999994,
"heapDeltaBytes": 12855840,
"heapUsedBytes": 83730004,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.458999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1699.7130000000311,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.189000000000002,
"layouts": 12,
"layoutDurationMs": 4.609,
"taskDurationMs": 800.9370000000001,
"heapDeltaBytes": 3886388,
"heapUsedBytes": 68569384,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 146.861,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1763.0309999999554,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.535,
"layouts": 12,
"layoutDurationMs": 4.485,
"taskDurationMs": 752.5250000000001,
"heapDeltaBytes": -27438220,
"heapUsedBytes": 82801672,
"domNodes": -212,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 142.10999999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1772.527000000025,
"styleRecalcs": 19,
"styleRecalcDurationMs": 7.447999999999998,
"layouts": 3,
"layoutDurationMs": 1.063,
"taskDurationMs": 435.58799999999997,
"heapDeltaBytes": -48903100,
"heapUsedBytes": 61625584,
"domNodes": -167,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 13.099,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66698113207547,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.2400000000034,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.3999999999999995,
"layouts": 3,
"layoutDurationMs": 0.9380000000000001,
"taskDurationMs": 362.94300000000004,
"heapDeltaBytes": 9089788,
"heapUsedBytes": 73700572,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.196000000000002,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 634.3360000000189,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.6220000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.47499999999997,
"heapDeltaBytes": -7474580,
"heapUsedBytes": 57129244,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.42100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631594,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 594.6870000000217,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.236000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.36499999999995,
"heapDeltaBytes": -7449748,
"heapUsedBytes": 57119948,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.07,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1155.8190000000081,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 826.6449999999999,
"heapDeltaBytes": 16235356,
"heapUsedBytes": 99089332,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 58.863000000000014,
"eventListeners": 0,
"totalBlockingTimeMs": 514,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1144.7110000000293,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 811.6470000000002,
"heapDeltaBytes": 21083288,
"heapUsedBytes": 106945088,
"domNodes": 0,
"jsHeapTotalBytes": 1736704,
"scriptDurationMs": 65.01199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 504,
"frameDurationMs": 33.8264705882353,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 864.7039999999606,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.19500000000005,
"heapDeltaBytes": 20588292,
"heapUsedBytes": 107433836,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 152.325,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 880.0360000000182,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.4749999999997,
"heapDeltaBytes": -5426776,
"heapUsedBytes": 82526668,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 152.28800000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 24.53611111111109,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9801.577000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8881.112,
"heapDeltaBytes": 10513012,
"heapUsedBytes": 82955296,
"domNodes": -141,
"jsHeapTotalBytes": -5115904,
"scriptDurationMs": 7182.839,
"eventListeners": -65,
"totalBlockingTimeMs": 459,
"frameDurationMs": 30.62375,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9167.84199999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8214.758,
"heapDeltaBytes": -9250988,
"heapUsedBytes": 74088804,
"domNodes": 0,
"jsHeapTotalBytes": -17039360,
"scriptDurationMs": 6600.174,
"eventListeners": 0,
"totalBlockingTimeMs": 82,
"frameDurationMs": 27.69274924471299,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9036.676,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.7699999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8045.012999999999,
"heapDeltaBytes": -18644408,
"heapUsedBytes": 70735780,
"domNodes": -112,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 6741.133,
"eventListeners": -77,
"totalBlockingTimeMs": 310,
"frameDurationMs": 29.04501607717042,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9117.466000000037,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.844000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8350.877,
"heapDeltaBytes": 25389636,
"heapUsedBytes": 97321820,
"domNodes": -141,
"jsHeapTotalBytes": -6426624,
"scriptDurationMs": 6698.558,
"eventListeners": -65,
"totalBlockingTimeMs": 208,
"frameDurationMs": 30.387666666666664,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2013.5819999999853,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.106999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.399,
"heapDeltaBytes": 88060,
"heapUsedBytes": 79607416,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 33.586000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2022.0090000000255,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.641,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.867,
"heapDeltaBytes": 2943964,
"heapUsedBytes": 95273964,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 33.668000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2360.382999999956,
"styleRecalcs": 65,
"styleRecalcDurationMs": 6.275999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1608.394,
"heapDeltaBytes": 23729328,
"heapUsedBytes": 89630112,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 810.2739999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666901408450702,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2292.466999999988,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.792000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1540.5539999999999,
"heapDeltaBytes": 879976,
"heapUsedBytes": 84837532,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 776.522,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665942028985505,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3688.980000000015,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.976999999999999,
"layouts": 60,
"layoutDurationMs": 18.499000000000002,
"taskDurationMs": 1758.472,
"heapDeltaBytes": -14320124,
"heapUsedBytes": 71138880,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 813.706,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66561085972851,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3447.8030000000217,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.020999999999999,
"layouts": 60,
"layoutDurationMs": 17.115,
"taskDurationMs": 1623.651,
"heapDeltaBytes": 8376360,
"heapUsedBytes": 75675392,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 743.163,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66618357487923,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2942.1879999999874,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.700000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1901.995,
"heapDeltaBytes": 536852,
"heapUsedBytes": 87436260,
"domNodes": 0,
"jsHeapTotalBytes": 1241088,
"scriptDurationMs": 974.251,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.761142857142858,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2876.090999999974,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.664,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1893.3299999999997,
"heapDeltaBytes": 24317592,
"heapUsedBytes": 95972888,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 980.7170000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.861764705882354,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2009.4650000000343,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.419,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.5239999999999,
"heapDeltaBytes": 25320032,
"heapUsedBytes": 96432804,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.444,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.2219999999897,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4079999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.6379999999999,
"heapDeltaBytes": 26172356,
"heapUsedBytes": 96748652,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 32.653,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 557.4530000000095,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.476000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.06699999999995,
"heapDeltaBytes": 13787448,
"heapUsedBytes": 70903916,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 139.197,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.1299999999446,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.613000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.34499999999997,
"heapDeltaBytes": 14142264,
"heapUsedBytes": 80653140,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 143.12199999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2014.3820000000119,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.045000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.278,
"heapDeltaBytes": 7778472,
"heapUsedBytes": 64883416,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.073,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2018.324000000007,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.9699999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.0779999999999,
"heapDeltaBytes": -13566172,
"heapUsedBytes": 58747112,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.228,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.3580000000243,
"styleRecalcs": 79,
"styleRecalcDurationMs": 19.699,
"layouts": 16,
"layoutDurationMs": 6.551000000000001,
"taskDurationMs": 846.659,
"heapDeltaBytes": -11890476,
"heapUsedBytes": 80590144,
"domNodes": -230,
"jsHeapTotalBytes": -4980736,
"scriptDurationMs": 103.294,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1743.182000000047,
"styleRecalcs": 79,
"styleRecalcDurationMs": 17.335,
"layouts": 16,
"layoutDurationMs": 6.210999999999999,
"taskDurationMs": 806.5409999999999,
"heapDeltaBytes": -11920600,
"heapUsedBytes": 80308912,
"domNodes": -230,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 102.44200000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1366.706000000022,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.065,
"layouts": 6,
"layoutDurationMs": 13.798000000000002,
"taskDurationMs": 907.677,
"heapDeltaBytes": 36135068,
"heapUsedBytes": 114596260,
"domNodes": 14650,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 29.729000000000006,
"eventListeners": 2456,
"totalBlockingTimeMs": 113,
"frameDurationMs": 19.483098591549286,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8516.143999999997,
"styleRecalcs": 251,
"styleRecalcDurationMs": 23.074000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5710.554,
"heapDeltaBytes": -17757912,
"heapUsedBytes": 71300548,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2679.5939999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666144814090018,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8588.494999999966,
"styleRecalcs": 251,
"styleRecalcDurationMs": 22.189,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5731.9130000000005,
"heapDeltaBytes": 9388676,
"heapUsedBytes": 93132776,
"domNodes": 0,
"jsHeapTotalBytes": 1015808,
"scriptDurationMs": 2762.56,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66621359223301,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18621.708000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17999.965000000004,
"heapDeltaBytes": -36686980,
"heapUsedBytes": 184155180,
"domNodes": -3046,
"jsHeapTotalBytes": 2641920,
"scriptDurationMs": 293.296,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.74524647887324,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-idle",
"durationMs": 18800.20400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18312.784,
"heapDeltaBytes": -38481140,
"heapUsedBytes": 184000244,
"domNodes": -3046,
"jsHeapTotalBytes": 9306112,
"scriptDurationMs": 295.22499999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.49584775086505,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-pan",
"durationMs": 17296.681999999975,
"styleRecalcs": 129,
"styleRecalcDurationMs": 12.635000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16877.458000000002,
"heapDeltaBytes": -37373332,
"heapUsedBytes": 189722936,
"domNodes": -3046,
"jsHeapTotalBytes": 1941504,
"scriptDurationMs": 807.376,
"eventListeners": -14913,
"totalBlockingTimeMs": 27,
"frameDurationMs": 32.39569288389514,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 22989.027999999962,
"styleRecalcs": 180,
"styleRecalcDurationMs": 16.957,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22662.971,
"heapDeltaBytes": -10306848,
"heapUsedBytes": 190035088,
"domNodes": -3046,
"jsHeapTotalBytes": 10289152,
"scriptDurationMs": 847.04,
"eventListeners": -14912,
"totalBlockingTimeMs": 18,
"frameDurationMs": 43.15028142589118,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6939.424000000031,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.36899999999999,
"layouts": 20,
"layoutDurationMs": 26.353,
"taskDurationMs": 6863.592,
"heapDeltaBytes": 1016236,
"heapUsedBytes": 221316880,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 125.467,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.26440677966102,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6896.906999999942,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.349,
"layouts": 20,
"layoutDurationMs": 25.67599999999999,
"taskDurationMs": 6743,
"heapDeltaBytes": -13916968,
"heapUsedBytes": 216386436,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 118.396,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.76179775280899,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9413.05,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9069.225999999999,
"heapDeltaBytes": -32459748,
"heapUsedBytes": 185724724,
"domNodes": -3046,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 148.49099999999993,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.391134751773045,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9494.627000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9166.054,
"heapDeltaBytes": -32120244,
"heapUsedBytes": 185168144,
"domNodes": -3046,
"jsHeapTotalBytes": 8159232,
"scriptDurationMs": 150.53600000000006,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.44964788732395,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "workflow-execution",
"durationMs": 490.59999999997217,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.04,
"layouts": 6,
"layoutDurationMs": 2.9299999999999993,
"taskDurationMs": 148.33500000000004,
"heapDeltaBytes": 6853816,
"heapUsedBytes": 63500584,
"domNodes": 138,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 17.077999999999996,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 100.00200000001769,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.700000000000001,
"layouts": 2,
"layoutDurationMs": 1.192,
"taskDurationMs": 69.47699999999999,
"heapDeltaBytes": 4126788,
"heapUsedBytes": 72647320,
"domNodes": 119,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.043999999999993,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 846.1700000000292,
"styleRecalcs": 77,
"styleRecalcDurationMs": 95.58,
"layouts": 76,
"layoutDurationMs": 27.019000000000002,
"taskDurationMs": 823.671,
"heapDeltaBytes": 17819172,
"heapUsedBytes": 94163876,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 324.073,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 916.8339999999944,
"styleRecalcs": 77,
"styleRecalcDurationMs": 99.453,
"layouts": 76,
"layoutDurationMs": 28.122999999999998,
"taskDurationMs": 885.968,
"heapDeltaBytes": 18350708,
"heapUsedBytes": 95010852,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 351.368,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665454545454537,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1430.9819999999718,
"styleRecalcs": 77,
"styleRecalcDurationMs": 280.543,
"layouts": 76,
"layoutDurationMs": 30.485000000000003,
"taskDurationMs": 1413.0690000000002,
"heapDeltaBytes": 10325200,
"heapUsedBytes": 123405256,
"domNodes": 77,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 465.078,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.35316455696202,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1463.926000000015,
"styleRecalcs": 77,
"styleRecalcDurationMs": 270.18399999999997,
"layouts": 76,
"layoutDurationMs": 30.384,
"taskDurationMs": 1433.0669999999998,
"heapDeltaBytes": 10484440,
"heapUsedBytes": 119710024,
"domNodes": 77,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 471.95400000000006,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.51851851851852,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2243 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughFor desktop host users, ChangesDesktop host user
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Desktop users will see a generic name instead of their email repeated as their name, while their email remains available. No concrete regression remains; the change is ready for normal checks. 🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The title and commit subject use the bug-fix signal
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20536 +/- ##
==========================================
+ Coverage 85.82% 86.65% +0.82%
==========================================
Files 3586 2531 -1055
Lines 171877 143637 -28240
Branches 47151 37123 -10028
==========================================
- Hits 147521 124470 -23051
+ Misses 22341 18781 -3560
+ Partials 2015 386 -1629
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1063 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified at exact head 82537c17a6455ab20df796fd68e03ad3bcfc0e3d. userDisplayName now returns undefined for a Desktop host user instead of repeating desktopHostUser.value.email; every call site already falls back to a generic label (userDisplayName || $t('g.user')) or an empty string, so the account popover and settings panel stop showing the email twice without leaving either blank. New test pins the signed-in Desktop host case. CI green, no open threads.
|
@dante01yoon Successfully backported to #20572 |
|
@dante01yoon Successfully backported to #20573 |
…es (Comfy-Org#22155) ## Summary QA L14 on the local SSO plan: with a local web SSO session the account menu shows "User" instead of the account name. Root cause: host sessions (local web SSO and Desktop) get their identity from the OAuth access token, which carries `email` but no name, and `useCurrentUser` deliberately shows no display name for them (Comfy-Org#20536, so the email is not repeated as the name). There was nothing to show. Comfy-Org/cloud#16878 adds an optional `name` claim to OAuth access tokens, from the same `users.name` the web session returns. This reads it: `readAccessTokenIdentity` takes `name`, the host session keeps it on its user, and `userDisplayName` shows it for host sessions. A token without the claim (before the cloud change ships, or an account with no name) still shows "User" with the email under it, as today. `DesktopHostAuthState` widens the Desktop bridge's signed-in state with an optional `name` so Desktop can pass the same claim later. ## Verification - Unit: `useCurrentUser` shows a host account by the name its session carries; the existing "without repeating the email as the name" case still passes. `startLocalWebSession` carries the token's `name` through to the host user. `src/platform/auth` + `src/composables/auth`: 657 passing. - End to end needs the cloud change on staging; until then the menu is unchanged ("User" + email), which this PR keeps.
…in fails (Comfy-Org#22153) ## Summary Two local web SSO QA findings (FE-3099, Denys, L11a and L14): - **L14, no workspace switcher.** Root cause: the local web auth bridge did not implement `switchWorkspace`, so `canDesktopHostSwitchWorkspace()` was false and the account menu hid the dropdown even though the workspace list was loaded. The OAuth token is bound to the workspace picked on consent and ingest has no endpoint that re-scopes it, so this does what Desktop's `CloudSession.switchWorkspace` does: keep each workspace's tokens (`Comfy.LocalWebSignIn.WorkspaceTokens`), switch straight to a workspace this page signed in to before (refreshing its tokens if expired), and go through consent otherwise. Sign-out forgets every workspace. - **L11a, silent failed sign-in.** Root cause: `startLocalWebSession` only called `reportError` when the returned sign-in failed. It now returns `sign-in-failed`, and `main.ts` shows the existing `auth.desktopHost.signInFailed` toast once Pinia is up. A declined consent still shows nothing. Not in this PR: L14's "User" instead of the account name. Host sessions show no display name on purpose (Comfy-Org#20536) and the OAuth access token carries no `name` claim, so the name needs a server fact (a `name` claim, or a loopback-CORS profile endpoint). Same on Desktop. ## Verification - Unit: `src/platform/auth/localWeb` + `desktopHost` (63 tests). New cases: switch to the current workspace, consent for an unknown workspace, instant switch back to a kept workspace, refresh of an expired kept workspace, sign-out forgets all, storage persistence of per-workspace tokens, `sign-in-failed` result. - Manual, staging: this branch built with `VITE_STAGING_CLOUD_BASE_URL=https://stagingcloud.comfy.org`, core with Comfy-Org/ComfyUI#17410, `local_web_sso` + `partner_node_token` on, Chrome. | | AS IS | TO BE | | --- | --- | --- | | Failed sign-in (`/?code=bogus&state=bogus`) | Signed out, nothing shown (QA L11a) | <img src="https://gist.githubusercontent.com/dante01yoon/bb9b0671127c0ae8c9ef6966c8349ea1/raw/a4f7071eed4ea211ca8dbc8f9ca7ea73cd5d7f33/signin-failed-toast.jpg" width="420"> | | Account menu | Current workspace only, no dropdown (QA L14) | <img src="https://gist.githubusercontent.com/dante01yoon/bb9b0671127c0ae8c9ef6966c8349ea1/raw/f3d6973862faa142ec7463fbd2f265d1cd3bef63/workspace-switcher.jpg" width="420"> | | Switch back to a kept workspace | Log out and pick on consent | No page load, Personal active with its credits: <img src="https://gist.githubusercontent.com/dante01yoon/bb9b0671127c0ae8c9ef6966c8349ea1/raw/cd0ac1eca585549a0b95639d596c0dd846853fa4/switched-back-personal.jpg" width="420"> | Switching to `team-test` (never signed in to from this page) went through stagingcloud consent and came back on `team-test`; switching back to Personal then happened in place.
Summary
In Desktop local, the account menu for a Desktop-signed-in (SSO) user showed the email twice: once as the name and once as the email line. Follow-up to #20383 (FE-3267).
Why: the menu reads as broken, and the agent panel and Settings > User showed the email where a name belongs.
Root cause: a Desktop host session carries no display name (the OAuth claims have
emailbut no name).useCurrentUser().userDisplayNamefell back to the email for host users, and the menu then rendered bothuserDisplayNameanduserEmail.How: for a host user,
userDisplayNameis now unset, as for a Firebase account without a display name. The menu shows the generic "User" title over the email, Settings > User shows "Not set", and the agent panel greets without a name.userEmailis unchanged.Verification
useCurrentUsercase (host account: email set, name unset) fails onmainand passes here. The suite has 15 tests.ssotest1@example.com. Screenshots below.AS IS
The Desktop SSO account's menu repeats the email as the name.
TO BE
Same account with this build: the email shows once, under the generic "User" title.