Repository navigation
FE-3298 test(cloud): pin the full-page SSO return to the served consent path - #20533
Conversation
Adds the browser case Christian asked for on #20468: SSO start 302s to its return_to, a document load of /oauth/consent answers the server's JSON 404, and the sign-in must still reach the consent page with the same oauth_request_id. Also maps /oauth/consent/ (trailing slash) like /oauth/consent and names BE-4146 so the helper and the redirect route are removed together.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b786346badf345d2782e81504bf46b4df122e374
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.35 MB gzip 🔴 +62 BDetailsSummary
Category Glance App Entry Points — 4.43 kB (baseline 4.43 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.14 MB (baseline 2.14 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 154 kB (baseline 154 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 5 unchanged Panels & Settings — 671 kB (baseline 671 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 19 unchanged User & Accounts — 54.4 kB (baseline 54.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 8 unchanged Editors & Dialogs — 325 kB (baseline 325 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 9 added / 9 removed / 4 unchanged UI Components — 201 kB (baseline 201 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 17 unchanged Data & Services — 3.07 MB (baseline 3.07 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 18 added / 18 removed / 4 unchanged Utilities & Hooks — 812 kB (baseline 812 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 29 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.7 MB (baseline 18.7 MB) • 🔴 +101 BBundles that do not match a named category
Status: 88 added / 88 removed / 259 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-08T17:38:30.506Z",
"gitSha": "0075d6ec8072a7e4db2226301ecad35d8e5aba6c",
"branch": "jaewon/fe-3298-sso-return-followups",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2013.5760000000005,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.91,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.8960000000001,
"heapDeltaBytes": 8689056,
"heapUsedBytes": 73449552,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.769999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2022.8980000000547,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.308999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.323,
"heapDeltaBytes": 12754836,
"heapUsedBytes": 82107396,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.535999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1839.986999999951,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.552,
"layouts": 12,
"layoutDurationMs": 5.194000000000001,
"taskDurationMs": 916.598,
"heapDeltaBytes": -14668872,
"heapUsedBytes": 64028908,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 171.09000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665454545454544,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.7510000000138,
"styleRecalcs": 55,
"styleRecalcDurationMs": 16.752,
"layouts": 12,
"layoutDurationMs": 5.149,
"taskDurationMs": 897.336,
"heapDeltaBytes": -54258116,
"heapUsedBytes": 56280120,
"domNodes": -212,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 153.308,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.245999999976,
"styleRecalcs": 19,
"styleRecalcDurationMs": 8.657000000000002,
"layouts": 3,
"layoutDurationMs": 1.0459999999999998,
"taskDurationMs": 356.086,
"heapDeltaBytes": -48738900,
"heapUsedBytes": 61647644,
"domNodes": -167,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 14.284,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.2779999999893,
"styleRecalcs": 19,
"styleRecalcDurationMs": 7.319000000000001,
"layouts": 3,
"layoutDurationMs": 0.932,
"taskDurationMs": 436.266,
"heapDeltaBytes": -49133540,
"heapUsedBytes": 61336288,
"domNodes": -167,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 12.048999999999998,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 715.7569999999964,
"styleRecalcs": 15,
"styleRecalcDurationMs": 5.273,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.277,
"heapDeltaBytes": -38322136,
"heapUsedBytes": 72031264,
"domNodes": -212,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 169.43599999999998,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.073170731707318,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 698.2679999999846,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.457000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.99,
"heapDeltaBytes": -38954060,
"heapUsedBytes": 72015720,
"domNodes": -232,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 167.461,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285704,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1187.1600000000058,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 911.311,
"heapDeltaBytes": 13289432,
"heapUsedBytes": 93262324,
"domNodes": 0,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 69.55100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 556,
"frameDurationMs": 34.8029411764706,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1184.4899999999825,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 801.8649999999999,
"heapDeltaBytes": 24212516,
"heapUsedBytes": 110282304,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 69.56899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 552,
"frameDurationMs": 34.8,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 871.70100000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.4069999999994,
"heapDeltaBytes": 20165032,
"heapUsedBytes": 107310884,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 180.695,
"eventListeners": 0,
"totalBlockingTimeMs": 235,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 848.0349999999817,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.2930000000004,
"heapDeltaBytes": -6738584,
"heapUsedBytes": 84656704,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 162.29500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 25.0029411764706,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11142.975000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10238.456,
"heapDeltaBytes": -185208,
"heapUsedBytes": 83087236,
"domNodes": 0,
"jsHeapTotalBytes": -16252928,
"scriptDurationMs": 8331.060000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1398,
"frameDurationMs": 32.31768115942029,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10052.594,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9200.553,
"heapDeltaBytes": -12926168,
"heapUsedBytes": 70204912,
"domNodes": 0,
"jsHeapTotalBytes": -23330816,
"scriptDurationMs": 7525.227,
"eventListeners": 0,
"totalBlockingTimeMs": 895,
"frameDurationMs": 31.404999999999994,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11107.518000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10299.022,
"heapDeltaBytes": -1282384,
"heapUsedBytes": 82064304,
"domNodes": 0,
"jsHeapTotalBytes": -16515072,
"scriptDurationMs": 8509.492,
"eventListeners": 0,
"totalBlockingTimeMs": 1322,
"frameDurationMs": 31.443342776203966,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10742.328000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9895.724000000002,
"heapDeltaBytes": 4177200,
"heapUsedBytes": 87900436,
"domNodes": 0,
"jsHeapTotalBytes": -10485760,
"scriptDurationMs": 8166.71,
"eventListeners": 0,
"totalBlockingTimeMs": 1336,
"frameDurationMs": 31.848367952522253,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 216.51100000002543,
"styleRecalcs": 24,
"styleRecalcDurationMs": 19.416999999999998,
"layouts": 5,
"layoutDurationMs": 2.216,
"taskDurationMs": 151.601,
"heapDeltaBytes": 12150188,
"heapUsedBytes": 76778988,
"domNodes": 918,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.096000000000007,
"eventListeners": 202,
"totalBlockingTimeMs": 2,
"frameDurationMs": 24.077777777777857,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 216.84800000002724,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.805,
"layouts": 5,
"layoutDurationMs": 1.8789999999999998,
"taskDurationMs": 161.91,
"heapDeltaBytes": -10601524,
"heapUsedBytes": 76395180,
"domNodes": 918,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.342000000000002,
"eventListeners": 202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2007.6220000000262,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.191999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.753,
"heapDeltaBytes": 482788,
"heapUsedBytes": 84009488,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 38.89499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.8570000000072,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.353999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.689,
"heapDeltaBytes": -18338640,
"heapUsedBytes": 87442500,
"domNodes": -308,
"jsHeapTotalBytes": -5378048,
"scriptDurationMs": 32.870999999999995,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2560.5860000000007,
"styleRecalcs": 63,
"styleRecalcDurationMs": 5.572000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1697.8819999999998,
"heapDeltaBytes": 23071556,
"heapUsedBytes": 89430988,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 849.1059999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.775657894736845,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2429.6509999999216,
"styleRecalcs": 66,
"styleRecalcDurationMs": 6.152999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1620.5109999999997,
"heapDeltaBytes": 23842580,
"heapUsedBytes": 89095760,
"domNodes": -308,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 832.808,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78194444444445,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3566.2300000000187,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.809000000000001,
"layouts": 60,
"layoutDurationMs": 17.536,
"taskDurationMs": 1641.5270000000003,
"heapDeltaBytes": 14027524,
"heapUsedBytes": 84577540,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 837.545,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665887850467293,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3575.550999999905,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.938,
"layouts": 60,
"layoutDurationMs": 17.535999999999998,
"taskDurationMs": 1578.2100000000003,
"heapDeltaBytes": -10695116,
"heapUsedBytes": 75133556,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 794.578,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665887850467286,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3137.654999999995,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.961999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1996.1159999999998,
"heapDeltaBytes": 2609744,
"heapUsedBytes": 90428264,
"domNodes": 0,
"jsHeapTotalBytes": 1241088,
"scriptDurationMs": 1011.9349999999998,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84516129032258,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3094.0160000000105,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.906,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2013.084,
"heapDeltaBytes": 850372,
"heapUsedBytes": 88596552,
"domNodes": 0,
"jsHeapTotalBytes": 716800,
"scriptDurationMs": 1031.4070000000002,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.847282608695654,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.7750000000287,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.4020000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.211,
"heapDeltaBytes": 921800,
"heapUsedBytes": 85895500,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 38.63,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.9810000000625,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.745,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.343,
"heapDeltaBytes": 803784,
"heapUsedBytes": 85313784,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 38.25600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.5809999999951,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.821,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.241,
"heapDeltaBytes": -8037052,
"heapUsedBytes": 64646860,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 146.923,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 630.1830000001019,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.435999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.43899999999996,
"heapDeltaBytes": -24492100,
"heapUsedBytes": 67941156,
"domNodes": -230,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 144.857,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888906,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.3729999999873,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.743999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.307,
"heapDeltaBytes": 7832736,
"heapUsedBytes": 64219928,
"domNodes": -230,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.62,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2060.510000000022,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.8950000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.07699999999994,
"heapDeltaBytes": -49847164,
"heapUsedBytes": 61741824,
"domNodes": -230,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 11.467999999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1732.9709999999636,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.54,
"layouts": 16,
"layoutDurationMs": 6.828000000000001,
"taskDurationMs": 833.397,
"heapDeltaBytes": 25595172,
"heapUsedBytes": 82830696,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.99900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.1210000000192,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.491,
"layouts": 16,
"layoutDurationMs": 6.650999999999999,
"taskDurationMs": 814.635,
"heapDeltaBytes": 4145536,
"heapUsedBytes": 76134756,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 110.88699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.367999999934,
"styleRecalcs": 19,
"styleRecalcDurationMs": 29.557999999999993,
"layouts": 6,
"layoutDurationMs": 15.168999999999999,
"taskDurationMs": 944.3039999999999,
"heapDeltaBytes": 33929432,
"heapUsedBytes": 113499648,
"domNodes": 14650,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 31.182000000000002,
"eventListeners": 2456,
"totalBlockingTimeMs": 132,
"frameDurationMs": 19.4054794520548,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9578.31200000004,
"styleRecalcs": 249,
"styleRecalcDurationMs": 20.802,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6039.782999999999,
"heapDeltaBytes": 10206184,
"heapUsedBytes": 93294300,
"domNodes": 0,
"jsHeapTotalBytes": 491520,
"scriptDurationMs": 2889.319,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8873.849000000064,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.937,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5791.915999999999,
"heapDeltaBytes": 12765060,
"heapUsedBytes": 97007636,
"domNodes": 0,
"jsHeapTotalBytes": 1277952,
"scriptDurationMs": 2751.34,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69717514124294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18822.795999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18312.364999999998,
"heapDeltaBytes": -34649900,
"heapUsedBytes": 184395040,
"domNodes": -3047,
"jsHeapTotalBytes": 6197248,
"scriptDurationMs": 294.18899999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.163931623931624,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-idle",
"durationMs": 18895.22599999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18494.878999999997,
"heapDeltaBytes": -42002240,
"heapUsedBytes": 183394544,
"domNodes": -3046,
"jsHeapTotalBytes": 892928,
"scriptDurationMs": 291.00100000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.333219178082196,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 23220.21000000001,
"styleRecalcs": 179,
"styleRecalcDurationMs": 15.936000000000034,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22820.048,
"heapDeltaBytes": -26821796,
"heapUsedBytes": 189983100,
"domNodes": -3046,
"jsHeapTotalBytes": 5787648,
"scriptDurationMs": 925.446,
"eventListeners": -14913,
"totalBlockingTimeMs": 3,
"frameDurationMs": 42.754511970534075,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 23563.11000000005,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.992000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23237.817,
"heapDeltaBytes": -39579708,
"heapUsedBytes": 190119924,
"domNodes": -3046,
"jsHeapTotalBytes": 9490432,
"scriptDurationMs": 886.7790000000001,
"eventListeners": -14913,
"totalBlockingTimeMs": 26,
"frameDurationMs": 43.47915129151292,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 5054.977000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.73100000000002,
"layouts": 20,
"layoutDurationMs": 23.48800000000001,
"taskDurationMs": 4894.182,
"heapDeltaBytes": 793552,
"heapUsedBytes": 224673648,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 95.06899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.021839080459767,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 6785.545999999954,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.83500000000002,
"layouts": 20,
"layoutDurationMs": 26.05099999999999,
"taskDurationMs": 6679.215999999999,
"heapDeltaBytes": 15365812,
"heapUsedBytes": 215825912,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 120.74000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.33953488372094,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9643.256999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9339.539,
"heapDeltaBytes": -39969460,
"heapUsedBytes": 185845600,
"domNodes": -3046,
"jsHeapTotalBytes": 1155072,
"scriptDurationMs": 145.2,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.821768707483,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9609.014000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9305.451,
"heapDeltaBytes": -35954572,
"heapUsedBytes": 184332440,
"domNodes": -3046,
"jsHeapTotalBytes": 5906432,
"scriptDurationMs": 153.06099999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.988316151202746,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "workflow-execution",
"durationMs": 485.4680000000826,
"styleRecalcs": 21,
"styleRecalcDurationMs": 18.217999999999996,
"layouts": 4,
"layoutDurationMs": 2.6760000000000006,
"taskDurationMs": 145.36100000000002,
"heapDeltaBytes": 6590588,
"heapUsedBytes": 68924036,
"domNodes": 134,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.404000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 126.91499999993994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 14.036,
"layouts": 4,
"layoutDurationMs": 2.503,
"taskDurationMs": 92.63000000000002,
"heapDeltaBytes": 4194300,
"heapUsedBytes": 66811100,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.164999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.433333333333394,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 908.5679999999456,
"styleRecalcs": 77,
"styleRecalcDurationMs": 94.981,
"layouts": 76,
"layoutDurationMs": 27.017,
"taskDurationMs": 884.4340000000001,
"heapDeltaBytes": 18279032,
"heapUsedBytes": 95895944,
"domNodes": 77,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 358.195,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667272727272724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 947.9690000000573,
"styleRecalcs": 77,
"styleRecalcDurationMs": 98.48400000000001,
"layouts": 76,
"layoutDurationMs": 27.982,
"taskDurationMs": 921.781,
"heapDeltaBytes": 18477936,
"heapUsedBytes": 96317156,
"domNodes": 77,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 370.469,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664912280701763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1517.1419999999216,
"styleRecalcs": 77,
"styleRecalcDurationMs": 276.225,
"layouts": 76,
"layoutDurationMs": 30.707,
"taskDurationMs": 1491.624,
"heapDeltaBytes": 10859856,
"heapUsedBytes": 127904280,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 499.51399999999995,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.495121951219517,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1547.9629999999815,
"styleRecalcs": 77,
"styleRecalcDurationMs": 281.676,
"layouts": 76,
"layoutDurationMs": 31.493,
"taskDurationMs": 1527.1319999999998,
"heapDeltaBytes": 10835020,
"heapUsedBytes": 123911136,
"domNodes": 77,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 519.4830000000001,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.901219512195116,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2249 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe SSO return-path helper now matches ChangesSSO OAuth Consent Return Path
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change normalizes OAuth consent return paths and adds regression coverage for the consent flow. The supplied evidence shows no actionable merge risk. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20533 +/- ##
==========================================
+ Coverage 85.82% 86.65% +0.82%
==========================================
Files 3586 2531 -1055
Lines 171877 143643 -28234
Branches 47151 39291 -7860
==========================================
- Hits 147521 124474 -23047
+ Misses 22341 18783 -3558
+ Partials 2015 386 -1629
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1103 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
The e2e server only serves the SPA at /, so a direct load of /cloud/login came back as a download. Start at /?oauth_request_id= (the router keeps the request id) and answer the full-page /cloud/oauth/consent load with the app, as the real server does.
Playwright does not route requests that follow a redirect, so the 302 from the mocked SSO start reached the e2e server's real 404 for /cloud/oauth/consent. Answer SSO start with a page that navigates to return_to, which the consent route then serves like the real server.
christian-byrne
left a comment
There was a problem hiding this comment.
No actionable findings. The SSO return-path normalization preserves the OAuth request ID, and the browser regression test covers the full-page consent return boundary.
|
@dante01yoon Successfully backported to #20568 |
|
@dante01yoon Successfully backported to #20569 |
Summary
This PR picks up three follow-ups from Christian's review of #20468 (FE-3298, the SSO return to OAuth consent). It adds the browser coverage he asked for and fixes both of his notes on
ssoReturnPath.ts.Why: the
/cloud/oauth/consentredirect route now carries every SSO return to consent. Until now only an in-memory unit test guarded it. The bug in #20468 lived at the full-page-load boundary, and no test exercised that boundary.How:
Browser case in
cloudSsoSignIn.spec.ts, built the way Christian outlined:/api/auth/sso/start302s to itsreturn_to./oauth/consentgets the server's JSON 404./cloud/login?oauth_request_id=…with Continue with SSO, the test asserts the consent heading and the sameoauth_request_id.No real IdP is involved.
Trailing slash:
toSsoReturnPathnow also maps/oauth/consent/, which also 404s on both hosts and which vue-router would match to the consent view.Coupling note: the doc comment now names BE-4146, so this helper and the redirect route get removed together.
No user-facing change, so there are no AS IS/TO BE screenshots.
Verification
ssoReturnPath.test.tscovers five cases. The trailing-slash case fails onmainand passes here.typecheck:appandtypecheck:browserare clean.@cloud). Its target behaviour is already onmain, so it is a regression guard and is not expected to go red onmain.