Repository navigation
[backport core/1.55] feat(agent): add an asset tray with independent inline references (#20156) - #20524
[backport core/1.55] feat(agent): add an asset tray with independent inline references (#20156)#20524christian-byrne wants to merge 5 commits into
Conversation
…0156) Separate attached assets from inline references so users can build a prompt naturally while keeping their files in a visible asset tray. - **A separate asset tray.** Added assets appear above the prompt as thumbnails or type icons, with transparent backgrounds and no borders. Filenames appear on hover. The circular × appears on hover or keyboard focus, and stays visible on touch devices. The extra node-reference row is removed. - **Assets referenced inline with `@`.** Users can search by asset name and select with the mouse or keyboard to insert at the caret. The same asset can be referenced unlimited times. Assets sit alongside the existing node and workflow options. - **Consistent, compact inline chips.** Asset, node and workflow chips share the same appearance and removal interaction, with no left/right padding. Chips fit within the compact composer line height. Removing a chip deletes only that occurrence, supports Undo and returns focus for continued typing. - **Different hover behavior for tray and inline.** Tray hover shows the filename and a large image or media preview. Click, keyboard and touch can open an interactive preview. Activating another asset replaces the current preview, so only one stays open. Inline hover/focus highlights the corresponding tray asset without opening a preview, so inserting a chip beneath the pointer doesn't interrupt typing. - **Video and audio support.** Videos share one thumbnail across the tray, `@` menu and inline chips. Audio uses the music icon throughout, including renamed files. Tray previews provide native playback controls with no autoplay. Closing, replacing or removing a preview stops and resets playback, including quick close/reopen. Audio controls are inset within the card’s corners. - **Discoverable tray scrolling.** Many assets stay in one horizontally scrollable row at a consistent size. Arrows and edge fades indicate additional content. Controls reflect scroll boundaries and update as assets or panel width change. - **The whole chat panel accepts drops.** Users can drop supported files or drag assets from the in-app library anywhere in the panel. Drop feedback covers the panel while preserving composer layout and input. Library drops work for unnamed assets and re-additions after removal or sending; already included library assets remain deduplicated. - **Duplicate additions stay clear.** Adding an included file or library asset again keeps one tray item and shows a brief filename notice; a batch reports the number skipped while unique files continue uploading. Removing an asset and adding it again is allowed, and repeated inline mentions remain unlimited. - **Stable composer sizing.** Production-style compact text spacing is retained. Inline chips don't expand the line height. Starting to type doesn't shrink the composer when its placeholder wraps onto multiple lines. - **Clear attachment and removal rules.** Adding an asset doesn't automatically mention it. Removing an inline occurrence keeps the asset in the tray; removing the tray asset removes all its mentions. Sending includes each tray asset once, even when unmentioned or referenced repeatedly. Asset-only messages work. Failed sends restore an untouched draft; newer input takes priority. - **Visible upload feedback.** Pending-upload status stays visible outside the horizontally scrolling tray. Users can see why Send is unavailable, and pressing Enter preserves their draft while uploads are pending. - **Theme-aware styling and fresh node references.** Asset surfaces, previews, highlights and controls follow the active theme. The `@` node list follows the eligible viewed graph as nodes are added, renamed or removed, and updates when switching graphs without another keystroke. Check the distinction between tray inclusion and inline occurrences, draft recovery after a failed send, and preview cleanup after removal, replacement or successful sending. Preserve the bulk-layout/action guarantees from #20110 and the upload-feedback behavior overlapping Validation: 553 tests pass across ten focused unit/component suites after merging latest main. All 14 focused Chromium browser regressions pass with retries disabled: exclusive previews, native media close/reopen and replacement, single/plural duplicate notices, mixed pending batches, grid/list null-name library re-addition, touch disclosure/removal, node rename/delete/undo freshness, shared posters and short-panel geometry. Touch was emulated; physical devices were not exercised. Normal commit and Knip/Fallow push gates pass without added suppressions or baseline changes. Remote CI is pending for this update. this PR. File deduplication uses browser file metadata (name, size, lastModified and MIME type); library additions use stable source identity. It does not hash local file bytes or retroactively remove duplicates from an already-open draft. - Upgrade and full related-ticket map: [FE-3219](https://linear.app/comfyorg/issue/FE-3219/agent-composer-asset-tray-with-independent-inline-references). - Fixes tracked within this PR: [FE-3220](https://linear.app/comfyorg/issue/FE-3220/fix-stale-node-candidates-in-the-agent-picker) (stale `@` node candidates) and [FE-3221](https://linear.app/comfyorg/issue/FE-3221/fix-unnamed-and-re-added-library-asset-drops-into-agent-chat) (unnamed/re-added library drops). - QA: [CQA-1080](https://linear.app/comfyorg/issue/CQA-1080/asset-tray-independent-inline-asset-references-in-agent-composer-20156). Related product reports: [PM-1230](https://linear.app/comfyorg/issue/PM-1230) / [PM-1231](https://linear.app/comfyorg/issue/PM-1231) cover attachment/reference confusion. [PM-1126](https://linear.app/comfyorg/issue/PM-1126) / [PM-1127](https://linear.app/comfyorg/issue/PM-1127) are partially aligned: mentions become optional, but this PR uses a tray rather than their proposed Reference-panel section. [FE-2209](https://linear.app/comfyorg/issue/FE-2209) was reopened for the approved composer rework and is In Review: show nodes once inline, keep useful asset previews, and preserve sent-message rendering. This upgrade also changes asset removal so deleting an inline occurrence keeps the included file. Upstream overlap: [PM-1954](https://linear.app/comfyorg/issue/PM-1954) / [FE-3202](https://linear.app/comfyorg/issue/FE-3202) retain ownership of bulk-layout/upload-feedback fixes (#20110, #20150, #20152); their guarantees are preserved here. These related links do not assert that every older ticket is fully resolved. Media scope from #20157 is included here, with QA in [CQA-1081](https://linear.app/comfyorg/issue/CQA-1081/shared-video-posters-and-hover-playback-for-agent-media-attachments). --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2152 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ❌ FailedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (78 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2b12a925bf8c8415d654cf3d9dd0fdf8c27bd5bc
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-08T10:43:19.783Z",
"gitSha": "7c5750d9a1c0f09dd12ee8d6f6d7e69df4002fb4",
"branch": "backport-20156-to-core-1.55-manual",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1986.8319999999926,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.378,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.09299999999996,
"heapDeltaBytes": -10652416,
"heapUsedBytes": 58181220,
"domNodes": -256,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.775,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2000.6899999999632,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.152,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.4270000000001,
"heapDeltaBytes": 8494972,
"heapUsedBytes": 77538500,
"domNodes": -260,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 11.639999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.6040000000266,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.141,
"heapDeltaBytes": 8733744,
"heapUsedBytes": 77662212,
"domNodes": -257,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 110.11699999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.0820000000276,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.867,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 636.413,
"heapDeltaBytes": -7517376,
"heapUsedBytes": 61731836,
"domNodes": -259,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 120.583,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1690.731000000028,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.788,
"layouts": 6,
"layoutDurationMs": 1.0099999999999998,
"taskDurationMs": 214.28300000000002,
"heapDeltaBytes": 3354956,
"heapUsedBytes": 71596256,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9.456000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1702.8520000000071,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.507,
"layouts": 6,
"layoutDurationMs": 1.1489999999999998,
"taskDurationMs": 288.16600000000005,
"heapDeltaBytes": 3221072,
"heapUsedBytes": 72036500,
"domNodes": 80,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 14.308,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 476.41500000003134,
"styleRecalcs": 17,
"styleRecalcDurationMs": 9.092,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 312.12899999999996,
"heapDeltaBytes": -7983952,
"heapUsedBytes": 61060156,
"domNodes": 25,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 110.904,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 516.7800000000398,
"styleRecalcs": 16,
"styleRecalcDurationMs": 9.450999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 349.877,
"heapDeltaBytes": 18136404,
"heapUsedBytes": 87122472,
"domNodes": 23,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 119.005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 874.781999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.92600000000004,
"heapDeltaBytes": 39040760,
"heapUsedBytes": 104386096,
"domNodes": -289,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 37.36300000000001,
"eventListeners": -195,
"totalBlockingTimeMs": 275,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 919.9359999999501,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.1100000000001,
"heapDeltaBytes": -17831980,
"heapUsedBytes": 73272552,
"domNodes": -292,
"jsHeapTotalBytes": 19791872,
"scriptDurationMs": 39.44199999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 280,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 670.6560000000081,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 253.1920000000003,
"heapDeltaBytes": 14839080,
"heapUsedBytes": 90801696,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 89.946,
"eventListeners": 0,
"totalBlockingTimeMs": 81,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 685.6640000000311,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 287.44900000000007,
"heapDeltaBytes": 14366400,
"heapUsedBytes": 91318340,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 94.384,
"eventListeners": 0,
"totalBlockingTimeMs": 89,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6462.016000000005,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.4760000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5278.603,
"heapDeltaBytes": 3066132,
"heapUsedBytes": 81815216,
"domNodes": -270,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 4093.591,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6531.789000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5260.177,
"heapDeltaBytes": -8123548,
"heapUsedBytes": 73365564,
"domNodes": -18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 4101.0960000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6454.084000000023,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.4090000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5282.772,
"heapDeltaBytes": 14954568,
"heapUsedBytes": 97006108,
"domNodes": -12,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 4232.639000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 16,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6570.455999999978,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.162000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5418.357,
"heapDeltaBytes": 8350088,
"heapUsedBytes": 72706056,
"domNodes": -270,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 4291.638,
"eventListeners": -174,
"totalBlockingTimeMs": 13,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2025.762000000043,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.193,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.104,
"heapDeltaBytes": -23030032,
"heapUsedBytes": 66333312,
"domNodes": -254,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 25.869000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2009.1550000000211,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.355999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.56500000000005,
"heapDeltaBytes": -23088664,
"heapUsedBytes": 66973024,
"domNodes": -247,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 30.661,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2130.726999999979,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.413,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1083.2150000000001,
"heapDeltaBytes": 1979136,
"heapUsedBytes": 91694004,
"domNodes": -244,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 553.1140000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2248.716999999999,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.689,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1191.115,
"heapDeltaBytes": 494040,
"heapUsedBytes": 65451700,
"domNodes": -242,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 606.4150000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3083.0859999999802,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.766999999999996,
"layouts": 60,
"layoutDurationMs": 14.457,
"taskDurationMs": 1120.552,
"heapDeltaBytes": -435368,
"heapUsedBytes": 89913244,
"domNodes": 42,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 506.46900000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3117.1869999999444,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.832000000000003,
"layouts": 60,
"layoutDurationMs": 15.588999999999999,
"taskDurationMs": 1241.252,
"heapDeltaBytes": 106204,
"heapUsedBytes": 65760420,
"domNodes": 32,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 565.0590000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2389.9509999999964,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.164000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1385.405,
"heapDeltaBytes": 3341344,
"heapUsedBytes": 69751800,
"domNodes": 12,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 722.089,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2512.440999999967,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.059999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1425.7909999999997,
"heapDeltaBytes": 3606484,
"heapUsedBytes": 68515876,
"domNodes": -250,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 727.93,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2036.3669999999843,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.9499999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.983,
"heapDeltaBytes": -22737980,
"heapUsedBytes": 67958252,
"domNodes": -251,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 28.705000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.0680000000375,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.635,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.11100000000005,
"heapDeltaBytes": -23741920,
"heapUsedBytes": 67775660,
"domNodes": -249,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 28.976000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 526.7100000000369,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.934999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.173,
"heapDeltaBytes": 13286136,
"heapUsedBytes": 84069328,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 115.269,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 480.2439999999706,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.552,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 296.1859999999999,
"heapDeltaBytes": 14370188,
"heapUsedBytes": 85406000,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 102.839,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1989.9469999999724,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.97,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 268.846,
"heapDeltaBytes": 9670736,
"heapUsedBytes": 80681996,
"domNodes": -272,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 5.63,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1989.4259999999804,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.151000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.378,
"heapDeltaBytes": -8024068,
"heapUsedBytes": 63213964,
"domNodes": -273,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 10.623000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.5400000000177,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.915999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.328,
"heapDeltaBytes": -9550108,
"heapUsedBytes": 61570032,
"domNodes": -274,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 77.49600000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1674.1400000000226,
"styleRecalcs": 47,
"styleRecalcDurationMs": 17.446,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 636.625,
"heapDeltaBytes": -9743916,
"heapUsedBytes": 61296708,
"domNodes": -274,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 98.72200000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 800.7719999999949,
"styleRecalcs": 19,
"styleRecalcDurationMs": 20.074,
"layouts": 5,
"layoutDurationMs": 7.984,
"taskDurationMs": 605.3850000000001,
"heapDeltaBytes": -6313992,
"heapUsedBytes": 81889944,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 20.496,
"eventListeners": 2383,
"totalBlockingTimeMs": 63,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8153.356999999971,
"styleRecalcs": 251,
"styleRecalcDurationMs": 43.933,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3645.784,
"heapDeltaBytes": -4164336,
"heapUsedBytes": 85157856,
"domNodes": -241,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 1844.209,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8337.946999999986,
"styleRecalcs": 252,
"styleRecalcDurationMs": 49.31999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4288.016,
"heapDeltaBytes": -2021872,
"heapUsedBytes": 87840484,
"domNodes": -242,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 2074.009,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12060.757000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11604.720000000001,
"heapDeltaBytes": -49605868,
"heapUsedBytes": 176604504,
"domNodes": -8062,
"jsHeapTotalBytes": -12591104,
"scriptDurationMs": 164.19400000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12166.416000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11934.615000000002,
"heapDeltaBytes": -32140132,
"heapUsedBytes": 194677028,
"domNodes": -8062,
"jsHeapTotalBytes": -13447168,
"scriptDurationMs": 177.167,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13830.105000000003,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.392000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13577.310999999998,
"heapDeltaBytes": -51439428,
"heapUsedBytes": 174858796,
"domNodes": -8062,
"jsHeapTotalBytes": -21311488,
"scriptDurationMs": 585.106,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14369.856000000027,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.693999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14268.263,
"heapDeltaBytes": -38897628,
"heapUsedBytes": 180951968,
"domNodes": -8062,
"jsHeapTotalBytes": -21311488,
"scriptDurationMs": 699.681,
"eventListeners": -14928,
"totalBlockingTimeMs": 57,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4268.609000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.181999999999974,
"layouts": 20,
"layoutDurationMs": 22.581999999999997,
"taskDurationMs": 4233.659,
"heapDeltaBytes": -35827068,
"heapUsedBytes": 190434076,
"domNodes": -8062,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 65.306,
"eventListeners": -14928,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4639.51499999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.77199999999999,
"layouts": 20,
"layoutDurationMs": 31.80200000000001,
"taskDurationMs": 4603.383,
"heapDeltaBytes": -49884516,
"heapUsedBytes": 177812944,
"domNodes": -8061,
"jsHeapTotalBytes": 5439488,
"scriptDurationMs": 75.519,
"eventListeners": -14928,
"totalBlockingTimeMs": 175,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5934.573999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5845.0639999999985,
"heapDeltaBytes": 22467804,
"heapUsedBytes": 190020872,
"domNodes": 0,
"jsHeapTotalBytes": -21233664,
"scriptDurationMs": 102.12599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5990.593999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5926.386,
"heapDeltaBytes": 18845368,
"heapUsedBytes": 182251212,
"domNodes": 0,
"jsHeapTotalBytes": -11010048,
"scriptDurationMs": 83.32099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 456.7049999999995,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.052999999999997,
"layouts": 4,
"layoutDurationMs": 1.9680000000000002,
"taskDurationMs": 118.616,
"heapDeltaBytes": 5342748,
"heapUsedBytes": 71821204,
"domNodes": 156,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.068,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 432.9769999999371,
"styleRecalcs": 17,
"styleRecalcDurationMs": 19.938,
"layouts": 2,
"layoutDurationMs": 0.5780000000000002,
"taskDurationMs": 91.96600000000001,
"heapDeltaBytes": 4883272,
"heapUsedBytes": 72084472,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.849,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
dante01yoon
left a comment
There was a problem hiding this comment.
Two reproducible regressions remain on this core/1.55 backport: different files with equal metadata are rejected as duplicates, and Escape leaves an interactive media preview open/playing.
Own exact-head verification: isolated frozen install; 729 unit/component tests across 22 files; app/browser types, OSS and Cloud production builds, changed-file type-aware oxlint/ESLint/format and Knip PASS. On the actual Cloud production build with an isolated local ComfyUI backend, 10 relevant browser cases PASS and 6 media-preview cases FAIL. An independent equal-metadata red/blue PNG case also FAILS (one chip, one upload); its real composable/store unit case FAILS, while the pre-backport production code passes it.
In a disposable diagnostic build, explicit preview state dismissal plus bypassing the metadata-only duplicate key makes all 11 affected browser cases PASS; restoring original source and production output restores the five preview failures plus the file collision failure. This is causal validation, not a proposed committed patch. The failed-submission attachment and media-stop mutations fail 4/44 and 2/44 respectively; restoration passes 44/44. Two narrower reference-cleanup mutations still pass 44/44 and are not claimed as discriminating evidence.
UploadImageResponse and its parser remain generated imports; attachment/reference state is local draft state, not inferred backend authority. Auth/billing/Agent transport is controlled; uploaded PNGs use the real local backend and media decodes in Chromium. Live Cloud/accounts/payment/native Desktop/other OS browsers/broad extension packs/full performance and accessibility audits NOT_RUN. Required unit and E2E workflows are still running in the inspected matching-head CI snapshot; no overall CI PASS claimed. All temporary source/artifacts restored.
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 4 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 654e963 | Docs | View more details | Give us feedback! |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.55 #20524 +/- ##
=============================================
+ Coverage 84.92% 84.98% +0.06%
=============================================
Files 2347 2357 +10
Lines 134014 134577 +563
Branches 35797 34092 -1705
=============================================
+ Hits 113816 114375 +559
- Misses 19833 19837 +4
Partials 365 365
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
The two earlier findings are fixed: independent equal-metadata red/blue PNG uploads and audio/video Escape dismissal now pass in the exact-head production app. Each new committed regression fails when its old production implementation is restored (1 file-key failure; 2 Escape failures), then 70 focused tests pass after restoration.
Approval remains blocked by the repeated-drop contract below. Own frozen install, app/browser types, OSS and Cloud production builds, changed-file type-aware lint/ESLint/format and knip passed. Related unit suites: 728 PASS / 2 FAIL. Actual production Chromium: 11 PASS / 2 FAIL. Restoring the old file-key implementation makes both failing unit cases and both repeated-drop browser journeys pass; restoring the current source reproduces the failures. Matching-head latest required unit CI run 37755234802 is completed FAILURE on the same two tests; this is not a cancelled-run gate.
Cloud auth/billing/Agent services were controlled fixtures with a real isolated local ComfyUI backend. Live Cloud accounts, payment, native Desktop, other OS/browsers and broad performance/accessibility validation are NOT_RUN; no performance claim or new server/API contract is involved in this four-file increment. Prior full-PR evidence remains timestamped separately.
| .filter((file) => !isTooLarge(file)) | ||
| .map((file) => ({ file, id: stage(file.name) })) | ||
| .flatMap((file) => { | ||
| const id = stage(file.name, fileSourceKey(file)) |
There was a problem hiding this comment.
[P2] Reconcile fresh-File identity with the existing repeated-drop contract
A repeated user drop/reselection creates a new File object, so this key now stages the same physical file again. On this exact production head, agentComposerRepeatedFileDrop.spec.ts stages 2 chips instead of 1 for a repeated drop and 4 instead of 2 for the mixed batch; AgentPanelRoot.test.ts (reports 1/2 skipped files once) fails the same contract. Restoring only the old useAttachment.ts makes both unit cases and both browser journeys pass, while the current source reproduces all four failures; latest matching-head unit CI also fails these two cases. The distinct-content collision fix and Escape fix are verified. Please reconcile repeated-drop behavior and the integration/E2E expectations before approval, preserving distinct equal-metadata contents; if object-identity-only dedup is an intentional contract change, document it and align the affected suites rather than leaving them red.
Addresses review feedback: #20524 (comment)
|
Addressed the final repeated-drop finding on the current head: fresh File objects now deduplicate by content while equal-metadata/different-content files remain independent. Focused attachment tests (42/42), the duplicate-notice panel cases, the isolated telemetry case, app typecheck, changed-file lint/format, and pre-push audit pass. The full AgentPanelRoot file had one order-dependent telemetry failure that passes alone; CI is running for the published head. Review finding: #20524 (comment) |
dante01yoon
left a comment
There was a problem hiding this comment.
The original fresh-File deduplication failure is fixed: the single-file pending/settled repeat journey and independent equal-metadata red/blue PNG case now pass. Two issues remain in the new fingerprint path, reproduced below.
Own exact-head verification: frozen install; app/browser types; OSS and Cloud production builds; changed-file type-aware oxlint, production/browser ESLint, format and Knip PASS. Related unit suites: 729 PASS / 1 FAIL (the existing deferred-asset drop-telemetry case); that failure is not treated as a successful suite. Actual production Chromium against an isolated local backend: 12 PASS / 1 FAIL, with the mixed pending batch missing its duplicate notice. A separate controlled digest-failure journey FAILS on an unhandled page error while uploads still succeed; the real composable/store probe also exits with an unhandled rejection.
In a disposable diagnostic, separating duplicate notification from upload completion and handling every fingerprint promise makes both independent unit probes and all three repeat/fingerprint browser cases PASS. Restoring original source/output reproduces both browser failures. The committed fresh-File unit fails with the previous production implementation restored; a constant-content-hash mutation fails the distinct-content guard; restoration passes 70 focused tests. Matching-head unit/E2E CI is still in progress; no complete CI PASS is claimed.
These checks use controlled auth/billing/Agent services and digest failure injection with an actual local backend/production browser. Live Cloud/customer accounts/payment/native Desktop/other OS browsers/broad extension and full performance/accessibility audits NOT_RUN (outside this increment; no performance claim). Generated upload response/parser and backend authority remain unchanged. All temporary source, tests and build mutations were restored.
| if (await uploadStagedFile(finalId, file)) uploaded += 1 | ||
| }) | ||
| ) | ||
| if (fingerprintDuplicates.length) |
There was a problem hiding this comment.
issue: [P2] Report duplicates before awaiting unrelated uploads. fingerprintDuplicates is emitted only after this Promise.all has awaited every uploadStagedFile. Drop a previously staged image twice together with a new audio file while uploads are pending: the two existing files are correctly skipped, but no plural duplicate notice appears until the new upload finishes (or times out). I reproduced the committed agentComposerRepeatedFileDrop.spec.ts:71 failure on the exact-head production build: expected one “Skipped 2 duplicate assets” alert, received zero. An independent real-composable/store case fails the same way; separating fingerprint/staging completion from upload completion makes both pass. Please preserve one batched notice as soon as duplicate classification finishes, without waiting for the accepted sibling upload.
| if (!priorFingerprint) { | ||
| metadataFingerprints.set( | ||
| metadataKey, | ||
| fingerprint.then((sourceKey) => { |
There was a problem hiding this comment.
issue: [P2] Handle rejected fingerprint promises on every branch. Catching fingerprint later does not handle the separate promise returned by this .then, nor the fire-and-forget .then below. Also, when await priorFingerprint rejects, the newly created fingerprint is never awaited before the fallback runs. With a controlled SHA-256 rejection, actual production uploads still complete through the fallback, but the browser reports an unhandled NotSupportedError; the real composable/store test likewise exits with an unhandled rejection. This can also be reached when WebCrypto/file reading is unavailable. Please own rejection handling for all derived/new fingerprint promises and retain a regression that checks the fallback uploads without an unhandled error. Handling only the update .then branches still leaves the second-file rejection; handling all three paths makes the unit and production-browser probes pass.
|
Closing because core/1.55 is retired. This carrier must not be refreshed or merged; any still-needed delivery should be recreated from the merged source on core/1.56. |
Pull request was closed
Backports #20156 to core/1.55 after the automatic cherry-pick conflicted.
This preserves the target branch architecture and adapts the attachment-click telemetry contract so menu and drag/drop entry remain distinguishable on core/1.55.
Validation: 641 focused unit/component tests pass across 11 suites; app typecheck, changed-file formatting/lint, commit hooks, and pre-push Knip pass.
Source: #20156