Repository navigation
[backport cloud/1.54] fix(agent): mint a promoted host write so prompt-node edits aren't rejected (#20377) - #20520
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1988 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-08T06:24:14.523Z",
"gitSha": "40b1b80ec71be8573b07f55ab48c40908a4f794d",
"branch": "backport-20377-to-cloud-1.54-manual",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2125.437999999974,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.9339999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.963,
"heapDeltaBytes": 8190956,
"heapUsedBytes": 81544312,
"domNodes": -279,
"jsHeapTotalBytes": 3702784,
"scriptDurationMs": 21.254,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.4829999999793,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.861999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.819,
"heapDeltaBytes": 2687304,
"heapUsedBytes": 76152936,
"domNodes": -279,
"jsHeapTotalBytes": 3964928,
"scriptDurationMs": 10.543999999999997,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1748.3220000000301,
"styleRecalcs": 74,
"styleRecalcDurationMs": 25.979999999999997,
"layouts": 14,
"layoutDurationMs": 3.7510000000000003,
"taskDurationMs": 772.591,
"heapDeltaBytes": -13980304,
"heapUsedBytes": 59202436,
"domNodes": -282,
"jsHeapTotalBytes": 5275648,
"scriptDurationMs": 130.38000000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1722.652999999923,
"styleRecalcs": 74,
"styleRecalcDurationMs": 25.596,
"layouts": 14,
"layoutDurationMs": 3.497,
"taskDurationMs": 740.395,
"heapDeltaBytes": 10374928,
"heapUsedBytes": 83664988,
"domNodes": -280,
"jsHeapTotalBytes": 3702784,
"scriptDurationMs": 122.613,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.4509999999918,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.745000000000001,
"layouts": 6,
"layoutDurationMs": 1.097,
"taskDurationMs": 289.151,
"heapDeltaBytes": 4910332,
"heapUsedBytes": 78078988,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.05,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1686.2979999999652,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.801,
"layouts": 6,
"layoutDurationMs": 1.1360000000000001,
"taskDurationMs": 348.742,
"heapDeltaBytes": 4442496,
"heapUsedBytes": 76549488,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.963000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 575.4220000000032,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.872000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.947,
"heapDeltaBytes": -7162948,
"heapUsedBytes": 65962544,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 135.247,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 557.8319999999621,
"styleRecalcs": 14,
"styleRecalcDurationMs": 7.774999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.11600000000004,
"heapDeltaBytes": -7141724,
"heapUsedBytes": 66533396,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 133.589,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2028.6609999999996,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.579000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.275,
"heapDeltaBytes": -4107472,
"heapUsedBytes": 76142016,
"domNodes": -266,
"jsHeapTotalBytes": -2326528,
"scriptDurationMs": 35.263999999999996,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.5339999999796,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.545,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.745,
"heapDeltaBytes": -6754804,
"heapUsedBytes": 73572940,
"domNodes": -274,
"jsHeapTotalBytes": -2064384,
"scriptDurationMs": 33.260999999999996,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2221.5040000000386,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.809999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1434.339,
"heapDeltaBytes": 10784292,
"heapUsedBytes": 88647440,
"domNodes": -286,
"jsHeapTotalBytes": -1454080,
"scriptDurationMs": 690.6399999999999,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2152.4029999999357,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.742,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1333.2150000000001,
"heapDeltaBytes": 10751840,
"heapUsedBytes": 92709688,
"domNodes": -280,
"jsHeapTotalBytes": 258048,
"scriptDurationMs": 664.4290000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3260.5479999999716,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.151,
"layouts": 60,
"layoutDurationMs": 12.357,
"taskDurationMs": 1487.345,
"heapDeltaBytes": 1620964,
"heapUsedBytes": 68297536,
"domNodes": 30,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 689.09,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3268.1980000000976,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.275999999999998,
"layouts": 60,
"layoutDurationMs": 12.157000000000002,
"taskDurationMs": 1482.5080000000003,
"heapDeltaBytes": -15176728,
"heapUsedBytes": 66856364,
"domNodes": -256,
"jsHeapTotalBytes": -2326528,
"scriptDurationMs": 646.021,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2590.5480000000125,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.112,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1679.245,
"heapDeltaBytes": 13881016,
"heapUsedBytes": 96454656,
"domNodes": 8,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 855.636,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2367.2310000000607,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.216,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1607.1540000000002,
"heapDeltaBytes": 14261824,
"heapUsedBytes": 97004972,
"domNodes": 12,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 818.972,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2001.9589999999994,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.196999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.1869999999999,
"heapDeltaBytes": 11761440,
"heapUsedBytes": 77643276,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.151,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.34799999998,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.788,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.952,
"heapDeltaBytes": 10503816,
"heapUsedBytes": 90266756,
"domNodes": -283,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 34.318,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.3800000000192,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.867999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.015,
"heapDeltaBytes": 14607700,
"heapUsedBytes": 88352360,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 128.274,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 546.0869999999431,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.433,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.46599999999995,
"heapDeltaBytes": 14487164,
"heapUsedBytes": 86924100,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 127.98899999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2041.1220000000299,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.635,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.045,
"heapDeltaBytes": -3628084,
"heapUsedBytes": 72192340,
"domNodes": -297,
"jsHeapTotalBytes": 3702784,
"scriptDurationMs": 12.357,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2034.4479999999976,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.330999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.933,
"heapDeltaBytes": -11078200,
"heapUsedBytes": 62363244,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.616,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.8589999999945,
"styleRecalcs": 78,
"styleRecalcDurationMs": 25.917999999999996,
"layouts": 18,
"layoutDurationMs": 4.505,
"taskDurationMs": 759.447,
"heapDeltaBytes": -9465348,
"heapUsedBytes": 63924120,
"domNodes": -296,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 100.333,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.6940000000131,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.900999999999996,
"layouts": 18,
"layoutDurationMs": 4.396,
"taskDurationMs": 726.705,
"heapDeltaBytes": -8109380,
"heapUsedBytes": 65278920,
"domNodes": -295,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 98.355,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 917.6330000000235,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.911000000000005,
"layouts": 16,
"layoutDurationMs": 11.720999999999998,
"taskDurationMs": 730.1399999999998,
"heapDeltaBytes": 22156036,
"heapUsedBytes": 106431124,
"domNodes": 13831,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 23.61200000000001,
"eventListeners": 2385,
"totalBlockingTimeMs": 95,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8312.917000000027,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.316,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4735.048,
"heapDeltaBytes": -11890884,
"heapUsedBytes": 68228212,
"domNodes": -242,
"jsHeapTotalBytes": -1015808,
"scriptDurationMs": 2207.511,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8366.07700000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.254,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4844.0199999999995,
"heapDeltaBytes": 1207132,
"heapUsedBytes": 78652368,
"domNodes": -280,
"jsHeapTotalBytes": -143360,
"scriptDurationMs": 2253.8900000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15475.12800000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14909.399999999998,
"heapDeltaBytes": -46965996,
"heapUsedBytes": 177179152,
"domNodes": -8068,
"jsHeapTotalBytes": -18063360,
"scriptDurationMs": 259.99899999999997,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 15495.76300000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15072.731000000002,
"heapDeltaBytes": -37227480,
"heapUsedBytes": 194191000,
"domNodes": -8068,
"jsHeapTotalBytes": -11837440,
"scriptDurationMs": 272.822,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17657.076999999957,
"styleRecalcs": 135,
"styleRecalcDurationMs": 16.19699999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17364.549,
"heapDeltaBytes": -36189836,
"heapUsedBytes": 170450592,
"domNodes": -8068,
"jsHeapTotalBytes": -14663680,
"scriptDurationMs": 790.51,
"eventListeners": -14931,
"totalBlockingTimeMs": 30,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18280.760999999984,
"styleRecalcs": 127,
"styleRecalcDurationMs": 17.44499999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18040.786999999997,
"heapDeltaBytes": -38858364,
"heapUsedBytes": 183990556,
"domNodes": -8068,
"jsHeapTotalBytes": -17661952,
"scriptDurationMs": 800.538,
"eventListeners": -14931,
"totalBlockingTimeMs": 103,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5508.853000000045,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.71399999999999,
"layouts": 20,
"layoutDurationMs": 22.46899999999999,
"taskDurationMs": 5447.044999999999,
"heapDeltaBytes": -24681912,
"heapUsedBytes": 200510652,
"domNodes": -8068,
"jsHeapTotalBytes": 15630336,
"scriptDurationMs": 97.41400000000002,
"eventListeners": -14931,
"totalBlockingTimeMs": 219,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5465.6179999999495,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.449000000000005,
"layouts": 20,
"layoutDurationMs": 23.51199999999999,
"taskDurationMs": 5403.455999999999,
"heapDeltaBytes": -50050876,
"heapUsedBytes": 184657604,
"domNodes": -8068,
"jsHeapTotalBytes": 21221376,
"scriptDurationMs": 94.48599999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 297,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7761.109000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7469.311999999999,
"heapDeltaBytes": 28584368,
"heapUsedBytes": 192881192,
"domNodes": 0,
"jsHeapTotalBytes": -15990784,
"scriptDurationMs": 118.57199999999996,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7135.778999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6902.731999999998,
"heapDeltaBytes": -42987820,
"heapUsedBytes": 170332036,
"domNodes": -3057,
"jsHeapTotalBytes": 9134080,
"scriptDurationMs": 112.10599999999998,
"eventListeners": -14934,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 83.63499999995838,
"styleRecalcs": 6,
"styleRecalcDurationMs": 13.108,
"layouts": 2,
"layoutDurationMs": 0.6429999999999999,
"taskDurationMs": 62.06399999999999,
"heapDeltaBytes": 3108832,
"heapUsedBytes": 75064924,
"domNodes": 107,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.027000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666674,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 476.4099999999871,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.978,
"layouts": 3,
"layoutDurationMs": 1.5109999999999997,
"taskDurationMs": 119.21,
"heapDeltaBytes": 4984784,
"heapUsedBytes": 74474344,
"domNodes": 144,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.992999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.54 #20520 +/- ##
=============================================
Coverage ? 84.20%
=============================================
Files ? 2132
Lines ? 128739
Branches ? 34997
=============================================
Hits ? 108403
Misses ? 20155
Partials ? 181
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed exact cloud/1.54 head a4aaf5f in an isolated Git checkout with its own frozen dependency installation.
PASS: 613 relevant unit tests across 9 files (2 existing expected failures separate), app/browser types, Cloud production build, changed-file type-aware oxlint/production ESLint/format and final knip. Two real production Chromium journeys exercised Vue and legacy promoted widgets through the installed public host applier: multiline/Unicode prompt, sibling seed preservation, subsequent remote update and graph serialization. Legacy prompt input was a real UI interaction; its numeric sibling used the real legacy widget setter/callback. Restoring the 5 pre-PR production files gives 4 unit failures and 2 browser failures (host prompt remains unchanged); restoring this head gives 59 focused tests and both browser journeys passing. Index/order/report-budget mutations each fail a committed guard. Independent matching-name/cardinality and intervening-normal-write budget checks pass at head and fail their corresponding mutations. All temporary source/artifact changes are restored; 12 PR files match this SHA and the checkout is clean.
The new derived layout is local shared-document data; promoted writes use the public PromotedHostWrite from @comfyorg/comfy-multi-player 0.3.6 and the real installed applier. No new HTTP response shape or server billing/auth state is assembled here. Existing entity callbacks and UI layout are unchanged. Auth/billing/workflow/Agent transport are controlled fixtures, with an isolated local ComfyUI backend; this does not prove live Cloud/customer, payment, ingestion or broad extension/other-OS behavior. Those checks and unrelated full performance/accessibility matrices are NOT_RUN for this focused protocol fix. Initial unavailable release fixture APIs and diagnostic-only type/knip failures were harness issues, corrected before the valid runs above.
BLOCKED for approval: matching-head required test job in CI: Tests Unit run 37736433192 remains in progress. Matching E2E 37736435309 and lint 37736433550 have completed successfully, but they do not replace the unfinished unit gate. I will re-check the current state/SHA and valid required result before approving. CI was not rerun.
|
|
||
| it('refuses and reports a drifted promoted layout once per host', () => { | ||
| rootNodes.set('7', promotedHost(['prefix', 'text'])) | ||
| docPromotedWidgets = { |
There was a problem hiding this comment.
Non-blocking regression-coverage suggestion: also cover matching promoted names with a different stored valueCount (for example 3 stored values for these 2 live inputs). Removing only doc.valueCount === liveNames.length leaves all 11 committed widget-port tests green; an independent case passes on this head and fails with that mutation. The runtime currently refuses this case correctly; this suggestion is about retaining that guard.
dante01yoon
left a comment
There was a problem hiding this comment.
Approved a4aaf5f after all three latest required contexts and their matching-head unit/lint/E2E workflows completed SUCCESS. This closes the CI-only blocker in review 5452590961. The preceding exact-head isolated verification remains: own frozen install; 613 related units /9 files (two existing expected failures); app/browser types, Cloud production build, changed lint/format and final knip PASS; two actual-production Vue/legacy browser cases PASS. Restoring the five preceding production files fails four focused units and both production browser cases; restoring the reviewed source passes. Index/order/report-budget mutations also fail and restore passes. The matching-name cardinality safety-net suggestion remains nonblocking. No local units/types/build/browser/mutations were rerun for this unchanged-head CI follow-up. Public PromotedHostWrite and the installed host applier were verified in the preceding review; no new HTTP response type or backend authority inference. Controlled auth/billing/Agent transport and NOT_RUN live Cloud/customer/accounts/payment/ingestion/inference/native/other-OS/broad-extension/full performance/a11y limits remain as documented.
Summary
Backports the target-compatible prompt-node reliability fix from #20377 to cloud/1.54.
Changes
Review Focus
Verify promoted host sibling ordering and the fail-closed drift guard. No feature flags, exposure, or user-visible copy changed.
Validation:
pnpm test:unit widgetMintPort.test.ts mintPortWiring.test.ts agentSubgraphDefinitions.test.ts(59 passed);pnpm typecheck; staged formatting/lint hooks.