Skip to content

[backport cloud/1.54] fix(agent): mint a promoted host write so prompt-node edits aren't rejected (#20377) - #20520

Merged
comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-20377-to-cloud-1.54-manual
Oct 8, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-20377-to-cloud-1.54-manual

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backports the target-compatible prompt-node reliability fix from #20377 to cloud/1.54.

Changes

  • What: Emits the positional promoted-host payload required when a user edits a promoted subgraph widget while the Agent document is bound; fails closed and reports once when live/document widget order drifts.
  • Dependencies: None. This adapts the merged fix to cloud/1.54's legacy mint-port architecture.

Review Focus

Verify promoted host sibling ordering and the fail-closed drift guard. No feature flags, exposure, or user-visible copy changed.

Validation: pnpm test:unit widgetMintPort.test.ts mintPortWiring.test.ts agentSubgraphDefinitions.test.ts (59 passed); pnpm typecheck; staged formatting/lint hooks.

@vercel

vercel Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 8, 2026 6:13am UTC
billing-web-test Ignored Ignored Oct 8, 2026 6:13am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 3eeb6c2c-03f6-4847-9925-a6d2347cb3ee

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/08/2026, 06:15:33 AM UTC

Links

🎭 Playwright: ✅ 1988 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1967 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 92.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 95ms TBT · 101.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.0 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 177.1 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 67ms TBT · 169.0 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 258ms TBT · 183.7 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.2 MB heap
workflow-execution: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 532ms
canvas-idle: script duration 16ms
canvas-idle: TBT 0ms
canvas-idle: heap used 75.2 MB
canvas-idle: DOM nodes -279
canvas-idle: event listeners -189
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 26ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 756ms
canvas-mouse-sweep: script duration 126ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 68.1 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -164
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 319ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 73.7 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 398ms
dom-widget-clipping: script duration 134ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 63.2 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 548ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 71.4 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -177
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1384ms
large-graph-pan: script duration 678ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 86.5 MB
large-graph-pan: DOM nodes -283
large-graph-pan: event listeners -175
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 69
large-graph-zoom: task duration 1485ms
large-graph-zoom: script duration 668ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 64.4 MB
large-graph-zoom: DOM nodes -113
large-graph-zoom: event listeners -90
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 9ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1643ms
legacy-node-drag: script duration 837ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 92.2 MB
legacy-node-drag: DOM nodes 10
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 514ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.1 MB
minimap-idle: DOM nodes -139
minimap-idle: event listeners -92
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 374ms
subgraph-dom-widget-clipping: script duration 128ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.6 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 491ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 64.2 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -242
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 25ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 743ms
subgraph-mouse-sweep: script duration 99ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 61.6 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -241
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 26ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 730ms
subgraph-transition-enter: script duration 24ms
subgraph-transition-enter: TBT 95ms
subgraph-transition-enter: heap used 101.5 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4790ms
viewport-pan-sweep: script duration 2231ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 70.0 MB
viewport-pan-sweep: DOM nodes -261
viewport-pan-sweep: event listeners -174
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14991ms
vue-large-graph-idle: script duration 266ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 177.1 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 131
vue-large-graph-pan: task duration 17703ms
vue-large-graph-pan: script duration 796ms
vue-large-graph-pan: TBT 67ms
vue-large-graph-pan: heap used 169.0 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14931
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 62ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5425ms
vue-node-resize-workload: script duration 96ms
vue-node-resize-workload: TBT 258ms
vue-node-resize-workload: heap used 183.7 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14930
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7186ms
vue-zoom-out-idle: script duration 115ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 173.2 MB
vue-zoom-out-idle: DOM nodes -1529
vue-zoom-out-idle: event listeners -7472
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 20ms
workflow-execution: layout count 3
workflow-execution: style recalc count 12
workflow-execution: task duration 91ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 71.3 MB
workflow-execution: DOM nodes 126
workflow-execution: event listeners 49
Raw data
{
  "timestamp": "2026-10-08T06:24:14.523Z",
  "gitSha": "40b1b80ec71be8573b07f55ab48c40908a4f794d",
  "branch": "backport-20377-to-cloud-1.54-manual",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2125.437999999974,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.9339999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 586.963,
      "heapDeltaBytes": 8190956,
      "heapUsedBytes": 81544312,
      "domNodes": -279,
      "jsHeapTotalBytes": 3702784,
      "scriptDurationMs": 21.254,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2007.4829999999793,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.861999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 477.819,
      "heapDeltaBytes": 2687304,
      "heapUsedBytes": 76152936,
      "domNodes": -279,
      "jsHeapTotalBytes": 3964928,
      "scriptDurationMs": 10.543999999999997,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1748.3220000000301,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 25.979999999999997,
      "layouts": 14,
      "layoutDurationMs": 3.7510000000000003,
      "taskDurationMs": 772.591,
      "heapDeltaBytes": -13980304,
      "heapUsedBytes": 59202436,
      "domNodes": -282,
      "jsHeapTotalBytes": 5275648,
      "scriptDurationMs": 130.38000000000002,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1722.652999999923,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 25.596,
      "layouts": 14,
      "layoutDurationMs": 3.497,
      "taskDurationMs": 740.395,
      "heapDeltaBytes": 10374928,
      "heapUsedBytes": 83664988,
      "domNodes": -280,
      "jsHeapTotalBytes": 3702784,
      "scriptDurationMs": 122.613,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.4509999999918,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 12.745000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.097,
      "taskDurationMs": 289.151,
      "heapDeltaBytes": 4910332,
      "heapUsedBytes": 78078988,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.05,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1686.2979999999652,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.801,
      "layouts": 6,
      "layoutDurationMs": 1.1360000000000001,
      "taskDurationMs": 348.742,
      "heapDeltaBytes": 4442496,
      "heapUsedBytes": 76549488,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 12.963000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 575.4220000000032,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 8.872000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.947,
      "heapDeltaBytes": -7162948,
      "heapUsedBytes": 65962544,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 135.247,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 557.8319999999621,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 7.774999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 387.11600000000004,
      "heapDeltaBytes": -7141724,
      "heapUsedBytes": 66533396,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 133.589,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2028.6609999999996,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.579000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 544.275,
      "heapDeltaBytes": -4107472,
      "heapUsedBytes": 76142016,
      "domNodes": -266,
      "jsHeapTotalBytes": -2326528,
      "scriptDurationMs": 35.263999999999996,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.5339999999796,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.545,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 550.745,
      "heapDeltaBytes": -6754804,
      "heapUsedBytes": 73572940,
      "domNodes": -274,
      "jsHeapTotalBytes": -2064384,
      "scriptDurationMs": 33.260999999999996,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2221.5040000000386,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.809999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1434.339,
      "heapDeltaBytes": 10784292,
      "heapUsedBytes": 88647440,
      "domNodes": -286,
      "jsHeapTotalBytes": -1454080,
      "scriptDurationMs": 690.6399999999999,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2152.4029999999357,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.742,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1333.2150000000001,
      "heapDeltaBytes": 10751840,
      "heapUsedBytes": 92709688,
      "domNodes": -280,
      "jsHeapTotalBytes": 258048,
      "scriptDurationMs": 664.4290000000001,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3260.5479999999716,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.151,
      "layouts": 60,
      "layoutDurationMs": 12.357,
      "taskDurationMs": 1487.345,
      "heapDeltaBytes": 1620964,
      "heapUsedBytes": 68297536,
      "domNodes": 30,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 689.09,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3268.1980000000976,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.275999999999998,
      "layouts": 60,
      "layoutDurationMs": 12.157000000000002,
      "taskDurationMs": 1482.5080000000003,
      "heapDeltaBytes": -15176728,
      "heapUsedBytes": 66856364,
      "domNodes": -256,
      "jsHeapTotalBytes": -2326528,
      "scriptDurationMs": 646.021,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2590.5480000000125,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 8.112,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1679.245,
      "heapDeltaBytes": 13881016,
      "heapUsedBytes": 96454656,
      "domNodes": 8,
      "jsHeapTotalBytes": 5922816,
      "scriptDurationMs": 855.636,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2367.2310000000607,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.216,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1607.1540000000002,
      "heapDeltaBytes": 14261824,
      "heapUsedBytes": 97004972,
      "domNodes": 12,
      "jsHeapTotalBytes": 5398528,
      "scriptDurationMs": 818.972,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2001.9589999999994,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.196999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.1869999999999,
      "heapDeltaBytes": 11761440,
      "heapUsedBytes": 77643276,
      "domNodes": 6,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 33.151,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.34799999998,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.788,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 545.952,
      "heapDeltaBytes": 10503816,
      "heapUsedBytes": 90266756,
      "domNodes": -283,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 34.318,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 574.3800000000192,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 12.867999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 369.015,
      "heapDeltaBytes": 14607700,
      "heapUsedBytes": 88352360,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 128.274,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 546.0869999999431,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.433,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 378.46599999999995,
      "heapDeltaBytes": 14487164,
      "heapUsedBytes": 86924100,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 127.98899999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2041.1220000000299,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.635,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 551.045,
      "heapDeltaBytes": -3628084,
      "heapUsedBytes": 72192340,
      "domNodes": -297,
      "jsHeapTotalBytes": 3702784,
      "scriptDurationMs": 12.357,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2034.4479999999976,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.330999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 431.933,
      "heapDeltaBytes": -11078200,
      "heapUsedBytes": 62363244,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.616,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.8589999999945,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 25.917999999999996,
      "layouts": 18,
      "layoutDurationMs": 4.505,
      "taskDurationMs": 759.447,
      "heapDeltaBytes": -9465348,
      "heapUsedBytes": 63924120,
      "domNodes": -296,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 100.333,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.6940000000131,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 24.900999999999996,
      "layouts": 18,
      "layoutDurationMs": 4.396,
      "taskDurationMs": 726.705,
      "heapDeltaBytes": -8109380,
      "heapUsedBytes": 65278920,
      "domNodes": -295,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 98.355,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 917.6330000000235,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 25.911000000000005,
      "layouts": 16,
      "layoutDurationMs": 11.720999999999998,
      "taskDurationMs": 730.1399999999998,
      "heapDeltaBytes": 22156036,
      "heapUsedBytes": 106431124,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 23.61200000000001,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 95,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8312.917000000027,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 39.316,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4735.048,
      "heapDeltaBytes": -11890884,
      "heapUsedBytes": 68228212,
      "domNodes": -242,
      "jsHeapTotalBytes": -1015808,
      "scriptDurationMs": 2207.511,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8366.07700000002,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 40.254,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4844.0199999999995,
      "heapDeltaBytes": 1207132,
      "heapUsedBytes": 78652368,
      "domNodes": -280,
      "jsHeapTotalBytes": -143360,
      "scriptDurationMs": 2253.8900000000003,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15475.12800000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14909.399999999998,
      "heapDeltaBytes": -46965996,
      "heapUsedBytes": 177179152,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18063360,
      "scriptDurationMs": 259.99899999999997,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15495.76300000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15072.731000000002,
      "heapDeltaBytes": -37227480,
      "heapUsedBytes": 194191000,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11837440,
      "scriptDurationMs": 272.822,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17657.076999999957,
      "styleRecalcs": 135,
      "styleRecalcDurationMs": 16.19699999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17364.549,
      "heapDeltaBytes": -36189836,
      "heapUsedBytes": 170450592,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14663680,
      "scriptDurationMs": 790.51,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 30,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18280.760999999984,
      "styleRecalcs": 127,
      "styleRecalcDurationMs": 17.44499999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18040.786999999997,
      "heapDeltaBytes": -38858364,
      "heapUsedBytes": 183990556,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17661952,
      "scriptDurationMs": 800.538,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 103,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5508.853000000045,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 61.71399999999999,
      "layouts": 20,
      "layoutDurationMs": 22.46899999999999,
      "taskDurationMs": 5447.044999999999,
      "heapDeltaBytes": -24681912,
      "heapUsedBytes": 200510652,
      "domNodes": -8068,
      "jsHeapTotalBytes": 15630336,
      "scriptDurationMs": 97.41400000000002,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 219,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5465.6179999999495,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 62.449000000000005,
      "layouts": 20,
      "layoutDurationMs": 23.51199999999999,
      "taskDurationMs": 5403.455999999999,
      "heapDeltaBytes": -50050876,
      "heapUsedBytes": 184657604,
      "domNodes": -8068,
      "jsHeapTotalBytes": 21221376,
      "scriptDurationMs": 94.48599999999999,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 297,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7761.109000000033,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7469.311999999999,
      "heapDeltaBytes": 28584368,
      "heapUsedBytes": 192881192,
      "domNodes": 0,
      "jsHeapTotalBytes": -15990784,
      "scriptDurationMs": 118.57199999999996,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7135.778999999957,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6902.731999999998,
      "heapDeltaBytes": -42987820,
      "heapUsedBytes": 170332036,
      "domNodes": -3057,
      "jsHeapTotalBytes": 9134080,
      "scriptDurationMs": 112.10599999999998,
      "eventListeners": -14934,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 83.63499999995838,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 13.108,
      "layouts": 2,
      "layoutDurationMs": 0.6429999999999999,
      "taskDurationMs": 62.06399999999999,
      "heapDeltaBytes": 3108832,
      "heapUsedBytes": 75064924,
      "domNodes": 107,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.027000000000001,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666674,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 476.4099999999871,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 25.978,
      "layouts": 3,
      "layoutDurationMs": 1.5109999999999997,
      "taskDurationMs": 119.21,
      "heapDeltaBytes": 4984784,
      "heapUsedBytes": 74474344,
      "domNodes": 144,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 12.992999999999999,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51187 76659 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@christian-byrne christian-byrne added the cloud/1.54 Backport PRs for cloud 1.54 label Oct 8, 2026
@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.28571% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../extensions/agent/crdt/agentSubgraphDefinitions.ts 87.50% 4 Missing and 1 partial ⚠️
.../extensions/agent/crdt/__fixtures__/crdtSession.ts 0.00% 2 Missing ⚠️
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 33.33% 2 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #20520   +/-   ##
=============================================
  Coverage              ?   84.20%           
=============================================
  Files                 ?     2132           
  Lines                 ?   128739           
  Branches              ?    34997           
=============================================
  Hits                  ?   108403           
  Misses                ?    20155           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.77% <ø> (?)
unit 79.67% <89.28%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/workbench/extensions/agent/AgentPanelRoot.vue 92.73% <ø> (ø)
.../workbench/extensions/agent/crdt/mintPortWiring.ts 93.89% <100.00%> (ø)
.../workbench/extensions/agent/crdt/widgetMintPort.ts 100.00% <100.00%> (ø)
.../extensions/agent/crdt/__fixtures__/crdtSession.ts 96.00% <0.00%> (ø)
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 95.13% <33.33%> (ø)
.../extensions/agent/crdt/agentSubgraphDefinitions.ts 96.31% <87.50%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact cloud/1.54 head a4aaf5f in an isolated Git checkout with its own frozen dependency installation.

PASS: 613 relevant unit tests across 9 files (2 existing expected failures separate), app/browser types, Cloud production build, changed-file type-aware oxlint/production ESLint/format and final knip. Two real production Chromium journeys exercised Vue and legacy promoted widgets through the installed public host applier: multiline/Unicode prompt, sibling seed preservation, subsequent remote update and graph serialization. Legacy prompt input was a real UI interaction; its numeric sibling used the real legacy widget setter/callback. Restoring the 5 pre-PR production files gives 4 unit failures and 2 browser failures (host prompt remains unchanged); restoring this head gives 59 focused tests and both browser journeys passing. Index/order/report-budget mutations each fail a committed guard. Independent matching-name/cardinality and intervening-normal-write budget checks pass at head and fail their corresponding mutations. All temporary source/artifact changes are restored; 12 PR files match this SHA and the checkout is clean.

The new derived layout is local shared-document data; promoted writes use the public PromotedHostWrite from @comfyorg/comfy-multi-player 0.3.6 and the real installed applier. No new HTTP response shape or server billing/auth state is assembled here. Existing entity callbacks and UI layout are unchanged. Auth/billing/workflow/Agent transport are controlled fixtures, with an isolated local ComfyUI backend; this does not prove live Cloud/customer, payment, ingestion or broad extension/other-OS behavior. Those checks and unrelated full performance/accessibility matrices are NOT_RUN for this focused protocol fix. Initial unavailable release fixture APIs and diagnostic-only type/knip failures were harness issues, corrected before the valid runs above.

BLOCKED for approval: matching-head required test job in CI: Tests Unit run 37736433192 remains in progress. Matching E2E 37736435309 and lint 37736433550 have completed successfully, but they do not replace the unfinished unit gate. I will re-check the current state/SHA and valid required result before approving. CI was not rerun.


it('refuses and reports a drifted promoted layout once per host', () => {
rootNodes.set('7', promotedHost(['prefix', 'text']))
docPromotedWidgets = {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking regression-coverage suggestion: also cover matching promoted names with a different stored valueCount (for example 3 stored values for these 2 live inputs). Removing only doc.valueCount === liveNames.length leaves all 11 committed widget-port tests green; an independent case passes on this head and fails with that mutation. The runtime currently refuses this case correctly; this suggestion is about retaining that guard.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved a4aaf5f after all three latest required contexts and their matching-head unit/lint/E2E workflows completed SUCCESS. This closes the CI-only blocker in review 5452590961. The preceding exact-head isolated verification remains: own frozen install; 613 related units /9 files (two existing expected failures); app/browser types, Cloud production build, changed lint/format and final knip PASS; two actual-production Vue/legacy browser cases PASS. Restoring the five preceding production files fails four focused units and both production browser cases; restoring the reviewed source passes. Index/order/report-budget mutations also fail and restore passes. The matching-name cardinality safety-net suggestion remains nonblocking. No local units/types/build/browser/mutations were rerun for this unchanged-head CI follow-up. Public PromotedHostWrite and the installed host applier were verified in the preceding review; no new HTTP response type or backend authority inference. Controlled auth/billing/Agent transport and NOT_RUN live Cloud/customer/accounts/payment/ingestion/inference/native/other-OS/broad-extension/full performance/a11y limits remain as documented.

@comfy-pr-bot
comfy-pr-bot merged commit 48bd7a0 into cloud/1.54 Oct 8, 2026
121 of 123 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-20377-to-cloud-1.54-manual branch October 8, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cloud/1.54 Backport PRs for cloud 1.54

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants