Repository navigation
[backport core/1.55] fix(agent): mint a promoted host write so prompt-node edits aren't rejected (#20377) - #20519
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2154 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0d0f9c1c323bfff42d0682e2dcc2ac958c21bcfe
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-08T06:26:24.745Z",
"gitSha": "132d80b0bae1763bb4788399e6d3a3c27c98a648",
"branch": "christian/backport-20377-core-1.55-manual",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.0850000000278,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.671000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.40100000000007,
"heapDeltaBytes": 4910800,
"heapUsedBytes": 74160920,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.303999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1995.5899999999929,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.491999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.143,
"heapDeltaBytes": 2005388,
"heapUsedBytes": 70279632,
"domNodes": -256,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.959999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.8910000000096,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.098,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 801.5459999999999,
"heapDeltaBytes": 7186964,
"heapUsedBytes": 76249048,
"domNodes": -246,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 161.62,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.0219999999963,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.006000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 794.19,
"heapDeltaBytes": 10407548,
"heapUsedBytes": 79221860,
"domNodes": -259,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 160.896,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.825000000014,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.622000000000002,
"layouts": 6,
"layoutDurationMs": 1.2750000000000001,
"taskDurationMs": 350.097,
"heapDeltaBytes": 3638804,
"heapUsedBytes": 72731828,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.125999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1732.0199999999204,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.199999999999998,
"layouts": 6,
"layoutDurationMs": 1.198,
"taskDurationMs": 345.236,
"heapDeltaBytes": 3338472,
"heapUsedBytes": 72134816,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.849999999999996,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 643.3729999999969,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.665999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.796,
"heapDeltaBytes": -7619816,
"heapUsedBytes": 61615740,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 168.357,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 617.917000000034,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.34,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.63399999999996,
"heapDeltaBytes": -7893832,
"heapUsedBytes": 61298592,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 165.316,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1167.09400000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 781.2239999999999,
"heapDeltaBytes": 38332872,
"heapUsedBytes": 105606584,
"domNodes": 0,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 72.68700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 562,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1206.860000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 884.177,
"heapDeltaBytes": 30288280,
"heapUsedBytes": 101765840,
"domNodes": -293,
"jsHeapTotalBytes": 17190912,
"scriptDurationMs": 68.62099999999998,
"eventListeners": -217,
"totalBlockingTimeMs": 591,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.9189999999617,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.25999999999976,
"heapDeltaBytes": 14423704,
"heapUsedBytes": 91469408,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.433,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.0100000000257,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.58399999999966,
"heapDeltaBytes": 14959132,
"heapUsedBytes": 90577824,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.86300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 235,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9835.417000000007,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.1439999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8949.849,
"heapDeltaBytes": -8113316,
"heapUsedBytes": 71004160,
"domNodes": -269,
"jsHeapTotalBytes": 2351104,
"scriptDurationMs": 7631.452,
"eventListeners": -174,
"totalBlockingTimeMs": 1270,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10580.727999999908,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9744.019000000002,
"heapDeltaBytes": -12095216,
"heapUsedBytes": 69077624,
"domNodes": -16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8170.738,
"eventListeners": 0,
"totalBlockingTimeMs": 1229,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10413.145999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9499.685,
"heapDeltaBytes": 4347720,
"heapUsedBytes": 83475524,
"domNodes": -265,
"jsHeapTotalBytes": 3399680,
"scriptDurationMs": 7956.783,
"eventListeners": -174,
"totalBlockingTimeMs": 1159,
"frameDurationMs": 19.99999999999994,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10449.921000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9540.254,
"heapDeltaBytes": 12801504,
"heapUsedBytes": 94250152,
"domNodes": -16,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8004.0459999999985,
"eventListeners": 0,
"totalBlockingTimeMs": 1011,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2025.400999999988,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.505999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.296,
"heapDeltaBytes": -16101424,
"heapUsedBytes": 73463080,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.931999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2027.789000000098,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.327,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.80799999999994,
"heapDeltaBytes": -16311752,
"heapUsedBytes": 73418084,
"domNodes": -241,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.616,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2276.597000000038,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.384000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1576.0559999999998,
"heapDeltaBytes": 716752,
"heapUsedBytes": 64948644,
"domNodes": -244,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 859.832,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2296.9880000000558,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.633000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1624.647,
"heapDeltaBytes": -2612724,
"heapUsedBytes": 88201828,
"domNodes": -256,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 877.726,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3529.6940000000063,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.218,
"layouts": 60,
"layoutDurationMs": 12.953000000000001,
"taskDurationMs": 1607.8239999999998,
"heapDeltaBytes": -630644,
"heapUsedBytes": 65529748,
"domNodes": 30,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 774.891,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3572.183999999993,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.238999999999997,
"layouts": 60,
"layoutDurationMs": 12.978,
"taskDurationMs": 1591.9500000000003,
"heapDeltaBytes": -572604,
"heapUsedBytes": 65519464,
"domNodes": 28,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 784.5629999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3169.590000000028,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.489000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1958.914,
"heapDeltaBytes": -18357920,
"heapUsedBytes": 75224872,
"domNodes": 12,
"jsHeapTotalBytes": 8118272,
"scriptDurationMs": 1052.242,
"eventListeners": 180,
"totalBlockingTimeMs": 23,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3102.0839999999907,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.502,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1906.6459999999997,
"heapDeltaBytes": -25234752,
"heapUsedBytes": 68337276,
"domNodes": -224,
"jsHeapTotalBytes": 2125824,
"scriptDurationMs": 1009.6559999999998,
"eventListeners": 28,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.7520000000168,
"styleRecalcs": 9,
"styleRecalcDurationMs": 13.294999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.1920000000001,
"heapDeltaBytes": -23470140,
"heapUsedBytes": 67791668,
"domNodes": -255,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 33.47300000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2029.8100000001114,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.546999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.988,
"heapDeltaBytes": -17256800,
"heapUsedBytes": 74064476,
"domNodes": -243,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 33.61299999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.4119999999539,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.545,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.118,
"heapDeltaBytes": 13186480,
"heapUsedBytes": 84307888,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 152.535,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.2590000000837,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.232000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.37500000000006,
"heapDeltaBytes": 12968772,
"heapUsedBytes": 84039580,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 148.77599999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2007.2640000000206,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.092,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.67400000000004,
"heapDeltaBytes": -6751208,
"heapUsedBytes": 64015596,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.514999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.9239999999127,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.208,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.506,
"heapDeltaBytes": 7517428,
"heapUsedBytes": 77478428,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.619999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.8509999999815,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.639,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 747.927,
"heapDeltaBytes": -4790772,
"heapUsedBytes": 59505920,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 108.13599999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.0289999999577,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.184999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 720.5970000000001,
"heapDeltaBytes": -7218016,
"heapUsedBytes": 57094816,
"domNodes": -275,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 102.21600000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.4939999999278,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.525000000000002,
"layouts": 5,
"layoutDurationMs": 13.546,
"taskDurationMs": 892.6889999999999,
"heapDeltaBytes": -4587492,
"heapUsedBytes": 85167480,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 30.81,
"eventListeners": 2383,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8331.342000000006,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.544,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5608.691000000001,
"heapDeltaBytes": 4043112,
"heapUsedBytes": 93268552,
"domNodes": -245,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 2907.23,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8207.209000000035,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.567,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4933.348,
"heapDeltaBytes": -23836720,
"heapUsedBytes": 65960256,
"domNodes": -243,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 2777.3510000000006,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17170.829000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16727.566,
"heapDeltaBytes": -37046288,
"heapUsedBytes": 191162232,
"domNodes": -8061,
"jsHeapTotalBytes": -18812928,
"scriptDurationMs": 272.305,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12706.305000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12082.654000000002,
"heapDeltaBytes": -40121860,
"heapUsedBytes": 195643468,
"domNodes": -8061,
"jsHeapTotalBytes": -9560064,
"scriptDurationMs": 211.11900000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20948.289999999928,
"styleRecalcs": 165,
"styleRecalcDurationMs": 17.85199999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20690.267,
"heapDeltaBytes": -63539972,
"heapUsedBytes": 170631168,
"domNodes": -8061,
"jsHeapTotalBytes": -11546624,
"scriptDurationMs": 892.061,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20520.932000000015,
"styleRecalcs": 162,
"styleRecalcDurationMs": 17.427,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20262.463,
"heapDeltaBytes": -64320492,
"heapUsedBytes": 170384776,
"domNodes": -8061,
"jsHeapTotalBytes": -10760192,
"scriptDurationMs": 900.548,
"eventListeners": -14928,
"totalBlockingTimeMs": 44,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6196.270000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.79299999999998,
"layouts": 20,
"layoutDurationMs": 25.15300000000001,
"taskDurationMs": 6117.64,
"heapDeltaBytes": -37190744,
"heapUsedBytes": 184509668,
"domNodes": -8061,
"jsHeapTotalBytes": 12382208,
"scriptDurationMs": 108.279,
"eventListeners": -14928,
"totalBlockingTimeMs": 507,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6031.3449999999875,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.06499999999997,
"layouts": 20,
"layoutDurationMs": 24.183999999999997,
"taskDurationMs": 5960.179999999999,
"heapDeltaBytes": -58884404,
"heapUsedBytes": 181935220,
"domNodes": -8061,
"jsHeapTotalBytes": 11595776,
"scriptDurationMs": 106.35499999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 519,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6400.556000000051,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6163.289000000001,
"heapDeltaBytes": -7894556,
"heapUsedBytes": 176943200,
"domNodes": 0,
"jsHeapTotalBytes": -23068672,
"scriptDurationMs": 99.937,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8445.03599999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8233.782000000001,
"heapDeltaBytes": -11850900,
"heapUsedBytes": 189506872,
"domNodes": 0,
"jsHeapTotalBytes": -29360128,
"scriptDurationMs": 130.34199999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 476.0280000000421,
"styleRecalcs": 21,
"styleRecalcDurationMs": 26.958,
"layouts": 5,
"layoutDurationMs": 2.4749999999999996,
"taskDurationMs": 145.74099999999999,
"heapDeltaBytes": 5292032,
"heapUsedBytes": 72177812,
"domNodes": 153,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.668999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 115.97499999993488,
"styleRecalcs": 9,
"styleRecalcDurationMs": 19.868,
"layouts": 3,
"layoutDurationMs": 1.684,
"taskDurationMs": 80.77499999999999,
"heapDeltaBytes": 3018556,
"heapUsedBytes": 69887892,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.0859999999999985,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.55 #20519 +/- ##
==========================================
Coverage 84.92% 84.93%
==========================================
Files 2347 2347
Lines 134014 134091 +77
Branches 35797 35836 +39
==========================================
+ Hits 113816 113890 +74
- Misses 19833 19836 +3
Partials 365 365
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Verified this core/1.55 adaptation against its exact head and target branch. Root promoted widgets use the public PromotedHostWrite contract; nested/interior routing retains the release branch path. No duplicated HTTP response type or inferred server authorization/billing state is introduced.
Own PASS: frozen install in the isolated checkout; 491 related unit/component tests across 5 files; app/browser types, OSS and Cloud production builds, changed-file type-aware oxlint/ESLint/format and Knip. Actual Cloud production plus isolated local ComfyUI backend: Vue and legacy prompt editing both reach the real shared host applier, preserve multiline Unicode text and sibling seed, accept a later remote seed=42, and serialize correctly (2 browser cases). Legacy seed editing uses the real widget setter/callback; it is not a numeric-keyboard UI claim.
Pre-patch minter restoration gives 6 FAIL/32 PASS in the committed minter suite and 2 browser FAIL (host prompt unchanged); original source/output restoration gives 38 unit PASS and 2 browser PASS. Index/order mutations give 2/38 and 4/38 FAIL. Independent count and lifetime-reporting guards pass 40/40, fail 1/40 under each respective mutation, then pass 40/40 after restoration. Original committed suite restoration passes 38/38. The lifetime mutation still passes the original 38 tests, so it is not claimed as committed regression coverage; the inline suggestions below are non-blocking guard improvements.
Latest required unit/lint/E2E are SUCCESS and matching exact-SHA workflows completed SUCCESS. Controlled auth/billing/Agent transport and a real shared local applier are not live Cloud/customer proof. Live accounts/payment/inference/ingestion/native Desktop/other OS/broad extensions/full performance/accessibility NOT_RUN (layout unchanged, no performance improvement claimed). All temporary tests/source and production output restored; checkout clean.
|
|
||
| it.for([ | ||
| { | ||
| name: 'has a different widget count', |
There was a problem hiding this comment.
[P3] Vary cardinality independently from the promoted names
The current different-count row also changes promotedNames, so the names check still rejects it if the valueCount guard is removed. An independent case with valueCount=3 and promotedNames=['prefix','text'] fails under that count mutation while all committed cases remain green. Consider adding it so this safety condition has its own regression guard.
| docDeclaredNames: doc.declaredNames, | ||
| docPromotedNames: doc.promotedNames | ||
| }, | ||
| reportedDrift |
There was a problem hiding this comment.
[P3] Cover the lifetime reporting budget across a normal flush
Changing this budget back to the per-flush reported set still passes the committed minter suite. An independent sequence of drifted host write → ordinary widget write/flush → another drifted host write reports once on this head and twice with that mutation. Consider retaining that regression case to protect the lifetime budget.
Summary
Backports #20377 so edits to promoted prompt widgets mint the positional host payload accepted by the Agent CRDT document.
Changes
Review Focus
Please verify the core-specific
mintSetWidgetreconciliation: root subgraph hosts receive the promoted payload, nested hosts retain the interior path, and drifted layouts are dropped without poisoning sibling operations.Validation
No feature-flag, exposure, dependency, or user-facing copy changes.