Skip to content

[backport cloud/1.54] fix(agent): report upload failure cause, file type and size for attachment telemetry - #20503

Merged
comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-20405-to-cloud-1.54
Oct 8, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-20405-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backports #20405 after the media-diagnostics prerequisite landed, adding bounded attachment failure cause, MIME type, and size telemetry without changing upload behavior.

Changes

Review Focus

Verify the new telemetry remains privacy-bounded and preserves the existing upload lifecycle.

Parent: #20405

…hment telemetry (#20405)

- The agent composer's attachment upload has two error paths (direct
upload, deferred drag/paste fetch) that each used a bare `catch {}`,
discarding the real thrown error before reporting a synthetic,
context-free `Error('Agent attachment upload failed')`.
- That's why the Sentry alert for PM-1997 carries zero diagnostic detail
— no HTTP status, failure shape, file type, or size — nothing to
distinguish a size rejection from an auth refusal from a transport
failure.
- This PR binds the caught error, classifies it into a bounded
`upload_failure_cause` tag (`http_<status>`, `unreadable_response`,
`timeout`, `aborted`, `unknown`), and adds `file_type`/`file_size_bytes`
tags to the existing `reportError()` call.
- The original error's message/stack are still never reported (an
existing test guards against a dropped file's local path leaking into
telemetry) — only the file's own declared, bounded metadata and a
closed-set failure-shape tag are added.

PM-1997 is a one-line Sentry relay from `cloud-frontend-prod` with no
repro steps, file name, MIME type, size, or HTTP status — nothing to
build a targeted fix from. Per the project's standing telemetry-first
triage pattern (see PM-1802 / #20046), this PR adds the missing
structured context at the failure site instead of guessing at a fix, so
the alert is actionable once fresh occurrences land.

- [x] Added test cases asserting `upload_failure_cause` resolves
correctly for `AgentApiError` (HTTP status),
`AgentResponseUnreadableError`, a timeout, and an unrecognized error
shape.
- [x] Updated the existing privacy-preserving test (reported error must
never leak a dropped file's local path) to assert the new bounded tags
are present.
- [x] `pnpm vitest run
src/workbench/extensions/agent/composables/agent/` — 401/401 passing, no
regressions.
- [x] `pnpm typecheck:app` — clean.
- [x] `eslint` / `oxlint` on changed files — clean.

Linear: PM-1997
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Oct 8, 2026
@vercel

vercel Bot commented Oct 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 8, 2026 1:49am UTC
billing-web-test Ignored Ignored Oct 8, 2026 1:49am UTC

Request Review

@christian-byrne
christian-byrne enabled auto-merge (squash) October 8, 2026 01:49
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: c1693312-ba3e-4c3b-9485-6c56e788c285

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1991 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1970 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/08/2026, 01:51:39 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 16ms TBT · 72.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 146ms TBT · 105.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.4 MB heap
vue-large-graph-idle: · 54.6 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.7 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 82ms TBT · 167.2 MB heap
vue-node-resize-workload: · 54.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 446ms TBT · 172.6 MB heap
vue-zoom-out-idle: · 54.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 12ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 620ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 73.4 MB
canvas-idle: DOM nodes -277
canvas-idle: event listeners -181
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 33ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 961ms
canvas-mouse-sweep: script duration 172ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.1 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -194
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 405ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 74.9 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 471ms
dom-widget-clipping: script duration 167ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 63.6 MB
dom-widget-clipping: DOM nodes 16
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 3
large-graph-idle: task duration 563ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 73.6 MB
large-graph-idle: DOM nodes -273
large-graph-idle: event listeners -162
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1633ms
large-graph-pan: script duration 834ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 75.1 MB
large-graph-pan: DOM nodes -141
large-graph-pan: event listeners -93
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 69
large-graph-zoom: task duration 1739ms
large-graph-zoom: script duration 810ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 84.4 MB
large-graph-zoom: DOM nodes -99
large-graph-zoom: event listeners -91
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1986ms
legacy-node-drag: script duration 1034ms
legacy-node-drag: TBT 16ms
legacy-node-drag: heap used 72.3 MB
legacy-node-drag: DOM nodes 2
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 625ms
minimap-idle: script duration 37ms
minimap-idle: TBT 0ms
minimap-idle: heap used 70.7 MB
minimap-idle: DOM nodes -280
minimap-idle: event listeners -192
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 420ms
subgraph-dom-widget-clipping: script duration 143ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 74.0 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 563ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.3 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -240
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 863ms
subgraph-mouse-sweep: script duration 117ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 68.8 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -242
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 1015ms
subgraph-transition-enter: script duration 34ms
subgraph-transition-enter: TBT 146ms
subgraph-transition-enter: heap used 105.8 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5750ms
viewport-pan-sweep: script duration 2735ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 79.4 MB
viewport-pan-sweep: DOM nodes -277
viewport-pan-sweep: event listeners -162
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16958ms
vue-large-graph-idle: script duration 297ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.7 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 163
vue-large-graph-pan: task duration 20878ms
vue-large-graph-pan: script duration 925ms
vue-large-graph-pan: TBT 82ms
vue-large-graph-pan: heap used 167.2 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14925
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 81ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6213ms
vue-node-resize-workload: script duration 110ms
vue-node-resize-workload: TBT 446ms
vue-node-resize-workload: heap used 172.6 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8549ms
vue-zoom-out-idle: script duration 150ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 171.0 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 4
workflow-execution: style recalc count 16
workflow-execution: task duration 124ms
workflow-execution: script duration 12ms
workflow-execution: TBT 0ms
workflow-execution: heap used 72.0 MB
workflow-execution: DOM nodes 131
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-10-08T02:01:03.166Z",
  "gitSha": "afed3a863ca848aea5f6e94a4c103a43c86f9762",
  "branch": "backport-20405-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2126.7839999999865,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 13.736000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 669.983,
      "heapDeltaBytes": 7268000,
      "heapUsedBytes": 79024696,
      "domNodes": -273,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 11.41,
      "eventListeners": -168,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2045.8130000000665,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 10.077,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 569.5939999999999,
      "heapDeltaBytes": 642424,
      "heapUsedBytes": 74903824,
      "domNodes": -281,
      "jsHeapTotalBytes": 4227072,
      "scriptDurationMs": 11.428,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2024.5649999999955,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 31.214,
      "layouts": 14,
      "layoutDurationMs": 4.267999999999999,
      "taskDurationMs": 983.1220000000001,
      "heapDeltaBytes": -3239564,
      "heapUsedBytes": 70052700,
      "domNodes": -280,
      "jsHeapTotalBytes": 5275648,
      "scriptDurationMs": 174.07699999999997,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1906.9909999999481,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 34.103,
      "layouts": 14,
      "layoutDurationMs": 4.269,
      "taskDurationMs": 938.03,
      "heapDeltaBytes": -2628772,
      "heapUsedBytes": 70680196,
      "domNodes": -282,
      "jsHeapTotalBytes": 4227072,
      "scriptDurationMs": 169.478,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1740.5050000000415,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.933,
      "layouts": 6,
      "layoutDurationMs": 0.985,
      "taskDurationMs": 408.477,
      "heapDeltaBytes": 4944252,
      "heapUsedBytes": 78709152,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 13.986000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.6990000000578,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.59,
      "layouts": 6,
      "layoutDurationMs": 1.1440000000000001,
      "taskDurationMs": 401.792,
      "heapDeltaBytes": 4584760,
      "heapUsedBytes": 78356700,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 13.169999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 674.4099999999662,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.757,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 467.00399999999996,
      "heapDeltaBytes": -6935504,
      "heapUsedBytes": 66902188,
      "domNodes": 16,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 168.387,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 706.5309999999272,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.491,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.388,
      "heapDeltaBytes": -6859264,
      "heapUsedBytes": 66566628,
      "domNodes": 16,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 165.64900000000003,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.3630000000371,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.260000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 576.776,
      "heapDeltaBytes": -3853908,
      "heapUsedBytes": 76828384,
      "domNodes": -271,
      "jsHeapTotalBytes": -1802240,
      "scriptDurationMs": 35.899,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2022.5550000000112,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.9910000000000032,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 549.1279999999999,
      "heapDeltaBytes": 11876104,
      "heapUsedBytes": 77479524,
      "domNodes": -275,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 36.852000000000004,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2185.6819999999857,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.813,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1563.894,
      "heapDeltaBytes": 1341868,
      "heapUsedBytes": 67518764,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 800.178,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2393.0520000000115,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.562999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1702.9840000000004,
      "heapDeltaBytes": 9497812,
      "heapUsedBytes": 89873800,
      "domNodes": -283,
      "jsHeapTotalBytes": 258048,
      "scriptDurationMs": 867.8359999999999,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3596.473000000003,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.846,
      "layouts": 60,
      "layoutDurationMs": 12.393999999999998,
      "taskDurationMs": 1706.875,
      "heapDeltaBytes": 4387236,
      "heapUsedBytes": 84804248,
      "domNodes": 30,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 809.6170000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3569.0160000000333,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.883000000000001,
      "layouts": 60,
      "layoutDurationMs": 11.751000000000001,
      "taskDurationMs": 1771.1280000000002,
      "heapDeltaBytes": 9517112,
      "heapUsedBytes": 92191572,
      "domNodes": -228,
      "jsHeapTotalBytes": -753664,
      "scriptDurationMs": 810.894,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3163.5050000000433,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.850999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2030.0620000000001,
      "heapDeltaBytes": -6113888,
      "heapUsedBytes": 75801152,
      "domNodes": 2,
      "jsHeapTotalBytes": 6410240,
      "scriptDurationMs": 1068.6180000000002,
      "eventListeners": 188,
      "totalBlockingTimeMs": 31,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3117.8659999999354,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.690999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1941.701,
      "heapDeltaBytes": 8629056,
      "heapUsedBytes": 75797932,
      "domNodes": 2,
      "jsHeapTotalBytes": 716800,
      "scriptDurationMs": 999.299,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2050.837999999999,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 7.533999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 627.51,
      "heapDeltaBytes": -6446280,
      "heapUsedBytes": 75810808,
      "domNodes": -273,
      "jsHeapTotalBytes": -1540096,
      "scriptDurationMs": 38.757000000000005,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2076.9090000000006,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.768999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 622.2129999999999,
      "heapDeltaBytes": -7326536,
      "heapUsedBytes": 72452504,
      "domNodes": -286,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 35.205,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 607.3590000000308,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 11.793000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 422.925,
      "heapDeltaBytes": -10531824,
      "heapUsedBytes": 65550888,
      "domNodes": 22,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 141.30800000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 581.0800000000427,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.081000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 417.459,
      "heapDeltaBytes": 14375092,
      "heapUsedBytes": 89666624,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 144.333,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2023.804000000041,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.755000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 546.061,
      "heapDeltaBytes": -8071544,
      "heapUsedBytes": 65259076,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 10.427000000000001,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2055.2449999999,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 11.024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 580.052,
      "heapDeltaBytes": 1946320,
      "heapUsedBytes": 77950924,
      "domNodes": -295,
      "jsHeapTotalBytes": 4751360,
      "scriptDurationMs": 10.397,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.0890000000159,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 30.26,
      "layouts": 18,
      "layoutDurationMs": 5.205,
      "taskDurationMs": 872.0860000000001,
      "heapDeltaBytes": -4117456,
      "heapUsedBytes": 69255888,
      "domNodes": -294,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 119.69599999999998,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1750.996999999984,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.775000000000002,
      "layouts": 18,
      "layoutDurationMs": 4.655,
      "taskDurationMs": 852.9419999999999,
      "heapDeltaBytes": -1078196,
      "heapUsedBytes": 74955940,
      "domNodes": -297,
      "jsHeapTotalBytes": 4751360,
      "scriptDurationMs": 113.39399999999998,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.2399999999925,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 33.775,
      "layouts": 16,
      "layoutDurationMs": 16.182000000000002,
      "taskDurationMs": 1014.751,
      "heapDeltaBytes": 21484940,
      "heapUsedBytes": 110939040,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 33.931,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 146,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8355.362000000014,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 37.987,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5796.234,
      "heapDeltaBytes": -9395112,
      "heapUsedBytes": 68289504,
      "domNodes": -284,
      "jsHeapTotalBytes": 3039232,
      "scriptDurationMs": 2743.857,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8354.552000000012,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 34.831,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5703.014999999999,
      "heapDeltaBytes": 18062800,
      "heapUsedBytes": 98211260,
      "domNodes": -270,
      "jsHeapTotalBytes": -1052672,
      "scriptDurationMs": 2727.057,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17800.724000000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16995.166,
      "heapDeltaBytes": -48171812,
      "heapUsedBytes": 179167260,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17174528,
      "scriptDurationMs": 287.48600000000005,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.886666666666738,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17843.25100000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16921.221,
      "heapDeltaBytes": -48887264,
      "heapUsedBytes": 178875288,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12333056,
      "scriptDurationMs": 306.13599999999997,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21017.54699999998,
      "styleRecalcs": 164,
      "styleRecalcDurationMs": 19.400000000000027,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20761.454,
      "heapDeltaBytes": -39478224,
      "heapUsedBytes": 166478512,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12857344,
      "scriptDurationMs": 938.4940000000001,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 138,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21282.33499999999,
      "styleRecalcs": 162,
      "styleRecalcDurationMs": 18.459999999999976,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20994.033000000003,
      "heapDeltaBytes": -22792844,
      "heapUsedBytes": 184266104,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13381632,
      "scriptDurationMs": 912.4839999999998,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 26,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6290.8069999999725,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 84.09400000000001,
      "layouts": 20,
      "layoutDurationMs": 24.955999999999992,
      "taskDurationMs": 6230.17,
      "heapDeltaBytes": -48621004,
      "heapUsedBytes": 177285800,
      "domNodes": -8068,
      "jsHeapTotalBytes": 13127680,
      "scriptDurationMs": 110.35099999999998,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 468,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6305.311999999958,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.928,
      "layouts": 20,
      "layoutDurationMs": 23.20299999999999,
      "taskDurationMs": 6195.589999999999,
      "heapDeltaBytes": -41270904,
      "heapUsedBytes": 184626220,
      "domNodes": -8068,
      "jsHeapTotalBytes": 15192064,
      "scriptDurationMs": 110.20299999999999,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 423,
      "frameDurationMs": 18.890000000000025,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8815.799999999967,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8503.464999999998,
      "heapDeltaBytes": -8845808,
      "heapUsedBytes": 179262880,
      "domNodes": 0,
      "jsHeapTotalBytes": -13893632,
      "scriptDurationMs": 153.887,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9033.510999999977,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8594.078,
      "heapDeltaBytes": 8940320,
      "heapUsedBytes": 179444092,
      "domNodes": 0,
      "jsHeapTotalBytes": -9175040,
      "scriptDurationMs": 146.123,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.890000000000025,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 509.9359999999251,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 24.214,
      "layouts": 5,
      "layoutDurationMs": 2.484,
      "taskDurationMs": 135.885,
      "heapDeltaBytes": 5175136,
      "heapUsedBytes": 74157544,
      "domNodes": 145,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 14.635,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 492.57599999998547,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 17.476,
      "layouts": 3,
      "layoutDurationMs": 0.7630000000000002,
      "taskDurationMs": 112.451,
      "heapDeltaBytes": 4881072,
      "heapUsedBytes": 76842928,
      "domNodes": 117,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.252,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51187 76668 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #20503   +/-   ##
=============================================
  Coverage              ?   84.19%           
=============================================
  Files                 ?     2133           
  Lines                 ?   128681           
  Branches              ?    32781           
=============================================
  Hits                  ?   108346           
  Misses                ?    20154           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.77% <ø> (?)
unit 79.66% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...xtensions/agent/composables/agent/useAttachment.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Own exact-head frozen install and actual cloud/1.54 source/callers review completed. 504 PASS/5 files, plus 2 independent real Agent REST→reportError→Sentry normalization checks PASS: HTTP 503 bounded tags with no private path in the event, a successful sibling retained, and an abort-responsive transport deadline classified as timeout. Transport/SDK endpoints are controlled. The Cloud target has no legacy failure_reason tag; its prior return/cancellation policy remains intact. I did not import the different core contract into this backport.

Restoring only the previous production attachment function produces 10 FAIL/21 PASS; MIME privacy, deadline identity and HTTP cause mutations each produce 1 FAIL/30 PASS; exact source restored 31 PASS. App types, respective OSS/Cloud production build, changed type-aware oxlint/production ESLint/format/knip and final types/knip PASS. The first core build command named a script absent from 1.54 (NOT_RUN), then the actual pnpm build completed. Initial SDK harness failures assumed the wrong release return value/tag and left fake timer work outstanding; the corrected release-aware real-timer harness passes both cases. No product defect is asserted from those setup attempts.

Generated shared UploadImageResponse/zod response remains authoritative. These new fields describe bounded local failure context; no server ownership/billing state is inferred. No API, layout, upload mechanics or extension callbacks change. New product browser, live original PM1997 incident/account/ingestion/payment, other OS and unrelated full/performance/a11y checks NOT_RUN: telemetry-only, with the actual request boundary/SDK/lifecycle tested directly. Current required3 SUCCESS and each matching-head workflow completed SUCCESS checked separately. Three PR files byte-exact, checkout clean, all temporary mutations/tests restored.

@comfy-pr-bot
comfy-pr-bot merged commit 07d820e into cloud/1.54 Oct 8, 2026
106 of 109 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-20405-to-cloud-1.54 branch October 8, 2026 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants