Repository navigation
[backport core/1.54] fix(agent): report upload failure cause, file type and size for attachment telemetry - #20502
Conversation
…hment telemetry (#20405) - The agent composer's attachment upload has two error paths (direct upload, deferred drag/paste fetch) that each used a bare `catch {}`, discarding the real thrown error before reporting a synthetic, context-free `Error('Agent attachment upload failed')`. - That's why the Sentry alert for PM-1997 carries zero diagnostic detail — no HTTP status, failure shape, file type, or size — nothing to distinguish a size rejection from an auth refusal from a transport failure. - This PR binds the caught error, classifies it into a bounded `upload_failure_cause` tag (`http_<status>`, `unreadable_response`, `timeout`, `aborted`, `unknown`), and adds `file_type`/`file_size_bytes` tags to the existing `reportError()` call. - The original error's message/stack are still never reported (an existing test guards against a dropped file's local path leaking into telemetry) — only the file's own declared, bounded metadata and a closed-set failure-shape tag are added. PM-1997 is a one-line Sentry relay from `cloud-frontend-prod` with no repro steps, file name, MIME type, size, or HTTP status — nothing to build a targeted fix from. Per the project's standing telemetry-first triage pattern (see PM-1802 / #20046), this PR adds the missing structured context at the failure site instead of guessing at a fix, so the alert is actionable once fresh occurrences land. - [x] Added test cases asserting `upload_failure_cause` resolves correctly for `AgentApiError` (HTTP status), `AgentResponseUnreadableError`, a timeout, and an unrecognized error shape. - [x] Updated the existing privacy-preserving test (reported error must never leak a dropped file's local path) to assert the new bounded tags are present. - [x] `pnpm vitest run src/workbench/extensions/agent/composables/agent/` — 401/401 passing, no regressions. - [x] `pnpm typecheck:app` — clean. - [x] `eslint` / `oxlint` on changed files — clean. Linear: PM-1997
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1983 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-08T02:00:46.711Z",
"gitSha": "57316829a98c96c5a74c7b452034d562f3ebfb6a",
"branch": "backport-20405-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2053.814999999986,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.039,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.329,
"heapDeltaBytes": 3779736,
"heapUsedBytes": 77005040,
"domNodes": -281,
"jsHeapTotalBytes": 3964928,
"scriptDurationMs": 10.357999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2054.3119999999817,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.504999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.646,
"heapDeltaBytes": -10392888,
"heapUsedBytes": 60611028,
"domNodes": -283,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.526000000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1940.1409999999828,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.132,
"layouts": 14,
"layoutDurationMs": 4.095,
"taskDurationMs": 950.305,
"heapDeltaBytes": 8353536,
"heapUsedBytes": 79832076,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 152.231,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1843.4540000000652,
"styleRecalcs": 75,
"styleRecalcDurationMs": 26.089,
"layouts": 14,
"layoutDurationMs": 4.185,
"taskDurationMs": 816.062,
"heapDeltaBytes": -2061616,
"heapUsedBytes": 69276700,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 135.143,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.9790000000094,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.279,
"layouts": 6,
"layoutDurationMs": 1.016,
"taskDurationMs": 332.778,
"heapDeltaBytes": 4657976,
"heapUsedBytes": 78077988,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.737,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1742.572999999993,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.354999999999999,
"layouts": 6,
"layoutDurationMs": 0.992,
"taskDurationMs": 339.395,
"heapDeltaBytes": 4234424,
"heapUsedBytes": 75859264,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.308,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 628.1309999999962,
"styleRecalcs": 14,
"styleRecalcDurationMs": 7.1709999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.128,
"heapDeltaBytes": 18498036,
"heapUsedBytes": 88910924,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 140.709,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 625.2429999999549,
"styleRecalcs": 13,
"styleRecalcDurationMs": 12.622000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.25700000000006,
"heapDeltaBytes": -8271352,
"heapUsedBytes": 63614084,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 142.864,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2022.1969999999487,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.7920000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.69,
"heapDeltaBytes": -9403324,
"heapUsedBytes": 70042556,
"domNodes": -283,
"jsHeapTotalBytes": -1015808,
"scriptDurationMs": 31.538999999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2021.6300000000729,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.436,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.568,
"heapDeltaBytes": 12786156,
"heapUsedBytes": 90550156,
"domNodes": -281,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 34.23400000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2166.8769999999995,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.805,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1426.1619999999998,
"heapDeltaBytes": -11098324,
"heapUsedBytes": 66886784,
"domNodes": -273,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 699.0959999999999,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2210.519999999974,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.342,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1424.6270000000002,
"heapDeltaBytes": 10494376,
"heapUsedBytes": 88807432,
"domNodes": -281,
"jsHeapTotalBytes": 1167360,
"scriptDurationMs": 691.9839999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3429.5169999999757,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.607,
"layouts": 60,
"layoutDurationMs": 13.044,
"taskDurationMs": 1485.792,
"heapDeltaBytes": -356648,
"heapUsedBytes": 67385864,
"domNodes": 26,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 663.1479999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3388.682000000017,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.625,
"layouts": 60,
"layoutDurationMs": 12.669,
"taskDurationMs": 1516.674,
"heapDeltaBytes": 11881676,
"heapUsedBytes": 91975900,
"domNodes": -227,
"jsHeapTotalBytes": -106496,
"scriptDurationMs": 660.344,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2895.656000000031,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.919000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1698.4360000000001,
"heapDeltaBytes": 7424024,
"heapUsedBytes": 89970128,
"domNodes": 8,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 836.392,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2669.787999999926,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.757999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1619.0730000000003,
"heapDeltaBytes": 10237096,
"heapUsedBytes": 80196208,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 811.186,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2014.2290000000003,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.383,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.1850000000001,
"heapDeltaBytes": 10445016,
"heapUsedBytes": 89824224,
"domNodes": -286,
"jsHeapTotalBytes": -630784,
"scriptDurationMs": 31.629000000000005,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2030.3820000000314,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.1979999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.977,
"heapDeltaBytes": -9219604,
"heapUsedBytes": 70767268,
"domNodes": -283,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 32.059,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 563.857999999982,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.3,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.524,
"heapDeltaBytes": 14808280,
"heapUsedBytes": 88482100,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 127.30900000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.2030000000113,
"styleRecalcs": 49,
"styleRecalcDurationMs": 13.722999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.084,
"heapDeltaBytes": 14435108,
"heapUsedBytes": 89951264,
"domNodes": 24,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 130.902,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.3480000000027,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.576,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.33000000000004,
"heapDeltaBytes": -11985464,
"heapUsedBytes": 60986480,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.540000000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2018.3230000000094,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.598000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.4549999999999,
"heapDeltaBytes": -9986172,
"heapUsedBytes": 62912796,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.292,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.9240000000113,
"styleRecalcs": 78,
"styleRecalcDurationMs": 26.840000000000003,
"layouts": 18,
"layoutDurationMs": 4.35,
"taskDurationMs": 780.146,
"heapDeltaBytes": -12195824,
"heapUsedBytes": 60176692,
"domNodes": -293,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 94.33800000000001,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.135999999944,
"styleRecalcs": 77,
"styleRecalcDurationMs": 22.942,
"layouts": 18,
"layoutDurationMs": 4.283,
"taskDurationMs": 738.466,
"heapDeltaBytes": -11980072,
"heapUsedBytes": 61507900,
"domNodes": -298,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 93.482,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1000.0450000000001,
"styleRecalcs": 21,
"styleRecalcDurationMs": 27.404000000000003,
"layouts": 17,
"layoutDurationMs": 12.15,
"taskDurationMs": 813.6750000000002,
"heapDeltaBytes": -6858344,
"heapUsedBytes": 84396652,
"domNodes": 13831,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 25.387,
"eventListeners": 2385,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8191.640000000007,
"styleRecalcs": 250,
"styleRecalcDurationMs": 41.109,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4973.415,
"heapDeltaBytes": 11470328,
"heapUsedBytes": 88933824,
"domNodes": -277,
"jsHeapTotalBytes": 905216,
"scriptDurationMs": 2321.1690000000003,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8173.4050000000025,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.04200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4860.682,
"heapDeltaBytes": 1791104,
"heapUsedBytes": 67378856,
"domNodes": -269,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 2286.297,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14630.394999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13957.79,
"heapDeltaBytes": -40863220,
"heapUsedBytes": 177587000,
"domNodes": -8068,
"jsHeapTotalBytes": -16261120,
"scriptDurationMs": 231.31400000000002,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 14441.492999999922,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13438.241999999998,
"heapDeltaBytes": -40375244,
"heapUsedBytes": 177975500,
"domNodes": -8068,
"jsHeapTotalBytes": -12595200,
"scriptDurationMs": 224.38599999999997,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17248.35799999994,
"styleRecalcs": 140,
"styleRecalcDurationMs": 17.53599999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16792.577999999998,
"heapDeltaBytes": -53181132,
"heapUsedBytes": 169451084,
"domNodes": -8068,
"jsHeapTotalBytes": -15998976,
"scriptDurationMs": 836.385,
"eventListeners": -14927,
"totalBlockingTimeMs": 14,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17410.92499999991,
"styleRecalcs": 148,
"styleRecalcDurationMs": 18.305000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16926.729,
"heapDeltaBytes": -32922564,
"heapUsedBytes": 189552900,
"domNodes": -8067,
"jsHeapTotalBytes": -17641472,
"scriptDurationMs": 844.7289999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 14,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5239.3520000000535,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.43199999999999,
"layouts": 20,
"layoutDurationMs": 23.41299999999999,
"taskDurationMs": 5123.451999999999,
"heapDeltaBytes": -40429072,
"heapUsedBytes": 178174872,
"domNodes": -8068,
"jsHeapTotalBytes": 12046336,
"scriptDurationMs": 108.99000000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 162,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5040.144000000055,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.49700000000001,
"layouts": 20,
"layoutDurationMs": 29.948000000000004,
"taskDurationMs": 4869.886,
"heapDeltaBytes": -43488972,
"heapUsedBytes": 176723340,
"domNodes": -8068,
"jsHeapTotalBytes": 8593408,
"scriptDurationMs": 88.88499999999999,
"eventListeners": -14933,
"totalBlockingTimeMs": 129,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7233.631000000059,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6878.97,
"heapDeltaBytes": 5518952,
"heapUsedBytes": 184124812,
"domNodes": 0,
"jsHeapTotalBytes": -14942208,
"scriptDurationMs": 115.57600000000001,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7201.971000000071,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6718.6770000000015,
"heapDeltaBytes": 13259328,
"heapUsedBytes": 177687948,
"domNodes": 0,
"jsHeapTotalBytes": -28049408,
"scriptDurationMs": 120.396,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 453.2919999999194,
"styleRecalcs": 18,
"styleRecalcDurationMs": 18.381,
"layouts": 2,
"layoutDurationMs": 1.0320000000000003,
"taskDurationMs": 103.95500000000001,
"heapDeltaBytes": 4981772,
"heapUsedBytes": 74456276,
"domNodes": 147,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.802,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 447.7200000000039,
"styleRecalcs": 13,
"styleRecalcDurationMs": 15.110999999999999,
"layouts": 2,
"layoutDurationMs": 0.4729999999999999,
"taskDurationMs": 95.372,
"heapDeltaBytes": 4758044,
"heapUsedBytes": 74280168,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.866,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #20502 +/- ##
=============================================
- Coverage 84.33% 84.33% -0.01%
=============================================
Files 2126 2126
Lines 127812 127826 +14
Branches 32579 32586 +7
=============================================
+ Hits 107785 107796 +11
- Misses 19839 19842 +3
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Own exact-head frozen install and actual core/1.54 source/callers review completed. 376 PASS/5 files, plus 2 independent real Agent REST→reportError→Sentry normalization checks PASS: HTTP 503 bounded tags with no private path in the event, a successful sibling retained, and an abort-responsive transport deadline classified as timeout. Transport/SDK endpoints are controlled. The existing core failure_reason/cancellation/batch-limit policy remains intact and is asserted through the real SDK (transport and timeout).
Restoring only the previous production attachment function produces 10 FAIL/28 PASS; MIME privacy, deadline identity and HTTP cause mutations each produce 1 FAIL/37 PASS; exact source restored 38 PASS. App types, respective OSS/Cloud production build, changed type-aware oxlint/production ESLint/format/knip and final types/knip PASS. The first core build command named a script absent from 1.54 (NOT_RUN), then the actual pnpm build completed. Initial SDK harness failures assumed the wrong release return value/tag and left fake timer work outstanding; the corrected release-aware real-timer harness passes both cases. No product defect is asserted from those setup attempts.
Generated shared UploadImageResponse/zod response remains authoritative. These new fields describe bounded local failure context; no server ownership/billing state is inferred. No API, layout, upload mechanics or extension callbacks change. New product browser, live original PM1997 incident/account/ingestion/payment, other OS and unrelated full/performance/a11y checks NOT_RUN: telemetry-only, with the actual request boundary/SDK/lifecycle tested directly. Current required3 SUCCESS and each matching-head workflow completed SUCCESS checked separately. Three PR files byte-exact, checkout clean, all temporary mutations/tests restored.
Summary
Backports #20405 after the media-diagnostics prerequisite landed, preserving the core/1.54 cancellation, batch-limit, and
failure_reasoncontracts while adding bounded attachment failure cause, MIME type, and size telemetry.Changes
Review Focus
Verify that the legacy
failure_reasontag and cancellation paths remain intact alongside the new privacy-bounded tags.Parent: #20405