Repository navigation
Template model requirements (FE-1491): cover the desktop input-asset path in a browser - #20496
Conversation
📦 Bundle: 9.4 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 5.3 kB (baseline 5.3 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.15 MB (baseline 2.15 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 669 kB (baseline 669 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 29 unchanged User & Accounts — 61.1 kB (baseline 61.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 15 unchanged Editors & Dialogs — 340 kB (baseline 340 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 12 unchanged UI Components — 211 kB (baseline 211 kB) • ⚪ 0 BReusable component library chunks Status: 24 unchanged Data & Services — 1.36 MB (baseline 1.36 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 24 unchanged Utilities & Hooks — 2.29 MB (baseline 2.29 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 62 unchanged Vendor & Third-Party — 14.3 MB (baseline 14.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 19 MB (baseline 19 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 350 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-11T17:26:35.148Z",
"gitSha": "7fae6e9dccf671de019ad441e4c47677f9e61b12",
"branch": "jaeone/fe-1491-desktop-template-e2e",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.2700000000013,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.811,
"layouts": 11,
"layoutDurationMs": 3.046,
"taskDurationMs": 554.209,
"heapDeltaBytes": -7825236,
"heapUsedBytes": 67163676,
"domNodes": -162,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 8.046999999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2023.9340000000539,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.9339999999999993,
"layouts": 10,
"layoutDurationMs": 2.6119999999999997,
"taskDurationMs": 527.952,
"heapDeltaBytes": 929180,
"heapUsedBytes": 68679400,
"domNodes": -162,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.862000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.3490000000388,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.165000000000001,
"layouts": 11,
"layoutDurationMs": 3.272,
"taskDurationMs": 884.959,
"heapDeltaBytes": -705300,
"heapUsedBytes": 74342448,
"domNodes": -162,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 156.384,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.8160000000007,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.860999999999999,
"layouts": 10,
"layoutDurationMs": 2.3649999999999998,
"taskDurationMs": 741.6899999999999,
"heapDeltaBytes": 1053892,
"heapUsedBytes": 68774768,
"domNodes": -162,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 159.559,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665094339622645,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.3889999999833,
"styleRecalcs": 19,
"styleRecalcDurationMs": 7.0729999999999995,
"layouts": 12,
"layoutDurationMs": 3.464,
"taskDurationMs": 279.2,
"heapDeltaBytes": 20117524,
"heapUsedBytes": 87878228,
"domNodes": 47,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.152000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1792.925000000082,
"styleRecalcs": 19,
"styleRecalcDurationMs": 7.101000000000001,
"layouts": 14,
"layoutDurationMs": 3.683,
"taskDurationMs": 427.92999999999995,
"heapDeltaBytes": -2757792,
"heapUsedBytes": 72262104,
"domNodes": 47,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 10.517000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664814814814818,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 626.5240000000176,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.029,
"layouts": 10,
"layoutDurationMs": 2.538,
"taskDurationMs": 472.12100000000004,
"heapDeltaBytes": -1553320,
"heapUsedBytes": 66072676,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 167.255,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 594.6210000000747,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.031000000000001,
"layouts": 11,
"layoutDurationMs": 3.0309999999999993,
"taskDurationMs": 430.379,
"heapDeltaBytes": 1082380,
"heapUsedBytes": 68972200,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 174.78500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1180.8510000000183,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 869.189,
"heapDeltaBytes": -89676,
"heapUsedBytes": 81803492,
"domNodes": -192,
"jsHeapTotalBytes": 16261120,
"scriptDurationMs": 68.26800000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 503,
"frameDurationMs": 31.978378378378373,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1180.5219999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 884.738,
"heapDeltaBytes": -11722776,
"heapUsedBytes": 81464968,
"domNodes": -192,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 67.556,
"eventListeners": -106,
"totalBlockingTimeMs": 511,
"frameDurationMs": 32.86944444444445,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.4059999999686,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.4269999999999,
"heapDeltaBytes": -5555804,
"heapUsedBytes": 75594148,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 153.92499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 213,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 833.7700000000723,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.64400000000023,
"heapDeltaBytes": -4969584,
"heapUsedBytes": 74962980,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 150.501,
"eventListeners": 0,
"totalBlockingTimeMs": 212,
"frameDurationMs": 25.251515151515157,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9307.59999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8478.942,
"heapDeltaBytes": 3335112,
"heapUsedBytes": 83675796,
"domNodes": -258,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 7135.88,
"eventListeners": -68,
"totalBlockingTimeMs": 800,
"frameDurationMs": 32.918439716312065,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10331.875999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9406.286,
"heapDeltaBytes": 4374104,
"heapUsedBytes": 84184268,
"domNodes": -258,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 8018.222,
"eventListeners": -68,
"totalBlockingTimeMs": 1198,
"frameDurationMs": 31.79353846153846,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9211.803000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8469.654,
"heapDeltaBytes": 4149704,
"heapUsedBytes": 83189920,
"domNodes": -258,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 6769.5650000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 483,
"frameDurationMs": 31.61408934707904,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8674.112999999921,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8170000000000001,
"layouts": 3,
"layoutDurationMs": 1.0939999999999999,
"taskDurationMs": 7974.786,
"heapDeltaBytes": 21947544,
"heapUsedBytes": 100729568,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 6699.104,
"eventListeners": -68,
"totalBlockingTimeMs": 654,
"frameDurationMs": 32.399253731343286,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 272.91200000001936,
"styleRecalcs": 27,
"styleRecalcDurationMs": 15.346,
"layouts": 12,
"layoutDurationMs": 3.185,
"taskDurationMs": 218.91299999999998,
"heapDeltaBytes": -11558056,
"heapUsedBytes": 79451056,
"domNodes": 917,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8.670000000000002,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.800000000000043,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-combo-open",
"durationMs": 253.4689999999955,
"styleRecalcs": 23,
"styleRecalcDurationMs": 20.885,
"layouts": 11,
"layoutDurationMs": 3.508,
"taskDurationMs": 228.25199999999998,
"heapDeltaBytes": -19546760,
"heapUsedBytes": 74997744,
"domNodes": 701,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.864,
"eventListeners": 65,
"totalBlockingTimeMs": 8,
"frameDurationMs": 27.77777777777778,
"p95FrameDurationMs": 116.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2073.391000000015,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.6170000000000004,
"layouts": 9,
"layoutDurationMs": 2.546,
"taskDurationMs": 629.64,
"heapDeltaBytes": -8059936,
"heapUsedBytes": 90205320,
"domNodes": -258,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 33.534,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2040.0060000000622,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0559999999999996,
"layouts": 9,
"layoutDurationMs": 2.309,
"taskDurationMs": 601.441,
"heapDeltaBytes": -1443880,
"heapUsedBytes": 81857220,
"domNodes": -258,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 31.430000000000007,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2209.9090000000388,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.151999999999999,
"layouts": 8,
"layoutDurationMs": 1.8799999999999997,
"taskDurationMs": 1434.9120000000003,
"heapDeltaBytes": 2381424,
"heapUsedBytes": 86340072,
"domNodes": -258,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 798.576,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2316.760000000045,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.290999999999999,
"layouts": 7,
"layoutDurationMs": 1.8639999999999999,
"taskDurationMs": 1624.64,
"heapDeltaBytes": 5666760,
"heapUsedBytes": 83640784,
"domNodes": -258,
"jsHeapTotalBytes": 1925120,
"scriptDurationMs": 799.794,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66521739130435,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3664.4390000000158,
"styleRecalcs": 72,
"styleRecalcDurationMs": 7.8340000000000005,
"layouts": 66,
"layoutDurationMs": 10.584000000000001,
"taskDurationMs": 1751.4520000000002,
"heapDeltaBytes": -13289944,
"heapUsedBytes": 72794492,
"domNodes": -234,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 774.609,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74246575342466,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3689.241000000038,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.235,
"layouts": 65,
"layoutDurationMs": 10.188,
"taskDurationMs": 1748.4470000000001,
"heapDeltaBytes": -9500040,
"heapUsedBytes": 76314248,
"domNodes": -234,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 790.933,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.741818181818186,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2730.540000000019,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.448999999999999,
"layouts": 7,
"layoutDurationMs": 1.9259999999999997,
"taskDurationMs": 1696.612,
"heapDeltaBytes": 10309976,
"heapUsedBytes": 97067168,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 953.596,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.769135802469133,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2879.8189999999977,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.0230000000000015,
"layouts": 5,
"layoutDurationMs": 1.2790000000000001,
"taskDurationMs": 1898.0369999999998,
"heapDeltaBytes": 9223996,
"heapUsedBytes": 96317260,
"domNodes": 0,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 936.8910000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.861764705882354,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2033.2899999999654,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6699999999999986,
"layouts": 8,
"layoutDurationMs": 2.0260000000000002,
"taskDurationMs": 439.9649999999999,
"heapDeltaBytes": 467372,
"heapUsedBytes": 85762824,
"domNodes": -258,
"jsHeapTotalBytes": 1699840,
"scriptDurationMs": 30.525000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.8120000000545,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.7390000000000003,
"layouts": 10,
"layoutDurationMs": 2.769,
"taskDurationMs": 453.315,
"heapDeltaBytes": 656732,
"heapUsedBytes": 86810936,
"domNodes": -258,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 30.859999999999992,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.8159999999939,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.818000000000001,
"layouts": 10,
"layoutDurationMs": 2.6200000000000006,
"taskDurationMs": 363.46900000000005,
"heapDeltaBytes": 21595800,
"heapUsedBytes": 89654632,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 142.611,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.7830000000113,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.5280000000000005,
"layouts": 10,
"layoutDurationMs": 2.1069999999999993,
"taskDurationMs": 427.069,
"heapDeltaBytes": 2318340,
"heapUsedBytes": 79586956,
"domNodes": 0,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 141.484,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571443,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.3900000000435,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.058000000000001,
"layouts": 11,
"layoutDurationMs": 2.8089999999999997,
"taskDurationMs": 385.24,
"heapDeltaBytes": 758924,
"heapUsedBytes": 68780680,
"domNodes": -180,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 7.491000000000001,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2024.3669999999838,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.065,
"layouts": 11,
"layoutDurationMs": 3.0330000000000004,
"taskDurationMs": 531.9010000000001,
"heapDeltaBytes": 211220,
"heapUsedBytes": 68273640,
"domNodes": -180,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7.724000000000002,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.248999999978,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.684,
"layouts": 11,
"layoutDurationMs": 2.5429999999999997,
"taskDurationMs": 853.221,
"heapDeltaBytes": -11708224,
"heapUsedBytes": 65075648,
"domNodes": -172,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 106.34100000000001,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664761904761907,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.4369999999954,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.001000000000001,
"layouts": 10,
"layoutDurationMs": 1.9200000000000004,
"taskDurationMs": 793.214,
"heapDeltaBytes": -696808,
"heapUsedBytes": 67450944,
"domNodes": -172,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 98.31599999999999,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1451.6459999999825,
"styleRecalcs": 19,
"styleRecalcDurationMs": 29.323999999999995,
"layouts": 5,
"layoutDurationMs": 17.285,
"taskDurationMs": 998.1220000000002,
"heapDeltaBytes": 36115520,
"heapUsedBytes": 117563600,
"domNodes": 15956,
"jsHeapTotalBytes": 15867904,
"scriptDurationMs": 41.834999999999994,
"eventListeners": 3244,
"totalBlockingTimeMs": 159,
"frameDurationMs": 19.818918918918925,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8637.229999999989,
"styleRecalcs": 251,
"styleRecalcDurationMs": 17.394,
"layouts": 10,
"layoutDurationMs": 2.3319999999999994,
"taskDurationMs": 5639.309,
"heapDeltaBytes": -14050032,
"heapUsedBytes": 68854668,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 2605.1389999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73036750483559,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8651.967000000013,
"styleRecalcs": 251,
"styleRecalcDurationMs": 17.902,
"layouts": 9,
"layoutDurationMs": 2.167,
"taskDurationMs": 5724.005,
"heapDeltaBytes": 9883012,
"heapUsedBytes": 88632928,
"domNodes": -258,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 2658.591,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73056092843327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15518.815999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14813.285,
"heapDeltaBytes": 5332584,
"heapUsedBytes": 287246460,
"domNodes": -3330,
"jsHeapTotalBytes": 24104960,
"scriptDurationMs": 243.32899999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.209459459459463,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 22560.08399999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21558.162000000004,
"heapDeltaBytes": -22688756,
"heapUsedBytes": 267918392,
"domNodes": -3330,
"jsHeapTotalBytes": 6488064,
"scriptDurationMs": 293.83799999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.49054290718039,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 19282.36400000003,
"styleRecalcs": 172,
"styleRecalcDurationMs": 12.170000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18869.089,
"heapDeltaBytes": 3869812,
"heapUsedBytes": 280491052,
"domNodes": -3330,
"jsHeapTotalBytes": 16572416,
"scriptDurationMs": 827.7090000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 69,
"frameDurationMs": 34.433214285714286,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 27338.06599999991,
"styleRecalcs": 181,
"styleRecalcDurationMs": 14.546999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 26899.364,
"heapDeltaBytes": 1172880,
"heapUsedBytes": 270915668,
"domNodes": -1,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 848.8480000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 21,
"frameDurationMs": 50.70927643784787,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 5891.990000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.08000000000001,
"layouts": 20,
"layoutDurationMs": 23.193000000000005,
"taskDurationMs": 5773.318,
"heapDeltaBytes": -38163780,
"heapUsedBytes": 260063120,
"domNodes": -3330,
"jsHeapTotalBytes": 13565952,
"scriptDurationMs": 118.315,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.40350877192982,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8112.187999999946,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.62300000000002,
"layouts": 20,
"layoutDurationMs": 21.153999999999993,
"taskDurationMs": 7976.951999999999,
"heapDeltaBytes": 2645488,
"heapUsedBytes": 279408812,
"domNodes": -3330,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 110.33,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.64597701149425,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11320.42100000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10825.961,
"heapDeltaBytes": 9236,
"heapUsedBytes": 271796004,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 148.37999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.49081632653061,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11552.183000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11084.774000000001,
"heapDeltaBytes": 14728684,
"heapUsedBytes": 286186116,
"domNodes": 0,
"jsHeapTotalBytes": -14942208,
"scriptDurationMs": 157.03699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.74673539518901,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 491.691000000003,
"styleRecalcs": 22,
"styleRecalcDurationMs": 17.129,
"layouts": 15,
"layoutDurationMs": 5.837999999999999,
"taskDurationMs": 141.92899999999997,
"heapDeltaBytes": 6968688,
"heapUsedBytes": 73140640,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.234,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 463.48699999998644,
"styleRecalcs": 20,
"styleRecalcDurationMs": 14.182999999999998,
"layouts": 14,
"layoutDurationMs": 4.872,
"taskDurationMs": 118.26499999999999,
"heapDeltaBytes": 6696860,
"heapUsedBytes": 72959800,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.780999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 440.5659999999898,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9700000000000001,
"layouts": 76,
"layoutDurationMs": 14.466,
"taskDurationMs": 392.793,
"heapDeltaBytes": 10738644,
"heapUsedBytes": 103177016,
"domNodes": 4,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 188.243,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 459.37900000001264,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.287,
"layouts": 76,
"layoutDurationMs": 14.508000000000001,
"taskDurationMs": 407.01599999999996,
"heapDeltaBytes": 10726912,
"heapUsedBytes": 101100824,
"domNodes": 4,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 195.70499999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.285185185185178,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 554.0160000000469,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.2950000000000004,
"layouts": 76,
"layoutDurationMs": 14.51,
"taskDurationMs": 511.24,
"heapDeltaBytes": 900496,
"heapUsedBytes": 130790952,
"domNodes": 4,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 196.87,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 673.4220000000732,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.868,
"layouts": 76,
"layoutDurationMs": 15.729,
"taskDurationMs": 614.62,
"heapDeltaBytes": 1024852,
"heapUsedBytes": 128002136,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 250.998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.520512820512824,
"p95FrameDurationMs": 33.30000000000018
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2264 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 38ef604bd5fc04076b090f859b398c9d316ed883
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20496 +/- ##
==========================================
+ Coverage 86.08% 86.87% +0.79%
==========================================
Files 3638 2588 -1050
Lines 173746 145533 -28213
Branches 47902 37810 -10092
==========================================
- Hits 149565 126434 -23131
+ Misses 22172 18713 -3459
+ Partials 2009 386 -1623
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Desktop half: Comfy-Org/Comfy-Desktop#1679. It covers the stage this PR declares out of reach — that a file landing where the download manager is pointed actually becomes Together they close the journey: this one proves the renderer asks, gates, and holds the warning down; that one proves the host's answer is true. |
christian-byrne
left a comment
There was a problem hiding this comment.
One coverage gap still blocks this test-only successor. The missing-warning check must prove that the asynchronous scan reached a confirmed candidate before it asserts that the warning stayed hidden. I left the exact readiness boundary on the test.
This comment has been minimized.
This comment has been minimized.
Everything under this feature was covered by unit and component tests, which assert wiring rather than the journey a user takes. Nothing proved that opening an official template on Desktop reaches the host at all, and nothing proved the first-party gate holds from outside the composable that implements it. The bridge is the only thing crossing the process boundary, so the fixture replaces it and records what the renderer asked for. It installs before the app boots - `addInitScript` only reaches navigations that have not happened yet - while the seed data goes in afterwards, since the host is read lazily when a template opens. Two cases: a default-module template reaches `getTemplateInputAssets` and then asks to download the declared asset; an extension-module template does neither, and its workflow still opens. The second is seeded identically to the first so the module is the only difference left, and serving it under `default` fails it. `withIndex` is new because the helper always built a default-module index, which left the distinction this gate turns on unexpressible. Covers the lookup and the gate. Progress, binding refresh and missing-media clearing need a workflow that actually references a missing file, and follow.
…s fetched A declared input that is genuinely absent is also missing media, so without the download in flight the error overlay opens on it. Suppressing that is the point of `blockingFilenames`, and nothing proved it from outside the store. The mock now reports an admitted job to its listeners the way the host does. Without that the renderer learns a file is spoken for only when the test emits the first progress event, which is a window no real host leaves open - and the test failed about a third of the time because the scan raced into it. Not covered: the warning clearing after the download completes. A completed event removes the record, but the overlay does not reopen either, so asserting it stays hidden passes whatever the event says - replacing `completed` with `error` left the test green. Clearing needs the file to become visible to the backend that lists the combo options, which the bridge mock cannot do, so that stage belongs with the cross-process contract rather than here.
… the warning The suppression assertion ran as soon as the host had been asked to download. `runMissingMediaPipeline` starts `verifyMediaCandidates` without awaiting it, so a hidden overlay at that moment could mean the scan had not finished rather than that anything suppressed it. It now polls `pendingWarnings.missingMediaCandidates` until the scan has confirmed the file, the way `missingMediaFilePath.spec.ts` does, and only then reads the overlay. Evidence the assertion covers the filter rather than the timing: removing the `blockingFilenames` filter from `actionableMissingMediaCandidates`, rebuilding the desktop dist and rerunning gives `expect(locator).toBeHidden() failed - Received: visible`, 1 failed / 2 passed. Restored, 3 passed.
2fcc483 to
0ca1a40
Compare
|
Ready for another look. Two things changed since your review. The readiness boundary you asked for ( A rebase onto current main. The first push after your review went red, which was staleness rather than anything in the change: main had moved 123 commits and CI is green: 103 passing, and The Desktop half is Comfy-Org/Comfy-Desktop#1679, also rebased and green. |
christian-byrne
left a comment
There was a problem hiding this comment.
Verified the missing-media readiness boundary and the first-party versus extension gate. The focused browser coverage and required checks support approval.
Successor to #20084, per the coverage follow-up there: a feature-level browser test for the Desktop template input-asset path. Non-blocking, as agreed.
What it covers
The bridge is the only thing crossing the process boundary, so the fixture replaces it and records what the renderer asked for. Three cases:
default-module template callsgetTemplateInputAssets, then asks to download the declared asset.blockingFilenamesis for, and nothing proved it from outside the store.Everything under this feature already had unit and component coverage; those assert wiring rather than the journey.
What it does not cover
The warning clearing after the download completes. I wrote that assertion, then found it vacuous: replacing
completedwitherrorleft the test green. A completed event removes the record, but the overlay does not reopen either, so asserting it stays hidden passes whatever the event says.Clearing needs the file to become visible to the backend that lists the combo options, which a renderer-side bridge mock cannot do. That stage belongs with the cross-process contract — Desktop's integration harness — rather than here. I would rather leave the gap visible than ship an assertion that cannot fail.
Notes for review
The mock emits on admission, and that was a real bug in it. The first version only spoke when the test told it to, so the renderer learned a file was spoken for later than it would in production. The suppression test failed about a third of the time because the missing-media scan raced into that window. Real hosts report an admitted job straight away; once the mock did too, the race was gone. Worth knowing because it is the failure mode a mock-based test has — the mock drifting from the contract it stands in for.
Each assertion was checked by breaking what it covers:
defaultfails the gate testwithIndexis new.TemplateHelperalways built adefault-module index, which left the distinction this gate turns on unexpressible.Tagged
@desktop, so it runs on thefrontend-dist-desktopartifact whereisDesktopis true —__DISTRIBUTION__is baked at build time, so a window stub cannot stand in for it.Verified locally against a ComfyUI backend serving
pnpm build:desktop-dist, three consecutive clean runs.