Skip to content

[backport cloud/1.56] FE-3298 fix(cloud): return SSO to the consent path the server serves - #20486

Merged
comfy-pr-bot merged 1 commit into
cloud/1.56from
backport-20468-to-cloud-1.56
Oct 7, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.56from
backport-20468-to-cloud-1.56

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #20468 to cloud/1.56

Automatically created by backport workflow.

…20468)

## Summary

An OAuth sign-in (Comfy Desktop, MCP clients) that goes through SSO
lands on a JSON 404 instead of the consent page, so a first-time SSO
user can never finish signing in. SSO now returns to
`/cloud/oauth/consent`, the consent path the server serves as a page.

- Fixes FE-3298

**Why:** a person with no Cloud session who picks Continue with SSO
during an OAuth sign-in is stuck on `{"code":"NOT_FOUND"}`. This blocks
the Oct 15 internal Desktop SSO test, since every first sign-in takes
this path. With an existing Cloud session the SSO step is skipped, which
is why it went unnoticed.

**Root cause:** `resolveSsoReturnTo` (added in #20217) resolves the
pending consent by route name, which gives `/oauth/consent`. That route
only exists inside the SPA. The SSO callback is a full page load, and
the server answers `/oauth/consent` with a 404 on testcloud and prod.
Only `/cloud/oauth/consent` is served as a page; the SPA then redirects
it to `/oauth/consent`.

| Path | testcloud | prod |
|---|---|---|
| `/oauth/consent` | 404 JSON | 404 JSON |
| `/cloud/oauth/consent` | 200 HTML | 200 HTML |

**How:** one helper, `toSsoReturnPath`, maps `/oauth/consent` to
`/cloud/oauth/consent` (query kept) for every SSO return:
- `resolveSsoReturnTo`: the login/signup pages' Continue with SSO and
the post-Firebase `sso_required` handoff.
- `SsoRequiredDialogContent`: its fallback to the current route, so a
refusal raised on the consent page itself (e.g. by the consent route's
session setup or a re-mint) no longer returns to the 404.

The legacy redirect route now notes that SSO depends on it, so it isn't
removed before BE-4146 serves `/oauth/consent`.

**Every OAuth sign-in path** (context from #14006 and #15026):

| Path into consent | Navigation | Before | After |
|---|---|---|---|
| Signed in: `/oauth/authorize` → 302 `/cloud/oauth/consent` | full
load, then SPA redirect | ok | ok (untouched) |
| Signed out, Firebase sign-in on `/cloud/login?oauth_request_id=` | SPA
`router.push` by name | ok | ok (untouched) |
| Signed out, Continue with SSO on login or signup | SSO callback full
load | **404** | ok |
| Firebase sign-in refused with `sso_required` on the login page | SSO
callback full load | **404** | ok |
| SSO error, retry with the id kept in storage | SSO callback full load
| **404** | ok |
| `sso_required` dialog raised on the consent page | SSO callback full
load | **404** | ok |
| Legacy `/login` (#15026) | SPA redirect to `cloud-login`, query kept |
ok | ok (untouched) |

## Plan position

| PR | Scope | State |
|---|---|---|
| #20217 | `sso_enabled` flag, SSO sign-in (introduced the bug) | merged
|
| #20383 | Desktop local signs in with the Desktop session | in review |
| **this PR** | **SSO returns to a served consent path** | **open** |
| FE-3297 | Workspace switching under Desktop host auth | follow-up |

```mermaid
flowchart LR
  A["#20217 SSO sign-in"] --> C["this PR: consent return fix"]
  B["#20383 Desktop host session"] --> D["Oct 15 internal test"]
  C --> D
  D --> E["FE-3297 workspace switch"]
  style C fill:#f5c518,color:#000
```

## Verification

- **Unit tests:** `CloudLoginView.test.ts` pinned the broken
`/oauth/consent` return in three cases.
  - With the old source, those three fail.
- With this change, all 65 tests in `CloudLoginView.test.ts` and
`onboardingCloudRoutes.test.ts` pass.
- **E2E:** none added. The flow needs a real IdP and a server-side SSO
callback, which the Playwright mocks don't cover; the unit test pins the
`returnTo` value the server receives.
- **Manual (before merge):** on the PR preview against testcloud, signed
out:
  1. Start a Desktop sign-in.
  2. Pick Continue with SSO and sign in as `ssotest1@example.com`.
  3. Confirm the consent page loads and Desktop finishes signing in.

### AS IS

Signed out, Continue with SSO during a Desktop sign-in returns to
`/oauth/consent`, which the server answers with a JSON 404.

<img
src="https://github.com/user-attachments/assets/8e878603-73b4-4cf7-90c9-9b92731f82ea"
width="700">

### TO BE

SSO returns to `/cloud/oauth/consent`; after the IdP the same flow
reaches the consent page. Verified on testcloud Oct 7; the token
exchange completed (`sign_in_provider: saml.workos`, `client_id:
comfy-desktop`).

<img
src="https://github.com/user-attachments/assets/ed1f542f-bbc3-49fb-aca6-63d935dcb3b1"
width="700">

<details><summary>Steps</summary>

<img
src="https://github.com/user-attachments/assets/84791e5f-d90c-4428-85df-f5a00a81df74"
width="700">
<img
src="https://github.com/user-attachments/assets/0f03a210-2d6f-48dc-8fd9-12eb6299f0a8"
width="700">

</details>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Oct 7, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) October 7, 2026 23:26
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/07/2026, 11:28:27 PM UTC

Links

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since c2a4e496012e7869b49129213ae471a8533656c2

Full docs: ADR-DEVEX-LINT-0015

🎭 Playwright: ✅ 2202 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2180 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.3 MB heap
dom-widget-order-dense-n200-w200-i120: · 28.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 570ms TBT · 93.6 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 40.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 216ms TBT · 99.5 MB heap
extension-clean-combined-draw: · 29.6 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 718ms TBT · 74.6 MB heap
extension-rgthree-prototype-draw: · 30.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 775ms TBT · 79.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.0 MB heap
large-graph-pan: · 59.6 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.3 MB heap
legacy-node-drag: · 59.7 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.7 MB heap
subgraph-transition-enter: · 50.9 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 139ms TBT · 93.3 MB heap
viewport-pan-sweep: · 59.9 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.6 MB heap
vue-large-graph-idle: · 32.4 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 170.6 MB heap
vue-large-graph-pan: · 24.1 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 14ms TBT · 180.8 MB heap
vue-node-resize-workload: · 26.7 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 200.3 MB heap
vue-zoom-out-idle: · 33.4 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 171.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.0 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.6 MB heap
agent-composer-long-conversation-typing: · 56.8 avg FPS · 39.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 104.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 4ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 400ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 65.5 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 17ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 725ms
canvas-mouse-sweep: script duration 162ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.8 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 0
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 10ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 335ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 68.8 MB
canvas-zoom-sweep: DOM nodes 53
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 4ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 453ms
dom-widget-clipping: script duration 163ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 58.3 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 35ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 831ms
dom-widget-order-dense-n200-w200-i120: script duration 72ms
dom-widget-order-dense-n200-w200-i120: TBT 570ms
dom-widget-order-dense-n200-w200-i120: heap used 93.6 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 474ms
dom-widget-order-sparse-n1000-w20-i120: script duration 167ms
dom-widget-order-sparse-n1000-w20-i120: TBT 216ms
dom-widget-order-sparse-n1000-w20-i120: heap used 99.5 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 34ms
extension-clean-combined-draw: p95 frame time 67ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 1
extension-clean-combined-draw: task duration 8205ms
extension-clean-combined-draw: script duration 6845ms
extension-clean-combined-draw: TBT 718ms
extension-clean-combined-draw: heap used 74.6 MB
extension-clean-combined-draw: DOM nodes -142
extension-clean-combined-draw: event listeners -76
extension-rgthree-prototype-draw: avg frame time 33ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 3
extension-rgthree-prototype-draw: task duration 8593ms
extension-rgthree-prototype-draw: script duration 7106ms
extension-rgthree-prototype-draw: TBT 775ms
extension-rgthree-prototype-draw: heap used 79.4 MB
extension-rgthree-prototype-draw: DOM nodes -142
extension-rgthree-prototype-draw: event listeners -65
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 489ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 70.0 MB
large-graph-idle: DOM nodes 0
large-graph-idle: event listeners 0
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1570ms
large-graph-pan: script duration 835ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 66.5 MB
large-graph-pan: DOM nodes 0
large-graph-pan: event listeners 0
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 72
large-graph-zoom: task duration 1592ms
large-graph-zoom: script duration 762ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 66.3 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 47
legacy-node-drag: task duration 1845ms
legacy-node-drag: script duration 961ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 72.2 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 480ms
minimap-idle: script duration 31ms
minimap-idle: TBT 0ms
minimap-idle: heap used 77.1 MB
minimap-idle: DOM nodes 0
minimap-idle: event listeners 0
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 6ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 395ms
subgraph-dom-widget-clipping: script duration 146ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 61.8 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 4ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 404ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.7 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 18ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 69
subgraph-mouse-sweep: task duration 726ms
subgraph-mouse-sweep: script duration 108ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 60.7 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 0
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 922ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 139ms
subgraph-transition-enter: heap used 93.3 MB
subgraph-transition-enter: DOM nodes 14227
subgraph-transition-enter: event listeners 2463
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 34ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 5375ms
viewport-pan-sweep: script duration 2693ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 66.6 MB
viewport-pan-sweep: DOM nodes 0
viewport-pan-sweep: event listeners 0
vue-large-graph-idle: avg frame time 31ms
vue-large-graph-idle: p95 frame time 67ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17197ms
vue-large-graph-idle: script duration 276ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.6 MB
vue-large-graph-idle: DOM nodes -3045
vue-large-graph-idle: event listeners -14915
vue-large-graph-pan: avg frame time 41ms
vue-large-graph-pan: p95 frame time 83ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 180
vue-large-graph-pan: task duration 22129ms
vue-large-graph-pan: script duration 884ms
vue-large-graph-pan: TBT 14ms
vue-large-graph-pan: heap used 180.8 MB
vue-large-graph-pan: DOM nodes -3045
vue-large-graph-pan: event listeners -14915
vue-node-resize-workload: avg frame time 37ms
vue-node-resize-workload: p95 frame time 67ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 79ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6285ms
vue-node-resize-workload: script duration 104ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 200.3 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 30ms
vue-zoom-out-idle: p95 frame time 67ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8677ms
vue-zoom-out-idle: script duration 138ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 171.7 MB
vue-zoom-out-idle: DOM nodes -3045
vue-zoom-out-idle: event listeners -14915
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 4
workflow-execution: style recalc count 12
workflow-execution: task duration 103ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.0 MB
workflow-execution: DOM nodes 99
workflow-execution: event listeners 49
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 23ms
agent-composer-empty-conversation-typing: style recalc duration 95ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 754ms
agent-composer-empty-conversation-typing: script duration 306ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 77.6 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 18ms
agent-composer-long-conversation-typing: p95 frame time 25ms
agent-composer-long-conversation-typing: layout duration 29ms
agent-composer-long-conversation-typing: style recalc duration 261ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 1373ms
agent-composer-long-conversation-typing: script duration 461ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 104.5 MB
agent-composer-long-conversation-typing: DOM nodes 76
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-10-07T23:40:36.837Z",
  "gitSha": "38e51d247be111b824362e21bb1dba91b0aa0217",
  "branch": "backport-20468-to-cloud-1.56",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2018.3279999999968,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.249,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 406.243,
      "heapDeltaBytes": 587888,
      "heapUsedBytes": 68705200,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.279999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2021.571999999992,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.968000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 393.588,
      "heapDeltaBytes": 599024,
      "heapUsedBytes": 68609508,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.832000000000006,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1745.9709999999973,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 17.041,
      "layouts": 12,
      "layoutDurationMs": 4.241,
      "taskDurationMs": 689.099,
      "heapDeltaBytes": -2081540,
      "heapUsedBytes": 65759004,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 166.74499999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6647619047619,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1754.242999999974,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 17.258000000000003,
      "layouts": 12,
      "layoutDurationMs": 4.065,
      "taskDurationMs": 761.8560000000001,
      "heapDeltaBytes": -2067644,
      "heapUsedBytes": 65931276,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 157.174,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1698.6949999999865,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 10.433,
      "layouts": 6,
      "layoutDurationMs": 1.296,
      "taskDurationMs": 340.298,
      "heapDeltaBytes": 4087604,
      "heapUsedBytes": 72218620,
      "domNodes": 53,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 11.507000000000003,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1683.7639999999965,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 9.240000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.1580000000000001,
      "taskDurationMs": 328.96999999999997,
      "heapDeltaBytes": 4064568,
      "heapUsedBytes": 72107616,
      "domNodes": 53,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 10.565999999999999,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665346534653462,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 727.7460000000247,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 4.706,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 460.96100000000007,
      "heapDeltaBytes": -6451488,
      "heapUsedBytes": 61313200,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 165.31799999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665116279069775,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 659.7790000000714,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 3.3570000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 445.99,
      "heapDeltaBytes": -7076532,
      "heapUsedBytes": 61034408,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 161.42600000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669230769230754,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1242.8620000000024,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 912.4029999999999,
      "heapDeltaBytes": 42152772,
      "heapUsedBytes": 111996192,
      "domNodes": 0,
      "jsHeapTotalBytes": 6193152,
      "scriptDurationMs": 76.338,
      "eventListeners": 0,
      "totalBlockingTimeMs": 620,
      "frameDurationMs": 36.76470588235294,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1147.408999999925,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 749.7919999999999,
      "heapDeltaBytes": 15105476,
      "heapUsedBytes": 84367008,
      "domNodes": 0,
      "jsHeapTotalBytes": 2785280,
      "scriptDurationMs": 68.09900000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 519,
      "frameDurationMs": 33.82058823529413,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 860.2700000000141,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 472.64399999999983,
      "heapDeltaBytes": 17288164,
      "heapUsedBytes": 104269340,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 165.67799999999994,
      "eventListeners": 0,
      "totalBlockingTimeMs": 213,
      "frameDurationMs": 24.76000000000001,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 846.6409999999769,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 474.7709999999996,
      "heapDeltaBytes": 18845844,
      "heapUsedBytes": 104411716,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 167.76999999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 218,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9407.005999999967,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.38999999999999974,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8610.885,
      "heapDeltaBytes": -138548,
      "heapUsedBytes": 84740472,
      "domNodes": -142,
      "jsHeapTotalBytes": -10358784,
      "scriptDurationMs": 7080.013,
      "eventListeners": -74,
      "totalBlockingTimeMs": 679,
      "frameDurationMs": 33.272791519434634,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 8449.778000000038,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.42800000000000127,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7798.686000000001,
      "heapDeltaBytes": -12549112,
      "heapUsedBytes": 71764356,
      "domNodes": -142,
      "jsHeapTotalBytes": -8523776,
      "scriptDurationMs": 6609.134,
      "eventListeners": -78,
      "totalBlockingTimeMs": 756,
      "frameDurationMs": 34.208906882591094,
      "p95FrameDurationMs": 66.59999999999945
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9196.167000000003,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.8009999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8505.037999999999,
      "heapDeltaBytes": -3005016,
      "heapUsedBytes": 81614800,
      "domNodes": -142,
      "jsHeapTotalBytes": -9048064,
      "scriptDurationMs": 7003.244000000001,
      "eventListeners": -78,
      "totalBlockingTimeMs": 661,
      "frameDurationMs": 33.092446043165474,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9425.215999999979,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.8350000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8680.504,
      "heapDeltaBytes": 16520368,
      "heapUsedBytes": 84877424,
      "domNodes": -142,
      "jsHeapTotalBytes": -5640192,
      "scriptDurationMs": 7207.8240000000005,
      "eventListeners": -52,
      "totalBlockingTimeMs": 889,
      "frameDurationMs": 32.69513888888889,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2018.749000000014,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.0869999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 502.641,
      "heapDeltaBytes": -10122404,
      "heapUsedBytes": 78610652,
      "domNodes": 0,
      "jsHeapTotalBytes": 36864,
      "scriptDurationMs": 36.93099999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2023.834000000079,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.8969999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.86899999999997,
      "heapDeltaBytes": -10975032,
      "heapUsedBytes": 68280732,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 29.302000000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2380.693000000008,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 11.472000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1610.794,
      "heapDeltaBytes": -20203960,
      "heapUsedBytes": 68731260,
      "domNodes": 0,
      "jsHeapTotalBytes": 823296,
      "scriptDurationMs": 842.9610000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.78380281690141,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2247.5350000000844,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 10.827,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1529.3129999999999,
      "heapDeltaBytes": -19074092,
      "heapUsedBytes": 70776192,
      "domNodes": 0,
      "jsHeapTotalBytes": 561152,
      "scriptDurationMs": 827.585,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.790298507462683,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3548.6549999999966,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 13.201999999999998,
      "layouts": 60,
      "layoutDurationMs": 14.088,
      "taskDurationMs": 1594.9619999999998,
      "heapDeltaBytes": 1215840,
      "heapUsedBytes": 69274384,
      "domNodes": 24,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 753.042,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66650943396227,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3556.0070000000223,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 13.422,
      "layouts": 60,
      "layoutDurationMs": 14.004000000000001,
      "taskDurationMs": 1589.756,
      "heapDeltaBytes": 869388,
      "heapUsedBytes": 69857544,
      "domNodes": 24,
      "jsHeapTotalBytes": 1572864,
      "scriptDurationMs": 771.465,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666355140186912,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3092.646000000002,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.3210000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1847.683,
      "heapDeltaBytes": 3951812,
      "heapUsedBytes": 73442008,
      "domNodes": 0,
      "jsHeapTotalBytes": 1572864,
      "scriptDurationMs": 961.536,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.757065217391304,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3024.373999999966,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.396999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1843.179,
      "heapDeltaBytes": 8809764,
      "heapUsedBytes": 77874016,
      "domNodes": 0,
      "jsHeapTotalBytes": 1273856,
      "scriptDurationMs": 959.8100000000001,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.75888888888889,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2012.377000000015,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.6290000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 487.7459999999999,
      "heapDeltaBytes": -9123648,
      "heapUsedBytes": 80605412,
      "domNodes": 0,
      "jsHeapTotalBytes": 36864,
      "scriptDurationMs": 30.464000000000006,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2009.435999999937,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 3.0189999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 471.9900000000001,
      "heapDeltaBytes": 13087292,
      "heapUsedBytes": 81006476,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 30.66200000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 624.5640000000208,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 6.224,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 398.861,
      "heapDeltaBytes": 9741460,
      "heapUsedBytes": 71889596,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 146.13299999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667567567567563,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 593.3210000000599,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.9049999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 390.73900000000003,
      "heapDeltaBytes": -11994172,
      "heapUsedBytes": 57716104,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 146.85899999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2009.9069999999983,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 4.515,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 411.21,
      "heapDeltaBytes": 1098356,
      "heapUsedBytes": 71736276,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.459000000000008,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.8280000000177,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.989999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 397.4,
      "heapDeltaBytes": 1352876,
      "heapUsedBytes": 72428072,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.052,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1692.4590000000421,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 17,
      "layouts": 16,
      "layoutDurationMs": 5.41,
      "taskDurationMs": 707.487,
      "heapDeltaBytes": -5961468,
      "heapUsedBytes": 64155912,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 105.225,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352944,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1695.5829999999423,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 18.153999999999996,
      "layouts": 16,
      "layoutDurationMs": 5.908,
      "taskDurationMs": 743.545,
      "heapDeltaBytes": -5984816,
      "heapUsedBytes": 63181696,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 110.85799999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1418.3439999999337,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 30.204,
      "layouts": 5,
      "layoutDurationMs": 14.757000000000003,
      "taskDurationMs": 922.1680000000001,
      "heapDeltaBytes": 3118884,
      "heapUsedBytes": 97836704,
      "domNodes": 14227,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 29.526000000000003,
      "eventListeners": 2463,
      "totalBlockingTimeMs": 139,
      "frameDurationMs": 19.63424657534247,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8375.100999999973,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 35.122,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5399.056,
      "heapDeltaBytes": -17785804,
      "heapUsedBytes": 70963332,
      "domNodes": 0,
      "jsHeapTotalBytes": 299008,
      "scriptDurationMs": 2691.4889999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66573705179283,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8254.78600000008,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 33.428,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5351.597,
      "heapDeltaBytes": -16505844,
      "heapUsedBytes": 68719556,
      "domNodes": 0,
      "jsHeapTotalBytes": 823296,
      "scriptDurationMs": 2695.271,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.69959595959596,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18210.735999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17167.712,
      "heapDeltaBytes": -43083492,
      "heapUsedBytes": 179907980,
      "domNodes": -3045,
      "jsHeapTotalBytes": 1679360,
      "scriptDurationMs": 274.87,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.690219224283304,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18276.45099999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17225.771,
      "heapDeltaBytes": -38684004,
      "heapUsedBytes": 177905780,
      "domNodes": -3045,
      "jsHeapTotalBytes": 3809280,
      "scriptDurationMs": 276.87700000000007,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.958983050847458,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22627.679999999997,
      "styleRecalcs": 180,
      "styleRecalcDurationMs": 19.952000000000027,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22224.502,
      "heapDeltaBytes": -32027224,
      "heapUsedBytes": 189568244,
      "domNodes": -3045,
      "jsHeapTotalBytes": 1871872,
      "scriptDurationMs": 873.0790000000001,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 28,
      "frameDurationMs": 40.92676311030742,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22394.801999999912,
      "styleRecalcs": 180,
      "styleRecalcDurationMs": 20.815999999999974,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22032.835,
      "heapDeltaBytes": -34304720,
      "heapUsedBytes": 189692528,
      "domNodes": -3045,
      "jsHeapTotalBytes": 1609728,
      "scriptDurationMs": 895.0610000000001,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 42.02457786116322,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6577.46800000001,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.10099999999997,
      "layouts": 20,
      "layoutDurationMs": 24.09399999999999,
      "taskDurationMs": 6460.058000000001,
      "heapDeltaBytes": 1265292,
      "heapUsedBytes": 205970660,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 105.79599999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 37.61714285714286,
      "p95FrameDurationMs": 66.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6282.664000000068,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.83599999999998,
      "layouts": 20,
      "layoutDurationMs": 23.759000000000004,
      "taskDurationMs": 6109.424,
      "heapDeltaBytes": 209600,
      "heapUsedBytes": 213995320,
      "domNodes": 0,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 101.79300000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 37.17810650887574,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8972.679999999968,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8630.97,
      "heapDeltaBytes": -22925528,
      "heapUsedBytes": 180166784,
      "domNodes": -3045,
      "jsHeapTotalBytes": 6311936,
      "scriptDurationMs": 135.85199999999998,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.144295302013422,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9183.590999999979,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8722.251,
      "heapDeltaBytes": -44053280,
      "heapUsedBytes": 179930528,
      "domNodes": -3045,
      "jsHeapTotalBytes": 368640,
      "scriptDurationMs": 140.86699999999996,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.760389610389613,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "workflow-execution",
      "durationMs": 463.92100000002756,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 16.322999999999997,
      "layouts": 4,
      "layoutDurationMs": 1.9050000000000002,
      "taskDurationMs": 115.28499999999997,
      "heapDeltaBytes": 5578796,
      "heapUsedBytes": 71275296,
      "domNodes": 102,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 10.425000000000004,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667857142857137,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 135.06200000006174,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 12.297,
      "layouts": 3,
      "layoutDurationMs": 1.3840000000000003,
      "taskDurationMs": 90.72999999999998,
      "heapDeltaBytes": 3792940,
      "heapUsedBytes": 69281832,
      "domNodes": 95,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.696000000000002,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.675000000000068,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 781.4830000000939,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 96.057,
      "layouts": 76,
      "layoutDurationMs": 23.576,
      "taskDurationMs": 746.399,
      "heapDeltaBytes": 16814432,
      "heapUsedBytes": 80950364,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 301.401,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665957446808516,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 799.9669999999242,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 93.889,
      "layouts": 76,
      "layoutDurationMs": 22.939,
      "taskDurationMs": 762.552,
      "heapDeltaBytes": 17179500,
      "heapUsedBytes": 81870212,
      "domNodes": 76,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 311.281,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1428.4079999999904,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 272.043,
      "layouts": 76,
      "layoutDurationMs": 29.645999999999997,
      "taskDurationMs": 1407.852,
      "heapDeltaBytes": -13224268,
      "heapUsedBytes": 104731704,
      "domNodes": 76,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 474.81,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.14177215189872,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1354.3979999999465,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 249.10999999999999,
      "layouts": 76,
      "layoutDurationMs": 28.126,
      "taskDurationMs": 1337.158,
      "heapDeltaBytes": 8685884,
      "heapUsedBytes": 114397008,
      "domNodes": 76,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 446.292,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.082500000000003,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions
github-actions Bot requested a review from thedatalife October 7, 2026 23:27
@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 7, 2026

@dante01yoon dante01yoon left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Approval is BLOCKED while the matching-head CI run 37702259974 is still running E2E/ecosystem validation. No code blocker found in this backport; please wait for the final valid gates. This CI question is unanchored because it concerns workflow results outside the diff.

Direct validation at 00004447727cd6747111feea5988a3742e82ec98 in an isolated checkout with its own frozen install:

  • PASS: 88 relevant frontend tests + 57 shared SSO URL tests; app/browser types, production build, changed-file type-aware lint, production ESLint (unit files ignored), format and knip. Core backport also built both OSS and Cloud distributions.
  • PASS: 8 Chromium journeys on the actual Cloud production bundle/local ComfyUI backend, including pending OAuth login and signup→login→SSO, flag-off Firebase and SSO-required dialog. Auth/discovery/SSO transport are controlled fixtures; local deep-link HTML delivery models Cloud ingress.
  • RED: restoring both pre-patch production callers gives 4 failed/84 passed unit tests and 2 failed OAuth browser journeys. Restoring only the old dialog mapping gives 1 failed/87 passed; dropping query preservation gives 4 failed/84 passed. Original restored: 88 unit and 8 browser PASS.
  • PASS: 7 additional URL/query/hash/redirect safety boundaries. Direct GET probes on testcloud and production returned 404 JSON for /oauth/consent and 200 HTML for /cloud/oauth/consent; current backend source also names the latter consent path. No new API response declarations or frontend-derived server facts.

NOT_RUN: live IdP/SSO callback, real customer/token exchange, other OS/browser and unrelated suites. Server route reachability and controlled navigation are distinct from live authentication. Temporary changes removed; all six PR files match the head, production output restored and checkout clean.

@comfy-pr-bot
comfy-pr-bot merged commit bd360e6 into cloud/1.56 Oct 7, 2026
134 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-20468-to-cloud-1.56 branch October 7, 2026 23:47
@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.56   #20486   +/-   ##
=============================================
  Coverage              ?   85.96%           
=============================================
  Files                 ?     2464           
  Lines                 ?   140791           
  Branches              ?    38296           
=============================================
  Hits                  ?   121035           
  Misses                ?    19378           
  Partials              ?      378           
Flag Coverage Δ
unit 82.90% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/auth/sso/SsoRequiredDialogContent.vue 94.59% <100.00%> (ø)
src/platform/auth/sso/ssoReturnPath.ts 100.00% <100.00%> (ø)
...tform/cloud/onboarding/composables/useSsoSignIn.ts 96.42% <100.00%> (ø)
...platform/cloud/onboarding/onboardingCloudRoutes.ts 83.78% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants