Repository navigation
[backport core/1.56] FE-3298 fix(cloud): return SSO to the consent path the server serves - #20485
Conversation
…20468) ## Summary An OAuth sign-in (Comfy Desktop, MCP clients) that goes through SSO lands on a JSON 404 instead of the consent page, so a first-time SSO user can never finish signing in. SSO now returns to `/cloud/oauth/consent`, the consent path the server serves as a page. - Fixes FE-3298 **Why:** a person with no Cloud session who picks Continue with SSO during an OAuth sign-in is stuck on `{"code":"NOT_FOUND"}`. This blocks the Oct 15 internal Desktop SSO test, since every first sign-in takes this path. With an existing Cloud session the SSO step is skipped, which is why it went unnoticed. **Root cause:** `resolveSsoReturnTo` (added in #20217) resolves the pending consent by route name, which gives `/oauth/consent`. That route only exists inside the SPA. The SSO callback is a full page load, and the server answers `/oauth/consent` with a 404 on testcloud and prod. Only `/cloud/oauth/consent` is served as a page; the SPA then redirects it to `/oauth/consent`. | Path | testcloud | prod | |---|---|---| | `/oauth/consent` | 404 JSON | 404 JSON | | `/cloud/oauth/consent` | 200 HTML | 200 HTML | **How:** one helper, `toSsoReturnPath`, maps `/oauth/consent` to `/cloud/oauth/consent` (query kept) for every SSO return: - `resolveSsoReturnTo`: the login/signup pages' Continue with SSO and the post-Firebase `sso_required` handoff. - `SsoRequiredDialogContent`: its fallback to the current route, so a refusal raised on the consent page itself (e.g. by the consent route's session setup or a re-mint) no longer returns to the 404. The legacy redirect route now notes that SSO depends on it, so it isn't removed before BE-4146 serves `/oauth/consent`. **Every OAuth sign-in path** (context from #14006 and #15026): | Path into consent | Navigation | Before | After | |---|---|---|---| | Signed in: `/oauth/authorize` → 302 `/cloud/oauth/consent` | full load, then SPA redirect | ok | ok (untouched) | | Signed out, Firebase sign-in on `/cloud/login?oauth_request_id=` | SPA `router.push` by name | ok | ok (untouched) | | Signed out, Continue with SSO on login or signup | SSO callback full load | **404** | ok | | Firebase sign-in refused with `sso_required` on the login page | SSO callback full load | **404** | ok | | SSO error, retry with the id kept in storage | SSO callback full load | **404** | ok | | `sso_required` dialog raised on the consent page | SSO callback full load | **404** | ok | | Legacy `/login` (#15026) | SPA redirect to `cloud-login`, query kept | ok | ok (untouched) | ## Plan position | PR | Scope | State | |---|---|---| | #20217 | `sso_enabled` flag, SSO sign-in (introduced the bug) | merged | | #20383 | Desktop local signs in with the Desktop session | in review | | **this PR** | **SSO returns to a served consent path** | **open** | | FE-3297 | Workspace switching under Desktop host auth | follow-up | ```mermaid flowchart LR A["#20217 SSO sign-in"] --> C["this PR: consent return fix"] B["#20383 Desktop host session"] --> D["Oct 15 internal test"] C --> D D --> E["FE-3297 workspace switch"] style C fill:#f5c518,color:#000 ``` ## Verification - **Unit tests:** `CloudLoginView.test.ts` pinned the broken `/oauth/consent` return in three cases. - With the old source, those three fail. - With this change, all 65 tests in `CloudLoginView.test.ts` and `onboardingCloudRoutes.test.ts` pass. - **E2E:** none added. The flow needs a real IdP and a server-side SSO callback, which the Playwright mocks don't cover; the unit test pins the `returnTo` value the server receives. - **Manual (before merge):** on the PR preview against testcloud, signed out: 1. Start a Desktop sign-in. 2. Pick Continue with SSO and sign in as `ssotest1@example.com`. 3. Confirm the consent page loads and Desktop finishes signing in. ### AS IS Signed out, Continue with SSO during a Desktop sign-in returns to `/oauth/consent`, which the server answers with a JSON 404. <img src="https://github.com/user-attachments/assets/8e878603-73b4-4cf7-90c9-9b92731f82ea" width="700"> ### TO BE SSO returns to `/cloud/oauth/consent`; after the IdP the same flow reaches the consent page. Verified on testcloud Oct 7; the token exchange completed (`sign_in_provider: saml.workos`, `client_id: comfy-desktop`). <img src="https://github.com/user-attachments/assets/ed1f542f-bbc3-49fb-aca6-63d935dcb3b1" width="700"> <details><summary>Steps</summary> <img src="https://github.com/user-attachments/assets/84791e5f-d90c-4428-85df-f5a00a81df74" width="700"> <img src="https://github.com/user-attachments/assets/0f03a210-2d6f-48dc-8fd9-12eb6299f0a8" width="700"> </details>
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 920b7aad35424e91cdceced5a12499740689f81b
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2200 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-07T23:41:00.206Z",
"gitSha": "dec43016fef8a49951af6174bba0bff08d3a9988",
"branch": "backport-20468-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.6840000000125,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.152,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.73699999999997,
"heapDeltaBytes": 608984,
"heapUsedBytes": 69064860,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.448,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2014.583000000016,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.8519999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.428,
"heapDeltaBytes": 935604,
"heapUsedBytes": 68126612,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.647000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.0849999999741,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.903999999999996,
"layouts": 12,
"layoutDurationMs": 4.076,
"taskDurationMs": 882.4119999999999,
"heapDeltaBytes": -2110664,
"heapUsedBytes": 65922448,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 177.174,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.3670000000502,
"styleRecalcs": 74,
"styleRecalcDurationMs": 20.503,
"layouts": 12,
"layoutDurationMs": 4.444,
"taskDurationMs": 818.403,
"heapDeltaBytes": -2414504,
"heapUsedBytes": 65952084,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 167.484,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.822641509433968,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.0919999999805,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.939,
"layouts": 6,
"layoutDurationMs": 1.336,
"taskDurationMs": 364.13699999999994,
"heapDeltaBytes": 4040400,
"heapUsedBytes": 71814020,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.782000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846145,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1699.294000000009,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.834,
"layouts": 6,
"layoutDurationMs": 1.1219999999999999,
"taskDurationMs": 343.77099999999996,
"heapDeltaBytes": 4049488,
"heapUsedBytes": 71625468,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.233000000000008,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 739.1220000000089,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.027000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.28,
"heapDeltaBytes": -6788416,
"heapUsedBytes": 60783876,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 172.76200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668181818181832,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 664.0939999999773,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.2299999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.495,
"heapDeltaBytes": -6793824,
"heapUsedBytes": 60409972,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 166.227,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1185.9300000000417,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 840.3539999999999,
"heapDeltaBytes": 39505188,
"heapUsedBytes": 108623836,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 72.15599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 552,
"frameDurationMs": 34.8029411764706,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1171.3799999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 827.9470000000001,
"heapDeltaBytes": 39122064,
"heapUsedBytes": 108450000,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 67.637,
"eventListeners": 0,
"totalBlockingTimeMs": 532,
"frameDurationMs": 34.31470588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.6290000000404,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.8810000000003,
"heapDeltaBytes": 17601700,
"heapUsedBytes": 104828128,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 166.398,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 879.6939999999722,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.79499999999933,
"heapDeltaBytes": 18237140,
"heapUsedBytes": 104535876,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 175.31999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 238,
"frameDurationMs": 25.23999999999999,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9969.202999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9079.845,
"heapDeltaBytes": -12927800,
"heapUsedBytes": 72285684,
"domNodes": -142,
"jsHeapTotalBytes": -7213056,
"scriptDurationMs": 7488.299,
"eventListeners": -78,
"totalBlockingTimeMs": 1048,
"frameDurationMs": 33.165333333333336,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11843.891000000098,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06800000000000035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10843.744,
"heapDeltaBytes": -8315444,
"heapUsedBytes": 76922252,
"domNodes": -142,
"jsHeapTotalBytes": -2756608,
"scriptDurationMs": 9095.681,
"eventListeners": -74,
"totalBlockingTimeMs": 2028,
"frameDurationMs": 35.47784431137725,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9533.321,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.38799999999999946,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8681.183,
"heapDeltaBytes": 19356916,
"heapUsedBytes": 97385528,
"domNodes": -142,
"jsHeapTotalBytes": -9048064,
"scriptDurationMs": 7132.544,
"eventListeners": -74,
"totalBlockingTimeMs": 899,
"frameDurationMs": 32.31525423728814,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10618.184000000041,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9631.513,
"heapDeltaBytes": -9635636,
"heapUsedBytes": 68844744,
"domNodes": -142,
"jsHeapTotalBytes": -9048064,
"scriptDurationMs": 7953.74,
"eventListeners": -74,
"totalBlockingTimeMs": 1311,
"frameDurationMs": 32.969875776397515,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-graph-idle",
"durationMs": 2010.9899999999925,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.0550000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.469,
"heapDeltaBytes": -10104796,
"heapUsedBytes": 78278896,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 37.561000000000014,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.613999999966,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.8779999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.914,
"heapDeltaBytes": -9927032,
"heapUsedBytes": 78946276,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 40.807,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2574.7120000000336,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.256000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1646.35,
"heapDeltaBytes": -18611732,
"heapUsedBytes": 70625184,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 880.789,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77516339869281,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2391.9730000000072,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.609000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1575.7720000000002,
"heapDeltaBytes": -15880072,
"heapUsedBytes": 69746100,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 846.855,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.783802816901417,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3746.4270000000397,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.798,
"layouts": 60,
"layoutDurationMs": 15.620999999999999,
"taskDurationMs": 1715.2020000000002,
"heapDeltaBytes": 1241836,
"heapUsedBytes": 69315356,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 812.7350000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66577777777778,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3587.7890000000434,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.194000000000003,
"layouts": 60,
"layoutDurationMs": 14.398,
"taskDurationMs": 1669.775,
"heapDeltaBytes": 1273640,
"heapUsedBytes": 70004716,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 801.6329999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574074074074,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3103.206,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.967,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1922.163,
"heapDeltaBytes": 13931300,
"heapUsedBytes": 94821376,
"domNodes": 0,
"jsHeapTotalBytes": 1241088,
"scriptDurationMs": 990.346,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75621621621622,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3136.194000000046,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.7879999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1871.7909999999997,
"heapDeltaBytes": 17591308,
"heapUsedBytes": 86747984,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 970.914,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755913978494625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.5140000000197,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.9299999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.3829999999999,
"heapDeltaBytes": -11232788,
"heapUsedBytes": 69813236,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 38.623,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.1329999999443,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.8480000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.4530000000001,
"heapDeltaBytes": -10016096,
"heapUsedBytes": 79862868,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 37.385000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.4210000000403,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.722000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.32800000000003,
"heapDeltaBytes": 10707736,
"heapUsedBytes": 74125684,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 144.294,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.7409999999809,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.803999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.08099999999996,
"heapDeltaBytes": -11947584,
"heapUsedBytes": 58075704,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 147.708,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2009.409000000005,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.065999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.75,
"heapDeltaBytes": 1049492,
"heapUsedBytes": 71086052,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.415,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.5180000000473,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.294000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.733,
"heapDeltaBytes": 1142468,
"heapUsedBytes": 69716248,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.245000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.4630000000043,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.825000000000003,
"layouts": 16,
"layoutDurationMs": 5.806,
"taskDurationMs": 775.259,
"heapDeltaBytes": -5963476,
"heapUsedBytes": 63209088,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 119.77799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.5890000000281,
"styleRecalcs": 77,
"styleRecalcDurationMs": 21.194000000000006,
"layouts": 16,
"layoutDurationMs": 5.848,
"taskDurationMs": 692.441,
"heapDeltaBytes": -41826832,
"heapUsedBytes": 68548744,
"domNodes": -270,
"jsHeapTotalBytes": -4194304,
"scriptDurationMs": 112.66500000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.825961538461534,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1483.5369999999557,
"styleRecalcs": 15,
"styleRecalcDurationMs": 32.50299999999999,
"layouts": 5,
"layoutDurationMs": 16.323,
"taskDurationMs": 1101.6120000000003,
"heapDeltaBytes": 1335984,
"heapUsedBytes": 95912200,
"domNodes": 14227,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 38.162,
"eventListeners": 2463,
"totalBlockingTimeMs": 160,
"frameDurationMs": 20.044594594594585,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9599.540999999988,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6041.706,
"heapDeltaBytes": -18770080,
"heapUsedBytes": 69813940,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 2964.443,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69495652173913,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8798.857999999997,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.552,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5804.625000000001,
"heapDeltaBytes": -16711588,
"heapUsedBytes": 72350764,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 2875.13,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69753320683112,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18121.790999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17159.908000000003,
"heapDeltaBytes": -33764796,
"heapUsedBytes": 179256896,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 337.899,
"eventListeners": -14915,
"totalBlockingTimeMs": 10,
"frameDurationMs": 30.8335604770017,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 17907.934000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17233.645000000004,
"heapDeltaBytes": -30805480,
"heapUsedBytes": 182885800,
"domNodes": -3045,
"jsHeapTotalBytes": 8409088,
"scriptDurationMs": 305.735,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.133501683501688,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 23289.647,
"styleRecalcs": 180,
"styleRecalcDurationMs": 23.455000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22894.163,
"heapDeltaBytes": -19135484,
"heapUsedBytes": 193685316,
"domNodes": -3045,
"jsHeapTotalBytes": 8601600,
"scriptDurationMs": 922.489,
"eventListeners": -14919,
"totalBlockingTimeMs": 20,
"frameDurationMs": 43.00499075785582,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 23276.731999999924,
"styleRecalcs": 181,
"styleRecalcDurationMs": 24.888999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22880.317,
"heapDeltaBytes": -33820868,
"heapUsedBytes": 189730616,
"domNodes": -3045,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 914.052,
"eventListeners": -14915,
"totalBlockingTimeMs": 12,
"frameDurationMs": 42.533089579524685,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6604.723000000035,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.239,
"layouts": 20,
"layoutDurationMs": 26.988,
"taskDurationMs": 6430.877,
"heapDeltaBytes": 1076048,
"heapUsedBytes": 214772780,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 118.576,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.0639344262295,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6429.006000000072,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.55199999999999,
"layouts": 20,
"layoutDurationMs": 24.45,
"taskDurationMs": 6306.230000000001,
"heapDeltaBytes": -13016784,
"heapUsedBytes": 214374768,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 109.29,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.95714285714286,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9521.427000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9137.311,
"heapDeltaBytes": -36040428,
"heapUsedBytes": 180775688,
"domNodes": -3045,
"jsHeapTotalBytes": 6692864,
"scriptDurationMs": 152.94200000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.478839590443684,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9448.078000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8992.751999999999,
"heapDeltaBytes": -37144256,
"heapUsedBytes": 180253692,
"domNodes": -3045,
"jsHeapTotalBytes": 5120000,
"scriptDurationMs": 167.84500000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.69757785467129,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "workflow-execution",
"durationMs": 511.3099999999804,
"styleRecalcs": 20,
"styleRecalcDurationMs": 20.839999999999996,
"layouts": 5,
"layoutDurationMs": 2.614,
"taskDurationMs": 167.91299999999998,
"heapDeltaBytes": 6092860,
"heapUsedBytes": 71840412,
"domNodes": 133,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 19.07999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 124.97099999995953,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.809000000000001,
"layouts": 3,
"layoutDurationMs": 1.0040000000000002,
"taskDurationMs": 79.19200000000001,
"heapDeltaBytes": 3755732,
"heapUsedBytes": 68913436,
"domNodes": 94,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.385999999999997,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142908,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 967.7490000000262,
"styleRecalcs": 78,
"styleRecalcDurationMs": 106.984,
"layouts": 76,
"layoutDurationMs": 26.889,
"taskDurationMs": 940.513,
"heapDeltaBytes": 18930196,
"heapUsedBytes": 84473848,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 400.632,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1020.8639999999605,
"styleRecalcs": 78,
"styleRecalcDurationMs": 110.954,
"layouts": 76,
"layoutDurationMs": 27.477999999999998,
"taskDurationMs": 985.348,
"heapDeltaBytes": 19240052,
"heapUsedBytes": 84409744,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 406.34700000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667213114754095,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1386.9260000000168,
"styleRecalcs": 78,
"styleRecalcDurationMs": 264.018,
"layouts": 76,
"layoutDurationMs": 29.097,
"taskDurationMs": 1372.731,
"heapDeltaBytes": 8272064,
"heapUsedBytes": 114989064,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 448.428,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.72151898734177,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1495.200000000068,
"styleRecalcs": 78,
"styleRecalcDurationMs": 281.833,
"layouts": 76,
"layoutDurationMs": 29.192,
"taskDurationMs": 1469.105,
"heapDeltaBytes": 8436496,
"heapUsedBytes": 115190344,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 478.278,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.74875000000002,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.56 #20485 +/- ##
============================================
Coverage 85.84% 85.85%
============================================
Files 2463 2464 +1
Lines 140822 140828 +6
Branches 38292 36327 -1965
============================================
+ Hits 120891 120906 +15
+ Misses 19553 19544 -9
Partials 378 378
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
question: Approval is BLOCKED while the matching-head CI run 37702246585 is still running E2E/ecosystem validation. No code blocker found in this backport; please wait for the final valid gates. This CI question is unanchored because it concerns workflow results outside the diff.
Direct validation at b47abe141afd9c0251a111d21ab0aaedf1c45efb in an isolated checkout with its own frozen install:
- PASS: 88 relevant frontend tests + 57 shared SSO URL tests; app/browser types, production build, changed-file type-aware lint, production ESLint (unit files ignored), format and knip. Core backport also built both OSS and Cloud distributions.
- PASS: 8 Chromium journeys on the actual Cloud production bundle/local ComfyUI backend, including pending OAuth login and signup→login→SSO, flag-off Firebase and SSO-required dialog. Auth/discovery/SSO transport are controlled fixtures; local deep-link HTML delivery models Cloud ingress.
- RED: restoring both pre-patch production callers gives 4 failed/84 passed unit tests and 2 failed OAuth browser journeys. Restoring only the old dialog mapping gives 1 failed/87 passed; dropping query preservation gives 4 failed/84 passed. Original restored: 88 unit and 8 browser PASS.
- PASS: 7 additional URL/query/hash/redirect safety boundaries. Direct GET probes on testcloud and production returned 404 JSON for
/oauth/consentand 200 HTML for/cloud/oauth/consent; current backend source also names the latter consent path. No new API response declarations or frontend-derived server facts.
NOT_RUN: live IdP/SSO callback, real customer/token exchange, other OS/browser and unrelated suites. Server route reachability and controlled navigation are distinct from live authentication. Temporary changes removed; all six PR files match the head, production output restored and checkout clean.
Backport of #20468 to
core/1.56Automatically created by backport workflow.