Repository navigation
[backport cloud/1.56] FE-3293 fix(billing): offer "Cancel payment and try again" when the server says the payment is cancelable - #20460
Conversation
…erver says the payment is cancelable (#20430) ## Why QA 1.56: buy Creator with a 3DS card, upgrade to Pro, fail the 3DS. "Confirm upgrade" stays disabled. The plan-change op stays `pending` (`failed_retryable`, `awaiting_invoice_payment`) for up to ~23h, and the server refuses a new subscribe while it is open. The customer is stuck with no way out. ## Root cause The plan-change confirm locks while an earlier payment needs the customer. `isVerificationRecoveryActive` holds it for `failed_retryable` under embedded checkout, and the in-app `isSubscribing` stays busy because the subscribe waits on a terminal that never comes. Nothing on the confirm can end the stuck attempt. `POST /api/billing/ops/{id}/cancel` exists, but the confirm had no server signal for when it would work. cloud#12343 adds that signal: `cancelable` on `GET /api/billing/ops/{id}`. ## How - **SDK (`account-core`):** `PendingBillingOperation.cancelable` carries each poll's `cancelable` from the generated, zod-validated `BillingOpStatusResponse`. Absent means no claim, and a later poll replaces an earlier one. A cancel refusal (`NOT_CANCELABLE` / `PAYMENT_IN_FLIGHT`) now keeps the server's `serverMessage`. The existing `commands.cancelOperation` is reused; it already wakes the lifecycle. - **Shared confirm (`account-ui`):** `CheckoutTransitionConfirm` takes `paymentCancelable`, `cancelingPayment` and `cancelPaymentError`, and emits `cancelPayment`. It shows a secondary "Cancel payment and try again" with a busy state and the failure sentence. The confirm's busy state doesn't block it. - **billing-web `CheckoutView`:** offers the action only when `pendingOperation.cancelable === true`. It calls `commands.cancelOperation` once (single flight). On failure it shows `serverMessage`, or the generic copy when there is none. - **Cloud app (`useSubscriptionCheckout`, SDK rail):** the rail record projects `cancelable` (`=== true`). `billingSdkStore.cancelOperation` projects the result, and failures carry `serverMessage`. Both transition dialogs pass the action through `SubscriptionTransitionPreviewWorkspace`. - **No inference of server state:** the action is gated only on `cancelable === true` and never derived from status, phase, `authentication_state` or challenge. After the cancel, the lifecycle's own re-read settles the op to `failed` (recovery `retry`). The existing failed path then releases the confirm. Nothing fakes a local state. - **Limitation:** the legacy (non-SDK) subscription rail has no `cancelable` and no op-cancel command, so it shows nothing there. ## AS IS / TO BE | AS IS | TO BE | | --- | --- | | _pending capture_ | _pending capture_ | ## Test plan - [x] `account-core`: `operationState.test.ts` covers the latest poll's `cancelable` (true / false / absent). `subscriptionCommands.test.ts` covers that a refusal carries `serverMessage`. - [x] `account-ui`: `CheckoutTransitionConfirm.test.ts` checks the action shows only for `paymentCancelable` true (false/absent show nothing), one emit per click even while the confirm is busy, the busy state, and the failure sentence. - [x] billing-web: `CheckoutView.test.ts` checks the action shows only for `cancelable: true`. One click calls `cancelOperation('op_1')` exactly once, and once the op settles to failed, "Confirm upgrade" is enabled and the action is gone. A refused or failed cancel shows the server's sentence. - [x] app: `operationRecordView.test.ts`, `subscriptionOperationView.test.ts` and `useSubscriptionCheckout.test.ts` cover the rail cancel (once, busy, `serverMessage`). - [ ] Manual: reproduce the QA steps against an env with cloud#12343. Check that the action appears, the cancel settles the op, and "Confirm upgrade" is usable again. Commits: `test(billing)` (red) then `fix(billing)` (green). The red commit adds the shared confirm's presentational props so the host tests compile under the pre-commit typecheck. ## Plan position | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Server `cancelable` on op status | - | cloud#12343 | merged | | Ingest types sync | - | #20408 | open | | **Cancel payment and try again** | **FE-3293** | **this PR** | **open** | ```mermaid graph LR A["cloud PR 12343: cancelable"] --> B["PR 20408: ingest types"] B --> C["FE-3293: cancel and try again"] style C fill:#f9d71c,stroke:#333,stroke-width:2px ``` Stacked on #20408 (`update-ingest-types`). It gets retargeted to `main` after that merges. - Fixes FE-3293 - QA report (original thread): https://comfy-organization.slack.com/archives/C0932CGKT5K/p1791358396550379?thread_ts=1791246295.718539&cid=C0932CGKT5K --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c4e1215216f60b10ebf884dde19557f8af5c25a1
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2202 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-07T21:12:48.793Z",
"gitSha": "74ca2048c93c34d75a88a01491d52bf624e3fd3d",
"branch": "backport-20430-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2013.8130000000274,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.6740000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.66999999999996,
"heapDeltaBytes": 532924,
"heapUsedBytes": 69263564,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.754000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2007.1239999999761,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.194999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.576,
"heapDeltaBytes": 547692,
"heapUsedBytes": 69237164,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.427000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1860.227000000009,
"styleRecalcs": 79,
"styleRecalcDurationMs": 18.431000000000004,
"layouts": 12,
"layoutDurationMs": 4.320000000000001,
"taskDurationMs": 819.2850000000001,
"heapDeltaBytes": -2431728,
"heapUsedBytes": 65821468,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 166.81099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1844.7350000000142,
"styleRecalcs": 74,
"styleRecalcDurationMs": 18.195,
"layouts": 12,
"layoutDurationMs": 4.604,
"taskDurationMs": 808.373,
"heapDeltaBytes": -2214192,
"heapUsedBytes": 65161796,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 165.688,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.32999999997,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.736999999999998,
"layouts": 6,
"layoutDurationMs": 1.16,
"taskDurationMs": 336.055,
"heapDeltaBytes": 25829412,
"heapUsedBytes": 80069448,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.810999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.9470000000238,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.440999999999997,
"layouts": 6,
"layoutDurationMs": 1.164,
"taskDurationMs": 339.526,
"heapDeltaBytes": 3767928,
"heapUsedBytes": 70903032,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.744000000000005,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 730.6889999999839,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.168,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.804,
"heapDeltaBytes": -6427952,
"heapUsedBytes": 61251736,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 169.768,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 702.7839999999514,
"styleRecalcs": 16,
"styleRecalcDurationMs": 3.835999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.031,
"heapDeltaBytes": -7067988,
"heapUsedBytes": 61379904,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 166.08299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1173.1889999999794,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 825.323,
"heapDeltaBytes": 15944676,
"heapUsedBytes": 84949908,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 68.717,
"eventListeners": 0,
"totalBlockingTimeMs": 535,
"frameDurationMs": 34.31176470588236,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1145.1330000001008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 809.567,
"heapDeltaBytes": 12101076,
"heapUsedBytes": 81516956,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 89.12900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 525,
"frameDurationMs": 33.82058823529413,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.3910000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.81000000000006,
"heapDeltaBytes": 16582632,
"heapUsedBytes": 103745688,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 165.39900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.0080000000735,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.97299999999996,
"heapDeltaBytes": 17758212,
"heapUsedBytes": 105022156,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 167.11299999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9111.573999999962,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.4369999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8415.633999999998,
"heapDeltaBytes": 1738636,
"heapUsedBytes": 80481788,
"domNodes": -172,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 7136.297,
"eventListeners": -78,
"totalBlockingTimeMs": 985,
"frameDurationMs": 35.334883720930236,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9717.61600000002,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.059000000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8817.117,
"heapDeltaBytes": 8851556,
"heapUsedBytes": 94378176,
"domNodes": -172,
"jsHeapTotalBytes": -4853760,
"scriptDurationMs": 7295.335,
"eventListeners": -78,
"totalBlockingTimeMs": 923,
"frameDurationMs": 32.2797342192691,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10358.98499999996,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.653,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9517.369,
"heapDeltaBytes": 9420648,
"heapUsedBytes": 94127656,
"domNodes": -142,
"jsHeapTotalBytes": -9048064,
"scriptDurationMs": 7911.346,
"eventListeners": -74,
"totalBlockingTimeMs": 1009,
"frameDurationMs": 32.96050955414013,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9303.585999999996,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8920000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8494.422999999999,
"heapDeltaBytes": 6223080,
"heapUsedBytes": 84083800,
"domNodes": -142,
"jsHeapTotalBytes": -8523776,
"scriptDurationMs": 6964.751,
"eventListeners": -74,
"totalBlockingTimeMs": 705,
"frameDurationMs": 32.17854671280277,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2018.7199999999734,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.8369999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.5799999999999,
"heapDeltaBytes": -10142524,
"heapUsedBytes": 78421620,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.92100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2007.6249999999618,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.139,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.779,
"heapDeltaBytes": -9966060,
"heapUsedBytes": 79003184,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.882999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2612.282999999991,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.587,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1656.2350000000001,
"heapDeltaBytes": -8280312,
"heapUsedBytes": 77864768,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 866.991,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2366.158999999925,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.901000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1589.3520000000003,
"heapDeltaBytes": -19486712,
"heapUsedBytes": 70620308,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 839.506,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666197183098593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3603.5270000000423,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.548000000000002,
"layouts": 60,
"layoutDurationMs": 14.812,
"taskDurationMs": 1664.867,
"heapDeltaBytes": 1553120,
"heapUsedBytes": 69593788,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 787.659,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589861751152,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3609.8779999999806,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.695000000000002,
"layouts": 60,
"layoutDurationMs": 14.427999999999999,
"taskDurationMs": 1664.0680000000002,
"heapDeltaBytes": -20888304,
"heapUsedBytes": 70166432,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 789.176,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665898617511527,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3128.0360000000087,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.79,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1889.3439999999998,
"heapDeltaBytes": -11098920,
"heapUsedBytes": 72584936,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 965.1359999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.846486486486487,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3155.2689999999757,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.19,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1815.6,
"heapDeltaBytes": 5503472,
"heapUsedBytes": 73708384,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 951.4999999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755080213903742,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2013.1309999999871,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.608,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.862,
"heapDeltaBytes": -9207012,
"heapUsedBytes": 80353600,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.05799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.899000000014,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.835,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.85600000000005,
"heapDeltaBytes": -11240708,
"heapUsedBytes": 69787120,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 33.708,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 665.2589999999918,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.358999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.008,
"heapDeltaBytes": -11979832,
"heapUsedBytes": 57463080,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 150.933,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 623.0349999999589,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.402000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.02200000000005,
"heapDeltaBytes": 12068208,
"heapUsedBytes": 79644828,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 143.419,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2019.9460000000045,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.7410000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.44399999999996,
"heapDeltaBytes": 1029800,
"heapUsedBytes": 71199088,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.839,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.1490000000604,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.665000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.009,
"heapDeltaBytes": 1099436,
"heapUsedBytes": 71146588,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.979000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1697.449000000006,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.945000000000004,
"layouts": 16,
"layoutDurationMs": 5.3020000000000005,
"taskDurationMs": 744.599,
"heapDeltaBytes": -5965636,
"heapUsedBytes": 64796280,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 111.61200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.8469999999543,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.358,
"layouts": 16,
"layoutDurationMs": 5.632,
"taskDurationMs": 758.815,
"heapDeltaBytes": -5939164,
"heapUsedBytes": 63503916,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 113.15599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.4749999999913,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.70199999999999,
"layouts": 5,
"layoutDurationMs": 14.696999999999997,
"taskDurationMs": 941.1530000000001,
"heapDeltaBytes": 1312372,
"heapUsedBytes": 94479408,
"domNodes": 14227,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 31.093999999999998,
"eventListeners": 2463,
"totalBlockingTimeMs": 134,
"frameDurationMs": 19.370270270270264,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8845.520000000022,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.426,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5952.91,
"heapDeltaBytes": -12184012,
"heapUsedBytes": 77277116,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2987.5409999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69735349716446,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8604.917000000001,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.339999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5556.51,
"heapDeltaBytes": 11104576,
"heapUsedBytes": 90504520,
"domNodes": 0,
"jsHeapTotalBytes": 491520,
"scriptDurationMs": 2739.297,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17901.921000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17005.854,
"heapDeltaBytes": -33348040,
"heapUsedBytes": 179578600,
"domNodes": -3046,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 278.80499999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.184148397976394,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 17970.48599999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17143.525,
"heapDeltaBytes": -33382612,
"heapUsedBytes": 180322788,
"domNodes": -3045,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 278.67400000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.165684575389946,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-pan",
"durationMs": 21772.51000000001,
"styleRecalcs": 172,
"styleRecalcDurationMs": 19.45099999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21342.516,
"heapDeltaBytes": -20115344,
"heapUsedBytes": 193080688,
"domNodes": -3045,
"jsHeapTotalBytes": 6766592,
"scriptDurationMs": 861.5699999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.08416206261509,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 23174.919000000045,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.899999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22706.523,
"heapDeltaBytes": -49583740,
"heapUsedBytes": 166980164,
"domNodes": -3045,
"jsHeapTotalBytes": 5120000,
"scriptDurationMs": 921.2439999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 7,
"frameDurationMs": 42.614705882352936,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6561.126999999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.88500000000002,
"layouts": 20,
"layoutDurationMs": 23.679000000000006,
"taskDurationMs": 6379.728000000001,
"heapDeltaBytes": -12810392,
"heapUsedBytes": 214176588,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 112.015,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.09830508474576,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6639.716000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.01200000000003,
"layouts": 20,
"layoutDurationMs": 23.804000000000006,
"taskDurationMs": 6481.3640000000005,
"heapDeltaBytes": 15009948,
"heapUsedBytes": 214260704,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 111.54299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.66182795698924,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8965.283999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8679.893000000002,
"heapDeltaBytes": -33631548,
"heapUsedBytes": 180748632,
"domNodes": -3045,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 136.01700000000005,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.860689655172422,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8975.416999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8657.212,
"heapDeltaBytes": -34245020,
"heapUsedBytes": 179767780,
"domNodes": -3045,
"jsHeapTotalBytes": 5787648,
"scriptDurationMs": 191.57899999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 7,
"frameDurationMs": 30.917931034482763,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 129.46199999998953,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.440000000000001,
"layouts": 4,
"layoutDurationMs": 2.236,
"taskDurationMs": 99.81499999999998,
"heapDeltaBytes": 3949200,
"heapUsedBytes": 63446284,
"domNodes": 98,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.793,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.649999999999977,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 484.70499999996264,
"styleRecalcs": 19,
"styleRecalcDurationMs": 15.818000000000001,
"layouts": 3,
"layoutDurationMs": 1.362,
"taskDurationMs": 125.20599999999999,
"heapDeltaBytes": 5807092,
"heapUsedBytes": 71187508,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.491000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 875.0250000000506,
"styleRecalcs": 78,
"styleRecalcDurationMs": 101.3,
"layouts": 76,
"layoutDurationMs": 24.676,
"taskDurationMs": 844.182,
"heapDeltaBytes": 17686220,
"heapUsedBytes": 82806376,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 347.34999999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 890.9820000000082,
"styleRecalcs": 78,
"styleRecalcDurationMs": 102.033,
"layouts": 76,
"layoutDurationMs": 26.195,
"taskDurationMs": 855.157,
"heapDeltaBytes": 17850436,
"heapUsedBytes": 84275432,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 349.272,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664814814814807,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1383.9140000000043,
"styleRecalcs": 78,
"styleRecalcDurationMs": 257.983,
"layouts": 76,
"layoutDurationMs": 29.062,
"taskDurationMs": 1365.9439999999997,
"heapDeltaBytes": 8308468,
"heapUsedBytes": 114434768,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 458.501,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.718987341772166,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1450.2320000000282,
"styleRecalcs": 78,
"styleRecalcDurationMs": 278.67199999999997,
"layouts": 76,
"layoutDurationMs": 29.426000000000002,
"taskDurationMs": 1426.202,
"heapDeltaBytes": 8488680,
"heapUsedBytes": 115081504,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 470.51,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.354430379746834,
"p95FrameDurationMs": 33.399999999999636
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.56 #20460 +/- ##
=============================================
Coverage ? 85.19%
=============================================
Files ? 3499
Lines ? 168403
Branches ? 46152
=============================================
Hits ? 143469
Misses ? 22951
Partials ? 1983
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Diff matches the #20430 squash commit line for line.
Backport of #20430 to
cloud/1.56Automatically created by backport workflow.