Repository navigation
[backport core/1.56] FE-3293 fix(billing): offer "Cancel payment and try again" when the server says the payment is cancelable - #20459
Conversation
…erver says the payment is cancelable (#20430) ## Why QA 1.56: buy Creator with a 3DS card, upgrade to Pro, fail the 3DS. "Confirm upgrade" stays disabled. The plan-change op stays `pending` (`failed_retryable`, `awaiting_invoice_payment`) for up to ~23h, and the server refuses a new subscribe while it is open. The customer is stuck with no way out. ## Root cause The plan-change confirm locks while an earlier payment needs the customer. `isVerificationRecoveryActive` holds it for `failed_retryable` under embedded checkout, and the in-app `isSubscribing` stays busy because the subscribe waits on a terminal that never comes. Nothing on the confirm can end the stuck attempt. `POST /api/billing/ops/{id}/cancel` exists, but the confirm had no server signal for when it would work. cloud#12343 adds that signal: `cancelable` on `GET /api/billing/ops/{id}`. ## How - **SDK (`account-core`):** `PendingBillingOperation.cancelable` carries each poll's `cancelable` from the generated, zod-validated `BillingOpStatusResponse`. Absent means no claim, and a later poll replaces an earlier one. A cancel refusal (`NOT_CANCELABLE` / `PAYMENT_IN_FLIGHT`) now keeps the server's `serverMessage`. The existing `commands.cancelOperation` is reused; it already wakes the lifecycle. - **Shared confirm (`account-ui`):** `CheckoutTransitionConfirm` takes `paymentCancelable`, `cancelingPayment` and `cancelPaymentError`, and emits `cancelPayment`. It shows a secondary "Cancel payment and try again" with a busy state and the failure sentence. The confirm's busy state doesn't block it. - **billing-web `CheckoutView`:** offers the action only when `pendingOperation.cancelable === true`. It calls `commands.cancelOperation` once (single flight). On failure it shows `serverMessage`, or the generic copy when there is none. - **Cloud app (`useSubscriptionCheckout`, SDK rail):** the rail record projects `cancelable` (`=== true`). `billingSdkStore.cancelOperation` projects the result, and failures carry `serverMessage`. Both transition dialogs pass the action through `SubscriptionTransitionPreviewWorkspace`. - **No inference of server state:** the action is gated only on `cancelable === true` and never derived from status, phase, `authentication_state` or challenge. After the cancel, the lifecycle's own re-read settles the op to `failed` (recovery `retry`). The existing failed path then releases the confirm. Nothing fakes a local state. - **Limitation:** the legacy (non-SDK) subscription rail has no `cancelable` and no op-cancel command, so it shows nothing there. ## AS IS / TO BE | AS IS | TO BE | | --- | --- | | _pending capture_ | _pending capture_ | ## Test plan - [x] `account-core`: `operationState.test.ts` covers the latest poll's `cancelable` (true / false / absent). `subscriptionCommands.test.ts` covers that a refusal carries `serverMessage`. - [x] `account-ui`: `CheckoutTransitionConfirm.test.ts` checks the action shows only for `paymentCancelable` true (false/absent show nothing), one emit per click even while the confirm is busy, the busy state, and the failure sentence. - [x] billing-web: `CheckoutView.test.ts` checks the action shows only for `cancelable: true`. One click calls `cancelOperation('op_1')` exactly once, and once the op settles to failed, "Confirm upgrade" is enabled and the action is gone. A refused or failed cancel shows the server's sentence. - [x] app: `operationRecordView.test.ts`, `subscriptionOperationView.test.ts` and `useSubscriptionCheckout.test.ts` cover the rail cancel (once, busy, `serverMessage`). - [ ] Manual: reproduce the QA steps against an env with cloud#12343. Check that the action appears, the cancel settles the op, and "Confirm upgrade" is usable again. Commits: `test(billing)` (red) then `fix(billing)` (green). The red commit adds the shared confirm's presentational props so the host tests compile under the pre-commit typecheck. ## Plan position | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Server `cancelable` on op status | - | cloud#12343 | merged | | Ingest types sync | - | #20408 | open | | **Cancel payment and try again** | **FE-3293** | **this PR** | **open** | ```mermaid graph LR A["cloud PR 12343: cancelable"] --> B["PR 20408: ingest types"] B --> C["FE-3293: cancel and try again"] style C fill:#f9d71c,stroke:#333,stroke-width:2px ``` Stacked on #20408 (`update-ingest-types`). It gets retargeted to `main` after that merges. - Fixes FE-3293 - QA report (original thread): https://comfy-organization.slack.com/archives/C0932CGKT5K/p1791358396550379?thread_ts=1791246295.718539&cid=C0932CGKT5K --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3cc6fb242a9cd331e95c826af02bfea67990b5c5
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2196 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-07T21:10:21.621Z",
"gitSha": "ddb7ec64ab20289543fe4f5ca2b3a3938467bd0b",
"branch": "backport-20430-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2016.6870000000472,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.2840000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.985,
"heapDeltaBytes": 572312,
"heapUsedBytes": 68579440,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.731000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.2809999999072,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.869,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.60400000000004,
"heapDeltaBytes": 904764,
"heapUsedBytes": 68441528,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.623,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1685.7180000000085,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.854,
"layouts": 12,
"layoutDurationMs": 3.693,
"taskDurationMs": 614.258,
"heapDeltaBytes": -6308996,
"heapUsedBytes": 55100036,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.76799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.8100000000513,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.966000000000001,
"layouts": 12,
"layoutDurationMs": 3.4670000000000005,
"taskDurationMs": 631.172,
"heapDeltaBytes": -2053708,
"heapUsedBytes": 65977928,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 119.02499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.3340000000085,
"styleRecalcs": 32,
"styleRecalcDurationMs": 8.479000000000001,
"layouts": 6,
"layoutDurationMs": 1.177,
"taskDurationMs": 272.22799999999995,
"heapDeltaBytes": 3667828,
"heapUsedBytes": 72470480,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.889999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.1879999999464,
"styleRecalcs": 32,
"styleRecalcDurationMs": 8.542,
"layouts": 6,
"layoutDurationMs": 1.003,
"taskDurationMs": 266.95000000000005,
"heapDeltaBytes": 3793264,
"heapUsedBytes": 71626868,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.921,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 550.0010000000088,
"styleRecalcs": 16,
"styleRecalcDurationMs": 3.8589999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.0650000000001,
"heapDeltaBytes": -6863204,
"heapUsedBytes": 61600804,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 135.98499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 563.9100000000781,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.4920000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.606,
"heapDeltaBytes": -6481152,
"heapUsedBytes": 61068528,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 134.42499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670588235294108,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1008.9249999999765,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 644.4239999999999,
"heapDeltaBytes": 15460816,
"heapUsedBytes": 85316112,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 46.803999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 392,
"frameDurationMs": 30.80606060606059,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1002.6629999999841,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.788,
"heapDeltaBytes": 15127636,
"heapUsedBytes": 84853700,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 48.40199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 368,
"frameDurationMs": 29.41176470588235,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 784.4100000000367,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.0740000000001,
"heapDeltaBytes": 18248980,
"heapUsedBytes": 104034416,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 119.95999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 23.035294117647055,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 784.8930000000109,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.79500000000024,
"heapDeltaBytes": 18451576,
"heapUsedBytes": 105021528,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 126.36899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 163,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7245.177000000012,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.254,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6420.022,
"heapDeltaBytes": 3146956,
"heapUsedBytes": 72847472,
"domNodes": -142,
"jsHeapTotalBytes": -11407360,
"scriptDurationMs": 5221.308000000001,
"eventListeners": -74,
"totalBlockingTimeMs": 106,
"frameDurationMs": 25.924731182795696,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6896.168999999986,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9689999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6214.736999999999,
"heapDeltaBytes": 11587072,
"heapUsedBytes": 96228692,
"domNodes": -142,
"jsHeapTotalBytes": -7737344,
"scriptDurationMs": 4995.389999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 1,
"frameDurationMs": 24.938405797101446,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6974.287000000004,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8780000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6350.891,
"heapDeltaBytes": -850300,
"heapUsedBytes": 84809196,
"domNodes": -148,
"jsHeapTotalBytes": -8785920,
"scriptDurationMs": 5189.576,
"eventListeners": -82,
"totalBlockingTimeMs": 106,
"frameDurationMs": 25.994029850746266,
"p95FrameDurationMs": 49.900000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6589.572999999973,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9150000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6015.872,
"heapDeltaBytes": -3284956,
"heapUsedBytes": 81923736,
"domNodes": -142,
"jsHeapTotalBytes": -10620928,
"scriptDurationMs": 4865.439,
"eventListeners": -78,
"totalBlockingTimeMs": 48,
"frameDurationMs": 25.22222222222222,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-graph-idle",
"durationMs": 2008.5809999999924,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.701,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.48199999999997,
"heapDeltaBytes": -11339252,
"heapUsedBytes": 68707944,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.676999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2009.12500000004,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9580000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.59299999999996,
"heapDeltaBytes": -11618532,
"heapUsedBytes": 68349316,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 29.14100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2122.793999999999,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.849999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1232.062,
"heapDeltaBytes": -19440632,
"heapUsedBytes": 70568556,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 661.2620000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66614173228346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2119.070000000079,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.597999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1237.3860000000002,
"heapDeltaBytes": -18680828,
"heapUsedBytes": 71075392,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 668.4559999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665354330708663,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3164.4900000000007,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.388999999999998,
"layouts": 60,
"layoutDurationMs": 13.274,
"taskDurationMs": 1310.816,
"heapDeltaBytes": 1248968,
"heapUsedBytes": 69449208,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 625.541,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66578947368421,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3221.6580000000477,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.434999999999999,
"layouts": 60,
"layoutDurationMs": 13.164,
"taskDurationMs": 1317.146,
"heapDeltaBytes": 1948536,
"heapUsedBytes": 69970308,
"domNodes": 24,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 631.329,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528497409326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2289.322000000027,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.535000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1543.247,
"heapDeltaBytes": 5502540,
"heapUsedBytes": 74547576,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 828.2570000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.788970588235294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2256.9409999999834,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.287,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1516.6529999999998,
"heapDeltaBytes": 3998308,
"heapUsedBytes": 73041108,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 797.3950000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.791044776119403,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.117000000018,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.747000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.041,
"heapDeltaBytes": -9575532,
"heapUsedBytes": 80379572,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 28.006000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.3000000000202,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.838,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.3089999999999,
"heapDeltaBytes": -8574604,
"heapUsedBytes": 81387900,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 27.884000000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 493.9480000000458,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.733999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 324.73600000000005,
"heapDeltaBytes": -11996304,
"heapUsedBytes": 58164792,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 118.07799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 533.0159999999751,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.8180000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.99,
"heapDeltaBytes": -11981016,
"heapUsedBytes": 58415928,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 120.02099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2021.6090000000122,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.109,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.315,
"heapDeltaBytes": -2951312,
"heapUsedBytes": 61115468,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.11,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.8380000000825,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.2379999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 324.73799999999994,
"heapDeltaBytes": 975412,
"heapUsedBytes": 71803176,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.089999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.5019999999804,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.302999999999999,
"layouts": 16,
"layoutDurationMs": 4.9830000000000005,
"taskDurationMs": 588.1149999999999,
"heapDeltaBytes": 16485540,
"heapUsedBytes": 78667276,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 83.544,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.1090000000395,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.06,
"layouts": 16,
"layoutDurationMs": 4.928,
"taskDurationMs": 589.445,
"heapDeltaBytes": -6262180,
"heapUsedBytes": 63342804,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 84.616,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 884.5749999999271,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.313,
"layouts": 5,
"layoutDurationMs": 10.666000000000002,
"taskDurationMs": 690.078,
"heapDeltaBytes": -2534604,
"heapUsedBytes": 90460572,
"domNodes": 14227,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 20.732,
"eventListeners": 2463,
"totalBlockingTimeMs": 85,
"frameDurationMs": 19.202173913043463,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8146.618999999987,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.577999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4293.416,
"heapDeltaBytes": -18294860,
"heapUsedBytes": 70536608,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2178.199,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665848670756645,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8147.330000000011,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.352999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4341.786,
"heapDeltaBytes": -17821216,
"heapUsedBytes": 71009804,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2190.614,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666053169734152,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15428.720999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14640.179,
"heapDeltaBytes": -25455664,
"heapUsedBytes": 180494296,
"domNodes": -3044,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 217.105,
"eventListeners": -14907,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.83947826086957,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 14604.713999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14020.569000000001,
"heapDeltaBytes": -32052680,
"heapUsedBytes": 181713144,
"domNodes": -3045,
"jsHeapTotalBytes": 8933376,
"scriptDurationMs": 207.353,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.17137931034483,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 17167.489999999987,
"styleRecalcs": 141,
"styleRecalcDurationMs": 15.390999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16815.035000000003,
"heapDeltaBytes": -50876724,
"heapUsedBytes": 167135800,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 701.213,
"eventListeners": -14915,
"totalBlockingTimeMs": 4,
"frameDurationMs": 32.38867924528302,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 17985.957999999984,
"styleRecalcs": 149,
"styleRecalcDurationMs": 15.639999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17556.287,
"heapDeltaBytes": -35949028,
"heapUsedBytes": 186507624,
"domNodes": -3045,
"jsHeapTotalBytes": 630784,
"scriptDurationMs": 714.756,
"eventListeners": -14915,
"totalBlockingTimeMs": 6,
"frameDurationMs": 33.455947955390336,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5497.096,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.713000000000015,
"layouts": 20,
"layoutDurationMs": 22.174,
"taskDurationMs": 5404.096,
"heapDeltaBytes": -17088388,
"heapUsedBytes": 217604964,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 90.774,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.16024844720498,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 5489.821000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.86,
"layouts": 20,
"layoutDurationMs": 22.765000000000008,
"taskDurationMs": 5388.974999999999,
"heapDeltaBytes": 965108,
"heapUsedBytes": 207616556,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 89.338,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.23151515151515,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7528.926000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7251.619,
"heapDeltaBytes": -22132644,
"heapUsedBytes": 181366876,
"domNodes": -3045,
"jsHeapTotalBytes": 7622656,
"scriptDurationMs": 107.209,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.065743944636672,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5662.587999999914,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5340.4540000000015,
"heapDeltaBytes": -32267348,
"heapUsedBytes": 185848824,
"domNodes": -3046,
"jsHeapTotalBytes": 13770752,
"scriptDurationMs": 83.55799999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.339249146757684,
"p95FrameDurationMs": 33.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 86.25899999992725,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.482999999999999,
"layouts": 3,
"layoutDurationMs": 0.8089999999999998,
"taskDurationMs": 63.92400000000001,
"heapDeltaBytes": 3917580,
"heapUsedBytes": 69525088,
"domNodes": 97,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.290999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.68333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 438.93100000002505,
"styleRecalcs": 14,
"styleRecalcDurationMs": 11.149000000000001,
"layouts": 3,
"layoutDurationMs": 0.825,
"taskDurationMs": 88.368,
"heapDeltaBytes": 5557232,
"heapUsedBytes": 70387392,
"domNodes": 99,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.306000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 554.102999999941,
"styleRecalcs": 78,
"styleRecalcDurationMs": 79.119,
"layouts": 76,
"layoutDurationMs": 19.146,
"taskDurationMs": 531.293,
"heapDeltaBytes": -17290112,
"heapUsedBytes": 64602236,
"domNodes": 76,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 200.62800000000001,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 492.4740000000156,
"styleRecalcs": 78,
"styleRecalcDurationMs": 74.332,
"layouts": 76,
"layoutDurationMs": 17.87,
"taskDurationMs": 466.48199999999997,
"heapDeltaBytes": -17780720,
"heapUsedBytes": 64370472,
"domNodes": 76,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 168.711,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1089.776000000029,
"styleRecalcs": 78,
"styleRecalcDurationMs": 237.991,
"layouts": 76,
"layoutDurationMs": 23.904999999999998,
"taskDurationMs": 1062.97,
"heapDeltaBytes": 12142728,
"heapUsedBytes": 138015268,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 318.08599999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.921538461538457,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1146.425000000022,
"styleRecalcs": 78,
"styleRecalcDurationMs": 249.414,
"layouts": 76,
"layoutDurationMs": 24.514,
"taskDurationMs": 1119.463,
"heapDeltaBytes": 7517336,
"heapUsedBytes": 113642776,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 343.683,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.56 #20459 +/- ##
=============================================
- Coverage 85.83% 85.09% -0.75%
=============================================
Files 2462 3499 +1037
Lines 140674 168446 +27772
Branches 38242 46149 +7907
=============================================
+ Hits 120747 143335 +22588
- Misses 19549 23128 +3579
- Partials 378 1983 +1605
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1036 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Diff matches the #20430 squash commit line for line.
Backport of #20430 to
core/1.56Automatically created by backport workflow.