Repository navigation
[backport core/1.56] FE-3293 chore(ingest-types): sync from cloud@7c76793 and read the op plan's prices as numbers - #20454
Conversation
…plan's prices as numbers (#20448) The bot sync #20408 (cloud@7c76793) is red, and the 1.56 QA fixes stack on these types (FE-3293 #20430; FE-3292 next). cloud#12343 / #12371 added `cancelable` and the op plan's `tier` / `price_cents` / `monthly_price_cents` / `currency` / `team_credit_stop_id` to `BillingOpStatusResponse`. The new plan prices are int64, so the generated zod coerces them to `bigint`, while the generated TS type says `number`. `BillingOpStatusSchema` in account-core already maps the other cents fields through `wireCents`, but not these two, so `BillingOpStatus` stopped accepting a `BillingOpStatusResponse` (typecheck failure in `customerActionParity.test.ts`). - The bot's regenerated `packages/ingest-types`, unchanged. - `BillingOpStatusSchema` extends `plan` with `price_cents` / `monthly_price_cents` read through `wireCents`, the same way as `amount_charged_cents` and `credits_added`. Not user-facing: types plus schema only. AS IS is CI typecheck red on - [x] account-core `src/core/billing`: 736 passed - [x] `typecheck:app` and `typecheck:account-core` (pre-commit) Supersedes #20408. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit eeaf6ed)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c9fb98ab4c49368381206cd0bfb1a1782b4567ee
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2200 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-07T19:38:22.020Z",
"gitSha": "e1f0538f3faaac080c724d0d40e65a16238433a5",
"branch": "backport-20448-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.6900000000114,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4999999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.478,
"heapDeltaBytes": 556752,
"heapUsedBytes": 69128732,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.626000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2016.8560000000753,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.681,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.42,
"heapDeltaBytes": 624120,
"heapUsedBytes": 68335428,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.549,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.9310000000419,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.69,
"layouts": 12,
"layoutDurationMs": 4.231,
"taskDurationMs": 738.4409999999999,
"heapDeltaBytes": -2151696,
"heapUsedBytes": 65982572,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 155.035,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1771.1380000000645,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.112000000000002,
"layouts": 12,
"layoutDurationMs": 4.138,
"taskDurationMs": 747.66,
"heapDeltaBytes": -2469984,
"heapUsedBytes": 65590768,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 149.94199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.7519999999713,
"styleRecalcs": 32,
"styleRecalcDurationMs": 8.653999999999998,
"layouts": 6,
"layoutDurationMs": 1.007,
"taskDurationMs": 324.82599999999996,
"heapDeltaBytes": 4022056,
"heapUsedBytes": 72084924,
"domNodes": 53,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.904000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1716.256000000044,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.515000000000002,
"layouts": 6,
"layoutDurationMs": 1.094,
"taskDurationMs": 322.2970000000001,
"heapDeltaBytes": 3997372,
"heapUsedBytes": 71963936,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.500000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 677.8140000000121,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.5060000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.80600000000004,
"heapDeltaBytes": -6758116,
"heapUsedBytes": 61345012,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 164.795,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 676.0189999999966,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.441999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.42900000000003,
"heapDeltaBytes": -6875416,
"heapUsedBytes": 61967892,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.126,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1130.2060000000438,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 772.6939999999998,
"heapDeltaBytes": 15426988,
"heapUsedBytes": 85710432,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 63.594999999999985,
"eventListeners": 0,
"totalBlockingTimeMs": 496,
"frameDurationMs": 33.332352941176474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1157.3969999999463,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 799.378,
"heapDeltaBytes": 12355776,
"heapUsedBytes": 81065512,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 68.055,
"eventListeners": 0,
"totalBlockingTimeMs": 523,
"frameDurationMs": 33.82058823529411,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.4009999999575,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.645,
"heapDeltaBytes": 18476848,
"heapUsedBytes": 105085852,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 157.235,
"eventListeners": 0,
"totalBlockingTimeMs": 213,
"frameDurationMs": 24.997058823529454,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.810000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.568,
"heapDeltaBytes": 18251920,
"heapUsedBytes": 104635336,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 161.028,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9161.775999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8418.150000000001,
"heapDeltaBytes": -9472376,
"heapUsedBytes": 75890464,
"domNodes": -142,
"jsHeapTotalBytes": -1445888,
"scriptDurationMs": 7208.233,
"eventListeners": -78,
"totalBlockingTimeMs": 1148,
"frameDurationMs": 36.02204724409449,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9160.59699999994,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05400000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8344.811,
"heapDeltaBytes": -1347944,
"heapUsedBytes": 83426240,
"domNodes": -142,
"jsHeapTotalBytes": -10620928,
"scriptDurationMs": 6891.674,
"eventListeners": -74,
"totalBlockingTimeMs": 588,
"frameDurationMs": 32.67714285714286,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9074.915000000034,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.7120000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8449.777000000002,
"heapDeltaBytes": -3894608,
"heapUsedBytes": 81025176,
"domNodes": -142,
"jsHeapTotalBytes": -8261632,
"scriptDurationMs": 6979.391,
"eventListeners": -74,
"totalBlockingTimeMs": 685,
"frameDurationMs": 33.70371747211896,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8692.764999999894,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.935,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8044.455000000001,
"heapDeltaBytes": -4173264,
"heapUsedBytes": 80323928,
"domNodes": -142,
"jsHeapTotalBytes": -12193792,
"scriptDurationMs": 6606.0650000000005,
"eventListeners": -74,
"totalBlockingTimeMs": 515,
"frameDurationMs": 32.95340909090908,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2009.6639999999866,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4940000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.7470000000001,
"heapDeltaBytes": -9891548,
"heapUsedBytes": 78374360,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 27.305999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2007.8649999999243,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.260999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.1569999999999,
"heapDeltaBytes": -9566556,
"heapUsedBytes": 79522952,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 29.456000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2246.106999999995,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.668000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1498.9789999999998,
"heapDeltaBytes": -18762844,
"heapUsedBytes": 70987120,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 818.9300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.791044776119403,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2237.6030000000355,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.771,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1500.8780000000002,
"heapDeltaBytes": -17866436,
"heapUsedBytes": 68330532,
"domNodes": 0,
"jsHeapTotalBytes": 1609728,
"scriptDurationMs": 810.322,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66616541353383,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3569.7620000000256,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.758000000000001,
"layouts": 60,
"layoutDurationMs": 13.481,
"taskDurationMs": 1587.954,
"heapDeltaBytes": 1268940,
"heapUsedBytes": 69953848,
"domNodes": 24,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 788.412,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3669.7719999999663,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.032000000000002,
"layouts": 60,
"layoutDurationMs": 14.236,
"taskDurationMs": 1673.0330000000001,
"heapDeltaBytes": 852232,
"heapUsedBytes": 69474864,
"domNodes": 24,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 796.798,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2993.0990000000293,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.0459999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1802.2630000000001,
"heapDeltaBytes": 4883368,
"heapUsedBytes": 73940276,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 945.0580000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.759550561797752,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3086.5259999999353,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.262000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1886.7749999999999,
"heapDeltaBytes": 9174064,
"heapUsedBytes": 77540360,
"domNodes": 0,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 996.5129999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75706521739131,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.0579999999823,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.5949999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.27699999999993,
"heapDeltaBytes": -9071672,
"heapUsedBytes": 80945664,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 28.248999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2011.1719999999877,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.4020000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.9780000000001,
"heapDeltaBytes": -10095316,
"heapUsedBytes": 79940640,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.520999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.7050000000331,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.249999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.407,
"heapDeltaBytes": -11674408,
"heapUsedBytes": 58240868,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 143.912,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66944444444443,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 629.750999999942,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.12,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.66300000000007,
"heapDeltaBytes": -11656272,
"heapUsedBytes": 57358572,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 144.869,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2022.182999999984,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.3179999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.838,
"heapDeltaBytes": 1067660,
"heapUsedBytes": 70827748,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.350999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2017.2079999999823,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.0280000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.428,
"heapDeltaBytes": 1092648,
"heapUsedBytes": 71549480,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.045000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1696.9040000000177,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.38,
"layouts": 16,
"layoutDurationMs": 5.747999999999999,
"taskDurationMs": 707.756,
"heapDeltaBytes": -6065856,
"heapUsedBytes": 63433488,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 102.564,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.851999999998,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.13,
"layouts": 16,
"layoutDurationMs": 5.694999999999999,
"taskDurationMs": 746.4630000000001,
"heapDeltaBytes": -5981228,
"heapUsedBytes": 63840572,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 108.30400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.6689999999699,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.112000000000005,
"layouts": 5,
"layoutDurationMs": 14.475999999999999,
"taskDurationMs": 902.521,
"heapDeltaBytes": 1328728,
"heapUsedBytes": 94995200,
"domNodes": 14227,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 27.629,
"eventListeners": 2463,
"totalBlockingTimeMs": 134,
"frameDurationMs": 19.14189189189189,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8373.089999999991,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.626,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5397.53,
"heapDeltaBytes": 13977424,
"heapUsedBytes": 93794804,
"domNodes": 0,
"jsHeapTotalBytes": 1277952,
"scriptDurationMs": 2808.9350000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665868263473055,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8363.88700000009,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.733,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5429.664,
"heapDeltaBytes": -18826128,
"heapUsedBytes": 69814696,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2728.057,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666067864271458,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16839.170000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16057.387999999999,
"heapDeltaBytes": -41148292,
"heapUsedBytes": 180405984,
"domNodes": -3045,
"jsHeapTotalBytes": 2465792,
"scriptDurationMs": 241.92400000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.675638841567288,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 16757.843999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16103.279,
"heapDeltaBytes": -47420928,
"heapUsedBytes": 179827632,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 243.349,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.928151986183078,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 21538.72999999999,
"styleRecalcs": 182,
"styleRecalcDurationMs": 17.706000000000028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21189.566999999995,
"heapDeltaBytes": -35550796,
"heapUsedBytes": 176289608,
"domNodes": -3045,
"jsHeapTotalBytes": 8441856,
"scriptDurationMs": 832.1659999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.72767527675277,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 20582.905000000097,
"styleRecalcs": 164,
"styleRecalcDurationMs": 15.841999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20203.681,
"heapDeltaBytes": -42868616,
"heapUsedBytes": 184159636,
"domNodes": -3045,
"jsHeapTotalBytes": 7360512,
"scriptDurationMs": 801.909,
"eventListeners": -14915,
"totalBlockingTimeMs": 5,
"frameDurationMs": 37.115675675675675,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6206.696000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.64299999999996,
"layouts": 20,
"layoutDurationMs": 23.668999999999997,
"taskDurationMs": 6070.737999999999,
"heapDeltaBytes": -13325472,
"heapUsedBytes": 214099952,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 98.41400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.255555555555546,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6094.450999999935,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.53800000000003,
"layouts": 20,
"layoutDurationMs": 22.442000000000004,
"taskDurationMs": 5979.194,
"heapDeltaBytes": 945812,
"heapUsedBytes": 213786740,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 97.879,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.461581920903946,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8707.039000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8305.847000000002,
"heapDeltaBytes": -37514676,
"heapUsedBytes": 178979580,
"domNodes": -3045,
"jsHeapTotalBytes": 4333568,
"scriptDurationMs": 124.12700000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.691808873720127,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8688.649000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8273.087,
"heapDeltaBytes": -21479604,
"heapUsedBytes": 181216560,
"domNodes": -3045,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 125.083,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.433898305084746,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 126.1059999999361,
"styleRecalcs": 11,
"styleRecalcDurationMs": 17.373,
"layouts": 4,
"layoutDurationMs": 1.944,
"taskDurationMs": 97.54300000000002,
"heapDeltaBytes": 4054196,
"heapUsedBytes": 70609384,
"domNodes": 100,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.832999999999997,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65714285714278,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 482.99599999995735,
"styleRecalcs": 21,
"styleRecalcDurationMs": 15.959000000000001,
"layouts": 3,
"layoutDurationMs": 1.592,
"taskDurationMs": 120.66200000000002,
"heapDeltaBytes": 5811180,
"heapUsedBytes": 70965000,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.225999999999994,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 758.5119999999961,
"styleRecalcs": 78,
"styleRecalcDurationMs": 95.421,
"layouts": 76,
"layoutDurationMs": 21.66,
"taskDurationMs": 723.229,
"heapDeltaBytes": 16687236,
"heapUsedBytes": 80477740,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 293.76000000000005,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 753.278000000023,
"styleRecalcs": 78,
"styleRecalcDurationMs": 93.735,
"layouts": 76,
"layoutDurationMs": 22.883,
"taskDurationMs": 715.6009999999999,
"heapDeltaBytes": 16606492,
"heapUsedBytes": 87656776,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 284.912,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1409.3699999999671,
"styleRecalcs": 78,
"styleRecalcDurationMs": 263.964,
"layouts": 76,
"layoutDurationMs": 29.445,
"taskDurationMs": 1390.1879999999999,
"heapDeltaBytes": 8474212,
"heapUsedBytes": 114946680,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 481.705,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.162820512820524,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1389.0459999998939,
"styleRecalcs": 78,
"styleRecalcDurationMs": 274.172,
"layouts": 76,
"layoutDurationMs": 26.586,
"taskDurationMs": 1365.31,
"heapDeltaBytes": 8644096,
"heapUsedBytes": 114206552,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 446.288,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.5,
"p95FrameDurationMs": 16.80000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.56 #20454 +/- ##
=============================================
- Coverage 85.83% 85.09% -0.75%
=============================================
Files 2462 3499 +1037
Lines 140676 168394 +27718
Branches 38242 46132 +7890
=============================================
+ Hits 120756 143291 +22535
- Misses 19542 23121 +3579
- Partials 378 1982 +1604
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1041 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
christian-byrne
left a comment
There was a problem hiding this comment.
Backport fidelity and packaging are sound at this head.
Full context for agent readers
The three resulting file blobs exactly match the merged original in PR 20448. The signed-line comparison has 13 extra generated fields, all forced by the older base; no original line is missing. No package manifest changes, and the relevant billing and generated-type exports remain intact. Required checks are settled green and there are no unresolved review threads.
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 57ba65a has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
Why
Manual backport of #20448 to
core/1.56. The 1.56 QA fixes (FE-3293 #20430, FE-3292) need the op statuscancelableand plan fields. The bot's auto-backport failed on conflicts.Root cause
The conflicts were only in the generated
packages/ingest-types/src/{types,zod}.gen.ts, becausecore/1.56was one bot type sync behind main.How
operationState.tsschema change applied cleanly.AS IS / TO BE
Not user-facing: types and schema only.
Test plan
src/core/billing: 736 passedtsc(account-core) andtypecheck:appclean on this branch