Repository navigation
[backport cloud/1.55] fix(execution): queue Agent-inserted selected outputs - #20444
Conversation
## What Allow **Queue Selected Output Nodes** to execute an Agent-inserted root output whose raw node ID contains colons, such as `insert:<opId>:root:node:<originalId>`. `getExecutionIdsForSelectedNodes()` still used strict multi-segment execution-ID construction for the root leaf. That returns `null` for the colon-bearing IDs created by `insert_workflow`, so selecting the inserted `SaveImage` output produced “Could not resolve path to selected nodes” even though the full workflow validated and was ready to run. The root case now uses the existing `createLeafNodeExecutionId()` contract added for PM-1580. Nested paths remain on the strict delimiter-aware path. ## User evidence - Production Agent feedback surfaced 2026-10-07 from a `prod-v2` session on Agent release `v0.381.0`. - The affected workflow came from an Agent-inserted Krea template and had root IDs in the `insert:...:root:node:...` form. - Agent-side validation reported 22 converted nodes, zero errors/warnings, `ready_to_run: true`, and `spends_credits: false`; selected-output queueing failed before execution. - Related earlier locator/callback repair: #18616 / PM-1580. This closes the analogous selected-output execution helper gap. ## Test plan - `pnpm vitest run src/utils/graphTraversalUtil.test.ts` — 115 passed - `pnpm exec oxfmt --check src/utils/graphTraversalUtil.ts src/utils/graphTraversalUtil.test.ts` - `pnpm exec oxlint --type-aware src/utils/graphTraversalUtil.ts src/utils/graphTraversalUtil.test.ts` - `pnpm exec eslint --no-cache src/utils/graphTraversalUtil.ts src/utils/graphTraversalUtil.test.ts` - `pnpm typecheck:app` - Commit and push hooks passed, including the changed-file fallow audit. No feature flag, exposure, workflow content, model choice, or credit behavior changes.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2157 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d78383a47831bb889f28fc25efbef9c50db5015b
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-07T18:20:40.274Z",
"gitSha": "4ab0b0e2e8f454f51df7775a4b1914285a19eea9",
"branch": "backport-20437-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1994.2889999999807,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.889,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.21,
"heapDeltaBytes": 7005392,
"heapUsedBytes": 76110204,
"domNodes": -257,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.750000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1995.046000000002,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.639999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.61999999999995,
"heapDeltaBytes": 6160536,
"heapUsedBytes": 75076236,
"domNodes": -258,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.2059999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1689.4570000000044,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.736999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.1800000000001,
"heapDeltaBytes": 3180948,
"heapUsedBytes": 71702192,
"domNodes": -255,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 95.387,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1689.9419999999736,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.116,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.317,
"heapDeltaBytes": 7013148,
"heapUsedBytes": 76155388,
"domNodes": -241,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 98.47399999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1694.6510000000217,
"styleRecalcs": 28,
"styleRecalcDurationMs": 10.248,
"layouts": 6,
"layoutDurationMs": 1.114,
"taskDurationMs": 233.02,
"heapDeltaBytes": 3353048,
"heapUsedBytes": 72543900,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8.491,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.4359999999297,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.406,
"layouts": 6,
"layoutDurationMs": 1.1900000000000002,
"taskDurationMs": 229.82400000000004,
"heapDeltaBytes": 3319068,
"heapUsedBytes": 72501124,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.242999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 493.142999999975,
"styleRecalcs": 16,
"styleRecalcDurationMs": 5.805000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 295.02099999999996,
"heapDeltaBytes": 17970248,
"heapUsedBytes": 86974184,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 103.05600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 482.3279999999386,
"styleRecalcs": 16,
"styleRecalcDurationMs": 6.313000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 317.358,
"heapDeltaBytes": -8000928,
"heapUsedBytes": 61246096,
"domNodes": 23,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 111.35999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1014.5869999999491,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.054,
"heapDeltaBytes": 26208556,
"heapUsedBytes": 97616220,
"domNodes": -289,
"jsHeapTotalBytes": 20074496,
"scriptDurationMs": 37.306999999999995,
"eventListeners": -217,
"totalBlockingTimeMs": 392,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1008.3439999999655,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 631.5730000000001,
"heapDeltaBytes": 26480048,
"heapUsedBytes": 98921548,
"domNodes": -293,
"jsHeapTotalBytes": 19025920,
"scriptDurationMs": 44.796,
"eventListeners": -217,
"totalBlockingTimeMs": 390,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 700.2029999999877,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 278.6010000000001,
"heapDeltaBytes": 14933132,
"heapUsedBytes": 90697744,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 85.822,
"eventListeners": 0,
"totalBlockingTimeMs": 102,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 700.4680000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 276.83200000000016,
"heapDeltaBytes": 15560176,
"heapUsedBytes": 91159820,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 86.315,
"eventListeners": 0,
"totalBlockingTimeMs": 94,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5619.507999999996,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.9999999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4828.945,
"heapDeltaBytes": 14113048,
"heapUsedBytes": 93935604,
"domNodes": -269,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 3899.3900000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 53,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5210.52300000008,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.1900000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4392.508999999999,
"heapDeltaBytes": 747588,
"heapUsedBytes": 80609692,
"domNodes": -263,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 3566.897,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5439.447000000029,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.7309999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4688.605,
"heapDeltaBytes": 9867864,
"heapUsedBytes": 89694248,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 3810.1690000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 25,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5512.777000000028,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.037000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4840.434,
"heapDeltaBytes": 13772300,
"heapUsedBytes": 92997384,
"domNodes": -257,
"jsHeapTotalBytes": 7856128,
"scriptDurationMs": 3791.704,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2000.2289999999903,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.8839999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 272.50700000000006,
"heapDeltaBytes": 10289748,
"heapUsedBytes": 75306760,
"domNodes": -237,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 25.888999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2009.2140000000427,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.454,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.067,
"heapDeltaBytes": 3411380,
"heapUsedBytes": 86282764,
"domNodes": -257,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 17.543000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2116.602999999998,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.546999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1066.6390000000001,
"heapDeltaBytes": -2400540,
"heapUsedBytes": 88429288,
"domNodes": -246,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 519.162,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2094.116999999983,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.479999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 978.7110000000001,
"heapDeltaBytes": 212108,
"heapUsedBytes": 90865248,
"domNodes": -244,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 473.478,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3110.090000000014,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.373999999999999,
"layouts": 60,
"layoutDurationMs": 13.061,
"taskDurationMs": 1092.333,
"heapDeltaBytes": 2249112,
"heapUsedBytes": 94982324,
"domNodes": 42,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 527.057,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3053.619000000026,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.364,
"layouts": 60,
"layoutDurationMs": 9.658999999999999,
"taskDurationMs": 1076.999,
"heapDeltaBytes": 1310024,
"heapUsedBytes": 67031080,
"domNodes": 36,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 495.706,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2164.8329999999874,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.833000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1268.6739999999998,
"heapDeltaBytes": 3362448,
"heapUsedBytes": 69406496,
"domNodes": -245,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 634.5580000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2105.4929999999104,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1171.156,
"heapDeltaBytes": 3187932,
"heapUsedBytes": 73697636,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 583.323,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.8710000000192,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.896999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.07899999999995,
"heapDeltaBytes": -23423860,
"heapUsedBytes": 68602804,
"domNodes": -245,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 25.390000000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2034.208000000035,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.3100000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.47600000000006,
"heapDeltaBytes": -23258044,
"heapUsedBytes": 67950948,
"domNodes": -251,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 29.98200000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 396.000000000015,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.358,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 263.317,
"heapDeltaBytes": 13247852,
"heapUsedBytes": 84118220,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 87.065,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 415.3800000000274,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.132,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 257.71299999999997,
"heapDeltaBytes": 13019256,
"heapUsedBytes": 84315192,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 87.20700000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1990.8910000000333,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.9319999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.731,
"heapDeltaBytes": -5047192,
"heapUsedBytes": 59465192,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.682,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1993.1040000000166,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.613,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.324,
"heapDeltaBytes": -4770292,
"heapUsedBytes": 59774628,
"domNodes": -272,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 5.785,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1673.0389999999602,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.379,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.99,
"heapDeltaBytes": -5322956,
"heapUsedBytes": 59182004,
"domNodes": -271,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 66.36299999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.554999999994,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.351999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.6700000000001,
"heapDeltaBytes": 5064812,
"heapUsedBytes": 75784624,
"domNodes": -270,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 61.92300000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 815.7850000000053,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.706,
"layouts": 5,
"layoutDurationMs": 7.397000000000001,
"taskDurationMs": 574.77,
"heapDeltaBytes": 19312768,
"heapUsedBytes": 107529984,
"domNodes": 13667,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 18.629,
"eventListeners": 2383,
"totalBlockingTimeMs": 88,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8155.183000000023,
"styleRecalcs": 252,
"styleRecalcDurationMs": 30.482999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3727.431,
"heapDeltaBytes": 2445244,
"heapUsedBytes": 92813976,
"domNodes": -234,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 1773.284,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8146.087999999963,
"styleRecalcs": 251,
"styleRecalcDurationMs": 25.389999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3507.2780000000002,
"heapDeltaBytes": 2231100,
"heapUsedBytes": 92428852,
"domNodes": -233,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 1666.7350000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10261.265999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9072.926000000001,
"heapDeltaBytes": -16846108,
"heapUsedBytes": 196139040,
"domNodes": -8062,
"jsHeapTotalBytes": -6537216,
"scriptDurationMs": 127.29600000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 9884.000000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8930.729,
"heapDeltaBytes": -60673828,
"heapUsedBytes": 173605468,
"domNodes": -8062,
"jsHeapTotalBytes": -11284480,
"scriptDurationMs": 119.759,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 12810.642000000029,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.731999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12204,
"heapDeltaBytes": -66079332,
"heapUsedBytes": 168271568,
"domNodes": -8062,
"jsHeapTotalBytes": -20647936,
"scriptDurationMs": 618.342,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 9443.338999999924,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.573,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8741.723,
"heapDeltaBytes": -59911440,
"heapUsedBytes": 175559908,
"domNodes": -8062,
"jsHeapTotalBytes": -5890048,
"scriptDurationMs": 519.2370000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3687.7640000000156,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.01599999999998,
"layouts": 20,
"layoutDurationMs": 20.613000000000007,
"taskDurationMs": 3549.893,
"heapDeltaBytes": -29038280,
"heapUsedBytes": 198652336,
"domNodes": -8062,
"jsHeapTotalBytes": 19124224,
"scriptDurationMs": 56.185,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3553.1240000000253,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.65699999999998,
"layouts": 20,
"layoutDurationMs": 19.168999999999997,
"taskDurationMs": 3375.056,
"heapDeltaBytes": -43660644,
"heapUsedBytes": 177261008,
"domNodes": -8062,
"jsHeapTotalBytes": 13692928,
"scriptDurationMs": 51.544,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5264.854000000014,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.09899999999998799,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4743.512000000001,
"heapDeltaBytes": -17175544,
"heapUsedBytes": 179561100,
"domNodes": 0,
"jsHeapTotalBytes": -23330816,
"scriptDurationMs": 65.21099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 4650.985999999989,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.12100000000000999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4274.803000000001,
"heapDeltaBytes": 3718840,
"heapUsedBytes": 187370524,
"domNodes": 0,
"jsHeapTotalBytes": -15990784,
"scriptDurationMs": 48.36400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 449.94900000006055,
"styleRecalcs": 22,
"styleRecalcDurationMs": 22.346999999999998,
"layouts": 5,
"layoutDurationMs": 1.9949999999999999,
"taskDurationMs": 120.30399999999999,
"heapDeltaBytes": 5243052,
"heapUsedBytes": 71777300,
"domNodes": 152,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.506,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 435.41800000002695,
"styleRecalcs": 15,
"styleRecalcDurationMs": 15.790000000000003,
"layouts": 4,
"layoutDurationMs": 1.454,
"taskDurationMs": 91.651,
"heapDeltaBytes": 4897736,
"heapUsedBytes": 71807676,
"domNodes": 123,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 7.6930000000000005,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #20444 +/- ##
=============================================
Coverage ? 85.01%
=============================================
Files ? 2344
Lines ? 134561
Branches ? 36294
=============================================
Hits ? 114398
Misses ? 19800
Partials ? 363
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: Approve. This is a faithful backport of #20437, with identical hunks in both files.
I compared against #20437's merge commit d8de6137db5c448d240aaa2662a3587eabbc0f8a. graphTraversalUtil.ts makes the same one-line change in getExecutionIdsForSelectedNodes, using createLeafNodeExecutionId(node.id) for root nodes. That helper already exists and is imported on cloud/1.55. graphTraversalUtil.test.ts adds the same "should keep a colon-bearing root node ID whole" case. No adaptation was needed.
Checks: graphTraversalUtil.test.ts passes locally at this head (115 tests). Hosted CI at ef5bc0b is green, including lint-and-format, test and e2e-status.
Backport of #20437 to
cloud/1.55Automatically created by backport workflow.