Repository navigation
[backport core/1.55] fix(execution): queue Agent-inserted selected outputs - #20443
Conversation
## What Allow **Queue Selected Output Nodes** to execute an Agent-inserted root output whose raw node ID contains colons, such as `insert:<opId>:root:node:<originalId>`. `getExecutionIdsForSelectedNodes()` still used strict multi-segment execution-ID construction for the root leaf. That returns `null` for the colon-bearing IDs created by `insert_workflow`, so selecting the inserted `SaveImage` output produced “Could not resolve path to selected nodes” even though the full workflow validated and was ready to run. The root case now uses the existing `createLeafNodeExecutionId()` contract added for PM-1580. Nested paths remain on the strict delimiter-aware path. ## User evidence - Production Agent feedback surfaced 2026-10-07 from a `prod-v2` session on Agent release `v0.381.0`. - The affected workflow came from an Agent-inserted Krea template and had root IDs in the `insert:...:root:node:...` form. - Agent-side validation reported 22 converted nodes, zero errors/warnings, `ready_to_run: true`, and `spends_credits: false`; selected-output queueing failed before execution. - Related earlier locator/callback repair: #18616 / PM-1580. This closes the analogous selected-output execution helper gap. ## Test plan - `pnpm vitest run src/utils/graphTraversalUtil.test.ts` — 115 passed - `pnpm exec oxfmt --check src/utils/graphTraversalUtil.ts src/utils/graphTraversalUtil.test.ts` - `pnpm exec oxlint --type-aware src/utils/graphTraversalUtil.ts src/utils/graphTraversalUtil.test.ts` - `pnpm exec eslint --no-cache src/utils/graphTraversalUtil.ts src/utils/graphTraversalUtil.test.ts` - `pnpm typecheck:app` - Commit and push hooks passed, including the changed-file fallow audit. No feature flag, exposure, workflow content, model choice, or credit behavior changes.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2151 passed, 0 failed · 2 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0b312ae65ff13fc41b0aa08ba148edf47aa07a02
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-07T18:23:13.639Z",
"gitSha": "45e895a920405553e2e8e445eb821dbd8e3129aa",
"branch": "backport-20437-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2015.5980000000113,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.125,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.846,
"heapDeltaBytes": 3638236,
"heapUsedBytes": 72699372,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.189,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2021.3039999999864,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.768999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.0919999999999,
"heapDeltaBytes": 4301720,
"heapUsedBytes": 72826908,
"domNodes": -262,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.119000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1773.2370000000515,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.962,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 890.1450000000001,
"heapDeltaBytes": 8820820,
"heapUsedBytes": 77890712,
"domNodes": -260,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 171.46800000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1777.127000000064,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.197,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 880.9860000000001,
"heapDeltaBytes": -5177304,
"heapUsedBytes": 63858596,
"domNodes": -260,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 168.464,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.6589999999883,
"styleRecalcs": 33,
"styleRecalcDurationMs": 15.294,
"layouts": 6,
"layoutDurationMs": 1.135,
"taskDurationMs": 356.5349999999999,
"heapDeltaBytes": 3292512,
"heapUsedBytes": 72421360,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.365999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.7959999999794,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.749,
"layouts": 6,
"layoutDurationMs": 1.2389999999999999,
"taskDurationMs": 397.40000000000003,
"heapDeltaBytes": 3557116,
"heapUsedBytes": 72718464,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 15.145,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 655.713999999989,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.617,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.366,
"heapDeltaBytes": -7646332,
"heapUsedBytes": 61457744,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 177.79299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 692.8770000000668,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.512,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.04600000000005,
"heapDeltaBytes": 18257116,
"heapUsedBytes": 87121836,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 174.032,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1193.928000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 867.99,
"heapDeltaBytes": 35336428,
"heapUsedBytes": 105280880,
"domNodes": 0,
"jsHeapTotalBytes": 18509824,
"scriptDurationMs": 76.534,
"eventListeners": 0,
"totalBlockingTimeMs": 576,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1284.9969999999757,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 998.641,
"heapDeltaBytes": 35543152,
"heapUsedBytes": 108584992,
"domNodes": 0,
"jsHeapTotalBytes": 18509824,
"scriptDurationMs": 85.203,
"eventListeners": 0,
"totalBlockingTimeMs": 665,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.5440000000417,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.64400000000006,
"heapDeltaBytes": 15625960,
"heapUsedBytes": 91635344,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.51299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 875.7430000000568,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.5810000000002,
"heapDeltaBytes": 16286024,
"heapUsedBytes": 93670736,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 178.10799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 233,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10909.40599999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9896.414999999999,
"heapDeltaBytes": -13216124,
"heapUsedBytes": 68521576,
"domNodes": -16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8457.698,
"eventListeners": 0,
"totalBlockingTimeMs": 1507,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10453.080999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9504.909,
"heapDeltaBytes": 5455636,
"heapUsedBytes": 84767384,
"domNodes": -275,
"jsHeapTotalBytes": 3137536,
"scriptDurationMs": 7929.101,
"eventListeners": -174,
"totalBlockingTimeMs": 1215,
"frameDurationMs": 20.003333333333284,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11820.559999999943,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10793.503999999999,
"heapDeltaBytes": -4771836,
"heapUsedBytes": 76588528,
"domNodes": -16,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 9135.088999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 2045,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11666.838999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10683.029,
"heapDeltaBytes": 14868832,
"heapUsedBytes": 96496408,
"domNodes": -12,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 8993.237,
"eventListeners": 0,
"totalBlockingTimeMs": 1934,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2035.5519999999956,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.542000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.6320000000001,
"heapDeltaBytes": -15797324,
"heapUsedBytes": 73109172,
"domNodes": -240,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 37.248999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.1260000000002,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.729000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.9350000000001,
"heapDeltaBytes": -23433568,
"heapUsedBytes": 66056164,
"domNodes": -261,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 42.318000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2327.4299999999926,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.945,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1623.9840000000002,
"heapDeltaBytes": 998916,
"heapUsedBytes": 65693480,
"domNodes": 8,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 888.18,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2355.3620000000137,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1546.925,
"heapDeltaBytes": -22677468,
"heapUsedBytes": 66518960,
"domNodes": -243,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 909.9499999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3656.4070000000015,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.976999999999999,
"layouts": 60,
"layoutDurationMs": 14.537,
"taskDurationMs": 1794.7410000000002,
"heapDeltaBytes": -1705880,
"heapUsedBytes": 89863876,
"domNodes": -231,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 832.5039999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3713.8740000000325,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.985999999999999,
"layouts": 60,
"layoutDurationMs": 14.474,
"taskDurationMs": 1723.361,
"heapDeltaBytes": -560064,
"heapUsedBytes": 65693148,
"domNodes": 28,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 837.671,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3216.4339999999925,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.262,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2014.2250000000001,
"heapDeltaBytes": -19154308,
"heapUsedBytes": 74377708,
"domNodes": 12,
"jsHeapTotalBytes": 7630848,
"scriptDurationMs": 1079.7489999999998,
"eventListeners": 180,
"totalBlockingTimeMs": 20,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3267.20499999999,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.4959999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1994.231,
"heapDeltaBytes": 9104376,
"heapUsedBytes": 74735496,
"domNodes": -252,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 1078.117,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.7670000000116,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.151000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.347,
"heapDeltaBytes": -16999652,
"heapUsedBytes": 73845368,
"domNodes": -246,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 41.839999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2062.5499999999874,
"styleRecalcs": 9,
"styleRecalcDurationMs": 12.727000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.6190000000001,
"heapDeltaBytes": -23344536,
"heapUsedBytes": 68130064,
"domNodes": -255,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 36.373,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 570.8349999999882,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.130999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.389,
"heapDeltaBytes": 12948384,
"heapUsedBytes": 83923328,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 146.85700000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.4120000000103,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.803999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.234,
"heapDeltaBytes": 13252520,
"heapUsedBytes": 84375312,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 146.845,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.9820000000036,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.629,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.478,
"heapDeltaBytes": 5788916,
"heapUsedBytes": 76959068,
"domNodes": -277,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.659,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.682000000079,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.565000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.998,
"heapDeltaBytes": -8130972,
"heapUsedBytes": 63065632,
"domNodes": -275,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 11.619000000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.7840000000133,
"styleRecalcs": 45,
"styleRecalcDurationMs": 17.054000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 783.129,
"heapDeltaBytes": 7638804,
"heapUsedBytes": 78599672,
"domNodes": -276,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 111.895,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.3060000000405,
"styleRecalcs": 46,
"styleRecalcDurationMs": 18.044999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 783.0699999999999,
"heapDeltaBytes": 10302064,
"heapUsedBytes": 80931852,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 112.331,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1404.1560000000572,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.660000000000004,
"layouts": 5,
"layoutDurationMs": 13.365000000000002,
"taskDurationMs": 953.833,
"heapDeltaBytes": 20258112,
"heapUsedBytes": 104148648,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 30.44600000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8316.325000000006,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.616,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5269.9800000000005,
"heapDeltaBytes": 3206384,
"heapUsedBytes": 92407628,
"domNodes": -242,
"jsHeapTotalBytes": 1531904,
"scriptDurationMs": 2908.124,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9074.672000000079,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.345000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6156.976000000001,
"heapDeltaBytes": 4994268,
"heapUsedBytes": 95017584,
"domNodes": -243,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 3119.606,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17783.48299999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17320.467999999997,
"heapDeltaBytes": -62976616,
"heapUsedBytes": 172417580,
"domNodes": -8061,
"jsHeapTotalBytes": -10608640,
"scriptDurationMs": 283.99600000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17231.330999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16939.265,
"heapDeltaBytes": -63668604,
"heapUsedBytes": 172100872,
"domNodes": -8061,
"jsHeapTotalBytes": -10870784,
"scriptDurationMs": 270.489,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21691.506000000005,
"styleRecalcs": 152,
"styleRecalcDurationMs": 19.257999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21467.652,
"heapDeltaBytes": -67157564,
"heapUsedBytes": 168755532,
"domNodes": -8061,
"jsHeapTotalBytes": -13754368,
"scriptDurationMs": 957.093,
"eventListeners": -14928,
"totalBlockingTimeMs": 81,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22015.714000000004,
"styleRecalcs": 159,
"styleRecalcDurationMs": 20.946999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21784.632,
"heapDeltaBytes": -58755328,
"heapUsedBytes": 182397944,
"domNodes": -8061,
"jsHeapTotalBytes": -20385792,
"scriptDurationMs": 959.0279999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 219,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6421.58100000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.39300000000006,
"layouts": 20,
"layoutDurationMs": 26.581999999999994,
"taskDurationMs": 6388.804999999999,
"heapDeltaBytes": -26590772,
"heapUsedBytes": 195384260,
"domNodes": -8065,
"jsHeapTotalBytes": 10022912,
"scriptDurationMs": 107.28999999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 514,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6741.769999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 94.99199999999996,
"layouts": 20,
"layoutDurationMs": 34.053,
"taskDurationMs": 6687.5869999999995,
"heapDeltaBytes": -66549664,
"heapUsedBytes": 174670848,
"domNodes": -8061,
"jsHeapTotalBytes": 2945024,
"scriptDurationMs": 126.466,
"eventListeners": -14928,
"totalBlockingTimeMs": 408,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6812.72899999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6619.526000000001,
"heapDeltaBytes": -13423100,
"heapUsedBytes": 175238204,
"domNodes": 0,
"jsHeapTotalBytes": -16515072,
"scriptDurationMs": 113.56900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8865.92799999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8750.291000000001,
"heapDeltaBytes": 22083908,
"heapUsedBytes": 196406224,
"domNodes": 0,
"jsHeapTotalBytes": -9961472,
"scriptDurationMs": 171.16300000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 120.00699999998687,
"styleRecalcs": 9,
"styleRecalcDurationMs": 20.333,
"layouts": 3,
"layoutDurationMs": 1.499,
"taskDurationMs": 92.786,
"heapDeltaBytes": 3237648,
"heapUsedBytes": 70003476,
"domNodes": 112,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9.988999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 118.52999999996428,
"styleRecalcs": 7,
"styleRecalcDurationMs": 17.348999999999997,
"layouts": 3,
"layoutDurationMs": 1.8449999999999998,
"taskDurationMs": 83.38300000000001,
"heapDeltaBytes": 2910340,
"heapUsedBytes": 69637080,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.141999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #20443 +/- ##
=============================================
- Coverage 84.91% 84.91% -0.01%
=============================================
Files 2344 2344
Lines 133923 133920 -3
Branches 33861 35763 +1902
=============================================
- Hits 113718 113714 -4
- Misses 19842 19843 +1
Partials 363 363
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: Approve. This is a faithful backport of #20437, with identical hunks in both files.
I compared against #20437's merge commit d8de6137db5c448d240aaa2662a3587eabbc0f8a. graphTraversalUtil.ts makes the same one-line change in getExecutionIdsForSelectedNodes, using createLeafNodeExecutionId(node.id) for root nodes. That helper already exists and is imported on core/1.55. graphTraversalUtil.test.ts adds the same "should keep a colon-bearing root node ID whole" case. No adaptation was needed.
Checks: graphTraversalUtil.test.ts passes locally at this head (115 tests). Hosted CI at b8c2e91 is green, including lint-and-format, test and e2e-status.
Backport of #20437 to
core/1.55Automatically created by backport workflow.