Skip to content

[backport cloud/1.54] fix(execution): queue Agent-inserted selected outputs - #20442

Merged
comfy-pr-bot merged 2 commits into
cloud/1.54from
backport-20437-to-cloud-1.54
Oct 7, 2026
Merged

comfy-pr-bot merged 2 commits into
cloud/1.54from
backport-20437-to-cloud-1.54

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #20437 to cloud/1.54

Automatically created by backport workflow.

## What

Allow **Queue Selected Output Nodes** to execute an Agent-inserted root
output whose raw node ID contains colons, such as
`insert:<opId>:root:node:<originalId>`.

`getExecutionIdsForSelectedNodes()` still used strict multi-segment
execution-ID construction for the root leaf. That returns `null` for the
colon-bearing IDs created by `insert_workflow`, so selecting the
inserted `SaveImage` output produced “Could not resolve path to selected
nodes” even though the full workflow validated and was ready to run.

The root case now uses the existing `createLeafNodeExecutionId()`
contract added for PM-1580. Nested paths remain on the strict
delimiter-aware path.

## User evidence

- Production Agent feedback surfaced 2026-10-07 from a `prod-v2` session
on Agent release `v0.381.0`.
- The affected workflow came from an Agent-inserted Krea template and
had root IDs in the `insert:...:root:node:...` form.
- Agent-side validation reported 22 converted nodes, zero
errors/warnings, `ready_to_run: true`, and `spends_credits: false`;
selected-output queueing failed before execution.
- Related earlier locator/callback repair: #18616 / PM-1580. This closes
the analogous selected-output execution helper gap.

## Test plan

- `pnpm vitest run src/utils/graphTraversalUtil.test.ts` — 115 passed
- `pnpm exec oxfmt --check src/utils/graphTraversalUtil.ts
src/utils/graphTraversalUtil.test.ts`
- `pnpm exec oxlint --type-aware src/utils/graphTraversalUtil.ts
src/utils/graphTraversalUtil.test.ts`
- `pnpm exec eslint --no-cache src/utils/graphTraversalUtil.ts
src/utils/graphTraversalUtil.test.ts`
- `pnpm typecheck:app`
- Commit and push hooks passed, including the changed-file fallow audit.

No feature flag, exposure, workflow content, model choice, or credit
behavior changes.
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Oct 7, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) October 7, 2026 18:08
@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 7, 2026 8:24pm UTC
billing-web-test Ignored Ignored Oct 7, 2026 8:24pm UTC

Request Review

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/07/2026, 08:26:35 PM UTC

Links

🎭 Playwright: ✅ 1989 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1968 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 149ms TBT · 80.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 90.4 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.3 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 85ms TBT · 169.9 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 418ms TBT · 175.9 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 558ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 62.1 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -181
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 30ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 936ms
canvas-mouse-sweep: script duration 170ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.2 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -179
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 359ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 73.3 MB
canvas-zoom-sweep: DOM nodes 75
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 462ms
dom-widget-clipping: script duration 167ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 62.0 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 544ms
large-graph-idle: script duration 32ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 72.8 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -177
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1614ms
large-graph-pan: script duration 832ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 65.0 MB
large-graph-pan: DOM nodes -280
large-graph-pan: event listeners -93
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 67
large-graph-zoom: task duration 1648ms
large-graph-zoom: script duration 782ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 64.3 MB
large-graph-zoom: DOM nodes 26
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1869ms
legacy-node-drag: script duration 972ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 72.2 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 553ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 72.1 MB
minimap-idle: DOM nodes -270
minimap-idle: event listeners -178
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 13ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 424ms
subgraph-dom-widget-clipping: script duration 148ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 73.6 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 489ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 71.3 MB
subgraph-idle: DOM nodes -298
subgraph-idle: event listeners -240
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 843ms
subgraph-mouse-sweep: script duration 114ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 68.6 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -209
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 18ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 981ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 149ms
subgraph-transition-enter: heap used 80.1 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5692ms
viewport-pan-sweep: script duration 2780ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 90.4 MB
viewport-pan-sweep: DOM nodes -257
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16476ms
vue-large-graph-idle: script duration 275ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.3 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14931
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 172
vue-large-graph-pan: task duration 20810ms
vue-large-graph-pan: script duration 988ms
vue-large-graph-pan: TBT 85ms
vue-large-graph-pan: heap used 169.9 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14924
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 81ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6113ms
vue-node-resize-workload: script duration 111ms
vue-node-resize-workload: TBT 418ms
vue-node-resize-workload: heap used 175.9 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8382ms
vue-zoom-out-idle: script duration 162ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 171.6 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 2
workflow-execution: style recalc count 8
workflow-execution: task duration 71ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.1 MB
workflow-execution: DOM nodes 129
workflow-execution: event listeners 17
Raw data
{
  "timestamp": "2026-10-07T20:36:18.617Z",
  "gitSha": "a145acb8e863de404664b861aaf738c3ca888de3",
  "branch": "backport-20437-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2145.9519999999657,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 8.393999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 593.976,
      "heapDeltaBytes": 1337264,
      "heapUsedBytes": 72446948,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 11.948000000000004,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2054.6110000000226,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.621,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 521.282,
      "heapDeltaBytes": -13225852,
      "heapUsedBytes": 57683188,
      "domNodes": -282,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.885,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1879.7840000000292,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 30.784,
      "layouts": 14,
      "layoutDurationMs": 4.058,
      "taskDurationMs": 966.9019999999999,
      "heapDeltaBytes": -10773236,
      "heapUsedBytes": 62891472,
      "domNodes": -280,
      "jsHeapTotalBytes": 3702784,
      "scriptDurationMs": 174.592,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1870.5270000000382,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 28.596999999999998,
      "layouts": 14,
      "layoutDurationMs": 4.233,
      "taskDurationMs": 905.7290000000002,
      "heapDeltaBytes": -3677180,
      "heapUsedBytes": 69655620,
      "domNodes": -280,
      "jsHeapTotalBytes": 4489216,
      "scriptDurationMs": 166.36200000000002,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.75900000001,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.071999999999996,
      "layouts": 6,
      "layoutDurationMs": 1.177,
      "taskDurationMs": 372.555,
      "heapDeltaBytes": 4631296,
      "heapUsedBytes": 77650800,
      "domNodes": 74,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 12.038999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1663.483000000042,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 13.745999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.983,
      "taskDurationMs": 344.738,
      "heapDeltaBytes": 4196572,
      "heapUsedBytes": 76012872,
      "domNodes": 75,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 9.800999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 672.3419999999578,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 8.636,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 471.371,
      "heapDeltaBytes": -7503120,
      "heapUsedBytes": 66325512,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 170.33599999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 691.5259999999535,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 9.605,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 453.577,
      "heapDeltaBytes": -7539596,
      "heapUsedBytes": 63662068,
      "domNodes": 20,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 163.72899999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2029.8199999999724,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.2620000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 534.3860000000001,
      "heapDeltaBytes": -3496752,
      "heapUsedBytes": 77157496,
      "domNodes": -269,
      "jsHeapTotalBytes": -2588672,
      "scriptDurationMs": 32.412000000000006,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2030.3220000000692,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.714000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 554.5029999999999,
      "heapDeltaBytes": -5244080,
      "heapUsedBytes": 75610572,
      "domNodes": -270,
      "jsHeapTotalBytes": -1802240,
      "scriptDurationMs": 31.968000000000004,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2277.281999999957,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.366000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1648.733,
      "heapDeltaBytes": -9589532,
      "heapUsedBytes": 68673020,
      "domNodes": -285,
      "jsHeapTotalBytes": 4087808,
      "scriptDurationMs": 841.33,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2258.3960000000616,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.864999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1579.962,
      "heapDeltaBytes": 1570584,
      "heapUsedBytes": 67740632,
      "domNodes": -274,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 821.938,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3514.7590000000264,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.808000000000002,
      "layouts": 60,
      "layoutDurationMs": 11.977,
      "taskDurationMs": 1642.992,
      "heapDeltaBytes": -309412,
      "heapUsedBytes": 67161012,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 775.478,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3587.1479999999565,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.76,
      "layouts": 60,
      "layoutDurationMs": 11.961,
      "taskDurationMs": 1653.2110000000002,
      "heapDeltaBytes": -45832,
      "heapUsedBytes": 67753472,
      "domNodes": 28,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 788.568,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3116.4079999999785,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.785999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1885.7740000000001,
      "heapDeltaBytes": 7854396,
      "heapUsedBytes": 75491424,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 980.3090000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3064.5509999999376,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.6469999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1852.5130000000001,
      "heapDeltaBytes": 7900296,
      "heapUsedBytes": 75853300,
      "domNodes": 0,
      "jsHeapTotalBytes": 978944,
      "scriptDurationMs": 964.2850000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "minimap-idle",
      "durationMs": 2071.5339999999856,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.606000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 576.358,
      "heapDeltaBytes": -5731736,
      "heapUsedBytes": 74206308,
      "domNodes": -272,
      "jsHeapTotalBytes": -368640,
      "scriptDurationMs": 32.27,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2053.6319999999932,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 7.333000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 529.6189999999999,
      "heapDeltaBytes": 11390284,
      "heapUsedBytes": 76994148,
      "domNodes": -268,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 37.629999999999995,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 646.1390000000051,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 15.638,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.425,
      "heapDeltaBytes": -10584032,
      "heapUsedBytes": 65608588,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 154.053,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 578.5929999999553,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.352,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 404.637,
      "heapDeltaBytes": 14903380,
      "heapUsedBytes": 88673120,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 141.80800000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2033.5860000000139,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.230999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.71400000000006,
      "heapDeltaBytes": 1317320,
      "heapUsedBytes": 77258892,
      "domNodes": -296,
      "jsHeapTotalBytes": 4751360,
      "scriptDurationMs": 7.6450000000000005,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.2510000000066,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.663000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 485.788,
      "heapDeltaBytes": -3990712,
      "heapUsedBytes": 72192328,
      "domNodes": -299,
      "jsHeapTotalBytes": 4489216,
      "scriptDurationMs": 7.801000000000001,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1754.6760000000177,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 28.189,
      "layouts": 18,
      "layoutDurationMs": 4.505999999999999,
      "taskDurationMs": 837.8639999999999,
      "heapDeltaBytes": -13604024,
      "heapUsedBytes": 61958128,
      "domNodes": -295,
      "jsHeapTotalBytes": 4751360,
      "scriptDurationMs": 111.124,
      "eventListeners": -208,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1756.768999999963,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 29.399999999999995,
      "layouts": 18,
      "layoutDurationMs": 5,
      "taskDurationMs": 848.8299999999999,
      "heapDeltaBytes": 9013936,
      "heapUsedBytes": 81872596,
      "domNodes": -297,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 116.99100000000001,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.1049999999923,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 33.442,
      "layouts": 15,
      "layoutDurationMs": 17.808,
      "taskDurationMs": 980.801,
      "heapDeltaBytes": -6976860,
      "heapUsedBytes": 83975568,
      "domNodes": 13831,
      "jsHeapTotalBytes": 13107200,
      "scriptDurationMs": 32.392,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 149,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8242.052999999998,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 34.94899999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5642.375,
      "heapDeltaBytes": 28631632,
      "heapUsedBytes": 93927668,
      "domNodes": -270,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 2714.293,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8361.809000000107,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 40.494,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5740.929,
      "heapDeltaBytes": 15261712,
      "heapUsedBytes": 95648952,
      "domNodes": -243,
      "jsHeapTotalBytes": -528384,
      "scriptDurationMs": 2844.91,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17105.185999999947,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16558.279,
      "heapDeltaBytes": -55388216,
      "heapUsedBytes": 178840148,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11546624,
      "scriptDurationMs": 279.094,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17028.10199999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16393.087,
      "heapDeltaBytes": -62027048,
      "heapUsedBytes": 180388700,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17739776,
      "scriptDurationMs": 270.879,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21009.17800000002,
      "styleRecalcs": 171,
      "styleRecalcDurationMs": 18.442999999999987,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20693.921,
      "heapDeltaBytes": -47787536,
      "heapUsedBytes": 170472284,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12595200,
      "scriptDurationMs": 979.381,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 112,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21222.997999999963,
      "styleRecalcs": 172,
      "styleRecalcDurationMs": 19.07399999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20925.956,
      "heapDeltaBytes": -45903504,
      "heapUsedBytes": 185779944,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18264064,
      "scriptDurationMs": 996.695,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 58,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6267.056000000025,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.843,
      "layouts": 20,
      "layoutDurationMs": 24.242,
      "taskDurationMs": 6151.9580000000005,
      "heapDeltaBytes": -34190900,
      "heapUsedBytes": 184321352,
      "domNodes": -8068,
      "jsHeapTotalBytes": 13357056,
      "scriptDurationMs": 115.46199999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 440,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6194.527999999991,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.88000000000001,
      "layouts": 20,
      "layoutDurationMs": 22.793999999999993,
      "taskDurationMs": 6074.201999999999,
      "heapDeltaBytes": -34034452,
      "heapUsedBytes": 184624808,
      "domNodes": -8068,
      "jsHeapTotalBytes": 13094912,
      "scriptDurationMs": 107.51900000000002,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 395,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8679.820000000063,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8390.803000000002,
      "heapDeltaBytes": 17201640,
      "heapUsedBytes": 177391720,
      "domNodes": 0,
      "jsHeapTotalBytes": -12845056,
      "scriptDurationMs": 183.388,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8666.969999999992,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8373.52,
      "heapDeltaBytes": -6000652,
      "heapUsedBytes": 182401348,
      "domNodes": 0,
      "jsHeapTotalBytes": -10485760,
      "scriptDurationMs": 141.3350000000001,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 119.19599999998809,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 15.808,
      "layouts": 2,
      "layoutDurationMs": 1.6289999999999998,
      "taskDurationMs": 77.91899999999998,
      "heapDeltaBytes": 3021980,
      "heapUsedBytes": 74952200,
      "domNodes": 131,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.604999999999999,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 102.55500000005213,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 10.968,
      "layouts": 1,
      "layoutDurationMs": 0.667,
      "taskDurationMs": 63.22800000000001,
      "heapDeltaBytes": 2975544,
      "heapUsedBytes": 72022120,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.447000000000001,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51186 76656 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #20442   +/-   ##
=============================================
  Coverage              ?   84.16%           
=============================================
  Files                 ?     2132           
  Lines                 ?   128485           
  Branches              ?    32990           
=============================================
  Hits                  ?   108138           
  Misses                ?    20166           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.78% <100.00%> (?)
unit 79.61% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/utils/graphTraversalUtil.ts 99.40% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor

Required E2E is red on the target-line Signin dialog resolves true on login expectation, not on the selected-output diff. The exact root repair is #20439, which is current-head required-green under Ryan. Keep this carrier parked; do not rerun unchanged CI. After #20439 lands, refresh this branch onto cloud/1.54, then revalidate required checks and request final review.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 7, 2026
@christian-byrne
christian-byrne requested review from DrJKL and removed request for thedatalife October 7, 2026 20:51

@mrseek-reviews mrseek-reviews Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Approve. This is a faithful backport of #20437, with identical hunks in both files.

I compared against #20437's merge commit d8de6137db5c448d240aaa2662a3587eabbc0f8a. Against the current cloud/1.54 tip, the branch's net diff (cherry-pick plus a merge of cloud/1.54) is exactly the source's two hunks:

  • graphTraversalUtil.ts uses createLeafNodeExecutionId(node.id) for root nodes in getExecutionIdsForSelectedNodes. That helper already exists and is imported on this branch.
  • graphTraversalUtil.test.ts adds the "should keep a colon-bearing root node ID whole" case.

No adaptation was needed.

Checks: graphTraversalUtil.test.ts passes locally at this head (115 tests). Hosted CI at 5f2a9ef is fully green, including lint-and-format, typecheck, test and e2e-status.

@DrJKL DrJKL assigned comfy-pr-bot and unassigned DrJKL Oct 7, 2026
@comfy-pr-bot
comfy-pr-bot merged commit 90e9d43 into cloud/1.54 Oct 7, 2026
96 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-20437-to-cloud-1.54 branch October 7, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants