Repository navigation
fix(execution): queue Agent-inserted selected outputs #20437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
christian-byrne
merged 1 commit into
Comfy-Org:main
from
christian-byrne:fix-agent-selected-insert-execution
Oct 7, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (non-blocking): this is the right change, but it's the second time this exact root-leaf case has been patched one call site at a time, and two more are still strict in this same file:
getExecutionIdByNode(line 483):if (node.graph === rootGraph || node.graph.isRootGraph) return createNodeExecutionId([node.id])getExecutionIdForNodeInGraph(line 606):const localExecutionId = createNodeExecutionId([localNodeId]), returned directly on thegraph === rootGraph || graph.isRootGraphbranchBoth have the identical shape your change fixes — no ancestor path, strict single-segment construction — so both still return
nullfor an Agent-inserted root node.getExecutionIdByNodein particular feedsexecutionErrorStore.ts,useErrorGroups.ts,missingModelScan.ts,missingMediaScan.ts,missingNodeScan.ts, andRightSidePanel.vue. For the same Krea-template workflow in the report, that would mean execution errors not attributing to the node and missing-model/media scans skipping it — the same class of bug as this one, just on surfaces nobody has filed yet.executionIdFromState(line 631-635) already carries the fixed ternary plus the explanatory comment from PM-1580, so after this PR it's 2 of 4 done.Rather than a third round, would it make sense to push the decision down one level — have the "no ancestor path ⇒ keep the raw id whole" rule live inside the helper, so callers can't pick the wrong one? That's a property of the contract, not of each call site, and it's what the
createLeafNodeExecutionIddocstring already describes. Happy for that to be a follow-up if you'd rather keep this PR tight to the production report — just flagging it so the remaining two don't wait for another user to hit them.