Repository navigation
[backport core/1.54] [chore] Update Ingest API types from cloud@6460455 - #20399
christian-byrne merged 1 commit into
Conversation
|
@christian-byrne is attempting to deploy a commit to the ComfyUI Team on Vercel. A member of the Team first needs to authorize it. |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1987 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-07T04:47:07.826Z",
"gitSha": "83d8b98db198724414624d3be5e4a8cad0ae9b0d",
"branch": "backport-20393-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2055.950999999993,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.360999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.293,
"heapDeltaBytes": -7901924,
"heapUsedBytes": 62730536,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.969000000000003,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2023.4159999999974,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.792000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.6740000000001,
"heapDeltaBytes": -12267112,
"heapUsedBytes": 60634184,
"domNodes": -280,
"jsHeapTotalBytes": 3964928,
"scriptDurationMs": 8.616999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1847.3859999999718,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.845999999999997,
"layouts": 14,
"layoutDurationMs": 3.7869999999999995,
"taskDurationMs": 889.923,
"heapDeltaBytes": 7954176,
"heapUsedBytes": 79381136,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 162.417,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1819.3200000000047,
"styleRecalcs": 76,
"styleRecalcDurationMs": 30.072000000000003,
"layouts": 14,
"layoutDurationMs": 3.3919999999999995,
"taskDurationMs": 872.861,
"heapDeltaBytes": -713224,
"heapUsedBytes": 70776860,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 158.086,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.5780000000223,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.604,
"layouts": 6,
"layoutDurationMs": 1.055,
"taskDurationMs": 345.095,
"heapDeltaBytes": 4513508,
"heapUsedBytes": 75280228,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.482999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.7279999999982,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.815999999999999,
"layouts": 6,
"layoutDurationMs": 0.9600000000000002,
"taskDurationMs": 342.912,
"heapDeltaBytes": 4508952,
"heapUsedBytes": 75858120,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.973000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 710.3020000000129,
"styleRecalcs": 15,
"styleRecalcDurationMs": 10.327,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.96000000000004,
"heapDeltaBytes": -7955056,
"heapUsedBytes": 63540472,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 169.015,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 631.9210000000339,
"styleRecalcs": 15,
"styleRecalcDurationMs": 9.601000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.85499999999996,
"heapDeltaBytes": -7543828,
"heapUsedBytes": 66101796,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 163.422,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.2630000000013,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.218,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 657.5929999999998,
"heapDeltaBytes": -8291232,
"heapUsedBytes": 72531232,
"domNodes": -278,
"jsHeapTotalBytes": -1802240,
"scriptDurationMs": 44.141999999999996,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.8820000000105,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.341,
"heapDeltaBytes": -9449924,
"heapUsedBytes": 71319568,
"domNodes": -284,
"jsHeapTotalBytes": -1540096,
"scriptDurationMs": 31.499999999999993,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2399.526000000037,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.331,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1675.4940000000001,
"heapDeltaBytes": 792412,
"heapUsedBytes": 67116296,
"domNodes": -276,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 856.409,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2191.237000000001,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.691,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1543.2269999999999,
"heapDeltaBytes": 1075636,
"heapUsedBytes": 66959064,
"domNodes": -271,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 811.3629999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3641.868000000045,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.280999999999999,
"layouts": 60,
"layoutDurationMs": 12.306,
"taskDurationMs": 1744.569,
"heapDeltaBytes": -1178440,
"heapUsedBytes": 67114756,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 802.406,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3624.135000000024,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.459,
"layouts": 60,
"layoutDurationMs": 11.843,
"taskDurationMs": 1717.1659999999997,
"heapDeltaBytes": -11510304,
"heapUsedBytes": 71078200,
"domNodes": -265,
"jsHeapTotalBytes": 2654208,
"scriptDurationMs": 782.516,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3126.098999999954,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.889,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1942.071,
"heapDeltaBytes": -13536808,
"heapUsedBytes": 68277748,
"domNodes": 8,
"jsHeapTotalBytes": 5136384,
"scriptDurationMs": 1007.4019999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 10,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3047.877999999969,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.161,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1833.005,
"heapDeltaBytes": 6656216,
"heapUsedBytes": 89751376,
"domNodes": 4,
"jsHeapTotalBytes": 6709248,
"scriptDurationMs": 939.5120000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2001.5730000000076,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.8569999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.70600000000013,
"heapDeltaBytes": 11516120,
"heapUsedBytes": 77804724,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.919,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2031.4769999999953,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.08,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.9650000000001,
"heapDeltaBytes": -3137028,
"heapUsedBytes": 76952640,
"domNodes": -271,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 40.01299999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.1180000000181,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.868,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.594,
"heapDeltaBytes": 15126264,
"heapUsedBytes": 91030720,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.02700000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 569.6770000000697,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.978999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.99,
"heapDeltaBytes": 13694932,
"heapUsedBytes": 86668220,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 140.72799999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2037.2780000000148,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.296999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.2630000000001,
"heapDeltaBytes": -16047828,
"heapUsedBytes": 56596116,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 12.812,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.764999999983,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.175,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.3259999999999,
"heapDeltaBytes": -3199220,
"heapUsedBytes": 72372412,
"domNodes": -295,
"jsHeapTotalBytes": 4489216,
"scriptDurationMs": 7.138999999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1718.8199999999938,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.176,
"layouts": 18,
"layoutDurationMs": 4.806,
"taskDurationMs": 868.75,
"heapDeltaBytes": 9049932,
"heapUsedBytes": 82587900,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 115.71400000000001,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.132000000015,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.013,
"layouts": 18,
"layoutDurationMs": 4.636,
"taskDurationMs": 796.049,
"heapDeltaBytes": -10800044,
"heapUsedBytes": 62607296,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 110.52300000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1382.141000000047,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.805,
"layouts": 15,
"layoutDurationMs": 15.396999999999997,
"taskDurationMs": 897.4729999999997,
"heapDeltaBytes": -5137404,
"heapUsedBytes": 87569704,
"domNodes": 13831,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 29.641999999999996,
"eventListeners": 2385,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8464.645999999959,
"styleRecalcs": 245,
"styleRecalcDurationMs": 34.616,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5783.179999999999,
"heapDeltaBytes": 14637632,
"heapUsedBytes": 92839384,
"domNodes": -273,
"jsHeapTotalBytes": -176128,
"scriptDurationMs": 2783.181,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8253.647999999997,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.799,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5419.358,
"heapDeltaBytes": 15053936,
"heapUsedBytes": 92728968,
"domNodes": -267,
"jsHeapTotalBytes": -929792,
"scriptDurationMs": 2660.987,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16598.911999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15848.987000000001,
"heapDeltaBytes": -41094460,
"heapUsedBytes": 179003880,
"domNodes": -8068,
"jsHeapTotalBytes": -10805248,
"scriptDurationMs": 252.591,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16910.88000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16403.428,
"heapDeltaBytes": -39174500,
"heapUsedBytes": 178594352,
"domNodes": -8068,
"jsHeapTotalBytes": -10469376,
"scriptDurationMs": 270.407,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20271.086999999967,
"styleRecalcs": 168,
"styleRecalcDurationMs": 16.239000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19900.68,
"heapDeltaBytes": -49079108,
"heapUsedBytes": 169678660,
"domNodes": -8068,
"jsHeapTotalBytes": -11051008,
"scriptDurationMs": 902.9010000000001,
"eventListeners": -14925,
"totalBlockingTimeMs": 16,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20853.656000000003,
"styleRecalcs": 170,
"styleRecalcDurationMs": 17.45100000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20436.67,
"heapDeltaBytes": -41661360,
"heapUsedBytes": 170321912,
"domNodes": -8068,
"jsHeapTotalBytes": -19427328,
"scriptDurationMs": 910.5339999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 29,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6202.50100000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.594,
"layouts": 20,
"layoutDurationMs": 23.294999999999995,
"taskDurationMs": 6064.653,
"heapDeltaBytes": -33618348,
"heapUsedBytes": 184708784,
"domNodes": -8068,
"jsHeapTotalBytes": 19910656,
"scriptDurationMs": 106.74100000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 457,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5958.798999999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.35400000000004,
"layouts": 20,
"layoutDurationMs": 21.634999999999987,
"taskDurationMs": 5854.666,
"heapDeltaBytes": -35518308,
"heapUsedBytes": 183154536,
"domNodes": -8068,
"jsHeapTotalBytes": 13123584,
"scriptDurationMs": 102.863,
"eventListeners": -14929,
"totalBlockingTimeMs": 355,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8386.995999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8153.383999999999,
"heapDeltaBytes": -989584,
"heapUsedBytes": 180770844,
"domNodes": 0,
"jsHeapTotalBytes": -25427968,
"scriptDurationMs": 153.15800000000002,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8373.643000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8072.447999999999,
"heapDeltaBytes": 13228256,
"heapUsedBytes": 178979484,
"domNodes": 0,
"jsHeapTotalBytes": -20971520,
"scriptDurationMs": 121.554,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 475.62099999998964,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.816000000000003,
"layouts": 3,
"layoutDurationMs": 1.2339999999999998,
"taskDurationMs": 109.51299999999999,
"heapDeltaBytes": 4895396,
"heapUsedBytes": 74356504,
"domNodes": 147,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.198,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 87.86499999996522,
"styleRecalcs": 6,
"styleRecalcDurationMs": 13.424999999999999,
"layouts": 2,
"layoutDurationMs": 1.4160000000000001,
"taskDurationMs": 67.67599999999999,
"heapDeltaBytes": 2965236,
"heapUsedBytes": 74691728,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.157,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #20399 +/- ##
=============================================
- Coverage 84.39% 82.79% -1.60%
=============================================
Files 2125 2555 +430
Lines 127696 135377 +7681
Branches 34415 36283 +1868
=============================================
+ Hits 107764 112091 +4327
- Misses 19744 22763 +3019
- Partials 188 523 +335
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 440 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: Approve. This is a faithful backport of #20393, with identical hunks in both generated files.
I compared against #20393's merge commit 850d562e93a4e2ed7920d1302a9ca2415378f7e5. types.gen.ts adds the same optional 'agent-starter-prompt-set'?: 'control' | 'test' field and doc comment to GetFeaturesResponses. zod.gen.ts adds the same z.enum(['control', 'test']).optional().default('control') entry to zGetFeaturesResponse. No other lines change.
The only difference is placement. The agent experiment keys that precede it on main do not exist on core/1.54, so it is the first key of the features response. That is its alphabetical position in this branch's schema, and it does not change what the schema accepts.
Checks: tsc --noEmit for packages/ingest-types passes locally at this head. Hosted CI at 5e1b7ca is green, including lint-and-format, test and e2e-status.
Summary
Backports the Agent starter-prompt experiment assignment contract from #20393 to core/1.54.
Changes
agent-starter-prompt-set?: control | testgenerated type and matching Zodcontroldefault.Review Focus
Confirm the release-line generated shape matches #20393 without importing unrelated regenerated API changes.
Validation: generated-file format check, package TypeScript check, root app typecheck, ESLint, and runtime Zod checks (default control; test accepted; invalid rejected) all pass. The local pre-commit was bypassed only after it hit the known release-line
comfy/no-duplicate-ingest-typefalse positive that reports the canonical generated file as duplicating itself; main already exempts that canonical path. The diff remains exactly two generated files / eight added lines.