Skip to content

[backport core/1.54] test(agent): pin the empty canvas a displaced agent build leaves behind (PM-1535) - #20378

Closed
comfy-pr-bot wants to merge 1 commit into
core/1.54from
backport-18610-to-core-1.54
Closed

comfy-pr-bot wants to merge 1 commit into
core/1.54from
backport-18610-to-core-1.54

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #18610 to core/1.54

Automatically created by backport workflow.

…nd (PM-1535) (#18610)

## Summary

Adds a black-box E2E pin for
[PM-1535](https://linear.app/comfyorg/issue/PM-1535): after two Agent
threads bind two workflow tabs, Alpha's build reaches Alpha's document
while Bravo remains active, but returning to Alpha leaves the selected
canvas empty.

The first case keeps an unconditional known-failure marker. An empty
canvas is the expected PM-1535 failure, a wrong or partial canvas fails
before the marker, and a fixed canvas becomes an unexpected pass that
tells the fixer to remove the marker and containment guard. The second
case is the positive control: a later turn rebinding Alpha materializes
the exact build already held by Alpha's document.

This carrier supersedes #18088 but intentionally does not carry its
three PM-1319 cases. Those pins and the shared-fixture consolidation are
tracked separately in #19663.

## Changes

- **What**: Adds `agentTwoSessionCrdtFixture.ts` and two focused cloud
Playwright cases for displaced-build return and recovery.
- **Dependencies**: None.

## Review Focus

- The unconditional `test.fail` must remain until PM-1535 is fixed.
- `expect([[], BUILT_NODE_IDS]).toContainEqual(canvas)` must reject
wrong or partial canvases before the known-failure marker.
- The exact-id positive control must continue proving that the stored
build is recoverable after rebinding.
- Scope is one of the two empty canvases in the report. This carrier
must not close PM-1535 by itself.

## Verification

```bash
PLAYWRIGHT_TEST_URL=http://127.0.0.1:6254 \
PLAYWRIGHT_SETUP_API_URL=http://127.0.0.1:6290 \
DEV_SERVER_COMFYUI_URL=http://127.0.0.1:6290 \
DISTRIBUTION=cloud NODE_OPTIONS=--no-experimental-webstorage \
pnpm exec playwright test \
  browser_tests/tests/agent/agentTwoSessionCrdtSubscription.spec.ts \
  --project=cloud --workers=1 --retries=0
```

Head `c61b3507f136c3c687833024af59a0fb8432aad7`: 2/2 focused tests
passed against a local backend. Mutation proof at that head makes a
canvas reader that always throws fail at that exact error instead of
passing as PM-1535. `6a40cf8` trims the harness (schema-parsed
`doc_subscribe`, private internals, catalog taken from the build
recording, comments moved into assertion and marker messages) without
changing either oracle; ESLint, type-aware oxlint, oxfmt, `pnpm
typecheck:browser`, and the hosted cloud Playwright shards cover it.

Related: PM-1535

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Oct 7, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) October 7, 2026 02:30
@vercel

vercel Bot commented Oct 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 7, 2026 2:30am UTC
billing-web-test Ignored Ignored Oct 7, 2026 2:30am UTC

Request Review

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: 🕵🏻 0 passed, 0 failed

📊 Browser Reports

📦 Bundle Size

⏳ Size data collection in progress…

🔬 E2E Coverage

⚠️ Coverage collection failed. Check the CI workflow logs.

@github-actions
github-actions Bot requested a review from thedatalife October 7, 2026 02:30
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 7, 2026
@datadog-official

datadog-official Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 27 Pipeline jobs failed

CI: Lint Format | lint-and-format — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

CI: Lint Format | repo-checks — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

CI: Lint Format | typecheck-aux — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

View all 27 failed jobs.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3f74763 | Docs | View more details | Give us feedback!

@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@             Coverage Diff              @@
##           core/1.54   #20378     +/-   ##
============================================
  Coverage      84.39%   84.39%             
============================================
  Files           2125     2125             
  Lines         127696   127696             
  Branches       34415    32532   -1883     
============================================
  Hits          107764   107764             
  Misses         19744    19744             
  Partials         188      188             
Flag Coverage Δ
unit 79.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head review at 3f74763bfec6d53779fc1db4efba423296e80ed2: this is not a valid core/1.54 test-only backport yet.

After adapting the main-only harness imports and helper signature in an isolated diagnostic worktree—without weakening either assertion—the required positive control still failed: the follower received and applied all three CRDT ops with no skips, errors, gaps, resets, or drops, and the shared document contained the three Alpha nodes, but the user-visible Alpha canvas remained empty. The release line lacks the current graph-API projection seam; carrying only these two test files cannot make the source behavior true. The current hosted failures are therefore not just mechanical collection failures.

Do not merge or weaken/delete the positive control. Wake this carrier only after an owning-team change on core/1.54 materializes the already-applied nodes on the visible canvas, or after the release owner explicitly supplies a target-supported equivalent. Then refresh the target, carry the required harness dependencies, remove the prohibited bot trailers, and require both focused cases plus all exact-head gates to pass. If that behavior will not be backported, close this carrier as non-applicable.

@christian-byrne

Copy link
Copy Markdown
Contributor

Closing this generated core/1.54 carrier as non-applicable after exact-head release diagnosis. The unchanged positive control proves the target line receives and applies all three CRDT ops into the shared document but its legacy projection leaves the visible canvas empty; carrying only these test files cannot make that product behavior true. The main-line source proof remains merged. Reopen only if core/1.54 gains a target-supported projection fix, then recut with its harness dependencies and require both focused cases plus all exact-head gates to pass.

auto-merge was automatically disabled October 7, 2026 11:41

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants