Repository navigation
[backport core/1.54] test(agent): pin the empty canvas a displaced agent build leaves behind (PM-1535) - #20378
comfy-pr-bot wants to merge 1 commit into
Conversation
…nd (PM-1535) (#18610) ## Summary Adds a black-box E2E pin for [PM-1535](https://linear.app/comfyorg/issue/PM-1535): after two Agent threads bind two workflow tabs, Alpha's build reaches Alpha's document while Bravo remains active, but returning to Alpha leaves the selected canvas empty. The first case keeps an unconditional known-failure marker. An empty canvas is the expected PM-1535 failure, a wrong or partial canvas fails before the marker, and a fixed canvas becomes an unexpected pass that tells the fixer to remove the marker and containment guard. The second case is the positive control: a later turn rebinding Alpha materializes the exact build already held by Alpha's document. This carrier supersedes #18088 but intentionally does not carry its three PM-1319 cases. Those pins and the shared-fixture consolidation are tracked separately in #19663. ## Changes - **What**: Adds `agentTwoSessionCrdtFixture.ts` and two focused cloud Playwright cases for displaced-build return and recovery. - **Dependencies**: None. ## Review Focus - The unconditional `test.fail` must remain until PM-1535 is fixed. - `expect([[], BUILT_NODE_IDS]).toContainEqual(canvas)` must reject wrong or partial canvases before the known-failure marker. - The exact-id positive control must continue proving that the stored build is recoverable after rebinding. - Scope is one of the two empty canvases in the report. This carrier must not close PM-1535 by itself. ## Verification ```bash PLAYWRIGHT_TEST_URL=http://127.0.0.1:6254 \ PLAYWRIGHT_SETUP_API_URL=http://127.0.0.1:6290 \ DEV_SERVER_COMFYUI_URL=http://127.0.0.1:6290 \ DISTRIBUTION=cloud NODE_OPTIONS=--no-experimental-webstorage \ pnpm exec playwright test \ browser_tests/tests/agent/agentTwoSessionCrdtSubscription.spec.ts \ --project=cloud --workers=1 --retries=0 ``` Head `c61b3507f136c3c687833024af59a0fb8432aad7`: 2/2 focused tests passed against a local backend. Mutation proof at that head makes a canvas reader that always throws fail at that exact error instead of passing as PM-1535. `6a40cf8` trims the harness (schema-parsed `doc_subscribe`, private internals, catalog taken from the build recording, comments moved into assertion and marker messages) without changing either oracle; ESLint, type-aware oxlint, oxfmt, `pnpm typecheck:browser`, and the hosted cloud Playwright shards cover it. Related: PM-1535 --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🎭 Playwright: 🕵🏻 0 passed, 0 failed📊 Browser Reports
📦 Bundle Size
🔬 E2E Coverage
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 27 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 3f74763 | Docs | View more details | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #20378 +/- ##
============================================
Coverage 84.39% 84.39%
============================================
Files 2125 2125
Lines 127696 127696
Branches 34415 32532 -1883
============================================
Hits 107764 107764
Misses 19744 19744
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head review at 3f74763bfec6d53779fc1db4efba423296e80ed2: this is not a valid core/1.54 test-only backport yet.
After adapting the main-only harness imports and helper signature in an isolated diagnostic worktree—without weakening either assertion—the required positive control still failed: the follower received and applied all three CRDT ops with no skips, errors, gaps, resets, or drops, and the shared document contained the three Alpha nodes, but the user-visible Alpha canvas remained empty. The release line lacks the current graph-API projection seam; carrying only these two test files cannot make the source behavior true. The current hosted failures are therefore not just mechanical collection failures.
Do not merge or weaken/delete the positive control. Wake this carrier only after an owning-team change on core/1.54 materializes the already-applied nodes on the visible canvas, or after the release owner explicitly supplies a target-supported equivalent. Then refresh the target, carry the required harness dependencies, remove the prohibited bot trailers, and require both focused cases plus all exact-head gates to pass. If that behavior will not be backported, close this carrier as non-applicable.
|
Closing this generated core/1.54 carrier as non-applicable after exact-head release diagnosis. The unchanged positive control proves the target line receives and applies all three CRDT ops into the shared document but its legacy projection leaves the visible canvas empty; carrying only these test files cannot make that product behavior true. The main-line source proof remains merged. Reopen only if core/1.54 gains a target-supported projection fix, then recut with its harness dependencies and require both focused cases plus all exact-head gates to pass. |
Pull request was closed
Backport of #18610 to
core/1.54Automatically created by backport workflow.