Repository navigation
[backport cloud/1.56] FE-3211 fix(cloud): drop the fallback unified credential once the web session signs the tab in - #20341
Conversation
… session signs the tab in (#20183) Stacked on #20151 (base). Part of FE-3211. ## Why PR 20151 stops the unified Firebase mint on a tab the web session signed in. A tab whose session first settles **not** signed in (e.g. `restore_failed`, or `retry_wait` then `signed_out`) still falls back to the token rail and mints a personal unified credential. If the session later signs that tab in (same user), the credential stays alive and the FE-3211 symptom comes back on this rarer path: Runs land in Personal. ## Root cause Nothing drops the fallback unified credential when the session signs the tab in. Its cross-tab lease (`comfy-account-refresh:<uid>:<workspace>`) keeps adopting a sibling's published token, and `workspaceAuthStore`'s `unifiedSessionClient.subscribe` then overwrites `currentWorkspace` with the sibling's workspace. `cloudWebSessionStore.requestScope()` takes `X-Comfy-Workspace-ID` from `currentWorkspace`, so `POST /api/prompt` loses the team header. ## How - `cloudWebSessionStore` watches `signedInUser.id`; when the tab becomes signed in it calls `workspaceAuthStore.clearUnifiedContext()` (now exposed). That invalidates the session client (credential, scheduler, cross-tab lease) without touching `currentWorkspace`. - A watch rather than a hook in `switchSessionWorkspace`: it also covers a tab that never switches, whose fallback credential would otherwise keep re-minting `/api/auth/token` in the background. - `cloudWebSessionStore` already imports `workspaceAuthStore`, so no new import cycle. - With `unified_web_session` off, `start()` never creates the identity, `state` stays `idle`, and the watch never fires. `webSessionFlagOff.test.ts` passes unchanged. ## AS IS / TO BE Regression test in `src/platform/auth/webSessionFlagOn.test.ts` (`a sibling tab under unified_cloud_auth`): session missing at boot → fallback mint → session sign-in → select `ws-team` → sibling publishes a personal token → Run. | | `currentWorkspace` | `POST /api/prompt` `x-comfy-workspace-id` | |---|---|---| | AS IS (test commit 1a30364 alone) | `ws-personal` | missing | | TO BE (with f64e0fd) | `ws-team` | `ws-team` | Real-app capture: _pending_ ## Plan position | Item | Ticket | PR | Status | |---|---|---|---| | Stop the unified mint on a session tab | FE-3211 | #20151 | open | | **Drop the fallback credential when the session signs the tab in** | **FE-3211** | **this PR** | **open** | ```mermaid graph LR A["PR 20151: no unified mint on a session tab"] --> B["This PR: drop fallback credential on session sign-in"] style B fill:#f9d71c,stroke:#333,stroke-width:2px ```
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (10 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4270d954e9bc60f4572943780b6ab58eb105c795
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2200 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-06T21:26:53.808Z",
"gitSha": "11caaf2d49ca8d00d8084e14d7fc02707aeb8636",
"branch": "backport-20183-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.7139999999886,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.241,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.958,
"heapDeltaBytes": 554612,
"heapUsedBytes": 68510112,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.049,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2024.2319999999836,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.056,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.34600000000006,
"heapDeltaBytes": 591492,
"heapUsedBytes": 68224684,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.288999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1836.8999999999573,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.131,
"layouts": 12,
"layoutDurationMs": 4.513000000000001,
"taskDurationMs": 883.111,
"heapDeltaBytes": -2235392,
"heapUsedBytes": 65733644,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 171.41,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665454545454544,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.2080000000205,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.040000000000003,
"layouts": 12,
"layoutDurationMs": 4.4510000000000005,
"taskDurationMs": 852.842,
"heapDeltaBytes": -2419688,
"heapUsedBytes": 65566692,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 168.661,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1700.5780000000073,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.54,
"layouts": 6,
"layoutDurationMs": 1.165,
"taskDurationMs": 383.699,
"heapDeltaBytes": 4064104,
"heapUsedBytes": 72364032,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.793000000000008,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.0749999999853,
"styleRecalcs": 29,
"styleRecalcDurationMs": 10.832999999999998,
"layouts": 6,
"layoutDurationMs": 1.284,
"taskDurationMs": 366.56100000000004,
"heapDeltaBytes": 3751556,
"heapUsedBytes": 71040048,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.982999999999995,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 723.7920000000031,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.823,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.45700000000005,
"heapDeltaBytes": 15687116,
"heapUsedBytes": 76046700,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 178.254,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 729.9050000000307,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.7649999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.49800000000005,
"heapDeltaBytes": -6424300,
"heapUsedBytes": 61237264,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 166.233,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1262.4339999999847,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 958.534,
"heapDeltaBytes": 39146304,
"heapUsedBytes": 108034228,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 78.17300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 630,
"frameDurationMs": 37.25294117647057,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1187.1290000000272,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 863.619,
"heapDeltaBytes": 15393140,
"heapUsedBytes": 84233712,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 70.131,
"eventListeners": 0,
"totalBlockingTimeMs": 553,
"frameDurationMs": 34.80294117647057,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.3749999999764,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.337,
"heapDeltaBytes": 17740472,
"heapUsedBytes": 104733668,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 173.00800000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 896.9109999999318,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.21099999999973,
"heapDeltaBytes": 17081512,
"heapUsedBytes": 104421680,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 167.38199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 250,
"frameDurationMs": 25.714285714285715,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10706.713000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9691.674,
"heapDeltaBytes": -5978100,
"heapUsedBytes": 78899200,
"domNodes": -142,
"jsHeapTotalBytes": -11407360,
"scriptDurationMs": 7979.856,
"eventListeners": -74,
"totalBlockingTimeMs": 1320,
"frameDurationMs": 33.4359375,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9470.376000000102,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8809.203,
"heapDeltaBytes": -12990812,
"heapUsedBytes": 72385424,
"domNodes": -112,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 7416.3640000000005,
"eventListeners": -78,
"totalBlockingTimeMs": 1228,
"frameDurationMs": 36.54903474903475,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10447.046999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9416.091999999999,
"heapDeltaBytes": 5771604,
"heapUsedBytes": 83511320,
"domNodes": -142,
"jsHeapTotalBytes": -5378048,
"scriptDurationMs": 7761.762999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 1239,
"frameDurationMs": 32.15261538461539,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10683.377000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9699.242,
"heapDeltaBytes": -12055996,
"heapUsedBytes": 73301316,
"domNodes": -171,
"jsHeapTotalBytes": -8261632,
"scriptDurationMs": 7979.234999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 1327,
"frameDurationMs": 33.48871473354232,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2021.8779999999583,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.212000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.16600000000005,
"heapDeltaBytes": -9725732,
"heapUsedBytes": 78925792,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 39.289,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2018.5969999999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.7680000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.24100000000004,
"heapDeltaBytes": -10555628,
"heapUsedBytes": 78485560,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 32.886999999999986,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2777.2940000000403,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.193000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1674.4759999999999,
"heapDeltaBytes": -19125380,
"heapUsedBytes": 70483140,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 860.37,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.766666666666662,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2340.3339999999844,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1556.4579999999999,
"heapDeltaBytes": -20447408,
"heapUsedBytes": 68827116,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 821.126,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3649.3689999999788,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.979,
"layouts": 60,
"layoutDurationMs": 15.270999999999999,
"taskDurationMs": 1610.459,
"heapDeltaBytes": 1612536,
"heapUsedBytes": 69566320,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 816.78,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66575342465753,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3667.3849999999675,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.972999999999999,
"layouts": 60,
"layoutDurationMs": 14.133999999999999,
"taskDurationMs": 1718.747,
"heapDeltaBytes": 1584668,
"heapUsedBytes": 69534556,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 814.102,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909086,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3115.0220000000104,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.898999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1949.626,
"heapDeltaBytes": 8691820,
"heapUsedBytes": 77266172,
"domNodes": 0,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 997.984,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.845945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3089.6779999999353,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.755,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1835.4840000000002,
"heapDeltaBytes": 4405416,
"heapUsedBytes": 72589956,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 977.208,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7568306010929,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2011.0459999999648,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.8919999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.558,
"heapDeltaBytes": -9884116,
"heapUsedBytes": 80081532,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 38.01800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.2039999999733,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.0219999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.87499999999994,
"heapDeltaBytes": -9687712,
"heapUsedBytes": 79658224,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 35.884,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 643.718999999976,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.214,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.9189999999999,
"heapDeltaBytes": -11712888,
"heapUsedBytes": 57693532,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 149.279,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.734999999996,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.276999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.1940000000001,
"heapDeltaBytes": -12004536,
"heapUsedBytes": 58350812,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 148.355,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2025.5429999999706,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.667000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.7479999999999,
"heapDeltaBytes": 1044204,
"heapUsedBytes": 70423480,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.795999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.3320000000858,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.756,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.59799999999996,
"heapDeltaBytes": 987676,
"heapUsedBytes": 71862732,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.455,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.4739999999765,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.072000000000003,
"layouts": 16,
"layoutDurationMs": 6.229000000000001,
"taskDurationMs": 815.0070000000001,
"heapDeltaBytes": -5932648,
"heapUsedBytes": 64076924,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 121.19599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.0419999999303,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.488,
"layouts": 16,
"layoutDurationMs": 5.6,
"taskDurationMs": 747.8119999999999,
"heapDeltaBytes": -5948240,
"heapUsedBytes": 63145212,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 112.78099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1436.130999999932,
"styleRecalcs": 16,
"styleRecalcDurationMs": 33.196000000000005,
"layouts": 5,
"layoutDurationMs": 15.59,
"taskDurationMs": 1061.604,
"heapDeltaBytes": 3079928,
"heapUsedBytes": 96863968,
"domNodes": 14227,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 34.65700000000001,
"eventListeners": 2463,
"totalBlockingTimeMs": 152,
"frameDurationMs": 19.861643835616434,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9043.30299999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.769000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5904.847,
"heapDeltaBytes": -18930396,
"heapUsedBytes": 69656324,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2850.738,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.696857670979668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8436.470999999983,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.779,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5484.888,
"heapDeltaBytes": 7797716,
"heapUsedBytes": 95892848,
"domNodes": 0,
"jsHeapTotalBytes": 1015808,
"scriptDurationMs": 2719.9849999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6990099009901,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18617.508000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17905.422000000002,
"heapDeltaBytes": -43159468,
"heapUsedBytes": 178516972,
"domNodes": -3045,
"jsHeapTotalBytes": 892928,
"scriptDurationMs": 288.26199999999994,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.822222222222223,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 18024.069000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17118.852,
"heapDeltaBytes": -39067656,
"heapUsedBytes": 179815576,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 273.50399999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.409274873524453,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 23784.918000000005,
"styleRecalcs": 179,
"styleRecalcDurationMs": 26.003999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23415.986,
"heapDeltaBytes": -40606536,
"heapUsedBytes": 175599540,
"domNodes": -3045,
"jsHeapTotalBytes": 1941504,
"scriptDurationMs": 929.0559999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.40130597014925,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 21853.426999999898,
"styleRecalcs": 182,
"styleRecalcDurationMs": 20.224999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21421.534,
"heapDeltaBytes": -22446448,
"heapUsedBytes": 192428568,
"domNodes": -3045,
"jsHeapTotalBytes": 6766592,
"scriptDurationMs": 858.4350000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 26,
"frameDurationMs": 39.90109489051095,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 6810.355999999956,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.65299999999998,
"layouts": 20,
"layoutDurationMs": 28.274999999999995,
"taskDurationMs": 6680.9310000000005,
"heapDeltaBytes": 6450192,
"heapUsedBytes": 224520748,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 121.37200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.72954545454545,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 6511.5780000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.58100000000002,
"layouts": 20,
"layoutDurationMs": 22.789000000000005,
"taskDurationMs": 6391.368999999999,
"heapDeltaBytes": 1229180,
"heapUsedBytes": 217086584,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 112.95399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.024431818181824,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9411.121999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8991.027999999998,
"heapDeltaBytes": -27056592,
"heapUsedBytes": 184677412,
"domNodes": -3045,
"jsHeapTotalBytes": 13684736,
"scriptDurationMs": 152.52900000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.47000000000001,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9209.186000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8721.174,
"heapDeltaBytes": -42876380,
"heapUsedBytes": 179644108,
"domNodes": -3045,
"jsHeapTotalBytes": 630784,
"scriptDurationMs": 143.728,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.767892976588623,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 504.5830000000251,
"styleRecalcs": 21,
"styleRecalcDurationMs": 21.124,
"layouts": 5,
"layoutDurationMs": 2.6839999999999997,
"taskDurationMs": 157.894,
"heapDeltaBytes": 5929076,
"heapUsedBytes": 71288292,
"domNodes": 129,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 17.468999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.24137931034483,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 473.53099999997994,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.859999999999998,
"layouts": 3,
"layoutDurationMs": 0.8069999999999999,
"taskDurationMs": 103.375,
"heapDeltaBytes": 5648628,
"heapUsedBytes": 70676208,
"domNodes": 101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.926999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 981.3500000000204,
"styleRecalcs": 78,
"styleRecalcDurationMs": 106.772,
"layouts": 76,
"layoutDurationMs": 26.179000000000002,
"taskDurationMs": 957.601,
"heapDeltaBytes": 19118100,
"heapUsedBytes": 83499240,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 405.342,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 835.9740000000784,
"styleRecalcs": 78,
"styleRecalcDurationMs": 102.039,
"layouts": 76,
"layoutDurationMs": 25.047,
"taskDurationMs": 808.689,
"heapDeltaBytes": 17471844,
"heapUsedBytes": 83297632,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 332.151,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1427.453000000014,
"styleRecalcs": 78,
"styleRecalcDurationMs": 272.453,
"layouts": 76,
"layoutDurationMs": 29.751,
"taskDurationMs": 1411.395,
"heapDeltaBytes": 8380196,
"heapUsedBytes": 118612004,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 481.3,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.375641025641016,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1465.951999999902,
"styleRecalcs": 78,
"styleRecalcDurationMs": 271.757,
"layouts": 76,
"layoutDurationMs": 29.038999999999998,
"taskDurationMs": 1451.1509999999998,
"heapDeltaBytes": 8817816,
"heapUsedBytes": 114356688,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 491.379,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.31234567901236,
"p95FrameDurationMs": 33.30000000000109
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
dante01yoon
left a comment
There was a problem hiding this comment.
Backport of PR 20183.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #20341 +/- ##
=============================================
Coverage ? 85.95%
=============================================
Files ? 2461
Lines ? 140577
Branches ? 36252
=============================================
Hits ? 120827
Misses ? 19372
Partials ? 378
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #20183 to
cloud/1.56Automatically created by backport workflow.