Repository navigation
[backport core/1.56] FE-3211 fix(cloud): drop the fallback unified credential once the web session signs the tab in - #20340
Conversation
… session signs the tab in (#20183) Stacked on #20151 (base). Part of FE-3211. ## Why PR 20151 stops the unified Firebase mint on a tab the web session signed in. A tab whose session first settles **not** signed in (e.g. `restore_failed`, or `retry_wait` then `signed_out`) still falls back to the token rail and mints a personal unified credential. If the session later signs that tab in (same user), the credential stays alive and the FE-3211 symptom comes back on this rarer path: Runs land in Personal. ## Root cause Nothing drops the fallback unified credential when the session signs the tab in. Its cross-tab lease (`comfy-account-refresh:<uid>:<workspace>`) keeps adopting a sibling's published token, and `workspaceAuthStore`'s `unifiedSessionClient.subscribe` then overwrites `currentWorkspace` with the sibling's workspace. `cloudWebSessionStore.requestScope()` takes `X-Comfy-Workspace-ID` from `currentWorkspace`, so `POST /api/prompt` loses the team header. ## How - `cloudWebSessionStore` watches `signedInUser.id`; when the tab becomes signed in it calls `workspaceAuthStore.clearUnifiedContext()` (now exposed). That invalidates the session client (credential, scheduler, cross-tab lease) without touching `currentWorkspace`. - A watch rather than a hook in `switchSessionWorkspace`: it also covers a tab that never switches, whose fallback credential would otherwise keep re-minting `/api/auth/token` in the background. - `cloudWebSessionStore` already imports `workspaceAuthStore`, so no new import cycle. - With `unified_web_session` off, `start()` never creates the identity, `state` stays `idle`, and the watch never fires. `webSessionFlagOff.test.ts` passes unchanged. ## AS IS / TO BE Regression test in `src/platform/auth/webSessionFlagOn.test.ts` (`a sibling tab under unified_cloud_auth`): session missing at boot → fallback mint → session sign-in → select `ws-team` → sibling publishes a personal token → Run. | | `currentWorkspace` | `POST /api/prompt` `x-comfy-workspace-id` | |---|---|---| | AS IS (test commit 1a30364 alone) | `ws-personal` | missing | | TO BE (with f64e0fd) | `ws-team` | `ws-team` | Real-app capture: _pending_ ## Plan position | Item | Ticket | PR | Status | |---|---|---|---| | Stop the unified mint on a session tab | FE-3211 | #20151 | open | | **Drop the fallback credential when the session signs the tab in** | **FE-3211** | **this PR** | **open** | ```mermaid graph LR A["PR 20151: no unified mint on a session tab"] --> B["This PR: drop fallback credential on session sign-in"] style B fill:#f9d71c,stroke:#333,stroke-width:2px ```
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (10 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d19dbd673dd5173f64e36b8f0f4ee6362c61ab2f
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2202 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-06T21:22:30.547Z",
"gitSha": "4c6db52e998b6772fa82bb4a9b01ffc3a030ba69",
"branch": "backport-20183-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2012.7580000000762,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.6869999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 266.903,
"heapDeltaBytes": 591640,
"heapUsedBytes": 68508508,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.639000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2007.622000000083,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.239000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 260.443,
"heapDeltaBytes": 520956,
"heapUsedBytes": 68635816,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.795999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.9520000000284,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.366,
"layouts": 12,
"layoutDurationMs": 4.275,
"taskDurationMs": 541.9999999999999,
"heapDeltaBytes": -2075932,
"heapUsedBytes": 65824852,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 113.712,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1672.3990000000413,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.182999999999998,
"layouts": 12,
"layoutDurationMs": 3.9259999999999997,
"taskDurationMs": 462.10299999999995,
"heapDeltaBytes": -2404256,
"heapUsedBytes": 65982796,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 94.531,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.5769999999966,
"styleRecalcs": 32,
"styleRecalcDurationMs": 7.965000000000002,
"layouts": 6,
"layoutDurationMs": 1.048,
"taskDurationMs": 214.889,
"heapDeltaBytes": 3737904,
"heapUsedBytes": 71803196,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.250000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.7269999999535,
"styleRecalcs": 29,
"styleRecalcDurationMs": 9.104,
"layouts": 6,
"layoutDurationMs": 1.3190000000000002,
"taskDurationMs": 230.14300000000003,
"heapDeltaBytes": 3805108,
"heapUsedBytes": 72704800,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.562999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 510.97200000003795,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.289,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.64000000000004,
"heapDeltaBytes": -6421336,
"heapUsedBytes": 61468440,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 109.32600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 415.4989999999543,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.685,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 281.83200000000005,
"heapDeltaBytes": -7465484,
"heapUsedBytes": 61022124,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 102.444,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 942.4410000000307,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.8389999999999,
"heapDeltaBytes": 15346588,
"heapUsedBytes": 84892116,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 37.391000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 340,
"frameDurationMs": 28.78787878787879,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 859.4630000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.24199999999996,
"heapDeltaBytes": 15186024,
"heapUsedBytes": 84880456,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 34.59699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 250,
"frameDurationMs": 25.488235294117644,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 700.7639999999355,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 272.71599999999995,
"heapDeltaBytes": 16904964,
"heapUsedBytes": 103800096,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 97.61,
"eventListeners": 0,
"totalBlockingTimeMs": 92,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 704.4069999999465,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 257.692,
"heapDeltaBytes": 17423396,
"heapUsedBytes": 103150988,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 87.96000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 87,
"frameDurationMs": 20.477142857142876,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5724.628000000052,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9410000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4962.028,
"heapDeltaBytes": -16369492,
"heapUsedBytes": 69437712,
"domNodes": -177,
"jsHeapTotalBytes": -13242368,
"scriptDurationMs": 3904.966,
"eventListeners": -82,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.409737827715354,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5024.736999999959,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5139999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4267.478000000001,
"heapDeltaBytes": 3496088,
"heapUsedBytes": 81570324,
"domNodes": -142,
"jsHeapTotalBytes": -8785920,
"scriptDurationMs": 3456.3869999999997,
"eventListeners": -74,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.815748031496064,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5298.237000000086,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.486000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4500.858,
"heapDeltaBytes": 6884432,
"heapUsedBytes": 85787168,
"domNodes": -143,
"jsHeapTotalBytes": -11145216,
"scriptDurationMs": 3545.0679999999998,
"eventListeners": -82,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.541860465116276,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5073.7100000000055,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4829999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4384.0830000000005,
"heapDeltaBytes": -7152000,
"heapUsedBytes": 70079388,
"domNodes": -142,
"jsHeapTotalBytes": -7999488,
"scriptDurationMs": 3470.895,
"eventListeners": -78,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.012598425196853,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2009.3570000000227,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.200999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 298.03999999999996,
"heapDeltaBytes": -10831252,
"heapUsedBytes": 77494440,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 27.755000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2007.7780000000303,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.646000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 268.22200000000004,
"heapDeltaBytes": -10549536,
"heapUsedBytes": 78259044,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 19.844999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2121.3339999999334,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.852999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1046.19,
"heapDeltaBytes": -19159152,
"heapUsedBytes": 70306292,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 566.649,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283467,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2130.3859999999304,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.591999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1026.438,
"heapDeltaBytes": -20107596,
"heapUsedBytes": 68454928,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 560.535,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665354330708666,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3169.1959999999426,
"styleRecalcs": 74,
"styleRecalcDurationMs": 14.18,
"layouts": 60,
"layoutDurationMs": 14.787,
"taskDurationMs": 1162.3830000000003,
"heapDeltaBytes": 2228092,
"heapUsedBytes": 70125576,
"domNodes": 24,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 564.6370000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666315789473682,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3098.7709999999424,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.004,
"layouts": 60,
"layoutDurationMs": 15.082,
"taskDurationMs": 1111.746,
"heapDeltaBytes": 1705132,
"heapUsedBytes": 70046336,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 511.655,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66559139784946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2153.43699999994,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.066,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1244.1599999999999,
"heapDeltaBytes": 4213948,
"heapUsedBytes": 72787144,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 651.5139999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667187499999997,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2155.5889999999636,
"styleRecalcs": 50,
"styleRecalcDurationMs": 7.936999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1245.928,
"heapDeltaBytes": 4052440,
"heapUsedBytes": 73083792,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 626.995,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2003.8150000000314,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9509999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 278.13599999999997,
"heapDeltaBytes": -9982096,
"heapUsedBytes": 79261184,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 25.044000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.6049999999323,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4499999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.959,
"heapDeltaBytes": -9766360,
"heapUsedBytes": 80208296,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.13699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 398.0749999999489,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.101000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 261.474,
"heapDeltaBytes": -11669256,
"heapUsedBytes": 57383684,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 91.71,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 442.12100000004284,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.794,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 276.295,
"heapDeltaBytes": -11715788,
"heapUsedBytes": 57355092,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 97.057,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670370370370367,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.1100000000115,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.5649999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 246.364,
"heapDeltaBytes": 1006360,
"heapUsedBytes": 71223712,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.404999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2011.1269999999877,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.902,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 219.434,
"heapDeltaBytes": -3683672,
"heapUsedBytes": 57445312,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.821000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1680.8980000000702,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.815000000000003,
"layouts": 16,
"layoutDurationMs": 5.1979999999999995,
"taskDurationMs": 470.661,
"heapDeltaBytes": -6019200,
"heapUsedBytes": 63796560,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 77.868,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.8950000000114,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.458,
"layouts": 16,
"layoutDurationMs": 5.0600000000000005,
"taskDurationMs": 468.521,
"heapDeltaBytes": -6085072,
"heapUsedBytes": 63708296,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 78.404,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 800.7849999999053,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.956,
"layouts": 5,
"layoutDurationMs": 8.152,
"taskDurationMs": 524.309,
"heapDeltaBytes": 236996,
"heapUsedBytes": 86807668,
"domNodes": 14227,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 18.162000000000006,
"eventListeners": 2463,
"totalBlockingTimeMs": 61,
"frameDurationMs": 19.047619047619047,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8121.759999999995,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.961999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3693.04,
"heapDeltaBytes": 7419048,
"heapUsedBytes": 95895388,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 1901.011,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665913757700203,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8106.506999999965,
"styleRecalcs": 250,
"styleRecalcDurationMs": 41.133,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3779.712,
"heapDeltaBytes": 8020088,
"heapUsedBytes": 96970092,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 1919.636,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66604938271605,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12018.312000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10877.236,
"heapDeltaBytes": -31350776,
"heapUsedBytes": 182480224,
"domNodes": -3045,
"jsHeapTotalBytes": 8933376,
"scriptDurationMs": 165.693,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.617697594501717,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "vue-large-graph-idle",
"durationMs": 12261.105000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11241.881,
"heapDeltaBytes": -45033104,
"heapUsedBytes": 181899688,
"domNodes": -3045,
"jsHeapTotalBytes": 9138176,
"scriptDurationMs": 177.94199999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.303652173913047,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 13935.807000000068,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.831999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13310.842,
"heapDeltaBytes": -35770852,
"heapUsedBytes": 189674076,
"domNodes": -3046,
"jsHeapTotalBytes": 8372224,
"scriptDurationMs": 564.742,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.67508833922262,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 15013.601999999992,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.10900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14452.860999999999,
"heapDeltaBytes": -13131080,
"heapUsedBytes": 187064640,
"domNodes": -3046,
"jsHeapTotalBytes": 8339456,
"scriptDurationMs": 618.1,
"eventListeners": -14915,
"totalBlockingTimeMs": 7,
"frameDurationMs": 26.160452961672476,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4077.5539999999637,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.95399999999999,
"layouts": 20,
"layoutDurationMs": 18.831,
"taskDurationMs": 3922.4330000000004,
"heapDeltaBytes": 987772,
"heapUsedBytes": 214418128,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 60.05300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.061538461538465,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4582.246000000055,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.77299999999999,
"layouts": 20,
"layoutDurationMs": 23.488999999999997,
"taskDurationMs": 4434.252,
"heapDeltaBytes": 14738376,
"heapUsedBytes": 214453988,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 75.275,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.044262295081968,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5750.982000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5285.390999999999,
"heapDeltaBytes": -31208180,
"heapUsedBytes": 181525768,
"domNodes": -3046,
"jsHeapTotalBytes": 10493952,
"scriptDurationMs": 71.73299999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.230100334448156,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6339.689000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5942.271,
"heapDeltaBytes": -34883028,
"heapUsedBytes": 179884664,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 100.18699999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.688698630136994,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 435.97699999997985,
"styleRecalcs": 18,
"styleRecalcDurationMs": 14.763,
"layouts": 3,
"layoutDurationMs": 1.396,
"taskDurationMs": 89.46699999999998,
"heapDeltaBytes": 5786632,
"heapUsedBytes": 72187316,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.176999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 90.2129999999488,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.69,
"layouts": 2,
"layoutDurationMs": 1.1830000000000003,
"taskDurationMs": 56.816,
"heapDeltaBytes": 3725408,
"heapUsedBytes": 69876264,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.476000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.68333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 490.099999999984,
"styleRecalcs": 78,
"styleRecalcDurationMs": 89.78800000000001,
"layouts": 76,
"layoutDurationMs": 23.024,
"taskDurationMs": 447.185,
"heapDeltaBytes": 13811652,
"heapUsedBytes": 95233740,
"domNodes": 76,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 145.761,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 510.87999999992917,
"styleRecalcs": 78,
"styleRecalcDurationMs": 90.692,
"layouts": 76,
"layoutDurationMs": 24.66,
"taskDurationMs": 470.681,
"heapDeltaBytes": 14230508,
"heapUsedBytes": 94633368,
"domNodes": 76,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 154.532,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1044.6169999999029,
"styleRecalcs": 78,
"styleRecalcDurationMs": 270.4,
"layouts": 76,
"layoutDurationMs": 29.093,
"taskDurationMs": 1020.3600000000001,
"heapDeltaBytes": -17624440,
"heapUsedBytes": 108496700,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 267.327,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66507936507936,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 978.1189999999924,
"styleRecalcs": 78,
"styleRecalcDurationMs": 257.644,
"layouts": 76,
"layoutDurationMs": 27.435000000000002,
"taskDurationMs": 960.6680000000001,
"heapDeltaBytes": 11600928,
"heapUsedBytes": 132470144,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 260.22799999999995,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.799999999999272
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
dante01yoon
left a comment
There was a problem hiding this comment.
Backport of PR 20183.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.56 #20340 +/- ##
==========================================
Coverage 85.90% 85.90%
==========================================
Files 2461 2461
Lines 140578 140588 +10
Branches 38207 38212 +5
==========================================
+ Hits 120761 120770 +9
- Misses 19439 19440 +1
Partials 378 378
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #20183 to
core/1.56Automatically created by backport workflow.