Repository navigation
feat(website): publish missing Japanese catalogs - #20302
Closed
benceruleanlu wants to merge 1 commit into
Closed
benceruleanlu wants to merge 1 commit into
benceruleanlu wants to merge 1 commit into
Conversation
Contributor
🌐 Website E2ENote Tests are running… View workflow run 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 96f896c967789373df545dc2c7f99f801e4192c4
Full docs: ADR-DEVEX-LINT-0015 |
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (7)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft stacked on #17903 (
bl/pr17244-03-source-provenanceat96f896c967789373df545dc2c7f99f801e4192c4); needs native Japanese copy review. Publish the missing website messages through the shared locale pipeline. English source blob:c5bce8b08a39d0d51682ab1f97cda25f43832aca.Changes
.publishedsnapshots together. English snapshot catches up to the parent's customer-directory additions; Chinese catalogs are reordered by the pipeline without value changes. Version-2 manifest, review flags and known-violation baseline remain unchanged.Review Focus
models.list.heroTitleBefore({name} をbefore hardcoded ComfyUI),about.careers.whyTitleBefore,about.story.investorsBody(どの企業が考えられる以上), gallery provenance wording, and inconsistent customer-story/Pro terminology. These are sampled findings, not linguistic approval./ja/browser test pass. Focused locale/render, footer and adjacent tests pass; 99 pipeline integration/retention/publication/token tests and 88 other pipeline unit tests pass. Required commit hooks pass on Windows; push hooks pass in WSL at the identical commit./bin/bashtest command as an unresolved import. The affected suites and actual push hook pass unmodified in an isolated Linux checkout. No workaround or diagnostic configuration is committed./ja/remains the only page. Video playback was not assessed.Screenshots
Before/after desktop and mobile evidence will be attached below.