Skip to content

feat(website): publish missing Japanese catalogs - #20302

Closed
benceruleanlu wants to merge 1 commit into
bl/pr17244-03-source-provenancefrom
bl/website-ja-catalogs
Closed

benceruleanlu wants to merge 1 commit into
bl/pr17244-03-source-provenancefrom
bl/website-ja-catalogs

Conversation

@benceruleanlu

Copy link
Copy Markdown
Member

Summary

Draft stacked on #17903 (bl/pr17244-03-source-provenance at 96f896c967789373df545dc2c7f99f801e4192c4); needs native Japanese copy review. Publish the missing website messages through the shared locale pipeline. English source blob: c5bce8b08a39d0d51682ab1f97cda25f43832aca.

Changes

  • Add 2,976 translated Japanese messages and two empty fragments. Preserve all 107 authored Japanese and 3,181 Chinese messages; no excluded legal/MiniMax-license entries added.
  • Publish matching English/Japanese/Chinese .published snapshots together. English snapshot catches up to the parent's customer-directory additions; Chinese catalogs are reordered by the pipeline without value changes. Version-2 manifest, review flags and known-violation baseline remain unchanged.
  • Update focused translation/footer tests for localized output, Japanese completeness, plural interpolation and excluded/empty copy. Route, indexing and bundle-loading changes remain separate.

Review Focus

  • Native wording review is required across the generated copy. Specific leads: models.list.heroTitleBefore ({name} を before hardcoded ComfyUI), about.careers.whyTitleBefore, about.story.investorsBody (どの企業が考えられる以上), gallery provenance wording, and inconsistent customer-story/Pro terminology. These are sampled findings, not linguistic approval.
  • Validation: offline preflight and post-generation check pass; a repeat generation makes zero requests and zero writes. All three snapshots match current catalogs byte-for-byte; authored values, URLs and protected product names were audited. Website build and built /ja/ browser test pass. Focused locale/render, footer and adjacent tests pass; 99 pipeline integration/retention/publication/token tests and 88 other pipeline unit tests pass. Required commit hooks pass on Windows; push hooks pass in WSL at the identical commit.
  • Parent Windows limitations: eight integration-fixture failures arise from path separators; footer collection fails on a root SVG URL; Knip treats the existing /bin/bash test command as an unresolved import. The affected suites and actual push hook pass unmodified in an isolated Linux checkout. No workaround or diagnostic configuration is committed.
  • Desktop/mobile Japanese and desktop Chinese browser inspection completed. New copy fits and navigation/accordion interactions work. The authored mobile hero clips at 390px before and after this change. No Japanese route was added; /ja/ remains the only page. Video playback was not assessed.

Screenshots

Before/after desktop and mobile evidence will be attached below.

@benceruleanlu
benceruleanlu added this pull request to stack #20303 October 6, 2026 05:13
@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Note

Tests are running… View workflow run

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 96f896c967789373df545dc2c7f99f801e4192c4

Full docs: ADR-DEVEX-LINT-0015

@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 54f6508a-cfc5-4eef-979c-9dcc89afbd4e
📥 Commits

Reviewing files that changed from the base of the PR and between 96f896c and 9b06959.

📒 Files selected for processing (7)
  • apps/website/src/components/common/SiteFooter.test.ts
  • apps/website/src/i18n/translations.test.ts
  • apps/website/src/locales/.published/en/main.json
  • apps/website/src/locales/.published/ja/main.json
  • apps/website/src/locales/.published/zh-CN/main.json
  • apps/website/src/locales/ja/main.json
  • apps/website/src/locales/zh-CN/main.json
 _______________________________________________________________________________________________
< bm = Δc/Δt: Bug momentum equals change in code over change in time. Can't argue with physics. >
 -----------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@benceruleanlu
benceruleanlu deleted the bl/website-ja-catalogs branch October 6, 2026 05:14
@benceruleanlu
benceruleanlu removed this pull request from stack #20303 October 6, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant