Repository navigation
fix(website): localize API pricing rate units - #20299
benceruleanlu wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 99ff869a0ae54ef8fe9973b5597c694aa3bc81f6
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-20299.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-k0vvnn9bz-comfyui.vercel.app Last updated: 2026-10-06T05:08:25Z for 🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (5)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughPricing formatters now accept an optional locale and use translated messages for GPU and storage rates. PricingSection passes its locale to the formatters, renders translated VRAM and credit labels, and uses the same rate data for desktop and mobile lists. Tests cover English, Simplified Chinese, and Japanese. ChangesPricing Localization
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The localized pricing tests cover the identified English fallback and Chinese rate-unit behavior. No pricing issue identified here needs correction before merge. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20299 +/- ##
==========================================
- Coverage 85.43% 85.31% -0.13%
==========================================
Files 3519 3420 -99
Lines 168796 165683 -3113
Branches 44294 43229 -1065
==========================================
- Hits 144219 141347 -2872
+ Misses 22594 22503 -91
+ Partials 1983 1833 -150
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 99 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Localize Comfy API pricing units: Chinese pages currently show English hourly/monthly units, and mobile storage credit prices omit their per-GB/month basis.
Changes
Review Focus
Independent follow-up to FE-2045; targets main without depending on #17903. The shared table serves the pricing and Comfy API pages. Japanese falls back to English for the new messages.
Validation: 38 focused tests pass across the pricing table, parent pricing section, rate card and catalogs. All three new locale cases fail against the original component. Targeted lint and the normal commit/push hooks pass, including website typecheck, Knip and Fallow. Chinese desktop (1280px) and mobile (390px) render correctly with no horizontal overflow or captured browser errors.
Screenshots