Skip to content

feat(website): fail CI when a published model page is removed without a redirect - #20292

Merged
MaanilVerma merged 5 commits into
mainfrom
maanil/fe-2971-model-page-removal-guard
Oct 6, 2026
Merged

MaanilVerma merged 5 commits into
mainfrom
maanil/fe-2971-model-page-removal-guard

Conversation

@MaanilVerma

@MaanilVerma MaanilVerma commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

CI now fails when a published model page leaves the build without a permanent redirect to a live page. This stops a catalogue refresh from turning a ranking page into a silent 404, as #15487 did to 10 /p/supported-models/ pages.

Changes

  • What:
    • src/config/published-model-pages.json is a committed list of every published model page (533 today). It is seeded from the sitemap of a main build.
    • check:published-model-pages reads the built sitemap and vercel.json. Each listed page must be in the sitemap or have a permanent redirect from its slash form to a page in the sitemap. Otherwise it prints page X removed: add a permanent redirect in src/config/redirects.ts or restore the page.
    • A model page in the sitemap that is not on the list also fails. record:published-model-pages adds new pages and never removes one.
    • "Model page" means anything under the Models URL registry roots (/hub/models, /hub/workflows, /hub/apps, /models) or /p/supported-models, in any locale. New /hub/models/local/<slug>/ pages are covered with no extra code.
    • New CI step after the models-html check in ci-website-build.yaml.
    • Redirect sources may use :name and :name(a|b) params (as the grouped /p/supported-models/ redirects do). Their params fill the destination before the live check. Other source syntax fails the check.
    • On a PR, the check also compares the list with the base branch. An entry dropped from the list fails unless it is in RETIRED_WITHOUT_REDIRECT with a reason.
    • Dedupe with fix(website): point llms.txt at /hub/models and Comfy Router, and fail on redirected llms links #20198's matcher once both land.

Changed from the ticket: the ticket guarded slugs in generated-models.json from a unit test. The pages now live at /hub/models/ as well, and the in-flight local pages come from a different source. So the check reads the built sitemap, which covers every model page the same way. A page that is retired on purpose goes in RETIRED_WITHOUT_REDIRECT with a reason. The 10 pages #15487 already removed are not seeded; their redirect and restore tickets own them.

Review Focus

  • A new model page fails CI until someone runs record:published-model-pages after a build. Without this, new pages would be unprotected. It also means the open supported-models PR must record its new pages once this merges.
  • The redirect must cover the slash form (/x/), because that is the address in the sitemap. sync:redirects always writes both forms.

Fixes FE-2971
https://linear.app/comfyorg/issue/FE-2971

@MaanilVerma
MaanilVerma requested review from a team October 6, 2026 04:06
@MaanilVerma MaanilVerma added the cursor-review Trigger multi-model Cursor agent review on this PR label Oct 6, 2026
@MaanilVerma MaanilVerma self-assigned this Oct 6, 2026
@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

QA: published model page guard

I ran these checks locally on this branch. The base is origin/main at ff15e31be6. I built once with pnpm --filter @comfyorg/website build:e2e, which is the same build CI runs. To simulate a removed page, I deleted its <url> entry from dist/sitemap-0.xml. To simulate a redirect, I added a row to vercel.json. I restored both files after each run.

What it checks Proof Result
Main build passes pnpm check:published-model-pages → 533 published model pages are live or redirect permanently to a live page. exit 0 Pass
A removed page with no redirect fails and names the page I removed /p/supported-models/flux1-dev-fp8/ and /hub/models/flux-2-max-text-to-image/ from the sitemap → /hub/models/flux-2-max-text-to-image/ removed: add a permanent redirect in src/config/redirects.ts or restore the page (same for flux1-dev-fp8). Exit 1 Pass
The same removal with a permanent redirect to a live page passes I added {source: "<page>/", destination: "/p/supported-models/flux1-dev/" or "/hub/models/flux-2-pro-text-to-image/", permanent: true} → 533 published model pages are live or redirect permanently to a live page. exit 0 Pass
A live model page that is not on the list fails I removed /hub/models/flux-pro-fill/ from published-model-pages.json → /hub/models/flux-pro-fill/ is new: run \pnpm --filter @comfyorg/website record:published-model-pages` after a build` exit 1 Pass
Rules on fixtures: temporary redirect, redirect to a removed page, bare-path-only redirect, retired with and without a reason, /hub/models/local/<slug>/, locale prefix vitest run scripts/published-model-pages.test.ts → 16 passed Pass
The tests can fail I made the temporary-redirect check a no-op → FAIL ... reports a removed page with a temporary redirect, 1 failed / 15 passed. Then I reverted it Pass
Existing redirect tests still pass vitest run src/config/redirects.test.ts → passed (44 tests total with the new file) Pass
Gates website vue-tsc exit 0, oxlint exit 0, oxfmt --check clean, pnpm knip --cache exit 0. The pre-commit hook ran typecheck:website Pass
The redirects reach prod curl -sI https://comfy.org/hub/models/ and /p/supported-models/flux1-dev-fp8/ both return x-vercel-id, so a vercel.json redirect for these paths is served by Vercel. comfy-router does not intercept them Pass

Not covered here: CI. The new step runs in CI: Website Build on this PR.

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 65d257e48111ba1ba4cbb8e9534668b9d38dc8bb

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-20292.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-8cbb5yg6m-comfyui.vercel.app

Last updated: 2026-10-06T13:17:32Z for cf3c546

📦 Bundle: 10.3 MB gzip ⚪ 0 B

Details

Summary

  • Raw size: 43.3 MB baseline 43.3 MB — ⚪ 0 B
  • Gzip: 10.3 MB baseline 10.3 MB — ⚪ 0 B
  • Brotli: 7.28 MB baseline 7.28 MB — ⚪ 0 B
  • Bundles: 484 current • 484 baseline

Category Glance
Other ⚪ 0 B (18.6 MB) · Vendor & Third-Party ⚪ 0 B (17.3 MB) · Data & Services ⚪ 0 B (4.18 MB) · Graph Workspace ⚪ 0 B (1.45 MB) · Panels & Settings ⚪ 0 B (672 kB) · Utilities & Hooks ⚪ 0 B (582 kB) · + 5 more

App Entry Points — 4.17 kB (baseline 4.17 kB) • ⚪ 0 B

Main entry bundles and manifests

Status: 1 unchanged

Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 3 unchanged

Views & Navigation — 143 kB (baseline 143 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 18 unchanged

Panels & Settings — 672 kB (baseline 672 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 29 unchanged

User & Accounts — 54.4 kB (baseline 54.4 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 15 unchanged

Editors & Dialogs — 133 kB (baseline 133 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 9 unchanged

UI Components — 205 kB (baseline 205 kB) • ⚪ 0 B

Reusable component library chunks

Status: 20 unchanged

Data & Services — 4.18 MB (baseline 4.18 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 582 kB (baseline 582 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 38 unchanged

Vendor & Third-Party — 17.3 MB (baseline 17.3 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 18.6 MB (baseline 18.6 MB) • ⚪ 0 B

Bundles that do not match a named category

Status: 316 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.8 MB heap
dom-widget-order-dense-n200-w200-i120: · 28.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 545ms TBT · 90.7 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 40.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 226ms TBT · 77.1 MB heap
extension-clean-combined-draw: · 31.2 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 903ms TBT · 71.7 MB heap
extension-rgthree-prototype-draw: · 31.3 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 1064ms TBT · 79.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
large-graph-pan: · 59.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.2 MB heap
legacy-node-drag: · 59.5 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.6 MB heap
subgraph-transition-enter: · 51.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 135ms TBT · 102.7 MB heap
viewport-pan-sweep: · 59.9 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.2 MB heap
vue-large-graph-idle: · 36.5 avg FPS · 17.2 P5 FPS ❌ (target: ≥52) · 0ms TBT · 175.2 MB heap
vue-large-graph-pan: · 23.8 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 4ms TBT · 179.2 MB heap
vue-node-resize-workload: · 27.7 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 210.2 MB heap
vue-zoom-out-idle: · 32.1 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 173.5 MB heap
workflow-execution: · 56.0 avg FPS · 39.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 65.5 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.0 MB heap
agent-composer-long-conversation-typing: · 56.2 avg FPS · 30.1 P5 FPS ❌ (target: ≥52) · 0ms TBT · 110.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 4ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 474ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 72.6 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 17ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 854ms
canvas-mouse-sweep: script duration 168ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.6 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 0
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 6ms
canvas-zoom-sweep: layout count 3
canvas-zoom-sweep: style recalc count 19
canvas-zoom-sweep: task duration 364ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 75.3 MB
canvas-zoom-sweep: DOM nodes 45
canvas-zoom-sweep: event listeners 39
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 4ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 474ms
dom-widget-clipping: script duration 172ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 59.8 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 35ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 859ms
dom-widget-order-dense-n200-w200-i120: script duration 71ms
dom-widget-order-dense-n200-w200-i120: TBT 545ms
dom-widget-order-dense-n200-w200-i120: heap used 90.7 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 491ms
dom-widget-order-sparse-n1000-w20-i120: script duration 166ms
dom-widget-order-sparse-n1000-w20-i120: TBT 226ms
dom-widget-order-sparse-n1000-w20-i120: heap used 77.1 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 32ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 8836ms
extension-clean-combined-draw: script duration 7372ms
extension-clean-combined-draw: TBT 903ms
extension-clean-combined-draw: heap used 71.7 MB
extension-clean-combined-draw: DOM nodes -141
extension-clean-combined-draw: event listeners -71
extension-rgthree-prototype-draw: avg frame time 32ms
extension-rgthree-prototype-draw: p95 frame time 58ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 2
extension-rgthree-prototype-draw: task duration 9407ms
extension-rgthree-prototype-draw: script duration 7821ms
extension-rgthree-prototype-draw: TBT 1064ms
extension-rgthree-prototype-draw: heap used 79.0 MB
extension-rgthree-prototype-draw: DOM nodes -141
extension-rgthree-prototype-draw: event listeners -71
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 551ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.8 MB
large-graph-idle: DOM nodes 0
large-graph-idle: event listeners 0
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 6ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1624ms
large-graph-pan: script duration 856ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 70.5 MB
large-graph-pan: DOM nodes 0
large-graph-pan: event listeners 0
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 16ms
large-graph-zoom: style recalc duration 9ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 72
large-graph-zoom: task duration 1659ms
large-graph-zoom: script duration 818ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 80.2 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 2010ms
legacy-node-drag: script duration 1079ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 77.9 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 585ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 69.3 MB
minimap-idle: DOM nodes 0
minimap-idle: event listeners 0
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 6ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 437ms
subgraph-dom-widget-clipping: script duration 145ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 63.3 MB
subgraph-dom-widget-clipping: DOM nodes -239
subgraph-dom-widget-clipping: event listeners -178
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 4ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 476ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 74.3 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 7ms
subgraph-mouse-sweep: style recalc duration 17ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 785ms
subgraph-mouse-sweep: script duration 112ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 60.6 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 0
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1053ms
subgraph-transition-enter: script duration 36ms
subgraph-transition-enter: TBT 135ms
subgraph-transition-enter: heap used 102.7 MB
subgraph-transition-enter: DOM nodes 14570
subgraph-transition-enter: event listeners 2458
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 20ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 5657ms
viewport-pan-sweep: script duration 2965ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 78.2 MB
viewport-pan-sweep: DOM nodes 0
viewport-pan-sweep: event listeners 0
vue-large-graph-idle: avg frame time 27ms
vue-large-graph-idle: p95 frame time 58ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 15349ms
vue-large-graph-idle: script duration 265ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 175.2 MB
vue-large-graph-idle: DOM nodes -3047
vue-large-graph-idle: event listeners -14915
vue-large-graph-pan: avg frame time 42ms
vue-large-graph-pan: p95 frame time 83ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 180
vue-large-graph-pan: task duration 22432ms
vue-large-graph-pan: script duration 861ms
vue-large-graph-pan: TBT 4ms
vue-large-graph-pan: heap used 179.2 MB
vue-large-graph-pan: DOM nodes -3061
vue-large-graph-pan: event listeners -14915
vue-node-resize-workload: avg frame time 36ms
vue-node-resize-workload: p95 frame time 67ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 74ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6489ms
vue-node-resize-workload: script duration 112ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 210.2 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 31ms
vue-zoom-out-idle: p95 frame time 67ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8897ms
vue-zoom-out-idle: script duration 136ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 173.5 MB
vue-zoom-out-idle: DOM nodes -3046
vue-zoom-out-idle: event listeners -14915
workflow-execution: avg frame time 18ms
workflow-execution: p95 frame time 25ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 4
workflow-execution: style recalc count 12
workflow-execution: task duration 100ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 65.5 MB
workflow-execution: DOM nodes 114
workflow-execution: event listeners 41
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 25ms
agent-composer-empty-conversation-typing: style recalc duration 90ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 835ms
agent-composer-empty-conversation-typing: script duration 353ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 71.0 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 18ms
agent-composer-long-conversation-typing: p95 frame time 33ms
agent-composer-long-conversation-typing: layout duration 29ms
agent-composer-long-conversation-typing: style recalc duration 256ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 1392ms
agent-composer-long-conversation-typing: script duration 469ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 110.6 MB
agent-composer-long-conversation-typing: DOM nodes 76
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-10-06T11:13:30.782Z",
  "gitSha": "7c6703a63654ac95d1b165d11d28ec6b153be892",
  "branch": "maanil/fe-2971-model-page-removal-guard",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2021.2490000000116,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.065,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 507.04,
      "heapDeltaBytes": 7321436,
      "heapUsedBytes": 76094720,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 13.133999999999993,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2017.4279999999953,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.8119999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 441.18,
      "heapDeltaBytes": 7327704,
      "heapUsedBytes": 76167656,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.037999999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1761.2139999999954,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 16.488000000000003,
      "layouts": 12,
      "layoutDurationMs": 4.944999999999999,
      "taskDurationMs": 837.447,
      "heapDeltaBytes": -766124,
      "heapUsedBytes": 59420936,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 166.186,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66603773584906,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1742.7619999999706,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 16.771,
      "layouts": 12,
      "layoutDurationMs": 4.968999999999999,
      "taskDurationMs": 869.688,
      "heapDeltaBytes": 3597316,
      "heapUsedBytes": 71910328,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 168.94500000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665714285714284,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1703.160999999966,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 6.215,
      "layouts": 3,
      "layoutDurationMs": 0.8019999999999997,
      "taskDurationMs": 366.45900000000006,
      "heapDeltaBytes": 9606628,
      "heapUsedBytes": 78192440,
      "domNodes": 45,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 12.812999999999999,
      "eventListeners": 39,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352944,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1702.2779999999784,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 6.066999999999999,
      "layouts": 3,
      "layoutDurationMs": 0.7979999999999999,
      "taskDurationMs": 362.11899999999997,
      "heapDeltaBytes": 9703244,
      "heapUsedBytes": 79766192,
      "domNodes": 45,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 11.453999999999999,
      "eventListeners": 39,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 655.4199999999923,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 3.634,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 464.163,
      "heapDeltaBytes": -5647760,
      "heapUsedBytes": 62464724,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 170.607,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664102564102578,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 655.5349999999862,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 3.79,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 483.65100000000007,
      "heapDeltaBytes": -5964916,
      "heapUsedBytes": 63023780,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 173.249,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66923076923078,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1195.2809999999658,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 867.7739999999999,
      "heapDeltaBytes": 13504772,
      "heapUsedBytes": 95476232,
      "domNodes": 0,
      "jsHeapTotalBytes": 2260992,
      "scriptDurationMs": 72.394,
      "eventListeners": 0,
      "totalBlockingTimeMs": 562,
      "frameDurationMs": 35.294117647058826,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1160.8169999999518,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 850.2230000000001,
      "heapDeltaBytes": 13017244,
      "heapUsedBytes": 94760800,
      "domNodes": 0,
      "jsHeapTotalBytes": 2785280,
      "scriptDurationMs": 69.34000000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 527,
      "frameDurationMs": 34.31470588235294,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 874.9520000000075,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 490.8979999999996,
      "heapDeltaBytes": -7988408,
      "heapUsedBytes": 80867240,
      "domNodes": 0,
      "jsHeapTotalBytes": 528384,
      "scriptDurationMs": 167.304,
      "eventListeners": 0,
      "totalBlockingTimeMs": 225,
      "frameDurationMs": 24.53611111111109,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 859.6959999999854,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.98999999999995,
      "heapDeltaBytes": -6874260,
      "heapUsedBytes": 80849764,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 165.118,
      "eventListeners": 0,
      "totalBlockingTimeMs": 227,
      "frameDurationMs": 25.485294117647058,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10001.393000000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9135.336,
      "heapDeltaBytes": -16108276,
      "heapUsedBytes": 69672276,
      "domNodes": -141,
      "jsHeapTotalBytes": -9310208,
      "scriptDurationMs": 7496.955,
      "eventListeners": -69,
      "totalBlockingTimeMs": 895,
      "frameDurationMs": 31.996474358974353,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9452.643999999964,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8537.477,
      "heapDeltaBytes": -4919876,
      "heapUsedBytes": 80657060,
      "domNodes": -141,
      "jsHeapTotalBytes": -9834496,
      "scriptDurationMs": 7246.745,
      "eventListeners": -73,
      "totalBlockingTimeMs": 911,
      "frameDurationMs": 32.032881355932204,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9731.416000000025,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.5779999999999986,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8911.772,
      "heapDeltaBytes": 1910952,
      "heapUsedBytes": 87830572,
      "domNodes": -141,
      "jsHeapTotalBytes": -9310208,
      "scriptDurationMs": 7340.575999999999,
      "eventListeners": -73,
      "totalBlockingTimeMs": 786,
      "frameDurationMs": 31.600324675324675,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10737.316999999963,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.059000000000000025,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9902.106,
      "heapDeltaBytes": -8276812,
      "heapUsedBytes": 77902740,
      "domNodes": -141,
      "jsHeapTotalBytes": -5115904,
      "scriptDurationMs": 8300.43,
      "eventListeners": -69,
      "totalBlockingTimeMs": 1341,
      "frameDurationMs": 32.23093093093094,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2023.69699999997,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.2320000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 502.225,
      "heapDeltaBytes": -2889032,
      "heapUsedBytes": 86899120,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 30.524999999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622944,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2021.5180000000146,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.289,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 599.771,
      "heapDeltaBytes": -2645864,
      "heapUsedBytes": 86671528,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 36.172999999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2238.1529999999543,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 4.949000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1523.5279999999998,
      "heapDeltaBytes": 15561540,
      "heapUsedBytes": 79432628,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 810.986,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66616541353383,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2484.27300000003,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 7.925999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1723.986,
      "heapDeltaBytes": -12259852,
      "heapUsedBytes": 68429664,
      "domNodes": 0,
      "jsHeapTotalBytes": 823296,
      "scriptDurationMs": 900.6390000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.778378378378378,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3541.9239999999945,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 8.523,
      "layouts": 60,
      "layoutDurationMs": 16.073999999999998,
      "taskDurationMs": 1539.3680000000002,
      "heapDeltaBytes": 11188652,
      "heapUsedBytes": 93592292,
      "domNodes": 24,
      "jsHeapTotalBytes": 823296,
      "scriptDurationMs": 810.7120000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66603773584906,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3765.7469999999194,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 9.144,
      "layouts": 60,
      "layoutDurationMs": 16.564000000000004,
      "taskDurationMs": 1777.864,
      "heapDeltaBytes": 6105656,
      "heapUsedBytes": 74603652,
      "domNodes": 24,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 825.652,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666222222222224,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2970.6689999999867,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 5.944,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1875.4590000000003,
      "heapDeltaBytes": 22343724,
      "heapUsedBytes": 92427120,
      "domNodes": 0,
      "jsHeapTotalBytes": 1204224,
      "scriptDurationMs": 1005.6050000000001,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.760451977401125,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3206.28499999998,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 5.121000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2144.974,
      "heapDeltaBytes": 1691044,
      "heapUsedBytes": 71020900,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 1152.416,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.841052631578947,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2010.7550000000174,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 3.4700000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 588.278,
      "heapDeltaBytes": -5623616,
      "heapUsedBytes": 72815476,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 35.524,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2008.2200000000512,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.3870000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 582.0920000000001,
      "heapDeltaBytes": -5669772,
      "heapUsedBytes": 72462772,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 36.544,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 622.5299999999834,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 6.0409999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.19,
      "heapDeltaBytes": -43313596,
      "heapUsedBytes": 65717320,
      "domNodes": -230,
      "jsHeapTotalBytes": -3932160,
      "scriptDurationMs": 142.22299999999998,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66486486486485,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 590.0970000000143,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 5.1309999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.05099999999993,
      "heapDeltaBytes": 11970072,
      "heapUsedBytes": 67030296,
      "domNodes": -248,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 148.30599999999998,
      "eventListeners": -168,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66571428571429,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.409999999993,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.213,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 466.2710000000001,
      "heapDeltaBytes": 8056676,
      "heapUsedBytes": 78133320,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.535999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2010.8139999999821,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.629999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 486.0059999999999,
      "heapDeltaBytes": 7685412,
      "heapUsedBytes": 77603132,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.857000000000005,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.0959999999882,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 16.730999999999998,
      "layouts": 16,
      "layoutDurationMs": 6.783000000000001,
      "taskDurationMs": 779.6049999999999,
      "heapDeltaBytes": -341516,
      "heapUsedBytes": 69784096,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 109.06099999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66601941747573,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.6520000000055,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 17.706,
      "layouts": 16,
      "layoutDurationMs": 6.5520000000000005,
      "taskDurationMs": 790.4739999999999,
      "heapDeltaBytes": -4515332,
      "heapUsedBytes": 57342420,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 115.45100000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475724,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1450.2749999999196,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 28.980999999999998,
      "layouts": 5,
      "layoutDurationMs": 14.779000000000003,
      "taskDurationMs": 1052.8310000000001,
      "heapDeltaBytes": 32284140,
      "heapUsedBytes": 107740252,
      "domNodes": 14570,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 35.608999999999995,
      "eventListeners": 2458,
      "totalBlockingTimeMs": 135,
      "frameDurationMs": 19.333333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8954.003999999997,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 19.448999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5941.646,
      "heapDeltaBytes": 15425092,
      "heapUsedBytes": 91943600,
      "domNodes": 0,
      "jsHeapTotalBytes": 978944,
      "scriptDurationMs": 3015.015,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665985130111526,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8278.871999999978,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 21.495,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5372.6669999999995,
      "heapDeltaBytes": -16889228,
      "heapUsedBytes": 72099560,
      "domNodes": 0,
      "jsHeapTotalBytes": 1085440,
      "scriptDurationMs": 2915.849,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.699596774193548,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18759.396000000037,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17912.837,
      "heapDeltaBytes": -43535388,
      "heapUsedBytes": 180426296,
      "domNodes": -3046,
      "jsHeapTotalBytes": 106496,
      "scriptDurationMs": 286.901,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 31.88639455782313,
      "p95FrameDurationMs": 66.60000000000218
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13605.688999999984,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12785.851,
      "heapDeltaBytes": -36959456,
      "heapUsedBytes": 187027012,
      "domNodes": -3047,
      "jsHeapTotalBytes": 6660096,
      "scriptDurationMs": 242.124,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 22.894781144781142,
      "p95FrameDurationMs": 49.899999999999636
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22337.78799999999,
      "styleRecalcs": 177,
      "styleRecalcDurationMs": 13.591999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21924.091999999997,
      "heapDeltaBytes": -27046636,
      "heapUsedBytes": 187982392,
      "domNodes": -3046,
      "jsHeapTotalBytes": 7360512,
      "scriptDurationMs": 854.355,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 8,
      "frameDurationMs": 40.604545454545445,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23310.22299999995,
      "styleRecalcs": 182,
      "styleRecalcDurationMs": 16.566000000000024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22939.585000000003,
      "heapDeltaBytes": -27399484,
      "heapUsedBytes": 187930820,
      "domNodes": -3076,
      "jsHeapTotalBytes": 6864896,
      "scriptDurationMs": 867.2620000000001,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 43.3877094972067,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6652.045999999984,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.78599999999996,
      "layouts": 20,
      "layoutDurationMs": 23.574000000000012,
      "taskDurationMs": 6508.883,
      "heapDeltaBytes": 781784,
      "heapUsedBytes": 215860632,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 109.46,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 36.13967391304348,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6618.062000000009,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.54299999999999,
      "layouts": 20,
      "layoutDurationMs": 23.647000000000002,
      "taskDurationMs": 6469.521,
      "heapDeltaBytes": 5300584,
      "heapUsedBytes": 224940748,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 114.82800000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 35.95869565217392,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9460.78099999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9072.273,
      "heapDeltaBytes": -32667912,
      "heapUsedBytes": 182855980,
      "domNodes": -3046,
      "jsHeapTotalBytes": 6836224,
      "scriptDurationMs": 141.876,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 32.19829931972789,
      "p95FrameDurationMs": 66.69999999999709
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9073.842000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8721.683000000003,
      "heapDeltaBytes": -34616564,
      "heapUsedBytes": 181038176,
      "domNodes": -3046,
      "jsHeapTotalBytes": 5263360,
      "scriptDurationMs": 129.61200000000005,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.176079734219268,
      "p95FrameDurationMs": 66.60000000000218
    },
    {
      "name": "workflow-execution",
      "durationMs": 122.59100000005674,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 13.744,
      "layouts": 5,
      "layoutDurationMs": 2.8019999999999996,
      "taskDurationMs": 99.501,
      "heapDeltaBytes": 4301464,
      "heapUsedBytes": 64972592,
      "domNodes": 125,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 12.845,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 19.057142857142804,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "workflow-execution",
      "durationMs": 456.37999999996737,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 11.612,
      "layouts": 3,
      "layoutDurationMs": 0.8669999999999999,
      "taskDurationMs": 100.73800000000003,
      "heapDeltaBytes": 5921120,
      "heapUsedBytes": 72438320,
      "domNodes": 103,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.479999999999995,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66296296296295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 778.6750000000211,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 87.708,
      "layouts": 76,
      "layoutDurationMs": 24.842,
      "taskDurationMs": 759.134,
      "heapDeltaBytes": 17296464,
      "heapUsedBytes": 85419056,
      "domNodes": 76,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 318.869,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664583333333326,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 934.0749999998934,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 92.509,
      "layouts": 76,
      "layoutDurationMs": 26.07,
      "taskDurationMs": 910.223,
      "heapDeltaBytes": -12233696,
      "heapUsedBytes": 63553744,
      "domNodes": 76,
      "jsHeapTotalBytes": 18087936,
      "scriptDurationMs": 386.826,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66607142857143,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1409.1009999999642,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 252.82100000000003,
      "layouts": 76,
      "layoutDurationMs": 28.729999999999997,
      "taskDurationMs": 1381.224,
      "heapDeltaBytes": -19127588,
      "heapUsedBytes": 114270380,
      "domNodes": 76,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 469.844,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.707499999999982,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1435.760000000073,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 259.19199999999995,
      "layouts": 76,
      "layoutDurationMs": 29.371000000000002,
      "taskDurationMs": 1402.269,
      "heapDeltaBytes": 10251228,
      "heapUsedBytes": 117704156,
      "domNodes": 76,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 467.269,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.88536585365852,
      "p95FrameDurationMs": 33.20000000000073
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 54422 84002 64.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.8% 1167
src/LGraphNode.ts 70.6% 387
src/platform/workspace/stores/billingOperationStore.ts 7.8% 366
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 79.0% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 39.3% 258
src/scripts/app.ts 73.0% 255
src/core/webSessionIdentity.ts 3.3% 231
src/scripts/pnginfo.ts 20.7% 222

🎭 Playwright: ✅ 2235 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2215 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 17 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 6, 2026
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: fe5fb2e7-ea93-4985-b086-143cf4a475c1
📥 Commits

Reviewing files that changed from the base of the PR and between 759b4f9 and cb3da50.

📒 Files selected for processing (4)
  • .github/workflows/ci-website-build.yaml
  • apps/website/scripts/check-published-model-pages.ts
  • apps/website/scripts/published-model-pages.test.ts
  • apps/website/scripts/published-model-pages.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The website build checks published model pages against sitemap pages and redirect rules. New utilities track published paths, validate removed pages, and record live pages without deleting existing entries.

Changes

Published model-page audit

Layer / File(s) Summary
Page tracking and audit rules
apps/website/scripts/published-model-pages.ts, apps/website/scripts/published-model-pages.test.ts, apps/website/src/config/published-model-pages.json
Adds path recognition, checks for valid redirects or retirement reasons, and helpers to find and record pages. Tests cover these rules. The JSON file adds the published model-page paths.
Sitemap and redirect audit
apps/website/scripts/check-published-model-pages.ts
Adds a script that reads sitemap pages and Vercel redirects, optionally records live pages, compares published-page lists, and reports audit errors.
Build and command wiring
apps/website/package.json, .github/workflows/ci-website-build.yaml
Adds commands to check or record published pages. The website build runs the check.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant WebsiteBuild
  participant CheckScript
  participant Sitemap
  participant VercelRedirects
  participant AuditRules
  WebsiteBuild->>CheckScript: run published-page check
  CheckScript->>Sitemap: read sitemap pages
  CheckScript->>VercelRedirects: load redirect rules
  CheckScript->>AuditRules: audit published and live pages
Loading

Suggested reviewers: benjcooley

Merge Risk: ⚪ Minimal · up to cb3da

This adds a CI check for removed model pages and does not change runtime behavior. No merge-blocking risk is evident from the supplied context.

Security Architecture Review

Security architecture risk: ⚪ Minimal · up to cb3da

The change adds a website validation gate, not a visitor-facing endpoint or a new privileged operation. No material security risk was identified in the reviewed paths. Recording changes remains an explicit developer action; CI only validates.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The newly introduced operational effects are website CI validation failure and an opt-in write to the local published-page history. The traced consumers do not add visitor reachability, tenant authority, or runtime redirect-serving authority.

Trust Boundaries and Controls

  • observed — Redirect validation evaluates static configuration rather than following destinations. It uses anchored, slash-sensitive patterns, rejects unsupported source syntax, and accepts a removed page only when its first matching redirect is permanent and targets a sitemap-listed page, unless explicitly retired.

Resilience and Maintainability Implications

  • observed — After verifying the base revision, any failure to read its history file is treated as an empty list. This accommodates initial seeding but does not distinguish an absent history file from other Git read failures. No independently reachable security bypass was established for this fallback.
🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The commit subjects include fix(website), but the changed-file list shows changes only under apps/website and the website CI workflow. The custom check exempts website-package changes and CI-proce…
Website End-To-End Regression Coverage ✅ Passed The PR changes website scripts, CI, tests, and apps/website/src/config/published-model-pages.json. It does not change website runtime behavior; the changed source-tree file is configuration. The cus…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed-file list contains website CI, scripts, tests, package configuration, and published-model-page configuration. It contains no files under src/lib/litegraph/ or src/ecs/, and no files re…
Title check ✅ Passed The title clearly and concisely describes the main change: CI fails when a published model page is removed without a redirect.
Description check ✅ Passed The description explains the problem, expected behavior, key design decisions, and review focus. It does not include the template’s Verification section or report test results.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #20292      +/-   ##
==========================================
- Coverage   85.40%   85.31%   -0.09%     
==========================================
  Files        3506     3420      -86     
  Lines      168310   165716    -2594     
  Branches    44138    43438     -700     
==========================================
- Hits       143737   141379    -2358     
+ Misses      22593    22504      -89     
+ Partials     1980     1833     -147     
Flag Coverage Δ
billing-web-unit ?
e2e 64.78% <ø> (-0.12%) ⬇️
unit 83.56% <ø> (+0.07%) ⬆️
website-unit 79.91% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 167 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 6, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @MaanilVerma.

Found 10 finding(s).

Severity Count
🟠 High 1
🟡 Medium 5
🟢 Low 3
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

…hed pages

Redirect sources with :name and :name(a|b) params now match published pages,
and their params fill the destination before the live check. Other source
syntax throws. CI also compares the published list with the base branch and
fails on an entry that was dropped without being retired.
@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Review fixes in cb3da50.

Finding Fix Proof
F1: grouped redirect sources from #20291 read as "removed" Each source compiles to an anchored matcher. :name(a|b) accepts literal alternatives only, and a bare :name matches one segment. Captured params fill the destination before the live check. Any other syntax (*, +, ?, unnamed or regex groups) throws Unsupported redirect source syntax. New table rows: a grouped source that lists the slug passes, one that does not fails, a bare-path grouped source fails, a filled destination that is not live fails, /:locale/models/ covers /zh-CN/models/, and 5 unsupported sources throw. 8 of these rows fail on 759b4f9.
F1 receipt The audit on this list, #20291's vercel.json (c83f634) and a live set with /p/supported-models/<slug>/ moved to /hub/models/local/<slug>/: 334 errors before, 0 errors now. With no redirects, the same live set gives 382 errors, so the run is not vacuous. Main's vercel.json still gives 0.
F2: deleting a list entry turned its guard off On a PR, the check reads the list from origin/$GITHUB_BASE_REF (locally origin/main) and fails on a dropped entry that is not in RETIRED_WITHOUT_REDIRECT. The CI step fetches the base branch at depth 1 first, because the checkout fetches only the PR ref. If the base ref is missing in CI, the check throws. droppedModelPages table rows. CLI dry run on a fabricated sitemap of the 533 pages, base = this branch: unchanged list exits 0. With /hub/models/bria-fibo-image-edit/ deleted from the list and the sitemap, it exits 1 with ... was dropped from the published list. The old script exits 0 on the same input. GITHUB_BASE_REF=no-such-branch throws origin/no-such-branch is not fetched.

Website typecheck, oxlint and oxfmt pass, and the test file passes 30/30. The is new errors for /hub/models/local/* in #20291 remain. That is a separate decision.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 6, 2026
Read served pages from the built HTML, so a noindexed or rolled-back model
page still counts as live. Reject retirements of unlisted or served pages,
fail on a missing sitemap chunk or a foreign origin, and write --record only
after the audit passes.
@vercel

vercel Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 6, 2026 10:58am UTC
billing-web-test Ignored Ignored Oct 6, 2026 10:58am UTC

Request Review

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed cf3c546 with the Claude review skill and shared review memories. No blocking finding after checking actual HTML liveness, grouped redirect matching/parameter substitution, permanent one-hop destinations, retirement validation, base-list retention, record-before-write ordering and CI base fetching. No API response contract or frontend-derived server fact is added.

PASS (executed locally, isolated exact head with its own pnpm install --frozen-lockfile): website typecheck, 63 focused tests, build:e2e, and check:published-model-pages over the real output (533 recorded pages). Deleting flux1-dev-fp8/index.html failed with the missing-redirect message; adding a permanent slash-form redirect to the built flux1-dev page passed; changing it to temporary failed; restoring output/config passed. Deleting the same page from the history list and HTML, using this head as a controlled Git base, failed the dropped-history check. Disabling the temporary-redirect branch failed the named test (1 failed / 34 passed); source/config/list restored byte-for-byte to head. Required GitHub checks currently pass.

NOT_RUN: browser QA and performance measurement; this changes filesystem/CI validation, not rendered UI or a performance-sensitive runtime path. Historical issue/author/bot QA is context, not counted as my own PASS. Node 24.14.1 / pnpm 11.13.1 was used. After a catalogue-changing sibling lands, its new model pages still need recording as documented.

@MaanilVerma
MaanilVerma added this pull request to the merge queue Oct 6, 2026
Merged via the queue into main with commit ed459b7 Oct 6, 2026
165 of 166 checks passed
@MaanilVerma
MaanilVerma deleted the maanil/fe-2971-model-page-removal-guard branch October 6, 2026 14:41
@webreviewer-bot

Copy link
Copy Markdown
Collaborator

webreviewer-bot — review completed after merge

This merged at 14:41:23Z while my pass was still running, so there is no review to submit — GitHub accepts neither APPROVE nor REQUEST_CHANGES on a closed PR. Recording the result here instead, because the code is now in main.

Verdict I reached: APPROVE at cf3c546e. 0 BLOCKER / 1 SHOULD FIX / 2 TRIVIAL. Nothing needs urgent follow-up; exposure is none (CI-only, two tsx script lines, no flag check, default or targeting touched).

The gate does not fail open — I tried seven ways to make it

Built build:e2e at cf3c546e in a throwaway clone, reproduced CI's baseline exactly (533, exit 0), then:

Mutation Result
Page leaves the build, no redirect exit 1, exact documented message
308 to a dead target exit 1 — "lands on …, which this build does not serve"
307 to a live page exit 1 — "is temporary; make it permanent"
Model page in sitemap, not on the list exit 1 — "is new: run record…"
Empty sitemap / missing index / missing chunk / empty urlset / no dist/ all exit 1
Positive control (308 to a live page) exit 0 — not always-red

That matters because three sibling gates reviewed today did fail open, each while printing success. This one does not, and the empty-input cases are the ones I most expected to pass silently. The step sits in the build job with no continue-on-error, and I confirmed it ran and printed 533 published model pages are served… at this head. The committed 533-page list is accurate against a real main build — zero drift in both directions, checked independently of this PR's own code. --record provably cannot remove an entry.

What the gate does not cover — worth stating plainly

It catches #15487's failure mode, not a wrong destination. Repointing all 383 /p/supported-models/ redirects at one unrelated but live page produces 0 errors. The check asks whether the destination is served, never whether it is the right page. That is a reasonable scope, but anyone reading this gate as protection against redirect mistakes in general will be surprised — it is specifically a protection against pages silently vanishing.

Relatedly, on #20291 I found a mutation that survives for the same reason: beeble → veo-3-text-to-video plus sync:redirects leaves 224/224 green. This gate would not have caught that either. Destination identity still has no oracle.

SHOULD FIX (follow-up)

RETIRED_WITHOUT_REDIRECT correctly rejects empty and whitespace-only reasons, but "x" passes and the success line is then byte-identical to a clean run — a waiver is invisible in CI output. Printing the active waivers and their reasons on success would make the escape hatch auditable. Cheap, and it is the only thing I would change.

Checked and cleared

The two redirect-source parsers do not disagree on any real source. Both this one and the now-merged #20198 matcher accept all 857 rows in main and all 919 in #20291. The differences are deliberate trailing-slash and named-group semantics; :path*/:path+ is the only genuine divergence and no row uses it today. So the "dedupe once both land" note is not urgent, and a naive dedupe would actively break the slash sensitivity this check needs. I would leave the two implementations alone.

Also confirmed: #20291's move, simulated against its real 919 rows, gives 0 errors — the "new /hub/models/local/ pages are covered with no extra code" claim holds.

Measured at cf3c546e in a temp clone outside the shared checkout, deleted afterwards; node_modules/.vite cleared before building; every restore verified by blob hash and a green re-run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:xhigh PR risk grade (advisory shadow check; grader-owned) webreviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants