Repository navigation
feat(website): fail CI when a published model page is removed without a redirect - #20292
Conversation
QA: published model page guardI ran these checks locally on this branch. The base is origin/main at
Not covered here: CI. The new step runs in |
🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 65d257e48111ba1ba4cbb8e9534668b9d38dc8bb
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-20292.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-8cbb5yg6m-comfyui.vercel.app Last updated: 2026-10-06T13:17:32Z for 📦 Bundle: 10.3 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 4.17 kB (baseline 4.17 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 143 kB (baseline 143 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 672 kB (baseline 672 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 29 unchanged User & Accounts — 54.4 kB (baseline 54.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 15 unchanged Editors & Dialogs — 133 kB (baseline 133 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 9 unchanged UI Components — 205 kB (baseline 205 kB) • ⚪ 0 BReusable component library chunks Status: 20 unchanged Data & Services — 4.18 MB (baseline 4.18 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 582 kB (baseline 582 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.3 MB (baseline 17.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.6 MB (baseline 18.6 MB) • ⚪ 0 BBundles that do not match a named category Status: 316 unchanged ⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-06T11:13:30.782Z",
"gitSha": "7c6703a63654ac95d1b165d11d28ec6b153be892",
"branch": "maanil/fe-2971-model-page-removal-guard",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.2490000000116,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.065,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.04,
"heapDeltaBytes": 7321436,
"heapUsedBytes": 76094720,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.133999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2017.4279999999953,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.8119999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.18,
"heapDeltaBytes": 7327704,
"heapUsedBytes": 76167656,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.037999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1761.2139999999954,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.488000000000003,
"layouts": 12,
"layoutDurationMs": 4.944999999999999,
"taskDurationMs": 837.447,
"heapDeltaBytes": -766124,
"heapUsedBytes": 59420936,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.186,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.7619999999706,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.771,
"layouts": 12,
"layoutDurationMs": 4.968999999999999,
"taskDurationMs": 869.688,
"heapDeltaBytes": 3597316,
"heapUsedBytes": 71910328,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 168.94500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1703.160999999966,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.215,
"layouts": 3,
"layoutDurationMs": 0.8019999999999997,
"taskDurationMs": 366.45900000000006,
"heapDeltaBytes": 9606628,
"heapUsedBytes": 78192440,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.812999999999999,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1702.2779999999784,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.066999999999999,
"layouts": 3,
"layoutDurationMs": 0.7979999999999999,
"taskDurationMs": 362.11899999999997,
"heapDeltaBytes": 9703244,
"heapUsedBytes": 79766192,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.453999999999999,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 655.4199999999923,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.634,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.163,
"heapDeltaBytes": -5647760,
"heapUsedBytes": 62464724,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 170.607,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102578,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 655.5349999999862,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.79,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.65100000000007,
"heapDeltaBytes": -5964916,
"heapUsedBytes": 63023780,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 173.249,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66923076923078,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1195.2809999999658,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 867.7739999999999,
"heapDeltaBytes": 13504772,
"heapUsedBytes": 95476232,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 72.394,
"eventListeners": 0,
"totalBlockingTimeMs": 562,
"frameDurationMs": 35.294117647058826,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1160.8169999999518,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 850.2230000000001,
"heapDeltaBytes": 13017244,
"heapUsedBytes": 94760800,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 69.34000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 527,
"frameDurationMs": 34.31470588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 874.9520000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.8979999999996,
"heapDeltaBytes": -7988408,
"heapUsedBytes": 80867240,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 167.304,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 24.53611111111109,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 859.6959999999854,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.98999999999995,
"heapDeltaBytes": -6874260,
"heapUsedBytes": 80849764,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 165.118,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 25.485294117647058,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10001.393000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9135.336,
"heapDeltaBytes": -16108276,
"heapUsedBytes": 69672276,
"domNodes": -141,
"jsHeapTotalBytes": -9310208,
"scriptDurationMs": 7496.955,
"eventListeners": -69,
"totalBlockingTimeMs": 895,
"frameDurationMs": 31.996474358974353,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9452.643999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8537.477,
"heapDeltaBytes": -4919876,
"heapUsedBytes": 80657060,
"domNodes": -141,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 7246.745,
"eventListeners": -73,
"totalBlockingTimeMs": 911,
"frameDurationMs": 32.032881355932204,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9731.416000000025,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5779999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8911.772,
"heapDeltaBytes": 1910952,
"heapUsedBytes": 87830572,
"domNodes": -141,
"jsHeapTotalBytes": -9310208,
"scriptDurationMs": 7340.575999999999,
"eventListeners": -73,
"totalBlockingTimeMs": 786,
"frameDurationMs": 31.600324675324675,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10737.316999999963,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.059000000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9902.106,
"heapDeltaBytes": -8276812,
"heapUsedBytes": 77902740,
"domNodes": -141,
"jsHeapTotalBytes": -5115904,
"scriptDurationMs": 8300.43,
"eventListeners": -69,
"totalBlockingTimeMs": 1341,
"frameDurationMs": 32.23093093093094,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-graph-idle",
"durationMs": 2023.69699999997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2320000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.225,
"heapDeltaBytes": -2889032,
"heapUsedBytes": 86899120,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.524999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2021.5180000000146,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.289,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.771,
"heapDeltaBytes": -2645864,
"heapUsedBytes": 86671528,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.172999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2238.1529999999543,
"styleRecalcs": 67,
"styleRecalcDurationMs": 4.949000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1523.5279999999998,
"heapDeltaBytes": 15561540,
"heapUsedBytes": 79432628,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 810.986,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66616541353383,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2484.27300000003,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.925999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1723.986,
"heapDeltaBytes": -12259852,
"heapUsedBytes": 68429664,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 900.6390000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.778378378378378,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3541.9239999999945,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.523,
"layouts": 60,
"layoutDurationMs": 16.073999999999998,
"taskDurationMs": 1539.3680000000002,
"heapDeltaBytes": 11188652,
"heapUsedBytes": 93592292,
"domNodes": 24,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 810.7120000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3765.7469999999194,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.144,
"layouts": 60,
"layoutDurationMs": 16.564000000000004,
"taskDurationMs": 1777.864,
"heapDeltaBytes": 6105656,
"heapUsedBytes": 74603652,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 825.652,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666222222222224,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2970.6689999999867,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.944,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1875.4590000000003,
"heapDeltaBytes": 22343724,
"heapUsedBytes": 92427120,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 1005.6050000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.760451977401125,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3206.28499999998,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.121000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2144.974,
"heapDeltaBytes": 1691044,
"heapUsedBytes": 71020900,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 1152.416,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.841052631578947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.7550000000174,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.4700000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.278,
"heapDeltaBytes": -5623616,
"heapUsedBytes": 72815476,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.524,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2008.2200000000512,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.3870000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.0920000000001,
"heapDeltaBytes": -5669772,
"heapUsedBytes": 72462772,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.544,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 622.5299999999834,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.0409999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.19,
"heapDeltaBytes": -43313596,
"heapUsedBytes": 65717320,
"domNodes": -230,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 142.22299999999998,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.0970000000143,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.1309999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.05099999999993,
"heapDeltaBytes": 11970072,
"heapUsedBytes": 67030296,
"domNodes": -248,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 148.30599999999998,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2007.409999999993,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.213,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.2710000000001,
"heapDeltaBytes": 8056676,
"heapUsedBytes": 78133320,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.535999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.8139999999821,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.629999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.0059999999999,
"heapDeltaBytes": 7685412,
"heapUsedBytes": 77603132,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.857000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.0959999999882,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.730999999999998,
"layouts": 16,
"layoutDurationMs": 6.783000000000001,
"taskDurationMs": 779.6049999999999,
"heapDeltaBytes": -341516,
"heapUsedBytes": 69784096,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 109.06099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.6520000000055,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.706,
"layouts": 16,
"layoutDurationMs": 6.5520000000000005,
"taskDurationMs": 790.4739999999999,
"heapDeltaBytes": -4515332,
"heapUsedBytes": 57342420,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.45100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1450.2749999999196,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.980999999999998,
"layouts": 5,
"layoutDurationMs": 14.779000000000003,
"taskDurationMs": 1052.8310000000001,
"heapDeltaBytes": 32284140,
"heapUsedBytes": 107740252,
"domNodes": 14570,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 35.608999999999995,
"eventListeners": 2458,
"totalBlockingTimeMs": 135,
"frameDurationMs": 19.333333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8954.003999999997,
"styleRecalcs": 251,
"styleRecalcDurationMs": 19.448999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5941.646,
"heapDeltaBytes": 15425092,
"heapUsedBytes": 91943600,
"domNodes": 0,
"jsHeapTotalBytes": 978944,
"scriptDurationMs": 3015.015,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665985130111526,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8278.871999999978,
"styleRecalcs": 250,
"styleRecalcDurationMs": 21.495,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5372.6669999999995,
"heapDeltaBytes": -16889228,
"heapUsedBytes": 72099560,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2915.849,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699596774193548,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18759.396000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17912.837,
"heapDeltaBytes": -43535388,
"heapUsedBytes": 180426296,
"domNodes": -3046,
"jsHeapTotalBytes": 106496,
"scriptDurationMs": 286.901,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.88639455782313,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 13605.688999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12785.851,
"heapDeltaBytes": -36959456,
"heapUsedBytes": 187027012,
"domNodes": -3047,
"jsHeapTotalBytes": 6660096,
"scriptDurationMs": 242.124,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.894781144781142,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "vue-large-graph-pan",
"durationMs": 22337.78799999999,
"styleRecalcs": 177,
"styleRecalcDurationMs": 13.591999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21924.091999999997,
"heapDeltaBytes": -27046636,
"heapUsedBytes": 187982392,
"domNodes": -3046,
"jsHeapTotalBytes": 7360512,
"scriptDurationMs": 854.355,
"eventListeners": -14915,
"totalBlockingTimeMs": 8,
"frameDurationMs": 40.604545454545445,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 23310.22299999995,
"styleRecalcs": 182,
"styleRecalcDurationMs": 16.566000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22939.585000000003,
"heapDeltaBytes": -27399484,
"heapUsedBytes": 187930820,
"domNodes": -3076,
"jsHeapTotalBytes": 6864896,
"scriptDurationMs": 867.2620000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.3877094972067,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6652.045999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.78599999999996,
"layouts": 20,
"layoutDurationMs": 23.574000000000012,
"taskDurationMs": 6508.883,
"heapDeltaBytes": 781784,
"heapUsedBytes": 215860632,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 109.46,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.13967391304348,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6618.062000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.54299999999999,
"layouts": 20,
"layoutDurationMs": 23.647000000000002,
"taskDurationMs": 6469.521,
"heapDeltaBytes": 5300584,
"heapUsedBytes": 224940748,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 114.82800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.95869565217392,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9460.78099999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9072.273,
"heapDeltaBytes": -32667912,
"heapUsedBytes": 182855980,
"domNodes": -3046,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 141.876,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.19829931972789,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9073.842000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8721.683000000003,
"heapDeltaBytes": -34616564,
"heapUsedBytes": 181038176,
"domNodes": -3046,
"jsHeapTotalBytes": 5263360,
"scriptDurationMs": 129.61200000000005,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.176079734219268,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 122.59100000005674,
"styleRecalcs": 9,
"styleRecalcDurationMs": 13.744,
"layouts": 5,
"layoutDurationMs": 2.8019999999999996,
"taskDurationMs": 99.501,
"heapDeltaBytes": 4301464,
"heapUsedBytes": 64972592,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.845,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.057142857142804,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "workflow-execution",
"durationMs": 456.37999999996737,
"styleRecalcs": 15,
"styleRecalcDurationMs": 11.612,
"layouts": 3,
"layoutDurationMs": 0.8669999999999999,
"taskDurationMs": 100.73800000000003,
"heapDeltaBytes": 5921120,
"heapUsedBytes": 72438320,
"domNodes": 103,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.479999999999995,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66296296296295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 778.6750000000211,
"styleRecalcs": 78,
"styleRecalcDurationMs": 87.708,
"layouts": 76,
"layoutDurationMs": 24.842,
"taskDurationMs": 759.134,
"heapDeltaBytes": 17296464,
"heapUsedBytes": 85419056,
"domNodes": 76,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 318.869,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664583333333326,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 934.0749999998934,
"styleRecalcs": 78,
"styleRecalcDurationMs": 92.509,
"layouts": 76,
"layoutDurationMs": 26.07,
"taskDurationMs": 910.223,
"heapDeltaBytes": -12233696,
"heapUsedBytes": 63553744,
"domNodes": 76,
"jsHeapTotalBytes": 18087936,
"scriptDurationMs": 386.826,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1409.1009999999642,
"styleRecalcs": 78,
"styleRecalcDurationMs": 252.82100000000003,
"layouts": 76,
"layoutDurationMs": 28.729999999999997,
"taskDurationMs": 1381.224,
"heapDeltaBytes": -19127588,
"heapUsedBytes": 114270380,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 469.844,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.707499999999982,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1435.760000000073,
"styleRecalcs": 78,
"styleRecalcDurationMs": 259.19199999999995,
"layouts": 76,
"layoutDurationMs": 29.371000000000002,
"taskDurationMs": 1402.269,
"heapDeltaBytes": 10251228,
"heapUsedBytes": 117704156,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 467.269,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.88536585365852,
"p95FrameDurationMs": 33.20000000000073
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2235 passed, 0 failed · 1 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe website build checks published model pages against sitemap pages and redirect rules. New utilities track published paths, validate removed pages, and record live pages without deleting existing entries. ChangesPublished model-page audit
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant WebsiteBuild
participant CheckScript
participant Sitemap
participant VercelRedirects
participant AuditRules
WebsiteBuild->>CheckScript: run published-page check
CheckScript->>Sitemap: read sitemap pages
CheckScript->>VercelRedirects: load redirect rules
CheckScript->>AuditRules: audit published and live pages
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This adds a CI check for removed model pages and does not change runtime behavior. No merge-blocking risk is evident from the supplied context. Security Architecture ReviewSecurity architecture risk: ⚪ Minimal · up to The change adds a website validation gate, not a visitor-facing endpoint or a new privileged operation. No material security risk was identified in the reviewed paths. Recording changes remains an explicit developer action; CI only validates. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20292 +/- ##
==========================================
- Coverage 85.40% 85.31% -0.09%
==========================================
Files 3506 3420 -86
Lines 168310 165716 -2594
Branches 44138 43438 -700
==========================================
- Hits 143737 141379 -2358
+ Misses 22593 22504 -89
+ Partials 1980 1833 -147
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @MaanilVerma.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 5 |
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
…hed pages Redirect sources with :name and :name(a|b) params now match published pages, and their params fill the destination before the live check. Other source syntax throws. CI also compares the published list with the base branch and fails on an entry that was dropped without being retired.
|
Review fixes in cb3da50.
Website typecheck, oxlint and oxfmt pass, and the test file passes 30/30. The |
Read served pages from the built HTML, so a noindexed or rolled-back model page still counts as live. Reject retirements of unlisted or served pages, fail on a missing sitemap chunk or a foreign origin, and write --record only after the audit passes.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed cf3c546 with the Claude review skill and shared review memories. No blocking finding after checking actual HTML liveness, grouped redirect matching/parameter substitution, permanent one-hop destinations, retirement validation, base-list retention, record-before-write ordering and CI base fetching. No API response contract or frontend-derived server fact is added.
PASS (executed locally, isolated exact head with its own pnpm install --frozen-lockfile): website typecheck, 63 focused tests, build:e2e, and check:published-model-pages over the real output (533 recorded pages). Deleting flux1-dev-fp8/index.html failed with the missing-redirect message; adding a permanent slash-form redirect to the built flux1-dev page passed; changing it to temporary failed; restoring output/config passed. Deleting the same page from the history list and HTML, using this head as a controlled Git base, failed the dropped-history check. Disabling the temporary-redirect branch failed the named test (1 failed / 34 passed); source/config/list restored byte-for-byte to head. Required GitHub checks currently pass.
NOT_RUN: browser QA and performance measurement; this changes filesystem/CI validation, not rendered UI or a performance-sensitive runtime path. Historical issue/author/bot QA is context, not counted as my own PASS. Node 24.14.1 / pnpm 11.13.1 was used. After a catalogue-changing sibling lands, its new model pages still need recording as documented.
webreviewer-bot — review completed after mergeThis merged at 14:41:23Z while my pass was still running, so there is no review to submit — GitHub accepts neither APPROVE nor REQUEST_CHANGES on a closed PR. Recording the result here instead, because the code is now in Verdict I reached: APPROVE at The gate does not fail open — I tried seven ways to make itBuilt
That matters because three sibling gates reviewed today did fail open, each while printing success. This one does not, and the empty-input cases are the ones I most expected to pass silently. The step sits in the What the gate does not cover — worth stating plainlyIt catches #15487's failure mode, not a wrong destination. Repointing all 383 Relatedly, on #20291 I found a mutation that survives for the same reason: SHOULD FIX (follow-up)
Checked and clearedThe two redirect-source parsers do not disagree on any real source. Both this one and the now-merged #20198 matcher accept all 857 rows in Also confirmed: #20291's move, simulated against its real 919 rows, gives 0 errors — the "new Measured at |
Summary
CI now fails when a published model page leaves the build without a permanent redirect to a live page. This stops a catalogue refresh from turning a ranking page into a silent 404, as #15487 did to 10
/p/supported-models/pages.Changes
src/config/published-model-pages.jsonis a committed list of every published model page (533 today). It is seeded from the sitemap of a main build.check:published-model-pagesreads the built sitemap andvercel.json. Each listed page must be in the sitemap or have a permanent redirect from its slash form to a page in the sitemap. Otherwise it printspage X removed: add a permanent redirect in src/config/redirects.ts or restore the page.record:published-model-pagesadds new pages and never removes one./hub/models,/hub/workflows,/hub/apps,/models) or/p/supported-models, in any locale. New/hub/models/local/<slug>/pages are covered with no extra code.ci-website-build.yaml.:nameand:name(a|b)params (as the grouped/p/supported-models/redirects do). Their params fill the destination before the live check. Other source syntax fails the check.RETIRED_WITHOUT_REDIRECTwith a reason.Changed from the ticket: the ticket guarded slugs in
generated-models.jsonfrom a unit test. The pages now live at/hub/models/as well, and the in-flight local pages come from a different source. So the check reads the built sitemap, which covers every model page the same way. A page that is retired on purpose goes inRETIRED_WITHOUT_REDIRECTwith a reason. The 10 pages #15487 already removed are not seeded; their redirect and restore tickets own them.Review Focus
record:published-model-pagesafter a build. Without this, new pages would be unprotected. It also means the open supported-models PR must record its new pages once this merges./x/), because that is the address in the sitemap.sync:redirectsalways writes both forms.Fixes FE-2971
https://linear.app/comfyorg/issue/FE-2971