Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1cde6db329ddd37730d657b8be14fb5fa6905045
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2201 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-06T04:01:18.166Z",
"gitSha": "af6d1f069bac2ddd10a59047099040e9b92d56ef",
"branch": "glary/harden-lgraphgroup-bounds-review",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.79900000002,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.706,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 296.33500000000004,
"heapDeltaBytes": -3536252,
"heapUsedBytes": 58861436,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.77,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2011.2570000000005,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.96,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 276.604,
"heapDeltaBytes": 601820,
"heapUsedBytes": 67966940,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.84,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.288000000009,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.682,
"layouts": 12,
"layoutDurationMs": 3.681,
"taskDurationMs": 568.265,
"heapDeltaBytes": -2155972,
"heapUsedBytes": 66699044,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 104.204,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1687.73699999997,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.168000000000001,
"layouts": 12,
"layoutDurationMs": 3.2199999999999998,
"taskDurationMs": 540.591,
"heapDeltaBytes": -2458728,
"heapUsedBytes": 66264368,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 100.09899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.7039999999688,
"styleRecalcs": 31,
"styleRecalcDurationMs": 7.987999999999999,
"layouts": 6,
"layoutDurationMs": 1.349,
"taskDurationMs": 248.829,
"heapDeltaBytes": 3631836,
"heapUsedBytes": 71972016,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.426000000000005,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.5979999999954,
"styleRecalcs": 32,
"styleRecalcDurationMs": 6.822,
"layouts": 6,
"layoutDurationMs": 1.1350000000000002,
"taskDurationMs": 226.603,
"heapDeltaBytes": 3750052,
"heapUsedBytes": 71230280,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.351000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 525.8059999999887,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.522,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.51399999999995,
"heapDeltaBytes": -6837716,
"heapUsedBytes": 61082040,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 113.699,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 495.1369999999997,
"styleRecalcs": 17,
"styleRecalcDurationMs": 2.9640000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.77600000000007,
"heapDeltaBytes": -6754204,
"heapUsedBytes": 61092876,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 111.744,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 979.329000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.5669999999999,
"heapDeltaBytes": 13848992,
"heapUsedBytes": 94980896,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 41.742000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 361,
"frameDurationMs": 28.920588235294122,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1004.805000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.549,
"heapDeltaBytes": 12328184,
"heapUsedBytes": 82761824,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 37.824,
"eventListeners": 0,
"totalBlockingTimeMs": 376,
"frameDurationMs": 29.41176470588235,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 718.3050000000435,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 291.0759999999999,
"heapDeltaBytes": 17705884,
"heapUsedBytes": 104087680,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 92.38200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 102,
"frameDurationMs": 21.079411764705878,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 717.630999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.6719999999999,
"heapDeltaBytes": 16759616,
"heapUsedBytes": 102915064,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 98.15700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 103,
"frameDurationMs": 21.073529411764707,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6604.396000000008,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.1429999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5805.745,
"heapDeltaBytes": -11974960,
"heapUsedBytes": 72870184,
"domNodes": -142,
"jsHeapTotalBytes": -6688768,
"scriptDurationMs": 4478.222000000001,
"eventListeners": -78,
"totalBlockingTimeMs": 49,
"frameDurationMs": 24.81127819548872,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5791.765999999996,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8680000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5118.974999999999,
"heapDeltaBytes": 503024,
"heapUsedBytes": 85778532,
"domNodes": -172,
"jsHeapTotalBytes": -7475200,
"scriptDurationMs": 4002.758,
"eventListeners": -86,
"totalBlockingTimeMs": 2,
"frameDurationMs": 22.47945736434108,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6359.758000000028,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8870000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5533.831999999999,
"heapDeltaBytes": 3067740,
"heapUsedBytes": 88862080,
"domNodes": -143,
"jsHeapTotalBytes": -4067328,
"scriptDurationMs": 4330.228,
"eventListeners": -82,
"totalBlockingTimeMs": 69,
"frameDurationMs": 25.7748987854251,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5361.4880000000085,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0000000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4729.125,
"heapDeltaBytes": 111564,
"heapUsedBytes": 84449776,
"domNodes": -142,
"jsHeapTotalBytes": -11145216,
"scriptDurationMs": 3660.8910000000005,
"eventListeners": -78,
"totalBlockingTimeMs": 1,
"frameDurationMs": 21.658704453441295,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2009.2809999999872,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3320000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.43899999999996,
"heapDeltaBytes": -10433408,
"heapUsedBytes": 78300728,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 28.045999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2021.9679999999585,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.206999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.785,
"heapDeltaBytes": -12137944,
"heapUsedBytes": 67248608,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 29.766000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2113.226999999995,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.477,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1055.399,
"heapDeltaBytes": -20332656,
"heapUsedBytes": 69339172,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 537.402,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665873015873018,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2115.426999999954,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.942,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1084.954,
"heapDeltaBytes": -19311540,
"heapUsedBytes": 70601344,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 552.4839999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665354330708666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3168.190999999979,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.826999999999998,
"layouts": 60,
"layoutDurationMs": 14.977,
"taskDurationMs": 1220.7330000000002,
"heapDeltaBytes": 1259552,
"heapUsedBytes": 69738164,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 566.772,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3155.5249999999546,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.575999999999999,
"layouts": 60,
"layoutDurationMs": 14.048000000000002,
"taskDurationMs": 1192.1060000000002,
"heapDeltaBytes": 1511548,
"heapUsedBytes": 70176096,
"domNodes": 24,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 542.8139999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666137566137564,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2173.6700000000155,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1304.7589999999998,
"heapDeltaBytes": 2978336,
"heapUsedBytes": 72272056,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 663.628,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7953488372093,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2201.8019999999865,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.003999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1308.4220000000003,
"heapDeltaBytes": 3415324,
"heapUsedBytes": 71210440,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 653.543,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793129770992365,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2021.5069999999855,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2529999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.71,
"heapDeltaBytes": -9158828,
"heapUsedBytes": 81132252,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.96800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.795999999942,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.3,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 342.71799999999996,
"heapDeltaBytes": -9222248,
"heapUsedBytes": 80904156,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 27.612,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 510.94499999999243,
"styleRecalcs": 49,
"styleRecalcDurationMs": 4.943999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 317.56600000000003,
"heapDeltaBytes": -12631164,
"heapUsedBytes": 58001280,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 107.60600000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 425.59400000004644,
"styleRecalcs": 49,
"styleRecalcDurationMs": 4.216999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 276.985,
"heapDeltaBytes": -12866784,
"heapUsedBytes": 57842604,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 92.754,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661538461538473,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.5380000000205,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.607999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 291.308,
"heapDeltaBytes": 977464,
"heapUsedBytes": 70881612,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.23,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2005.578000000014,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.645999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 285.07000000000005,
"heapDeltaBytes": 1002468,
"heapUsedBytes": 71006292,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.589000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1674.004000000025,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.446999999999997,
"layouts": 16,
"layoutDurationMs": 4.843,
"taskDurationMs": 533.397,
"heapDeltaBytes": -6060336,
"heapUsedBytes": 63711396,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 72.937,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.291999999999,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.118999999999998,
"layouts": 16,
"layoutDurationMs": 4.210999999999999,
"taskDurationMs": 515.347,
"heapDeltaBytes": -6314312,
"heapUsedBytes": 63618740,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 69.78,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 816.6659999999979,
"styleRecalcs": 17,
"styleRecalcDurationMs": 19.231000000000005,
"layouts": 5,
"layoutDurationMs": 8.38,
"taskDurationMs": 595.628,
"heapDeltaBytes": -2388804,
"heapUsedBytes": 90139636,
"domNodes": 14227,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 18.73099999999999,
"eventListeners": 2463,
"totalBlockingTimeMs": 83,
"frameDurationMs": 19.919512195121946,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8151.716000000022,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.390999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3965.695,
"heapDeltaBytes": -12461296,
"heapUsedBytes": 76808080,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 1970.3169999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665848670756645,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8152.521999999976,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.834000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3736.999,
"heapDeltaBytes": -18784956,
"heapUsedBytes": 69564788,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 1776.553,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66618852459016,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11216.786000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10313.119,
"heapDeltaBytes": -18540416,
"heapUsedBytes": 181099404,
"domNodes": -3045,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 151.02900000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.010677966101692,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 10632.322000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9692.993000000002,
"heapDeltaBytes": -35134276,
"heapUsedBytes": 181595400,
"domNodes": -3045,
"jsHeapTotalBytes": 8196096,
"scriptDurationMs": 147.7,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.930860033726812,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 13063.056999999957,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.741000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12508.062,
"heapDeltaBytes": -40059396,
"heapUsedBytes": 187680536,
"domNodes": -3045,
"jsHeapTotalBytes": 5386240,
"scriptDurationMs": 634.7590000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 37,
"frameDurationMs": 22.963444639718805,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 13584.558000000015,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.31300000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12966.324,
"heapDeltaBytes": -29873724,
"heapUsedBytes": 195523928,
"domNodes": -3044,
"jsHeapTotalBytes": 11202560,
"scriptDurationMs": 649.1289999999999,
"eventListeners": -14907,
"totalBlockingTimeMs": 30,
"frameDurationMs": 23.81681260945709,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 3604.4449999999983,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.347,
"layouts": 20,
"layoutDurationMs": 19.959000000000003,
"taskDurationMs": 3455.84,
"heapDeltaBytes": 934816,
"heapUsedBytes": 222685164,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 54.337999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.17529411764706,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-node-resize-workload",
"durationMs": 4006.2310000000707,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.153000000000006,
"layouts": 20,
"layoutDurationMs": 21.913,
"taskDurationMs": 3804.227999999999,
"heapDeltaBytes": 1265204,
"heapUsedBytes": 214743940,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 62.065999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.21734104046243,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5113.508000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4772.804000000001,
"heapDeltaBytes": -31863800,
"heapUsedBytes": 182262760,
"domNodes": -3045,
"jsHeapTotalBytes": 8671232,
"scriptDurationMs": 66.11499999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.089679715302495,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5953.579999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5618.879,
"heapDeltaBytes": -30760692,
"heapUsedBytes": 180641908,
"domNodes": -3045,
"jsHeapTotalBytes": 5963776,
"scriptDurationMs": 85.67400000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.180612244897954,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 441.8279999999868,
"styleRecalcs": 19,
"styleRecalcDurationMs": 13.244,
"layouts": 3,
"layoutDurationMs": 1.384,
"taskDurationMs": 102.92999999999999,
"heapDeltaBytes": 5804772,
"heapUsedBytes": 70880436,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.716999999999995,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962965,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 87.04000000000178,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.563999999999999,
"layouts": 3,
"layoutDurationMs": 1.142,
"taskDurationMs": 56.84,
"heapDeltaBytes": 3715296,
"heapUsedBytes": 70140304,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.2079999999999975,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.650000000000016,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 420.88300000000345,
"styleRecalcs": 78,
"styleRecalcDurationMs": 62.195,
"layouts": 76,
"layoutDurationMs": 15.765,
"taskDurationMs": 379.48199999999997,
"heapDeltaBytes": 13264900,
"heapUsedBytes": 85268756,
"domNodes": 76,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 131.44,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664000000000016,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 403.199000000086,
"styleRecalcs": 78,
"styleRecalcDurationMs": 61.043,
"layouts": 76,
"layoutDurationMs": 14.988,
"taskDurationMs": 363.945,
"heapDeltaBytes": 13049688,
"heapUsedBytes": 85429572,
"domNodes": 76,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 125.163,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 650.2720000000863,
"styleRecalcs": 78,
"styleRecalcDurationMs": 161.14600000000002,
"layouts": 76,
"layoutDurationMs": 15.6,
"taskDurationMs": 625.7669999999999,
"heapDeltaBytes": 8296648,
"heapUsedBytes": 132569576,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 158.915,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 734.1209999999592,
"styleRecalcs": 78,
"styleRecalcDurationMs": 172.797,
"layouts": 76,
"layoutDurationMs": 16.44,
"taskDurationMs": 705.758,
"heapDeltaBytes": -22478764,
"heapUsedBytes": 107404160,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 186.903,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444435,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## glary/harden-lgraphgroup-bounds #20290 +/- ##
===================================================================
- Coverage 85.88% 85.85% -0.04%
===================================================================
Files 2449 2449
Lines 140165 140145 -20
Branches 36124 38081 +1957
===================================================================
- Hits 120385 120315 -70
- Misses 19403 19452 +49
- Partials 377 378 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 27 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Follow-up to #20260 from a self-review: covers the untested finiteness guard and tidies the new tests, so the approved PR can merge untouched.
Changes
NaNandInfinityrows. Before this, every rejection row failed thetypeofcheck, so theNumber.isFiniteguard never ran; removing it left the suite green. With these rows, removing it fails 2 tests.[label, property, value]table, and silence the expected warning in it.warn.mockRestore(), sincerestoreMocks: truealready does this._childrenis still clobbered (outside fix(litegraph): stop external writes from replacing a group's geometry buffers #20260's scope).absorbWritesbecomescopyAssignmentsIntoBuffer). The reasoning is already in fix(litegraph): stop external writes from replacing a group's geometry buffers #20260's description.<key> was assigned a non-array value; kept the existing buffer. The console stack already shows the caller, so the speculative hint added nothing.Review Focus
Not changed: every group with the per-instance accessors now uses V8 dictionary-mode properties. A plain-JS copy of the pattern reports
%HasFastPropertiesas false. With typical group counts this doesn't matter. Avoiding it would mean shared prototype accessors, which drop the own-enumerable keys #20260 keeps on purpose.