Skip to content

test(litegraph): cover non-finite coordinates in group geometry writes - #20290

Merged
DrJKL merged 2 commits into
glary/harden-lgraphgroup-boundsfrom
glary/harden-lgraphgroup-bounds-review
Oct 6, 2026
Merged

DrJKL merged 2 commits into
glary/harden-lgraphgroup-boundsfrom
glary/harden-lgraphgroup-bounds-review

Conversation

@DrJKL

@DrJKL DrJKL commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #20260 from a self-review: covers the untested finiteness guard and tidies the new tests, so the approved PR can merge untouched.

Changes

  • What:
    • Add NaN and Infinity rows. Before this, every rejection row failed the typeof check, so the Number.isFinite guard never ran; removing it left the suite green. With these rows, removing it fails 2 tests.
    • Fold the non-array test and the bad-element table into one [label, property, value] table, and silence the expected warning in it.
    • Drop warn.mockRestore(), since restoreMocks: true already does this.
    • Rename the JSON round-trip test: it checks geometry only, and _children is still clobbered (outside fix(litegraph): stop external writes from replacing a group's geometry buffers #20260's scope).
    • Replace the constructor comment with a descriptive name (absorbWrites becomes copyAssignmentsIntoBuffer). The reasoning is already in fix(litegraph): stop external writes from replacing a group's geometry buffers #20260's description.
    • Shorten the warning to <key> was assigned a non-array value; kept the existing buffer. The console stack already shows the caller, so the speculative hint added nothing.

Review Focus

Not changed: every group with the per-instance accessors now uses V8 dictionary-mode properties. A plain-JS copy of the pattern reports %HasFastProperties as false. With typical group counts this doesn't matter. Avoiding it would mean shared prototype accessors, which drop the own-enumerable keys #20260 keeps on purpose.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 1162e49c-7950-405e-a48f-9a4324b3b50a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/06/2026, 03:48:57 AM UTC

Links

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 1cde6db329ddd37730d657b8be14fb5fa6905045

Full docs: ADR-DEVEX-LINT-0015

🎭 Playwright: ✅ 2201 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2179 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.3 MB heap
dom-widget-order-dense-n200-w200-i120: · 34.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 369ms TBT · 84.8 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 47.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 103ms TBT · 98.7 MB heap
extension-clean-combined-draw: · 42.3 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 26ms TBT · 75.6 MB heap
extension-rgthree-prototype-draw: · 42.2 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 35ms TBT · 82.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
legacy-node-drag: · 59.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.7 MB heap
subgraph-transition-enter: · 50.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 83ms TBT · 86.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap
vue-large-graph-idle: · 54.1 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 172.9 MB heap
vue-large-graph-pan: · 42.8 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 34ms TBT · 182.7 MB heap
vue-node-resize-workload: · 45.1 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 208.6 MB heap
vue-zoom-out-idle: · 52.3 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 173.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.2 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.4 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 114.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 2ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 286ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 60.5 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 13ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 72
canvas-mouse-sweep: task duration 554ms
canvas-mouse-sweep: script duration 102ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.4 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 0
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 7ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 238ms
canvas-zoom-sweep: script duration 9ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 68.3 MB
canvas-zoom-sweep: DOM nodes 53
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 16
dom-widget-clipping: task duration 315ms
dom-widget-clipping: script duration 113ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 58.3 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 29ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 603ms
dom-widget-order-dense-n200-w200-i120: script duration 40ms
dom-widget-order-dense-n200-w200-i120: TBT 369ms
dom-widget-order-dense-n200-w200-i120: heap used 84.8 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 21ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 296ms
dom-widget-order-sparse-n1000-w20-i120: script duration 95ms
dom-widget-order-sparse-n1000-w20-i120: TBT 103ms
dom-widget-order-sparse-n1000-w20-i120: heap used 98.7 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 24ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 4
extension-clean-combined-draw: task duration 5462ms
extension-clean-combined-draw: script duration 4240ms
extension-clean-combined-draw: TBT 26ms
extension-clean-combined-draw: heap used 75.6 MB
extension-clean-combined-draw: DOM nodes -157
extension-clean-combined-draw: event listeners -82
extension-rgthree-prototype-draw: avg frame time 24ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 4
extension-rgthree-prototype-draw: task duration 5131ms
extension-rgthree-prototype-draw: script duration 3996ms
extension-rgthree-prototype-draw: TBT 35ms
extension-rgthree-prototype-draw: heap used 82.6 MB
extension-rgthree-prototype-draw: DOM nodes -143
extension-rgthree-prototype-draw: event listeners -80
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 11
large-graph-idle: task duration 344ms
large-graph-idle: script duration 29ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 69.4 MB
large-graph-idle: DOM nodes 0
large-graph-idle: event listeners 0
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1070ms
large-graph-pan: script duration 545ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 66.7 MB
large-graph-pan: DOM nodes 0
large-graph-pan: event listeners 0
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 15ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 73
large-graph-zoom: task duration 1206ms
large-graph-zoom: script duration 555ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 66.7 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 47
legacy-node-drag: task duration 1307ms
legacy-node-drag: script duration 659ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 68.4 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 11
minimap-idle: task duration 348ms
minimap-idle: script duration 29ms
minimap-idle: TBT 0ms
minimap-idle: heap used 77.3 MB
minimap-idle: DOM nodes 0
minimap-idle: event listeners 0
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 49
subgraph-dom-widget-clipping: task duration 297ms
subgraph-dom-widget-clipping: script duration 100ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 55.2 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 13
subgraph-idle: task duration 288ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.7 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 14ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 524ms
subgraph-mouse-sweep: script duration 71ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 60.7 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 0
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 8ms
subgraph-transition-enter: style recalc duration 19ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 596ms
subgraph-transition-enter: script duration 19ms
subgraph-transition-enter: TBT 83ms
subgraph-transition-enter: heap used 86.0 MB
subgraph-transition-enter: DOM nodes 14227
subgraph-transition-enter: event listeners 2463
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 30ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 3851ms
viewport-pan-sweep: script duration 1873ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 69.8 MB
viewport-pan-sweep: DOM nodes 0
viewport-pan-sweep: event listeners 0
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 33ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 10003ms
vue-large-graph-idle: script duration 149ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 172.9 MB
vue-large-graph-idle: DOM nodes -3045
vue-large-graph-idle: event listeners -14915
vue-large-graph-pan: avg frame time 23ms
vue-large-graph-pan: p95 frame time 50ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 14ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 66
vue-large-graph-pan: task duration 12737ms
vue-large-graph-pan: script duration 642ms
vue-large-graph-pan: TBT 34ms
vue-large-graph-pan: heap used 182.7 MB
vue-large-graph-pan: DOM nodes -3045
vue-large-graph-pan: event listeners -14911
vue-node-resize-workload: avg frame time 22ms
vue-node-resize-workload: p95 frame time 42ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 52ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 3630ms
vue-node-resize-workload: script duration 58ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 208.6 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 19ms
vue-zoom-out-idle: p95 frame time 33ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5196ms
vue-zoom-out-idle: script duration 76ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 173.0 MB
vue-zoom-out-idle: DOM nodes -3045
vue-zoom-out-idle: event listeners -14915
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 10ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 80ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.2 MB
workflow-execution: DOM nodes 122
workflow-execution: event listeners 49
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 15ms
agent-composer-empty-conversation-typing: style recalc duration 62ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 372ms
agent-composer-empty-conversation-typing: script duration 128ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 81.4 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 16ms
agent-composer-long-conversation-typing: style recalc duration 167ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 666ms
agent-composer-long-conversation-typing: script duration 173ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 114.4 MB
agent-composer-long-conversation-typing: DOM nodes 76
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-10-06T04:01:18.166Z",
  "gitSha": "af6d1f069bac2ddd10a59047099040e9b92d56ef",
  "branch": "glary/harden-lgraphgroup-bounds-review",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2010.79900000002,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 2.706,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 296.33500000000004,
      "heapDeltaBytes": -3536252,
      "heapUsedBytes": 58861436,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.77,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760327,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2011.2570000000005,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 1.96,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 276.604,
      "heapDeltaBytes": 601820,
      "heapUsedBytes": 67966940,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.84,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1678.288000000009,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 13.682,
      "layouts": 12,
      "layoutDurationMs": 3.681,
      "taskDurationMs": 568.265,
      "heapDeltaBytes": -2155972,
      "heapUsedBytes": 66699044,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 104.204,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66534653465347,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1687.73699999997,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 12.168000000000001,
      "layouts": 12,
      "layoutDurationMs": 3.2199999999999998,
      "taskDurationMs": 540.591,
      "heapDeltaBytes": -2458728,
      "heapUsedBytes": 66264368,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 100.09899999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665346534653462,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1705.7039999999688,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 7.987999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.349,
      "taskDurationMs": 248.829,
      "heapDeltaBytes": 3631836,
      "heapUsedBytes": 71972016,
      "domNodes": 53,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 10.426000000000005,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666990291262135,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1720.5979999999954,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 6.822,
      "layouts": 6,
      "layoutDurationMs": 1.1350000000000002,
      "taskDurationMs": 226.603,
      "heapDeltaBytes": 3750052,
      "heapUsedBytes": 71230280,
      "domNodes": 53,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.351000000000004,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666990291262135,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 525.8059999999887,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 2.522,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 318.51399999999995,
      "heapDeltaBytes": -6837716,
      "heapUsedBytes": 61082040,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 113.699,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66562499999999,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 495.1369999999997,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 2.9640000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 311.77600000000007,
      "heapDeltaBytes": -6754204,
      "heapUsedBytes": 61092876,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 111.744,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 979.329000000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 596.5669999999999,
      "heapDeltaBytes": 13848992,
      "heapUsedBytes": 94980896,
      "domNodes": 0,
      "jsHeapTotalBytes": 2260992,
      "scriptDurationMs": 41.742000000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 361,
      "frameDurationMs": 28.920588235294122,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1004.805000000033,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 608.549,
      "heapDeltaBytes": 12328184,
      "heapUsedBytes": 82761824,
      "domNodes": 0,
      "jsHeapTotalBytes": 2785280,
      "scriptDurationMs": 37.824,
      "eventListeners": 0,
      "totalBlockingTimeMs": 376,
      "frameDurationMs": 29.41176470588235,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 718.3050000000435,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 291.0759999999999,
      "heapDeltaBytes": 17705884,
      "heapUsedBytes": 104087680,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 92.38200000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 102,
      "frameDurationMs": 21.079411764705878,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 717.630999999983,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 301.6719999999999,
      "heapDeltaBytes": 16759616,
      "heapUsedBytes": 102915064,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 98.15700000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 103,
      "frameDurationMs": 21.073529411764707,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6604.396000000008,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.1429999999999982,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5805.745,
      "heapDeltaBytes": -11974960,
      "heapUsedBytes": 72870184,
      "domNodes": -142,
      "jsHeapTotalBytes": -6688768,
      "scriptDurationMs": 4478.222000000001,
      "eventListeners": -78,
      "totalBlockingTimeMs": 49,
      "frameDurationMs": 24.81127819548872,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 5791.765999999996,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 0.8680000000000008,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5118.974999999999,
      "heapDeltaBytes": 503024,
      "heapUsedBytes": 85778532,
      "domNodes": -172,
      "jsHeapTotalBytes": -7475200,
      "scriptDurationMs": 4002.758,
      "eventListeners": -86,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 22.47945736434108,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6359.758000000028,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 0.8870000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5533.831999999999,
      "heapDeltaBytes": 3067740,
      "heapUsedBytes": 88862080,
      "domNodes": -143,
      "jsHeapTotalBytes": -4067328,
      "scriptDurationMs": 4330.228,
      "eventListeners": -82,
      "totalBlockingTimeMs": 69,
      "frameDurationMs": 25.7748987854251,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 5361.4880000000085,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.0000000000000009,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4729.125,
      "heapDeltaBytes": 111564,
      "heapUsedBytes": 84449776,
      "domNodes": -142,
      "jsHeapTotalBytes": -11145216,
      "scriptDurationMs": 3660.8910000000005,
      "eventListeners": -78,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 21.658704453441295,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2009.2809999999872,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.3320000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 351.43899999999996,
      "heapDeltaBytes": -10433408,
      "heapUsedBytes": 78300728,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 28.045999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2021.9679999999585,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.206999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 336.785,
      "heapDeltaBytes": -12137944,
      "heapUsedBytes": 67248608,
      "domNodes": 0,
      "jsHeapTotalBytes": 36864,
      "scriptDurationMs": 29.766000000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2113.226999999995,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 9.477,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1055.399,
      "heapDeltaBytes": -20332656,
      "heapUsedBytes": 69339172,
      "domNodes": 0,
      "jsHeapTotalBytes": 1085440,
      "scriptDurationMs": 537.402,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665873015873018,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2115.426999999954,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 9.942,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1084.954,
      "heapDeltaBytes": -19311540,
      "heapUsedBytes": 70601344,
      "domNodes": 0,
      "jsHeapTotalBytes": 1085440,
      "scriptDurationMs": 552.4839999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665354330708666,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3168.190999999979,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 13.826999999999998,
      "layouts": 60,
      "layoutDurationMs": 14.977,
      "taskDurationMs": 1220.7330000000002,
      "heapDeltaBytes": 1259552,
      "heapUsedBytes": 69738164,
      "domNodes": 24,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 566.772,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665789473684214,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3155.5249999999546,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 13.575999999999999,
      "layouts": 60,
      "layoutDurationMs": 14.048000000000002,
      "taskDurationMs": 1192.1060000000002,
      "heapDeltaBytes": 1511548,
      "heapUsedBytes": 70176096,
      "domNodes": 24,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 542.8139999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666137566137564,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2173.6700000000155,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 7.003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1304.7589999999998,
      "heapDeltaBytes": 2978336,
      "heapUsedBytes": 72272056,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 663.628,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.7953488372093,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2201.8019999999865,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 5.003999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1308.4220000000003,
      "heapDeltaBytes": 3415324,
      "heapUsedBytes": 71210440,
      "domNodes": 0,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 653.543,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.793129770992365,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "minimap-idle",
      "durationMs": 2021.5069999999855,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.2529999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 353.71,
      "heapDeltaBytes": -9158828,
      "heapUsedBytes": 81132252,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 30.96800000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2004.795999999942,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.3,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 342.71799999999996,
      "heapDeltaBytes": -9222248,
      "heapUsedBytes": 80904156,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 27.612,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 510.94499999999243,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 4.943999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 317.56600000000003,
      "heapDeltaBytes": -12631164,
      "heapUsedBytes": 58001280,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 107.60600000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667741935483864,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 425.59400000004644,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 4.216999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 276.985,
      "heapDeltaBytes": -12866784,
      "heapUsedBytes": 57842604,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 92.754,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.661538461538473,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2009.5380000000205,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 2.607999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 291.308,
      "heapDeltaBytes": 977464,
      "heapUsedBytes": 70881612,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.23,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.578000000014,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 2.645999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 285.07000000000005,
      "heapDeltaBytes": 1002468,
      "heapUsedBytes": 71006292,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.589000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1674.004000000025,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 14.446999999999997,
      "layouts": 16,
      "layoutDurationMs": 4.843,
      "taskDurationMs": 533.397,
      "heapDeltaBytes": -6060336,
      "heapUsedBytes": 63711396,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 72.937,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666336633663363,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1678.291999999999,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 13.118999999999998,
      "layouts": 16,
      "layoutDurationMs": 4.210999999999999,
      "taskDurationMs": 515.347,
      "heapDeltaBytes": -6314312,
      "heapUsedBytes": 63618740,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 69.78,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66534653465347,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 816.6659999999979,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 19.231000000000005,
      "layouts": 5,
      "layoutDurationMs": 8.38,
      "taskDurationMs": 595.628,
      "heapDeltaBytes": -2388804,
      "heapUsedBytes": 90139636,
      "domNodes": 14227,
      "jsHeapTotalBytes": 2097152,
      "scriptDurationMs": 18.73099999999999,
      "eventListeners": 2463,
      "totalBlockingTimeMs": 83,
      "frameDurationMs": 19.919512195121946,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8151.716000000022,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 31.390999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3965.695,
      "heapDeltaBytes": -12461296,
      "heapUsedBytes": 76808080,
      "domNodes": 0,
      "jsHeapTotalBytes": 561152,
      "scriptDurationMs": 1970.3169999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665848670756645,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8152.521999999976,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 28.834000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3736.999,
      "heapDeltaBytes": -18784956,
      "heapUsedBytes": 69564788,
      "domNodes": 0,
      "jsHeapTotalBytes": 1085440,
      "scriptDurationMs": 1776.553,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66618852459016,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11216.786000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10313.119,
      "heapDeltaBytes": -18540416,
      "heapUsedBytes": 181099404,
      "domNodes": -3045,
      "jsHeapTotalBytes": 8146944,
      "scriptDurationMs": 151.02900000000002,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 19.010677966101692,
      "p95FrameDurationMs": 33.30000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10632.322000000044,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9692.993000000002,
      "heapDeltaBytes": -35134276,
      "heapUsedBytes": 181595400,
      "domNodes": -3045,
      "jsHeapTotalBytes": 8196096,
      "scriptDurationMs": 147.7,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.930860033726812,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13063.056999999957,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 13.741000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12508.062,
      "heapDeltaBytes": -40059396,
      "heapUsedBytes": 187680536,
      "domNodes": -3045,
      "jsHeapTotalBytes": 5386240,
      "scriptDurationMs": 634.7590000000001,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 37,
      "frameDurationMs": 22.963444639718805,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13584.558000000015,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 13.31300000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12966.324,
      "heapDeltaBytes": -29873724,
      "heapUsedBytes": 195523928,
      "domNodes": -3044,
      "jsHeapTotalBytes": 11202560,
      "scriptDurationMs": 649.1289999999999,
      "eventListeners": -14907,
      "totalBlockingTimeMs": 30,
      "frameDurationMs": 23.81681260945709,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3604.4449999999983,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 51.347,
      "layouts": 20,
      "layoutDurationMs": 19.959000000000003,
      "taskDurationMs": 3455.84,
      "heapDeltaBytes": 934816,
      "heapUsedBytes": 222685164,
      "domNodes": 0,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 54.337999999999994,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.17529411764706,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4006.2310000000707,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 53.153000000000006,
      "layouts": 20,
      "layoutDurationMs": 21.913,
      "taskDurationMs": 3804.227999999999,
      "heapDeltaBytes": 1265204,
      "heapUsedBytes": 214743940,
      "domNodes": 0,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 62.065999999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.21734104046243,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5113.508000000024,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4772.804000000001,
      "heapDeltaBytes": -31863800,
      "heapUsedBytes": 182262760,
      "domNodes": -3045,
      "jsHeapTotalBytes": 8671232,
      "scriptDurationMs": 66.11499999999998,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.089679715302495,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5953.579999999988,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5618.879,
      "heapDeltaBytes": -30760692,
      "heapUsedBytes": 180641908,
      "domNodes": -3045,
      "jsHeapTotalBytes": 5963776,
      "scriptDurationMs": 85.67400000000004,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.180612244897954,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "workflow-execution",
      "durationMs": 441.8279999999868,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 13.244,
      "layouts": 3,
      "layoutDurationMs": 1.384,
      "taskDurationMs": 102.92999999999999,
      "heapDeltaBytes": 5804772,
      "heapUsedBytes": 70880436,
      "domNodes": 129,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.716999999999995,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662962962962965,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 87.04000000000178,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 7.563999999999999,
      "layouts": 3,
      "layoutDurationMs": 1.142,
      "taskDurationMs": 56.84,
      "heapDeltaBytes": 3715296,
      "heapUsedBytes": 70140304,
      "domNodes": 114,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.2079999999999975,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.650000000000016,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 420.88300000000345,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 62.195,
      "layouts": 76,
      "layoutDurationMs": 15.765,
      "taskDurationMs": 379.48199999999997,
      "heapDeltaBytes": 13264900,
      "heapUsedBytes": 85268756,
      "domNodes": 76,
      "jsHeapTotalBytes": 9175040,
      "scriptDurationMs": 131.44,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664000000000016,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 403.199000000086,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 61.043,
      "layouts": 76,
      "layoutDurationMs": 14.988,
      "taskDurationMs": 363.945,
      "heapDeltaBytes": 13049688,
      "heapUsedBytes": 85429572,
      "domNodes": 76,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 125.163,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662500000000023,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 650.2720000000863,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 161.14600000000002,
      "layouts": 76,
      "layoutDurationMs": 15.6,
      "taskDurationMs": 625.7669999999999,
      "heapDeltaBytes": 8296648,
      "heapUsedBytes": 132569576,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 158.915,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664999999999985,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 734.1209999999592,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 172.797,
      "layouts": 76,
      "layoutDurationMs": 16.44,
      "taskDurationMs": 705.758,
      "heapDeltaBytes": -22478764,
      "heapUsedBytes": 107404160,
      "domNodes": 76,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 186.903,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664444444444435,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 6, 2026
@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/lib/litegraph/src/LGraphGroup.ts 85.71% 1 Missing ⚠️
@@                         Coverage Diff                         @@
##           glary/harden-lgraphgroup-bounds   #20290      +/-   ##
===================================================================
- Coverage                            85.88%   85.85%   -0.04%     
===================================================================
  Files                                 2449     2449              
  Lines                               140165   140145      -20     
  Branches                             36124    38081    +1957     
===================================================================
- Hits                                120385   120315      -70     
- Misses                               19403    19452      +49     
- Partials                               377      378       +1     
Flag Coverage Δ
e2e 64.77% <85.71%> (-0.07%) ⬇️
unit 82.80% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/LGraphGroup.ts 76.87% <85.71%> (ø)

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL
DrJKL merged commit 7fa98b0 into glary/harden-lgraphgroup-bounds Oct 6, 2026
121 checks passed
@DrJKL
DrJKL deleted the glary/harden-lgraphgroup-bounds-review branch October 6, 2026 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant