Repository navigation
[backport cloud/1.54] fix(agent): focus a chat’s open draft tab instead of calling it unavailable - #20276
Merged
Conversation
…ilable (#19873) Returning to a chat whose target is an unsaved Agent draft could say the workflow was unavailable while that chat-owned draft tab was still open. This focuses the owned tab instead, while preserving the unavailable state for deleted workflows. - Treat a complete workflow listing as conclusive when no local tab owns the workflow ID. - When a local tab does own the ID, read `GET /api/workflows/{id}` because the listing omits version-less drafts; only a 404 proves deletion. - Re-resolve tab ownership after that asynchronous read so closing or replacing a draft during restoration cannot reopen a stale tab. - Keep incomplete listings and non-404 read failures inconclusive rather than retiring a live target. - Validate persisted workflow bindings against non-empty graph IDs. - Restoration, resolver, and REST client unit suites: 131 passed. - Browser typecheck passed. - The remaining browser journey composes chat-history restoration, the real REST client, and tab focus; redundant deletion journeys are covered at unit/API level and by `agentDeletedTargetNotice.spec.ts`. - [Recorded browser walkthrough](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36979467267) (shows returning to the chat focusing its existing draft tab instead of displaying the unavailable notice). The recorded browser walkthrough above is the visual evidence for the user-visible state change. Supersedes #19649 and #18562. Linear: [FE-3015](https://linear.app/comfyorg/issue/FE-3015/historical-chats-can-restore-closed-unsaved-workflows)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1989 passed, 0 failed · 2 flaky📊 Browser Reports
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #19873 to Cloud 1.54 after the automatic cherry-pick reported conflicts.\n\nThe resolution preserves the release branch’s REST error handling, legacy tab-binding coverage, and older browser fixture APIs while adding the workflow-list completeness, per-workflow lifecycle check, draft ownership race fix, and black-box journey from the main fix.\n\nValidation:\n- 5 focused unit suites: 303 passed\n- app typecheck passed\n- browser typecheck passed\n- format, Oxlint, ESLint, Knip, and pre-push checks passed\n\nNo main-only REST operation-name or telemetry-option contracts were pulled into this release branch.