Repository navigation
[backport cloud/1.55] fix(agent): focus a chat’s open draft tab instead of calling it unavailable - #20275
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2152 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 606d44f5a48a72c6b9c005520da139aa34896636
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
This comment has been minimized.
This comment has been minimized.
…ilable (#19873) Returning to a chat whose target is an unsaved Agent draft could say the workflow was unavailable while that chat-owned draft tab was still open. This focuses the owned tab instead, while preserving the unavailable state for deleted workflows. - Treat a complete workflow listing as conclusive when no local tab owns the workflow ID. - When a local tab does own the ID, read `GET /api/workflows/{id}` because the listing omits version-less drafts; only a 404 proves deletion. - Re-resolve tab ownership after that asynchronous read so closing or replacing a draft during restoration cannot reopen a stale tab. - Keep incomplete listings and non-404 read failures inconclusive rather than retiring a live target. - Validate persisted workflow bindings against non-empty graph IDs. - Restoration, resolver, and REST client unit suites: 131 passed. - Browser typecheck passed. - The remaining browser journey composes chat-history restoration, the real REST client, and tab focus; redundant deletion journeys are covered at unit/API level and by `agentDeletedTargetNotice.spec.ts`. - [Recorded browser walkthrough](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36979467267) (shows returning to the chat focusing its existing draft tab instead of displaying the unavailable notice). The recorded browser walkthrough above is the visual evidence for the user-visible state change. Supersedes #19649 and #18562. Linear: [FE-3015](https://linear.app/comfyorg/issue/FE-3015/historical-chats-can-restore-closed-unsaved-workflows)
e4cf78a to
760b76a
Compare
…le test The #20275 backport kept a main-only `surface` option in the expected reportError call. ReportErrorOptions on cloud/1.55 has no `surface`, so the 403/500 lifecycle cases failed on every PR against this branch.
Backports #19873 to Cloud 1.55 after the automatic cherry-pick reported conflicts.\n\nThe resolution preserves the release branch’s existing REST helper contract and legacy tab-binding coverage while adding the workflow-list completeness, per-workflow lifecycle check, draft ownership race fix, and black-box journey from the main fix.\n\nValidation:\n- 5 focused unit suites: 300 passed\n- app typecheck passed\n- format, Oxlint, ESLint, Knip, and pre-push checks passed\n\nNo main-only REST operation-name or telemetry-option contracts were pulled into this release branch.