Repository navigation
fix(litegraph): make LGraphGroup.bounds non-enumerable and non-writable - #20244
claude[bot] wants to merge 2 commits into
Conversation
Define the group's geometry storage (bounds and its _pos, _size and _bounding mutation views) as non-enumerable, non-writable own properties so code that copies a JSON or spread snapshot back onto a group can no longer replace the Rectangle with a plain object, which made syncBoundsFromStore throw 'this.bounds.set is not a function'.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 417f25b2d4ccc04ff8c58163bfc49356b701ccdd
Full docs: ADR-DEVEX-LINT-0015 🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 10.2 MB gzip 🔴 +521 BDetailsSummary
Category Glance App Entry Points — 3.98 kB (baseline 3.98 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.47 MB (baseline 1.47 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 135 kB (baseline 135 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 648 kB (baseline 648 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 53.7 kB (baseline 53.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 8 unchanged Editors & Dialogs — 133 kB (baseline 133 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 2 unchanged UI Components — 194 kB (baseline 194 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed / 10 unchanged Data & Services — 4.17 MB (baseline 4.17 MB) • 🔴 +1.55 kBStores, services, APIs, and repositories
Status: 12 added / 12 removed / 4 unchanged Utilities & Hooks — 580 kB (baseline 580 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.2 MB (baseline 17.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.4 MB (baseline 18.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 77 added / 77 removed / 232 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-05T22:11:02.904Z",
"gitSha": "d840e29fc32fe28e627578b9d6409a4f11f5526c",
"branch": "fix/lggroup-bounds-clobber",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.4420000000218,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.907,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.969,
"heapDeltaBytes": 480916,
"heapUsedBytes": 68493100,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.892000000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2017.5970000000234,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.125,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.97399999999993,
"heapDeltaBytes": -3261832,
"heapUsedBytes": 58447940,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.023,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1809.9320000000034,
"styleRecalcs": 75,
"styleRecalcDurationMs": 19.208,
"layouts": 12,
"layoutDurationMs": 4.146999999999999,
"taskDurationMs": 872.424,
"heapDeltaBytes": -2149640,
"heapUsedBytes": 66088700,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 166.999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1792.4729999999727,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.99,
"layouts": 12,
"layoutDurationMs": 4.256,
"taskDurationMs": 795.0760000000001,
"heapDeltaBytes": -2085248,
"heapUsedBytes": 65797680,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 165.139,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1743.0800000000204,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.82,
"layouts": 6,
"layoutDurationMs": 1.109,
"taskDurationMs": 374.65700000000004,
"heapDeltaBytes": 3737276,
"heapUsedBytes": 71331232,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.784999999999993,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.8800000000083,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.709,
"layouts": 6,
"layoutDurationMs": 1.252,
"taskDurationMs": 373.313,
"heapDeltaBytes": 3426816,
"heapUsedBytes": 71028388,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.585000000000008,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 762.3199999999883,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.7470000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.3449999999999,
"heapDeltaBytes": -8031228,
"heapUsedBytes": 59241872,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 177.79699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 694.6849999999358,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.875,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.899,
"heapDeltaBytes": -6786876,
"heapUsedBytes": 60598040,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.603,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536566,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1166.3609999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 872.698,
"heapDeltaBytes": 38516140,
"heapUsedBytes": 106724428,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 74.072,
"eventListeners": 0,
"totalBlockingTimeMs": 544,
"frameDurationMs": 35.351515151515166,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1128.419000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 784.722,
"heapDeltaBytes": 15171944,
"heapUsedBytes": 85444348,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 65.404,
"eventListeners": 0,
"totalBlockingTimeMs": 509,
"frameDurationMs": 33.335294117647045,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 943.1050000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.0759999999992,
"heapDeltaBytes": 18529400,
"heapUsedBytes": 105403744,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 172.09000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 284,
"frameDurationMs": 26.665714285714316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.0350000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.8459999999998,
"heapDeltaBytes": 17193204,
"heapUsedBytes": 105002420,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 164.16199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10605.13400000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9606.297000000002,
"heapDeltaBytes": 8807376,
"heapUsedBytes": 93205152,
"domNodes": -143,
"jsHeapTotalBytes": -10358784,
"scriptDurationMs": 7909.072000000001,
"eventListeners": -82,
"totalBlockingTimeMs": 1217,
"frameDurationMs": 33.973076923076924,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10104.352000000063,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9199.942000000001,
"heapDeltaBytes": 7910096,
"heapUsedBytes": 92819348,
"domNodes": -142,
"jsHeapTotalBytes": -11931648,
"scriptDurationMs": 7591.777999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 915,
"frameDurationMs": 32.32044728434505,
"p95FrameDurationMs": 66.5
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9846.88699999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9028.292000000001,
"heapDeltaBytes": 6116884,
"heapUsedBytes": 84751964,
"domNodes": -143,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 7456.9130000000005,
"eventListeners": -78,
"totalBlockingTimeMs": 857,
"frameDurationMs": 32.61423841059602,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9818.956999999955,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3759999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8946.874,
"heapDeltaBytes": -16300448,
"heapUsedBytes": 68548688,
"domNodes": -142,
"jsHeapTotalBytes": -9572352,
"scriptDurationMs": 7386.031,
"eventListeners": -74,
"totalBlockingTimeMs": 1121,
"frameDurationMs": 32.83010033444816,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-graph-idle",
"durationMs": 2021.2620000000356,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.279999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.9649999999999,
"heapDeltaBytes": -10598180,
"heapUsedBytes": 78402552,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.331,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2021.908999999937,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.405999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.8550000000001,
"heapDeltaBytes": -10615552,
"heapUsedBytes": 78854036,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.84799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2767.862999999977,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.252999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1679.4450000000004,
"heapDeltaBytes": -16647848,
"heapUsedBytes": 70117300,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 881.2379999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2537.953000000016,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.56,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1614.478,
"heapDeltaBytes": -19044384,
"heapUsedBytes": 70474244,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 864.8979999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3587.7179999999953,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.558999999999997,
"layouts": 60,
"layoutDurationMs": 14.061,
"taskDurationMs": 1676.489,
"heapDeltaBytes": 1269364,
"heapUsedBytes": 69652004,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 786.049,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666203703703705,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3805.7919999999967,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.089,
"layouts": 60,
"layoutDurationMs": 14.623999999999999,
"taskDurationMs": 1760.4569999999999,
"heapDeltaBytes": 2158776,
"heapUsedBytes": 70793996,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 864.502,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3143.9419999999814,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.339999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1982.0099999999998,
"heapDeltaBytes": 18012592,
"heapUsedBytes": 86720368,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 1045.644,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75508021390374,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3153.1850000000077,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.875000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1906.674,
"heapDeltaBytes": 13995372,
"heapUsedBytes": 97315028,
"domNodes": 0,
"jsHeapTotalBytes": 978944,
"scriptDurationMs": 989.556,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84438502673797,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.2349999999901,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.764,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.629,
"heapDeltaBytes": 12669468,
"heapUsedBytes": 80202164,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.598000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2009.2240000000174,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.0809999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.774,
"heapDeltaBytes": -10344748,
"heapUsedBytes": 79098244,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 39.741000000000014,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 641.8679999999881,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.418,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.322,
"heapDeltaBytes": -12340640,
"heapUsedBytes": 57312680,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 144.135,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 645.2239999999847,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.679000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.909,
"heapDeltaBytes": -11954484,
"heapUsedBytes": 58006992,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 148.625,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.655000000033,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.884999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.211,
"heapDeltaBytes": 1028908,
"heapUsedBytes": 70693780,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.629000000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2021.9200000000228,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.270000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.33000000000004,
"heapDeltaBytes": 1054612,
"heapUsedBytes": 71478528,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.720999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.691000000007,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.168,
"layouts": 16,
"layoutDurationMs": 5.635000000000001,
"taskDurationMs": 851.204,
"heapDeltaBytes": -6211976,
"heapUsedBytes": 64670276,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 121.507,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1728.6430000000337,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.364,
"layouts": 16,
"layoutDurationMs": 6.446999999999999,
"taskDurationMs": 750.518,
"heapDeltaBytes": -6413392,
"heapUsedBytes": 64014332,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 117.19000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846145,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1386.5729999999985,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.964,
"layouts": 5,
"layoutDurationMs": 14.931000000000003,
"taskDurationMs": 979.0669999999999,
"heapDeltaBytes": 1120108,
"heapUsedBytes": 96330992,
"domNodes": 14227,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 29.838000000000005,
"eventListeners": 2463,
"totalBlockingTimeMs": 132,
"frameDurationMs": 19.17808219178082,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8978.421999999966,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.642,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5861.616,
"heapDeltaBytes": -19189368,
"heapUsedBytes": 69694620,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2836.44,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.697206703910613,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8424.015999999938,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.342,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5705.303,
"heapDeltaBytes": 7586844,
"heapUsedBytes": 96595540,
"domNodes": 0,
"jsHeapTotalBytes": 491520,
"scriptDurationMs": 2805.7369999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699007936507936,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18704.03300000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17886.644,
"heapDeltaBytes": -42204020,
"heapUsedBytes": 179911528,
"domNodes": -3045,
"jsHeapTotalBytes": 1679360,
"scriptDurationMs": 301.983,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.4640625,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-idle",
"durationMs": 17964.99700000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17226.351000000002,
"heapDeltaBytes": -33309672,
"heapUsedBytes": 179565632,
"domNodes": -3045,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 302.234,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.763527397260276,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 22248.496999999985,
"styleRecalcs": 172,
"styleRecalcDurationMs": 22.426000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21856.284000000003,
"heapDeltaBytes": -29304288,
"heapUsedBytes": 184065584,
"domNodes": -3045,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 878.487,
"eventListeners": -14915,
"totalBlockingTimeMs": 19,
"frameDurationMs": 41.12587800369686,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21806.843999999954,
"styleRecalcs": 176,
"styleRecalcDurationMs": 21.848000000000035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21537.259,
"heapDeltaBytes": -28013164,
"heapUsedBytes": 184921720,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 876.5750000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 12,
"frameDurationMs": 40.89887429643527,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-node-resize-workload",
"durationMs": 6765.009999999961,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.90200000000003,
"layouts": 20,
"layoutDurationMs": 27.005000000000003,
"taskDurationMs": 6661.848,
"heapDeltaBytes": 5921208,
"heapUsedBytes": 224324812,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 113.84499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.66514285714287,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 6623.667999999952,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.84400000000002,
"layouts": 20,
"layoutDurationMs": 25.128999999999984,
"taskDurationMs": 6473.416,
"heapDeltaBytes": 778080,
"heapUsedBytes": 214224540,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 116.098,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.640837696335076,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9346.875999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8865.635,
"heapDeltaBytes": -29341912,
"heapUsedBytes": 185826120,
"domNodes": -3045,
"jsHeapTotalBytes": 5410816,
"scriptDurationMs": 158.16600000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.693898305084748,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9443.93100000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8992.319000000001,
"heapDeltaBytes": -31698248,
"heapUsedBytes": 180773864,
"domNodes": -3045,
"jsHeapTotalBytes": 8704000,
"scriptDurationMs": 149.31399999999994,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.472852233676974,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 125.76200000000881,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.601,
"layouts": 3,
"layoutDurationMs": 2.161,
"taskDurationMs": 98.29299999999999,
"heapDeltaBytes": 3927188,
"heapUsedBytes": 69261512,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.628,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "workflow-execution",
"durationMs": 125.29600000004848,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.535,
"layouts": 2,
"layoutDurationMs": 1.299,
"taskDurationMs": 84.029,
"heapDeltaBytes": 3655840,
"heapUsedBytes": 69297388,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.703,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142908,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1014.4040000000132,
"styleRecalcs": 78,
"styleRecalcDurationMs": 113.758,
"layouts": 76,
"layoutDurationMs": 28.165,
"taskDurationMs": 994.564,
"heapDeltaBytes": 18919608,
"heapUsedBytes": 85547936,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 412.868,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667213114754095,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1164.1309999999976,
"styleRecalcs": 78,
"styleRecalcDurationMs": 117.40599999999999,
"layouts": 76,
"layoutDurationMs": 30.34,
"taskDurationMs": 1111.225,
"heapDeltaBytes": 20044780,
"heapUsedBytes": 85671692,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 461.48,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.907246376811585,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1511.690999999928,
"styleRecalcs": 78,
"styleRecalcDurationMs": 283.66799999999995,
"layouts": 76,
"layoutDurationMs": 31.047,
"taskDurationMs": 1480.959,
"heapDeltaBytes": 8622268,
"heapUsedBytes": 115334184,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 488.488,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.72345679012346,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1505.2489999999352,
"styleRecalcs": 78,
"styleRecalcDurationMs": 279.69300000000004,
"layouts": 76,
"layoutDurationMs": 30.395,
"taskDurationMs": 1474.384,
"heapDeltaBytes": 8525816,
"heapUsedBytes": 114782580,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 498.185,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2200 passed, 0 failed · 1 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
The red checks on da8830d (
Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 1 |
| 🟢 Low | 2 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
| LGraphGroup.minWidth, | ||
| LGraphGroup.minHeight | ||
| ) | ||
| declare private readonly bounds: Rectangle |
There was a problem hiding this comment.
🟠 High — declare private readonly bounds places the accessibility modifier after declare, which TypeScript's modifier grammar rejects (TS1029, "'private' modifier must precede 'declare' modifier"), so pnpm typecheck / pnpm build will fail. Write it as private declare readonly bounds: Rectangle; the three declarations at lines 97-99 have no accessibility modifier and are unaffected. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
There was a problem hiding this comment.
Checked, and this one doesn't hold. Both declare private readonly and private declare readonly compile cleanly with the repo's TypeScript 6.0.3 (tsc --noEmit --strict on a scratch class) and with the tsgo-backed pnpm typecheck, which passed in the pre-commit hook for both commits. I originally wrote private declare, and oxfmt rewrote it to declare private, so the formatter enforces the current order. Leaving it as is.
Generated by Claude Code
Replace the non-writable, non-configurable data properties with non-enumerable, configurable accessors. Writes of a numeric tuple are applied through setBounds, and any other value is ignored, so assigning a snapshot that still carries these keys never throws or leaves the group half-updated. _nodes and _children get the same treatment, accepting only an array or Set, so a JSON copy assigned back can no longer break move() or recomputeInsideNodes().
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #20244 +/- ##
==========================================
+ Coverage 85.12% 85.88% +0.76%
==========================================
Files 3480 2449 -1031
Lines 167778 140167 -27611
Branches 43971 36100 -7871
==========================================
- Hits 142821 120384 -22437
+ Misses 22978 19406 -3572
+ Partials 1979 377 -1602
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1042 files with indirect coverage changes 🚀 New features to boost your workflow:
|
The same JSON round-trip that replaced the geometry buffers turns _children
into {} and _nodes into [], after which recomputeInsideNodes() throws
'children.clear is not a function' and move() throws 'this._children is not
iterable'. Guard both the way the buffers are guarded: only a real Array or
Set replaces the current collection, anything else is ignored.
Folds in the _children/_nodes half of #20244 so that PR can close, and closes
the gap flagged in review on this one. Scoping these out was defensible while
they lived in a separate PR; it is not once that PR is being retired.
|
Closing in favour of #20260, which now includes the Generated by Claude Code |
Requested via Slack thread
Before: Production sees
TypeError: this.bounds.set is not a functionfromLGraphGroup.syncBoundsFromStorewhen something outside the typed code overwrites the group's ownboundsfield, for example an extension copying a JSON snapshot of the group back onto it (Object.assign(group, JSON.parse(JSON.stringify(group)))).boundswas an ordinary enumerable, writable own field, so the snapshot replaced theRectanglewith a plain{ "0": x, "1": y, ... }object and every later geometry read threw.After:
bounds, its_pos/_size/_boundingmutation views, and the_nodes/_childrencollections are non-enumerable, configurable accessor properties on the instance. Snapshots (JSON, spread,Object.keys) no longer include them, so copying one back onto the group leaves geometry and child tracking intact. Writing one of them never replaces the backing object and never throws: a numeric tuple of the right length (e.g._pos = [x, y],bounds = [x, y, w, h]) is applied throughsetBoundsso the layout store stays in step,_nodes/_childrenaccept only an array /Set, and anything else (such as the{ "0": x, ... }object an older build's snapshot carries) is ignored.How: the fields become
declared and the constructor builds theRectangle, the mutation views and the collections as locals, then installs them through a small typeddefineGuardedhelper (the views previously readthis.boundsfrom class-field initializers). The exact trigger in production is not confirmed; this is hardening that makes the clobber impossible without turning stray writes into new exceptions. Plain properties (not#private) are kept so groups still work behind a Proxy, andconfigurable: truekeeps Proxy invariants and redefinition patterns working. The affected code came from #14246.Changes
LGraphGroupdefinesbounds,_pos,_size,_bounding,_nodesand_childrenas non-enumerable accessors in the constructor;serialize()output is unchanged (snapshot test still passes).LGraphsurvivesObject.assignof its own JSON copy (syncBoundsFromStore,pos/sizesetters,boundingRect, the layout store,recomputeInsideNodes()andmove()of a contained node all keep working); incompatible values assigned over these keys are ignored without throwing; numeric tuples are applied and committed; none of the six keys appear inObject.keys(group)orJSON.stringify(group). All of these fail onmain(this.bounds.set is not a function,children.clear is not a function).Review Focus
serialize()/configure()is the supported way to copy a group.Object.keys(group)) will no longer see them.🤖 Generated with Claude Code
https://claude.ai/code/session_0165pathsiwNTi9Jy3YUovyc