Skip to content

feat(website): retire /p/supported-models into /hub/models - #20192

Closed
MaanilVerma wants to merge 2 commits into
mainfrom
maanil/supported-models-to-hub
Closed

MaanilVerma wants to merge 2 commits into
mainfrom
maanil/supported-models-to-hub

Conversation

@MaanilVerma

Copy link
Copy Markdown
Collaborator

Summary

Retire /p/supported-models into /hub/models in one cut-over: each supported-model page that has a Hub page for the same model 308s straight to it, and every other address (the index, its .md and llms.txt, all other slugs and twins) 308s to /hub/models/.

Fixes FE-2964 (https://linear.app/comfyorg/issue/FE-2964). Changed from the ticket: the owner chose a single cut-over to the Hub instead of the measured batches in FE-2958, FE-2964, FE-2946, FE-2938, FE-2933 and FE-2920.

Changes

  • What:
    • src/config/supported-model-urls.ts: frozen table of all 394 published slugs (382 pages + 12 alias stubs), each with its Hub slug or none. Generated by scripts/generate-supported-model-urls.ts (pure compileSupportedModelUrls, rows stay frozen on regeneration).
    • redirects.ts: 9 exact rows, then /p/supported-models.md and one /p/supported-models/:path* catch-all, all 308. The 12 old alias rows go (the catch-all covers them in one hop). vercel.json goes from 857 to 855 routes.
    • The pages, their twins and llms.txt leave the build and the sitemap. llms.txt, the drops card, the showcase CTA and the launch-page "Models" breadcrumb now link /hub/models/. The footer and nav "Supported Models" links go, because the same menus already link the catalogue at /hub/models/. The modules and locale keys that only those pages used go too.
    • The llms.txt stale-link check now understands a /:path* source, so the catch-all doesn't hide a stale link.
  • Breaking: /p/supported-models/* no longer renders. routes.models is removed (use routes.workshop).

Where the pages were served: apps/website (Astro static pages under src/pages/p/supported-models/). comfy-router passes /p/* (except registered subpages; only test-page is registered) to the website origin unchanged with redirect: 'manual', so these Vercel redirects reach prod with no router change.

Match rule: a Hub page matches when its frozen display name minus the task suffix equals the supported-model name (slugified, 2 and 2.0 equal). Provider-only names (e.g. ElevenLabs) never match. When several task pages match, the first task in this order wins: text-to-image, text-to-vector, text-to-video, reference-to-video, text-to-speech, text-to-dialogue, image-to-video, first-last-frame, video-continuation, image-edit, video-edit, video-to-video, audio-to-video (the same use-case priority as primarySlug).

Supported-model page Hub target Other task pages for the same model
nano-banana nano-banana-text-to-image image-edit
nano-banana-2 nano-banana-2-text-to-image image-edit
wan2-6 wan-2-6-text-to-video image-to-video, reference-to-video
wan2-7 wan-2-7-text-to-video image-to-video, reference-to-video, video-continuation, video-edit
wan-3-0 wan-3-0-text-to-video image-to-video, reference-to-video
seedance-2-0 seedance-2-0-text-to-video image-to-video, reference-to-video
seedance-2 seedance-2-0-text-to-video same model, "2" read as "2.0"
veo-3 veo-3-text-to-video image-to-video, first-last-frame
kling-o3 kling-o3-text-to-video image-to-video, video-edit, video-to-video

Near misses sent to /hub/models/ (owner may want to override): grok-imagine (Hub has Grok Imagine Image / Video, not one model), kling-2-6 (Hub has only Kling 2.6 Pro), flux-2-api (Max and Pro), happyhorse1 (Hub names carry no version), elevenlabs (provider page), krea-2, recraft, ideogram, runway, beeble, heygen.

Review Focus

  • Traffic (GSC, 90 days to 2026-09-22, 47,267 clicks): exact-match pages 397 clicks (0.8%); fallback slugs 45,345; slugs no longer in the data (e.g. dreamshaper-8-pruned, stability-ai) 928; the index 597. So about 99% of the section's clicks land on /hub/models/, which is a many-to-one redirect Google may treat as a soft 404.
  • Open PRs that build on these pages: fix(website): restore model explorer with verified releases and usage trends #19786 (model explorer refresh) and [feat] Add search bar to supported models page #17681 (search bar).
  • /hub/models/* exists only when WORKSHOP_IN_BUILD=1; with it off every target 404s.
  • stability-ai was an intentional 404; the catch-all now 308s it to /hub/models/.

Each supported-model page that has a Hub page for the same model 308s
to it; every other address under /p/supported-models, the index and its
twins 308 to /hub/models/ through one catch-all. The mapping is a frozen
table generated from the supported-models data and the Hub URL table.
The pages, their markdown twins and llms.txt now redirect, so drop them
from the build, point the launch-page breadcrumbs, drops card, showcase
CTA and llms.txt at /hub/models/, and remove the footer and nav entries
that duplicated the catalogue link. Delete the modules only those pages
used.
@MaanilVerma
MaanilVerma requested a review from a team October 5, 2026 14:10
@MaanilVerma MaanilVerma added the cursor-review Trigger multi-model Cursor agent review on this PR label Oct 5, 2026
@MaanilVerma MaanilVerma self-assigned this Oct 5, 2026
@MaanilVerma MaanilVerma added the cursor-review Trigger multi-model Cursor agent review on this PR label Oct 5, 2026
@vercel

vercel Bot commented Oct 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 5, 2026 2:10pm UTC
billing-web-test Ignored Ignored Oct 5, 2026 2:10pm UTC

Request Review

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since c9326eb303a2a0628fd69d436df4975365f6fa1d

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-20192.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-g2p75dpxc-comfyui.vercel.app

Last updated: 2026-10-05T14:13:55Z for 81488bb

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 5, 2026
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (4)
apps/website/AGENTS.md — auto-discovered
docs/guidance/testing-principles.md — auto-discovered
docs/guidance/typescript.md — auto-discovered
src/AGENTS.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 2136837d-dfcc-4d42-be7b-f9ea89a669f7
📥 Commits

Reviewing files that changed from the base of the PR and between c9326eb and 81488bb.

📒 Files selected for processing (54)
  • apps/website/e2e/canonical-redirects.spec.ts
  • apps/website/e2e/flux-3.spec.ts
  • apps/website/e2e/gemini-omni.spec.ts
  • apps/website/e2e/ltx-2.5.spec.ts
  • apps/website/e2e/minimax-h3.spec.ts
  • apps/website/e2e/seedance.spec.ts
  • apps/website/e2e/supported-models.spec.ts
  • apps/website/e2e/wan-3.0.spec.ts
  • apps/website/e2e/wan-animate-2.spec.ts
  • apps/website/public/llms.txt
  • apps/website/scripts/generate-model-url-map.test.ts
  • apps/website/scripts/generate-supported-model-urls.test.ts
  • apps/website/scripts/generate-supported-model-urls.ts
  • apps/website/src/components/common/SiteFooter.vue
  • apps/website/src/components/models/ModelHeroSection.vue
  • apps/website/src/components/models/ModelsShowcase.astro
  • apps/website/src/config/indexing.test.ts
  • apps/website/src/config/indexing.ts
  • apps/website/src/config/llms-txt.test.ts
  • apps/website/src/config/model-descriptions.test.ts
  • apps/website/src/config/model-descriptions.ts
  • apps/website/src/config/model-llms.test.ts
  • apps/website/src/config/model-llms.ts
  • apps/website/src/config/model-pricing.test.ts
  • apps/website/src/config/model-pricing.ts
  • apps/website/src/config/models.ts
  • apps/website/src/config/redirects.test.ts
  • apps/website/src/config/redirects.ts
  • apps/website/src/config/routes.test.ts
  • apps/website/src/config/routes.ts
  • apps/website/src/config/supported-model-urls.ts
  • apps/website/src/data/drops.ts
  • apps/website/src/data/mainNavigation.ts
  • apps/website/src/integrations/markdown-twins.ts
  • apps/website/src/lib/hreflang.test.ts
  • apps/website/src/lib/llms-txt.test.ts
  • apps/website/src/lib/llms-txt.ts
  • apps/website/src/lib/section-index.test.ts
  • apps/website/src/lib/section-index.ts
  • apps/website/src/locales/en/main.json
  • apps/website/src/locales/zh-CN/main.json
  • apps/website/src/pages/p/supported-models/[slug].astro
  • apps/website/src/pages/p/supported-models/[slug].md.ts
  • apps/website/src/pages/p/supported-models/_llms.txt.test.ts
  • apps/website/src/pages/p/supported-models/_slug.md.test.ts
  • apps/website/src/pages/p/supported-models/index.astro
  • apps/website/src/pages/p/supported-models/llms.txt.ts
  • apps/website/src/pages/zh-CN/models.astro
  • apps/website/src/templates/model-launch/ModelLaunchPage.astro
  • apps/website/src/utils/modelFaq.test.ts
  • apps/website/src/utils/modelFaq.ts
  • apps/website/src/utils/modelSeoCopy.test.ts
  • apps/website/src/utils/modelSeoCopy.ts
  • apps/website/vercel.json
💤 Files with no reviewable changes (29)
  • apps/website/src/components/common/SiteFooter.vue
  • apps/website/src/pages/p/supported-models/index.astro
  • apps/website/src/lib/section-index.test.ts
  • apps/website/src/config/model-descriptions.test.ts
  • apps/website/src/utils/modelFaq.test.ts
  • apps/website/src/components/models/ModelHeroSection.vue
  • apps/website/e2e/supported-models.spec.ts
  • apps/website/src/config/model-llms.test.ts
  • apps/website/src/locales/en/main.json
  • apps/website/src/pages/p/supported-models/[slug].md.ts
  • apps/website/src/config/model-descriptions.ts
  • apps/website/src/config/models.ts
  • apps/website/src/config/model-pricing.ts
  • apps/website/src/locales/zh-CN/main.json
  • apps/website/src/pages/p/supported-models/_slug.md.test.ts
  • apps/website/src/lib/hreflang.test.ts
  • apps/website/src/data/mainNavigation.ts
  • apps/website/src/config/model-pricing.test.ts
  • apps/website/src/utils/modelFaq.ts
  • apps/website/src/pages/p/supported-models/_llms.txt.test.ts
  • apps/website/src/utils/modelSeoCopy.ts
  • apps/website/src/pages/p/supported-models/llms.txt.ts
  • apps/website/src/config/model-llms.ts
  • apps/website/src/config/indexing.test.ts
  • apps/website/src/utils/modelSeoCopy.test.ts
  • apps/website/e2e/canonical-redirects.spec.ts
  • apps/website/src/config/routes.ts
  • apps/website/src/pages/p/supported-models/[slug].astro
  • apps/website/src/config/indexing.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The website removes the Supported Models catalog and its model-specific pages and copy. Retired catalog URLs redirect to matching Hub model pages or the Hub models catalog. Site navigation, breadcrumbs, indexing, and generated text are updated.

Changes

Supported Models catalog retirement

Layer / File(s) Summary
Compile the retired-model URL registry
apps/website/scripts/generate-supported-model-urls.ts, apps/website/scripts/generate-supported-model-urls.test.ts, apps/website/src/config/supported-model-urls.ts
A generator matches supported-model slugs to Hub pages, preserves frozen rows, and writes a registry. Tests cover slug matching, aliases, and retained rows.
Redirect retired catalog URLs
apps/website/src/config/redirects.ts, apps/website/src/config/redirects.test.ts, apps/website/vercel.json, apps/website/e2e/canonical-redirects.spec.ts
Redirect rules map supported-model URLs to Hub model pages or /hub/models/. Vercel rules cover listed model paths and catalog catch-alls. Redirect tests validate destinations and permanent status.
Remove catalog pages and update site links
apps/website/src/pages/p/supported-models/*, apps/website/src/config/*, apps/website/src/components/*, apps/website/src/data/*, apps/website/src/locales/*, apps/website/src/templates/model-launch/ModelLaunchPage.astro, apps/website/src/pages/zh-CN/models.astro, apps/website/e2e/*
The catalog pages, model copy helpers, translations, and navigation links are removed. Remaining catalog calls to action point to Hub models, and model-launch breadcrumbs point to the workshop route.
Update generated text and redirect matching
apps/website/src/lib/llms-txt.ts, apps/website/src/lib/llms-txt.test.ts, apps/website/src/lib/section-index.ts, apps/website/src/lib/section-index.test.ts, apps/website/public/llms.txt, apps/website/src/integrations/markdown-twins.ts
Full-text output no longer excludes English supported-model Markdown pages. Redirected-link detection matches catch-all sources, and public llms.txt catalog references point to Hub models.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Other

Sequence Diagram(s)

sequenceDiagram
  participant Browser
  participant VercelRedirects
  participant HubModels
  Browser->>VercelRedirects: Request retired supported-model URL
  VercelRedirects-->>Browser: Permanent redirect to Hub model or /hub/models/
  Browser->>HubModels: Request redirect destination
Loading

Suggested reviewers: benceruleanlu, drjkl, christian-byrne

Merge Risk: ⚪ Minimal · up to 81488

The retired catalog URLs have the intended Hub destinations, and no blocking issue is established. The change is mergeable after normal checks.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 81488

The redirects use fixed destinations on the same website, without requester-controlled redirect targets or an evident increase in privileges. Permanent redirects make deployment readiness and rollback important, and production routing was not verified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — At the website-rule layer, independently supplied suffixes throughout the retired namespace can select only a fixed public Hub destination. The matching scope broadens beyond known aliases, but destination authority does not broaden with it. Effective upstream host routing remains outside verified coverage.

Trust Boundaries and Controls

  • observed — The wildcard capture is used only to match legacy requests; it is not copied into a Location destination. Exact mappings likewise use checked-in registry values. This prevents destination control through the retired request suffix in the inspected construction.

Resilience and Maintainability Implications

  • observed — The agent-readable link checker now recognizes catch-all redirect sources as well as literal sources. Its matching remains limited to normalized links on the configured website hostname, helping detect stale legacy links rather than granting an agent additional execution authority.

Hardening Proposals

  • proposed — Before publishing the permanent cutover, confirm production routing to both the retired namespace and Hub destinations, and document recovery that keeps cached Hub destinations available even after a rollback.

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore (reviewers only)

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Website End-To-End Regression Coverage ❌ Error The PR changes website runtime behavior. It removes /p/supported-models/* pages and adds redirects to /hub/models/ or matching Hub model pages. The listed Playwright changes update unrelated bread… Add or update a Playwright regression test under apps/website/e2e/ that exercises the new supported-model redirect behavior, or add a concrete explanation to the PR description for why an end-to-end test is not practical.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: retiring /p/supported-models and redirecting it to /hub/models.
Description check ✅ Passed The description covers the change, redirect behavior, breaking change, implementation details, and review risks. It includes the required Summary, Changes, and Review Focus sections. Dependencies and …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The PR title and commit subjects use “feat” and “refactor,” not bug-fix language. The supplied changed-file list shows changes exclusively under apps/website, which this check excludes because the w…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed-file list shows no files under src/lib/litegraph/ or src/ecs/, and no files related to graph entities. The custom check does not apply.
Full details: Website End-To-End Regression Coverage

Explanation

The PR changes website runtime behavior. It removes /p/supported-models/* pages and adds redirects to /hub/models/ or matching Hub model pages. The listed Playwright changes update unrelated breadcrumbs or remove the prior model-alias redirect assertion; none tests the new retirement redirects. The description explains that comfy-router passes these paths to the website, but it does not explain why a Playwright regression test was not added or why such a test is not practical.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

QA: retire /p/supported-models into /hub/models

Checked on the PR preview https://comfy-website-preview-pr-20192.vercel.app (head 81488bb), on prod comfy.org, and with unit tests in the worktree. Preview builds are noindex on every page by design (isIndexableBuild is false when VERCEL_ENV=preview; /pricing/ is noindex there too), so indexability of the targets is checked on prod.

What it checks Proof Status
Pages are served by apps/website, and comfy-router passes /p/* through unchanged Router src/index.js shouldRouteToWebsite: "Unregistered /p/* paths (e.g. /p/supported-models) fall through to the website origin", fetched with redirect: 'manual'; subpages.json registers only test-page. Prod curl -sI /p/supported-models/wan2-7/: x-served-by: vercel-website, x-vercel-id: bom1::…, server: cloudflare. Prod /p/supported-models/grok-image already answers the vercel.json 308. pass, no router change needed
Exact matches 308 in one hop to their Hub page wan2-7, wan2-7/ → /hub/models/wan-2-7-text-to-video/; nano-banana/ → nano-banana-text-to-image/; seedance-2/ → seedance-2-0-text-to-video/; veo-3 → veo-3-text-to-video/; kling-o3/ → kling-o3-text-to-video/. Each: first=308 hops=1 final=200. pass
Index, twins and fallbacks 308 in one hop to /hub/models/ /p/supported-models, /p/supported-models/, /p/supported-models.md, /p/supported-models/llms.txt, clip-vit-h-14-laion2b-s32b-b79k/, qwen-3-8b-fp8mixed, grok-imagine/, alias grok-image, alias t5xxl-fp8-e4m3fn-scaled/, wan2-7.md, 4x-ultrasharp.md, retired dreamshaper-8-pruned/, stability-ai/: all first=308 loc=/hub/models/ hops=1 final=200. pass
Locale variants /zh-CN/p/supported-models/ is 404 on prod today and on the preview; GSC has 0 zh-CN supported-models URLs in 90 days. Nothing to redirect. pass
Targets are indexable, self-canonical and in the sitemap (prod) Prod /hub/models/, /hub/models/seedance-2-0-text-to-video/, /hub/models/wan-2-7-text-to-video/ and the other 6 targets: 200, no robots meta, rel="canonical" = own URL, present in sitemap-0.xml. pass
Old pages leave the sitemap and internal links Preview sitemap-0.xml: 0 /p/supported-models. p/supported-models count in /, /zh-CN/, /llms.txt, /seedance-2.5/, /models/, /zh-CN/models/: 0 each. pass
Order: specific rows answer before the catch-all redirects.test.ts "each reach their Hub page, or the catalogue, permanently in one hop" resolves every table slug, both slash forms, by first match. Red: reversing supportedModelRedirects fails it (1 failed); green after restore (30 passed). pass
Mapping rule generate-supported-model-urls.test.ts: Wan 2.7 → text-to-video, Seedance 2 = 2.0, Kling 2.6 vs 2.6 Pro → none, ElevenLabs (provider) → none, alias resolves through its canonical, frozen rows kept. pass
Route budget vercel.json 857 → 855 routes (12 alias pairs out, 9 exact pairs + 2 catch-all + 2 .md in). pass
Gates vitest run on every touched test file: all pass. pnpm typecheck (website): 0 errors. knip --workspace apps/website: clean. eslint on changed files: 0 errors. pnpm format: no changes. CI website-build and deploy-preview: pass. pass

Light review (one pass trying to break the diff):

  • The llms.txt stale-link check skipped patterned sources, so a catch-all would hide a stale /p/supported-models link. Fixed: findRedirectedLinks now matches /:path* sources, with a test.
  • The nav "Supported Models" entry was ungated, so pointing it at /hub/models/ broke the rule that the catalogue nav is gated by WORKSHOP_IN_BUILD (mainNavigation test failed). Fixed: the entry is removed, since the gated catalogue entry already links there. The footer already had "Model catalogue" → /hub/models/, so its duplicate went too.
  • Launch-page breadcrumbs used routes.models; typecheck caught it after the route was removed. Fixed: they link routes.workshop.
  • Not fixed, owner's call: about 99% of the section's clicks go to the /hub/models/ fallback (see the PR body), and Google can treat a many-to-one redirect to an unrelated index as a soft 404. /hub/models/* exists only with WORKSHOP_IN_BUILD=1.

Not covered here: URL Inspection and GSC follow-up after deploy; a sibling PR (wt-fe-3083) flips the hub 307 rows in the same file, so expect a small merge conflict in redirects.ts and vercel.json.

@codecov

codecov Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #20192      +/-   ##
==========================================
- Coverage   85.12%   84.99%   -0.13%     
==========================================
  Files        3475     3369     -106     
  Lines      167631   164421    -3210     
  Branches    45882    44780    -1102     
==========================================
- Hits       142692   139751    -2941     
+ Misses      22961    22847     -114     
+ Partials     1978     1823     -155     
Flag Coverage Δ
billing-web-unit ?
website-unit 79.91% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/components/common/SiteFooter.vue 95.45% <ø> (ø)
apps/website/src/config/indexing.ts 97.05% <ø> (-0.31%) ⬇️
apps/website/src/config/models.ts 57.14% <ø> (+3.80%) ⬆️
apps/website/src/config/redirects.ts 100.00% <100.00%> (ø)
apps/website/src/config/routes.ts 100.00% <ø> (ø)
apps/website/src/config/supported-model-urls.ts 100.00% <100.00%> (ø)
apps/website/src/data/drops.ts 93.33% <ø> (ø)
apps/website/src/data/mainNavigation.ts 100.00% <ø> (ø)
apps/website/src/integrations/markdown-twins.ts 83.33% <ø> (ø)
apps/website/src/lib/llms-txt.ts 100.00% <100.00%> (ø)
... and 1 more

... and 99 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-merge checks failed. Please resolve the failing checks before merging.

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Closing. Sending all the /p/supported-models pages to /hub/models (only 9 have an exact match) would drop about 95% of the section's search traffic: open-weight file pages that Hub pages can't replace. We're taking the options to #proj-comfy-hub first (move the file pages to /hub/models/files/ vs keep them in place). A new PR will follow once that's decided. The branch is kept.

@MaanilVerma MaanilVerma closed this Oct 5, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @MaanilVerma.

Found 7 finding(s).

Severity Count
🟡 Medium 2
🟢 Low 5

Panel: 8/8 reviewers contributed findings.

rows: readonly SupportedModelUrl[]
): string {
const line = (row: SupportedModelUrl) =>
` [${row.map((value) => `'${value}'`).join(', ')}]`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — Each value is interpolated into a single-quoted TypeScript literal with no escaping, so a slug containing ', \, or a newline writes a syntactically broken — or, worst case, code-injecting — src/config/supported-model-urls.ts, which redirects.ts imports and the build then executes in Node. hubSlug is validated upstream but model.slug is not (models.ts checks only uniqueness and canonical targets, and the slugifier that produces these names from external template filenames lets quotes through); reuse the sibling generator's stringLiteral() helper and reject slugs that do not match its slug pattern. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case).

const taskOf = (slug: string) =>
TASKS_BY_PRIORITY.find((task) => slug.endsWith(`-${task}`))

const sameVersion = (slug: string) => slug.replace(/(\d)-0(?=-|$)/g, '$1')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — /(\d)-0(?=-|$)/g strips -0 after any digit anywhere in the key, not just a trailing .0, so a three-part version collapses onto a different model: a supported model named Model 2.0.1 keys as model-2-1 and matches the Hub page for Model 2.1. Anchor the replacement to the end of the key, and/or throw when two supported models resolve to the same key, so a bad match surfaces instead of shipping as a permanent 308 that browsers cache and cannot be retracted. Raised by 3 of 8 reviewers (gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max adversarial, kimi-k3-max edge-case).

),
{ source: `${SUPPORTED_MODELS_PATH}.md`, destination: `${HUB_MODELS_PATH}/` },
{
source: `${SUPPORTED_MODELS_PATH}/:path*`,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — This catch-all also swallows the per-model markdown twins the retired section published, so /p/supported-models/wan2-7.md 308s to the generic /hub/models/ even though its HTML sibling reaches /hub/models/wan-2-7-text-to-video/. Emitting a <slug>.md literal next to each slug row — the way the section root already gets /p/supported-models.md — keeps the specific destination for agents following those URLs. Raised by 2 of 8 reviewers (gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case).

const bySlug = new Map(supportedModels.map((model) => [model.slug, model]))
const rows = new Map(frozen.map((row) => [row[0], row]))
for (const model of supportedModels) {
if (rows.has(model.slug)) continue

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — Roughly 370 of the 380 generated rows are bare [slug] entries that 308 to the generic catalogue, and this continue means a frozen slug is skipped forever — a matching /hub/models/<slug> page launching later never upgrades the row. Nothing surfaces that drift: this PR adds no package.json script to run the generator, no drift report of the kind the sibling generate-model-url-map.ts prints, and the new test never asserts the committed supported-model-urls.ts equals renderSupportedModelUrlsModule(compileSupportedModelUrls(models, modelPageUrls, …)), so redirects.test.ts cannot catch staleness either (it derives expectations from the same table). Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).

{
label: t('models.breadcrumb.models'),
href: routes.models
href: routes.workshop

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — The href moved to routes.workshop but the label still resolves models.breadcrumb.models ('Supported Models' / '支持的模型'), naming the section this PR retires; the footer calls that same destination 'Model Catalogue'. crumbs feeds breadcrumbs, so the mismatched name is also emitted into the BreadcrumbList JSON-LD on every launch page. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

<ModelsHeroSection
modelName="Grok Imagine"
ctaHref="/p/supported-models/grok-imagine/"
ctaHref="/hub/models/"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — ModelsHeroSection builds its CTA label from modelName, so the button still reads 'Grok Imagine' while now navigating to the whole catalogue; the same substitution landed in src/pages/zh-CN/models.astro. Either point it at that model's Hub page or switch the label to a catalogue-level CTA. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

expect(
sources.filter((source) => !/^(\/[A-Za-z0-9._-]+)+$/.test(source))
sources.filter(
(source) =>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — With this exemption the /p/supported-models/:path* row escapes both guards that cover every other redirect source: the literal-path assertion skips it explicitly, and the 'never shadows a built page with a slash form' test compares ${source}/ against built pages, which a pattern source can never equal. hubModelRedirects carries a comment forbidding a /models/:path* catch-all for exactly this reason and has a dedicated test enforcing it; add the equivalent assertion that no built page or data file sits under /p/supported-models/. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant