Repository navigation
feat(website): retire /p/supported-models into /hub/models - #20192
MaanilVerma wants to merge 2 commits into
Conversation
Each supported-model page that has a Hub page for the same model 308s to it; every other address under /p/supported-models, the index and its twins 308 to /hub/models/ through one catch-all. The mapping is a frozen table generated from the supported-models data and the Hub URL table.
The pages, their markdown twins and llms.txt now redirect, so drop them from the build, point the launch-page breadcrumbs, drops card, showcase CTA and llms.txt at /hub/models/, and remove the footer and nav entries that duplicated the catalogue link. Delete the modules only those pages used.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c9326eb303a2a0628fd69d436df4975365f6fa1d
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-20192.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-g2p75dpxc-comfyui.vercel.app Last updated: 2026-10-05T14:13:55Z for 🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (4)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (54)
💤 Files with no reviewable changes (29)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe website removes the Supported Models catalog and its model-specific pages and copy. Retired catalog URLs redirect to matching Hub model pages or the Hub models catalog. Site navigation, breadcrumbs, indexing, and generated text are updated. ChangesSupported Models catalog retirement
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Other Sequence Diagram(s)sequenceDiagram
participant Browser
participant VercelRedirects
participant HubModels
Browser->>VercelRedirects: Request retired supported-model URL
VercelRedirects-->>Browser: Permanent redirect to Hub model or /hub/models/
Browser->>HubModels: Request redirect destination
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The retired catalog URLs have the intended Hub destinations, and no blocking issue is established. The change is mergeable after normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The redirects use fixed destinations on the same website, without requester-controlled redirect targets or an evident increase in privileges. Permanent redirects make deployment readiness and rollback important, and production routing was not verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (6 passed)
Full details: Website End-To-End Regression CoverageExplanation The PR changes website runtime behavior. It removes
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
QA: retire /p/supported-models into /hub/modelsChecked on the PR preview
Light review (one pass trying to break the diff):
Not covered here: URL Inspection and GSC follow-up after deploy; a sibling PR (wt-fe-3083) flips the hub 307 rows in the same file, so expect a small merge conflict in |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20192 +/- ##
==========================================
- Coverage 85.12% 84.99% -0.13%
==========================================
Files 3475 3369 -106
Lines 167631 164421 -3210
Branches 45882 44780 -1102
==========================================
- Hits 142692 139751 -2941
+ Misses 22961 22847 -114
+ Partials 1978 1823 -155
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 99 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Closing. Sending all the /p/supported-models pages to /hub/models (only 9 have an exact match) would drop about 95% of the section's search traffic: open-weight file pages that Hub pages can't replace. We're taking the options to #proj-comfy-hub first (move the file pages to /hub/models/files/ vs keep them in place). A new PR will follow once that's decided. The branch is kept. |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @MaanilVerma.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 5 |
Panel: 8/8 reviewers contributed findings.
| rows: readonly SupportedModelUrl[] | ||
| ): string { | ||
| const line = (row: SupportedModelUrl) => | ||
| ` [${row.map((value) => `'${value}'`).join(', ')}]` |
There was a problem hiding this comment.
🟡 Medium — Each value is interpolated into a single-quoted TypeScript literal with no escaping, so a slug containing ', \, or a newline writes a syntactically broken — or, worst case, code-injecting — src/config/supported-model-urls.ts, which redirects.ts imports and the build then executes in Node. hubSlug is validated upstream but model.slug is not (models.ts checks only uniqueness and canonical targets, and the slugifier that produces these names from external template filenames lets quotes through); reuse the sibling generator's stringLiteral() helper and reject slugs that do not match its slug pattern. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case).
| const taskOf = (slug: string) => | ||
| TASKS_BY_PRIORITY.find((task) => slug.endsWith(`-${task}`)) | ||
|
|
||
| const sameVersion = (slug: string) => slug.replace(/(\d)-0(?=-|$)/g, '$1') |
There was a problem hiding this comment.
🟡 Medium — /(\d)-0(?=-|$)/g strips -0 after any digit anywhere in the key, not just a trailing .0, so a three-part version collapses onto a different model: a supported model named Model 2.0.1 keys as model-2-1 and matches the Hub page for Model 2.1. Anchor the replacement to the end of the key, and/or throw when two supported models resolve to the same key, so a bad match surfaces instead of shipping as a permanent 308 that browsers cache and cannot be retracted. Raised by 3 of 8 reviewers (gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max adversarial, kimi-k3-max edge-case).
| ), | ||
| { source: `${SUPPORTED_MODELS_PATH}.md`, destination: `${HUB_MODELS_PATH}/` }, | ||
| { | ||
| source: `${SUPPORTED_MODELS_PATH}/:path*`, |
There was a problem hiding this comment.
🟢 Low — This catch-all also swallows the per-model markdown twins the retired section published, so /p/supported-models/wan2-7.md 308s to the generic /hub/models/ even though its HTML sibling reaches /hub/models/wan-2-7-text-to-video/. Emitting a <slug>.md literal next to each slug row — the way the section root already gets /p/supported-models.md — keeps the specific destination for agents following those URLs. Raised by 2 of 8 reviewers (gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case).
| const bySlug = new Map(supportedModels.map((model) => [model.slug, model])) | ||
| const rows = new Map(frozen.map((row) => [row[0], row])) | ||
| for (const model of supportedModels) { | ||
| if (rows.has(model.slug)) continue |
There was a problem hiding this comment.
🟢 Low — Roughly 370 of the 380 generated rows are bare [slug] entries that 308 to the generic catalogue, and this continue means a frozen slug is skipped forever — a matching /hub/models/<slug> page launching later never upgrades the row. Nothing surfaces that drift: this PR adds no package.json script to run the generator, no drift report of the kind the sibling generate-model-url-map.ts prints, and the new test never asserts the committed supported-model-urls.ts equals renderSupportedModelUrlsModule(compileSupportedModelUrls(models, modelPageUrls, …)), so redirects.test.ts cannot catch staleness either (it derives expectations from the same table). Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| { | ||
| label: t('models.breadcrumb.models'), | ||
| href: routes.models | ||
| href: routes.workshop |
There was a problem hiding this comment.
🟢 Low — The href moved to routes.workshop but the label still resolves models.breadcrumb.models ('Supported Models' / '支持的模型'), naming the section this PR retires; the footer calls that same destination 'Model Catalogue'. crumbs feeds breadcrumbs, so the mismatched name is also emitted into the BreadcrumbList JSON-LD on every launch page. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| <ModelsHeroSection | ||
| modelName="Grok Imagine" | ||
| ctaHref="/p/supported-models/grok-imagine/" | ||
| ctaHref="/hub/models/" |
There was a problem hiding this comment.
🟢 Low — ModelsHeroSection builds its CTA label from modelName, so the button still reads 'Grok Imagine' while now navigating to the whole catalogue; the same substitution landed in src/pages/zh-CN/models.astro. Either point it at that model's Hub page or switch the label to a catalogue-level CTA. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| expect( | ||
| sources.filter((source) => !/^(\/[A-Za-z0-9._-]+)+$/.test(source)) | ||
| sources.filter( | ||
| (source) => |
There was a problem hiding this comment.
🟢 Low — With this exemption the /p/supported-models/:path* row escapes both guards that cover every other redirect source: the literal-path assertion skips it explicitly, and the 'never shadows a built page with a slash form' test compares ${source}/ against built pages, which a pattern source can never equal. hubModelRedirects carries a comment forbidding a /models/:path* catch-all for exactly this reason and has a dedicated test enforcing it; add the equivalent assertion that no built page or data file sits under /p/supported-models/. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
Summary
Retire
/p/supported-modelsinto/hub/modelsin one cut-over: each supported-model page that has a Hub page for the same model 308s straight to it, and every other address (the index, its.mdandllms.txt, all other slugs and twins) 308s to/hub/models/.Fixes FE-2964 (https://linear.app/comfyorg/issue/FE-2964). Changed from the ticket: the owner chose a single cut-over to the Hub instead of the measured batches in FE-2958, FE-2964, FE-2946, FE-2938, FE-2933 and FE-2920.
Changes
src/config/supported-model-urls.ts: frozen table of all 394 published slugs (382 pages + 12 alias stubs), each with its Hub slug or none. Generated byscripts/generate-supported-model-urls.ts(purecompileSupportedModelUrls, rows stay frozen on regeneration).redirects.ts: 9 exact rows, then/p/supported-models.mdand one/p/supported-models/:path*catch-all, all 308. The 12 old alias rows go (the catch-all covers them in one hop).vercel.jsongoes from 857 to 855 routes.llms.txtleave the build and the sitemap.llms.txt, the drops card, the showcase CTA and the launch-page "Models" breadcrumb now link/hub/models/. The footer and nav "Supported Models" links go, because the same menus already link the catalogue at/hub/models/. The modules and locale keys that only those pages used go too./:path*source, so the catch-all doesn't hide a stale link./p/supported-models/*no longer renders.routes.modelsis removed (useroutes.workshop).Where the pages were served:
apps/website(Astro static pages undersrc/pages/p/supported-models/). comfy-router passes/p/*(except registered subpages; onlytest-pageis registered) to the website origin unchanged withredirect: 'manual', so these Vercel redirects reach prod with no router change.Match rule: a Hub page matches when its frozen display name minus the task suffix equals the supported-model name (slugified,
2and2.0equal). Provider-only names (e.g. ElevenLabs) never match. When several task pages match, the first task in this order wins: text-to-image, text-to-vector, text-to-video, reference-to-video, text-to-speech, text-to-dialogue, image-to-video, first-last-frame, video-continuation, image-edit, video-edit, video-to-video, audio-to-video (the same use-case priority asprimarySlug).nano-banananano-banana-text-to-imagenano-banana-2nano-banana-2-text-to-imagewan2-6wan-2-6-text-to-videowan2-7wan-2-7-text-to-videowan-3-0wan-3-0-text-to-videoseedance-2-0seedance-2-0-text-to-videoseedance-2seedance-2-0-text-to-videoveo-3veo-3-text-to-videokling-o3kling-o3-text-to-videoNear misses sent to
/hub/models/(owner may want to override):grok-imagine(Hub has Grok Imagine Image / Video, not one model),kling-2-6(Hub has only Kling 2.6 Pro),flux-2-api(Max and Pro),happyhorse1(Hub names carry no version),elevenlabs(provider page),krea-2,recraft,ideogram,runway,beeble,heygen.Review Focus
dreamshaper-8-pruned,stability-ai) 928; the index 597. So about 99% of the section's clicks land on/hub/models/, which is a many-to-one redirect Google may treat as a soft 404./hub/models/*exists only whenWORKSHOP_IN_BUILD=1; with it off every target 404s.stability-aiwas an intentional 404; the catch-all now 308s it to/hub/models/.