Skip to content

test: verify website greenlight approval rules - #20168

Closed
christian-byrne wants to merge 2 commits into
mainfrom
test/ruleset-website-greenlight
Closed

christian-byrne wants to merge 2 commits into
mainfrom
test/ruleset-website-greenlight

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Ruleset verification PR only.

Touches a website CODEOWNER path so the ProtectMain code-owner requirement and greenlight approval can be verified. Do not merge.

@christian-byrne
christian-byrne requested a review from a team October 5, 2026 06:30
@vercel

vercel Bot commented Oct 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 5, 2026 6:30am UTC
billing-web-test Ignored Ignored Oct 5, 2026 6:30am UTC

Request Review

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

📦 Bundle Size

⚠️ Size data collection failed. Check the CI workflow logs.

🔬 E2E Coverage

⚠️ Coverage collection failed. Check the CI workflow logs.

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since e2e6849eefd41e39dcf32804b330b1c64eb4648e

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-20168.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-6v1f2glcn-comfyui.vercel.app

Last updated: 2026-10-05T06:32:34Z for 936a719

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 5, 2026
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 41434b8b-199e-4c40-98eb-a33fe6512493
📥 Commits

Reviewing files that changed from the base of the PR and between 936a719 and 5f6ba5d.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 63c91326-8ef9-4281-a3a1-8ee890aae9c7
📥 Commits

Reviewing files that changed from the base of the PR and between 0d0643b and 936a719.

📒 Files selected for processing (1)
  • apps/website/src/config/workshop-account.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC.


📝 Walkthrough

Walkthrough

Two blank lines were added before the ruleset verification fixture comment in workshop-account.ts. No behavior changed.

Changes

Comment spacing

Layer / File(s) Summary
Comment spacing
apps/website/src/config/workshop-account.ts
Two blank lines were added before the ruleset verification fixture comment.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 936a7

The whitespace-only change has no product impact. The PR is described as a ruleset-verification exercise that should not be merged, so treat it as verification-only rather than as merge approval.

🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the verification purpose and says not to merge, but it omits the template sections for Summary, Changes, Review Focus, and Screenshots. It also does not describe the actual fi… Add the template sections. State the specific file change in Summary and Changes, indicate whether there are breaking changes or new dependencies, and describe the review focus. Keep the instruction not to merge.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the ruleset verification purpose stated in the PR objectives.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The PR changes only apps/website/src/config/workshop-account.ts, and the title and commit subject do not use bug-fix language. The check excludes changes that are exclusively in apps/website.
Website End-To-End Regression Coverage ✅ Passed The PR changes a file under apps/website/src/, but the diff adds only blank lines and a ruleset-verification comment. It does not change observable website behavior, so the coverage failure conditio…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The PR changes only apps/website/src/config/workshop-account.ts. This path is not under src/lib/litegraph/ or src/ecs/, and it is not related to graph entities. The check does not apply.
Full details: Description check

Explanation

The description explains the verification purpose and says not to merge, but it omits the template sections for Summary, Changes, Review Focus, and Screenshots. It also does not describe the actual file change or state whether the PR has breaking changes or dependencies.

✨ Finishing Touches 💡 1
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@comfy-greenlight-bot

comfy-greenlight-bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Swarmhost agentic review

The detailed evaluation is available to employees in the internal Slack review thread.

Evaluation failed to run (dispatch_timed_out).

Evaluation budget remaining for this pull request: 99 automatic and 99 manual.

Updated by Swarmhost's agentic review process.

@datadog-official

datadog-official Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 4 Pipeline jobs failed

CI: Tests E2E | e2e-status

View in Datadog · View in GitHub Actions

CI: Tests E2E | preflight

View in Datadog · View in GitHub Actions

CI: Tests E2E | test

View in Datadog · View in GitHub Actions

View all 4 failed jobs.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5f6ba5d | Docs | View more details | Give us feedback!

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Verification complete. The dedicated greenlight-label test is no longer needed; policy behavior was subsequently validated on #19864 after the CODEOWNERS union landed. Closing this temporary test PR without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants