Repository navigation
[backport cloud/1.54] fix(load3d): apply workspace inset to every viewer (#19729) - #20142
Conversation
## Summary - route every Load3D and HDR viewer through one inset-aware dialog configuration - remove raw-viewport centering overrides that let the docked Agent panel cover viewer content - keep the responsive 80vw cap paired with the full-size dialog variant This follows up on findings from the merged [core/1.55 backport](#19702 (comment)) and [cloud/1.55 backport](#19703 (comment)). ## Changes - apply the shared configuration to HDR, Agent reply, Assets, Job History, node, and viewer-control entry points - centralize `renderer`, `size`, `contentClass`, and `maximizable` so responsive geometry cannot drift across callers - remove brittle class-token assertions; browser coverage measures the visible viewer geometry ## Review Focus - confirm the shared `sm:max-w` override remains paired with `size: full` - confirm viewers with custom `onClose` behavior preserve it when spreading the shared configuration ## Validation - `oxfmt --check` passed for all nine changed files - `git diff --check` passed - the focused Vitest runner stalled before producing output in this workspace; CI is rerunning the affected suites (cherry picked from commit 3c4030d)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1990 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-05T00:17:11.646Z",
"gitSha": "1c23bdf065f97d38e6d4a053e9bd41d4ed5f6fea",
"branch": "backport-19729-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2099.5169999999916,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.178,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.3,
"heapDeltaBytes": 6498512,
"heapUsedBytes": 80282904,
"domNodes": -281,
"jsHeapTotalBytes": 3440640,
"scriptDurationMs": 10.464,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2043.405000000007,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.515,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.497,
"heapDeltaBytes": -14061476,
"heapUsedBytes": 59075196,
"domNodes": -282,
"jsHeapTotalBytes": 3702784,
"scriptDurationMs": 10.040999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1864.4219999999905,
"styleRecalcs": 75,
"styleRecalcDurationMs": 30.23,
"layouts": 14,
"layoutDurationMs": 3.908,
"taskDurationMs": 882.2339999999999,
"heapDeltaBytes": 4464916,
"heapUsedBytes": 75990560,
"domNodes": -278,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 164.925,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.4090000000028,
"styleRecalcs": 76,
"styleRecalcDurationMs": 28.994,
"layouts": 14,
"layoutDurationMs": 4.002000000000001,
"taskDurationMs": 882.779,
"heapDeltaBytes": -12799508,
"heapUsedBytes": 60857148,
"domNodes": -280,
"jsHeapTotalBytes": 3964928,
"scriptDurationMs": 161.75900000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.7829999999553,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.779000000000003,
"layouts": 6,
"layoutDurationMs": 1.1430000000000002,
"taskDurationMs": 361.07199999999995,
"heapDeltaBytes": 4717852,
"heapUsedBytes": 76306292,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.456000000000001,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.369000000058,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.787,
"layouts": 6,
"layoutDurationMs": 1.1080000000000003,
"taskDurationMs": 374.4310000000001,
"heapDeltaBytes": 4954108,
"heapUsedBytes": 79078620,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.995,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 667.8380000000175,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.609000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.00299999999993,
"heapDeltaBytes": -7104108,
"heapUsedBytes": 66497692,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 161.104,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 717.4530000000345,
"styleRecalcs": 15,
"styleRecalcDurationMs": 10.241,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.488,
"heapDeltaBytes": -6712116,
"heapUsedBytes": 64827896,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 166.685,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2037.8369999999677,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.812,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 607.9570000000001,
"heapDeltaBytes": 7823936,
"heapUsedBytes": 84568824,
"domNodes": -283,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 34.341,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2056.4520000000357,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.778000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.297,
"heapDeltaBytes": -9783260,
"heapUsedBytes": 70514684,
"domNodes": -282,
"jsHeapTotalBytes": -1277952,
"scriptDurationMs": 39.584,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2273.4510000000228,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.322999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1646.5510000000002,
"heapDeltaBytes": -10291260,
"heapUsedBytes": 68113388,
"domNodes": -282,
"jsHeapTotalBytes": 4087808,
"scriptDurationMs": 837.536,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2218.8019999999824,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.157000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1571.1500000000003,
"heapDeltaBytes": 924548,
"heapUsedBytes": 67075336,
"domNodes": 2,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 833.654,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3605.5979999999863,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.940999999999999,
"layouts": 60,
"layoutDurationMs": 12.402999999999999,
"taskDurationMs": 1772.7969999999998,
"heapDeltaBytes": -9290396,
"heapUsedBytes": 71059084,
"domNodes": -263,
"jsHeapTotalBytes": 3039232,
"scriptDurationMs": 803.6370000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3527.823000000012,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.162999999999998,
"layouts": 60,
"layoutDurationMs": 11.395999999999999,
"taskDurationMs": 1643.7710000000002,
"heapDeltaBytes": 969408,
"heapUsedBytes": 67872424,
"domNodes": -254,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 763.4,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3172.7540000000545,
"styleRecalcs": 43,
"styleRecalcDurationMs": 8.724000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2016.7920000000001,
"heapDeltaBytes": -10697752,
"heapUsedBytes": 75164324,
"domNodes": -284,
"jsHeapTotalBytes": -790528,
"scriptDurationMs": 1005.3700000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3200.505000000021,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.57,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1990.164,
"heapDeltaBytes": -3280384,
"heapUsedBytes": 82420848,
"domNodes": -289,
"jsHeapTotalBytes": 4382720,
"scriptDurationMs": 1039.27,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.900000000035,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.550999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 574.6210000000001,
"heapDeltaBytes": 10770904,
"heapUsedBytes": 90519292,
"domNodes": -283,
"jsHeapTotalBytes": -892928,
"scriptDurationMs": 32.309999999999995,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2051.6659999999547,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.746999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 663.7030000000001,
"heapDeltaBytes": 11348016,
"heapUsedBytes": 90815728,
"domNodes": -285,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 39.831,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 559.5469999999523,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.512,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.575,
"heapDeltaBytes": -10492436,
"heapUsedBytes": 65302100,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.69099999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.784999999978,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.556000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.187,
"heapDeltaBytes": 15184792,
"heapUsedBytes": 88694248,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 148.16000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.5610000000001,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.466000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.241,
"heapDeltaBytes": -19188060,
"heapUsedBytes": 56862636,
"domNodes": -298,
"jsHeapTotalBytes": 4227072,
"scriptDurationMs": 9.793999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2021.7329999999833,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.975999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.788,
"heapDeltaBytes": -15910444,
"heapUsedBytes": 57537596,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.382,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.2159999999799,
"styleRecalcs": 79,
"styleRecalcDurationMs": 26.997,
"layouts": 18,
"layoutDurationMs": 4.565,
"taskDurationMs": 839.2369999999999,
"heapDeltaBytes": -7080548,
"heapUsedBytes": 66692308,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 110.762,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1759.7369999999728,
"styleRecalcs": 80,
"styleRecalcDurationMs": 28.500999999999998,
"layouts": 18,
"layoutDurationMs": 4.604,
"taskDurationMs": 840.1919999999999,
"heapDeltaBytes": -11074596,
"heapUsedBytes": 61669112,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 113.19900000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.1120000000315,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.072,
"layouts": 14,
"layoutDurationMs": 15.368,
"taskDurationMs": 953.5859999999998,
"heapDeltaBytes": -6982716,
"heapUsedBytes": 87791556,
"domNodes": 13831,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 30.108999999999998,
"eventListeners": 2385,
"totalBlockingTimeMs": 148,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8278.877000000022,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.429,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5620.1539999999995,
"heapDeltaBytes": -12161232,
"heapUsedBytes": 67668908,
"domNodes": -267,
"jsHeapTotalBytes": -1015808,
"scriptDurationMs": 2675.375,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8323.87499999993,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.888999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5582.869000000001,
"heapDeltaBytes": -9553668,
"heapUsedBytes": 68257080,
"domNodes": -283,
"jsHeapTotalBytes": 3825664,
"scriptDurationMs": 2737.708,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17776.129000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16937.355,
"heapDeltaBytes": -53742516,
"heapUsedBytes": 179632596,
"domNodes": -8068,
"jsHeapTotalBytes": -11452416,
"scriptDurationMs": 294.641,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16883.32700000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16361.711,
"heapDeltaBytes": -56371452,
"heapUsedBytes": 179297272,
"domNodes": -8068,
"jsHeapTotalBytes": -11317248,
"scriptDurationMs": 288.057,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21197.625999999957,
"styleRecalcs": 168,
"styleRecalcDurationMs": 18.685000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20848.547,
"heapDeltaBytes": -33538848,
"heapUsedBytes": 184948084,
"domNodes": -8068,
"jsHeapTotalBytes": -11354112,
"scriptDurationMs": 931.6089999999999,
"eventListeners": -14925,
"totalBlockingTimeMs": 81,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20622.358000000077,
"styleRecalcs": 172,
"styleRecalcDurationMs": 23.475000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20334.11,
"heapDeltaBytes": -39694900,
"heapUsedBytes": 178715936,
"domNodes": -8068,
"jsHeapTotalBytes": -15478784,
"scriptDurationMs": 972.14,
"eventListeners": -14927,
"totalBlockingTimeMs": 90,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6265.903999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.87899999999999,
"layouts": 20,
"layoutDurationMs": 24.836999999999996,
"taskDurationMs": 6140.978999999999,
"heapDeltaBytes": -36039840,
"heapUsedBytes": 182436584,
"domNodes": -8068,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 116.888,
"eventListeners": -14929,
"totalBlockingTimeMs": 553,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6053.818999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.08499999999997,
"layouts": 20,
"layoutDurationMs": 23.19600000000001,
"taskDurationMs": 5985.251,
"heapDeltaBytes": -51905624,
"heapUsedBytes": 165957040,
"domNodes": -8068,
"jsHeapTotalBytes": 8929280,
"scriptDurationMs": 127.95299999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 353,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8567.667000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8397.726999999997,
"heapDeltaBytes": 2085016,
"heapUsedBytes": 177323280,
"domNodes": 0,
"jsHeapTotalBytes": -14942208,
"scriptDurationMs": 209.28800000000004,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8482.212000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8298.769999999999,
"heapDeltaBytes": 10790960,
"heapUsedBytes": 178880324,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 138.76699999999997,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 142.13399999999865,
"styleRecalcs": 10,
"styleRecalcDurationMs": 19.303,
"layouts": 4,
"layoutDurationMs": 1.8239999999999998,
"taskDurationMs": 95.978,
"heapDeltaBytes": 3099944,
"heapUsedBytes": 72341020,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.083000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 100.18999999999778,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.006000000000002,
"layouts": 2,
"layoutDurationMs": 0.7110000000000003,
"taskDurationMs": 72.54599999999999,
"heapDeltaBytes": 3007376,
"heapUsedBytes": 74788724,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.4110000000000005,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 1 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
christian-byrne
left a comment
There was a problem hiding this comment.
Self-review, because I opened this and cannot approve my own PR.
The cherry-pick is clean and the changed lines are identical to the merged commit, so the only real question is whether the fix is right for this branch. It is, for a narrower reason than the source PR's description suggests.
cloud/1.54 does not have #20002, and its full-size dialog variant already carries the workspace inset in its own sm:max-w. So the node and viewer-control entry points were already correct here, and this change does not move them: the viewer sits at x=8 with its right edge at 852 / 1012 / 1492 at viewport widths 1280 / 1440 / 1920, before and after.
What is actually broken on this branch is the other four entry points. The Assets sidebar, the Job History sidebar, the HDR viewer and the Agent reply asset group each passed their own left-1/2 w-[80vw] sm:max-w-[80vw] … class, which centres the dialog on the raw viewport under a cap that ignores the inset, so the docked Agent panel covers the right side of the viewer. Opening a 3D job output from the Job History sidebar against a 420px panel:
| viewport | viewer right edge | panel edge | covered |
|---|---|---|---|
| 1280 | 1152 | 860 | 292px |
| 1440 | 1296 | 1020 | 276px |
| 1920 | 1728 | 1500 | 228px |
With this change all three go to zero. I measured it in a real browser against a dev server rather than reasoning from the class strings, because none of those four entry points has browser coverage on any release line. That gap is why this landed on four release branches and was found only by reading a backport diff.
Two things worth checking in the diff, both of which hold:
- Every caller that had its own
onClosestill keeps it by spreading the shared config:handleViewerCloseon the node and on the viewer controls,refreshModelThumbnailon the agent reply.hdrViewerServicehas none and assigns the shared object directly. - The
sm:-prefixed cap is present and paired withsize: full. That is the half that matters above thesm:breakpoint, because tailwind-merge treats prefixed and unprefixedmax-w-*as separate groups. #20136 pins the same point onmain.
load3dViewer.spec.ts and load3d.spec.ts pass here, as do the unit suites for the six changed callers. One run of that spec pair had load3d.spec.ts "Recording controls collapse into a duration chip with a menu after a recording" fail. It passed on a rerun of the identical command, twice in isolation, and on the parent commit, and nothing in this diff reaches recording controls, so I am calling it a flake rather than quietly dropping it.
No assertions were weakened and nothing was added beyond the source commit. Merging this under the release policy for carrying applicable bug fixes to the 1.54 and 1.55 lines, once the required checks are green at this head.
Backport of #19729 to
cloud/1.54.Summary
Carries merged #19729 (
3c4030d80e619e0276dcd65667dc793acccf1525) tocloud/1.54. Clean cherry-pick with-x, no conflicts; the changed lines are byte-identical to the source commit (only hunk offsets differ).On this release line four Load3D/HDR viewer entry points still pass their own
left-1/2 w-[80vw] sm:max-w-[80vw] …dialog class instead of the shared inset-aware one, so the viewer is centred on the raw viewport and the docked Agent panel covers its right-hand side. #19729 routes all six entry points — node, viewer controls, HDR, Assets sidebar, Job History sidebar, Agent reply — through oneLOAD3D_VIEWER_DIALOG_PROPS.Why this line needs it
cloud/1.54does not carry #20002, so #19729 alone is the fix here. Measured against a 420px workspace inset (the production docked Agent panel width) through the real Job History sidebar:cloud/1.54viewer right edgeThe node entry point is unchanged by the carrier — 8/852, 8/1012, 8/1492 before and after — because
cloud/1.54'ssize: fullvariant already carries the inset in its ownsm:max-w. So this is a fix for the four overriding callers and a no-op for the two that already used the shared class.Validation
At head
4904bb7b6c, against a real browser and a real dev server:browser_tests/tests/load3d/load3dViewer.spec.ts+load3d.spec.ts— 15 passed (--project=chromium). One earlier run of the same invocation hadload3d.spec.ts:259("Recording controls collapse into a duration chip") fail; it passed on the rerun of the identical invocation, passed twice in isolation on this branch, and passed on the parent. It is in no file this diff touches.hdrViewerService,AssetsSidebarTab,extensions/core/load3d,ReplyAssetGroup,Load3dViewerContent,GlobalDialog— 127 passed.pnpm typecheck:app,pnpm typecheck:browser,oxfmt --check,oxlint --type-awareon the seven changed files: clean. Husky pre-push (knip) passed.No assertions were weakened and no production behaviour was added beyond the source commit.