Repository navigation
[backport cloud/1.55] fix(agent-crdt): fall through to stored serialize when the live widget leaves it undefined (#20027) - #20134
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2153 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d8201ce96d443a2bbf38b5006b470563d4f896ce
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-04T22:22:18.980Z",
"gitSha": "255a09adbc8f29689cd55b279b4820c1d66ebdad",
"branch": "backport-20027-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1994.2500000000223,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.591999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.591,
"heapDeltaBytes": -12233508,
"heapUsedBytes": 56644500,
"domNodes": -258,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.088,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2002.0399999999654,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.704000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 272.649,
"heapDeltaBytes": -13993172,
"heapUsedBytes": 54835672,
"domNodes": 23,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 5.268,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.286999999998,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.765,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.7639999999999,
"heapDeltaBytes": 2878552,
"heapUsedBytes": 71935532,
"domNodes": -258,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 110.47900000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1688.8020000000097,
"styleRecalcs": 48,
"styleRecalcDurationMs": 15.513000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.2520000000001,
"heapDeltaBytes": 8003176,
"heapUsedBytes": 76373284,
"domNodes": -256,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 103.84800000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1702.278999999976,
"styleRecalcs": 29,
"styleRecalcDurationMs": 13.349,
"layouts": 6,
"layoutDurationMs": 1.018,
"taskDurationMs": 228.838,
"heapDeltaBytes": 3198572,
"heapUsedBytes": 72355112,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.177,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1686.9299999999612,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.95,
"layouts": 6,
"layoutDurationMs": 0.977,
"taskDurationMs": 196.97899999999998,
"heapDeltaBytes": 3259104,
"heapUsedBytes": 71240368,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7.670000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 447.3520000000235,
"styleRecalcs": 15,
"styleRecalcDurationMs": 8.114999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.167,
"heapDeltaBytes": 18326096,
"heapUsedBytes": 81064292,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 105.993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 461.3759999999729,
"styleRecalcs": 14,
"styleRecalcDurationMs": 7.001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 295.86999999999995,
"heapDeltaBytes": -8082928,
"heapUsedBytes": 60935784,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 107.00399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 902.6049999999941,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.09799999999996,
"heapDeltaBytes": 38849036,
"heapUsedBytes": 105524732,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 37.525000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 301,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 923.3349999999518,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.528,
"heapDeltaBytes": 26819148,
"heapUsedBytes": 98122436,
"domNodes": -292,
"jsHeapTotalBytes": 21647360,
"scriptDurationMs": 33.73499999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 313,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 682.1640000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 273.533,
"heapDeltaBytes": 14471116,
"heapUsedBytes": 92005920,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 89.90100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 686.7650000000367,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 268.30500000000023,
"heapDeltaBytes": 15187324,
"heapUsedBytes": 92242348,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 92.40800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 89,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6463.355999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5254.403,
"heapDeltaBytes": 15725076,
"heapUsedBytes": 89693976,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 4198.2699999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 3,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5750.147999999967,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.0540000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4694.493,
"heapDeltaBytes": -8624460,
"heapUsedBytes": 69990348,
"domNodes": -259,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 3819.8469999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 18,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6300.363000000005,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.6490000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5419.41,
"heapDeltaBytes": 17918356,
"heapUsedBytes": 82598856,
"domNodes": -271,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 4278.1320000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5966.84300000004,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.147,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4801.921,
"heapDeltaBytes": 15686700,
"heapUsedBytes": 95168744,
"domNodes": -270,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 3810.947,
"eventListeners": -174,
"totalBlockingTimeMs": 8,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2016.08200000004,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.917999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.50800000000004,
"heapDeltaBytes": -15920820,
"heapUsedBytes": 73048528,
"domNodes": -236,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 27.767000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2026.8629999999348,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.702999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.49300000000005,
"heapDeltaBytes": -23230336,
"heapUsedBytes": 65533456,
"domNodes": -249,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 22.555000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2108.3419999999933,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.132,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1066.008,
"heapDeltaBytes": 1099912,
"heapUsedBytes": 65533236,
"domNodes": -235,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 569.3079999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2134.31300000002,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.215,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1045.998,
"heapDeltaBytes": -2901212,
"heapUsedBytes": 80549432,
"domNodes": -257,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 566.6759999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3135.669000000007,
"styleRecalcs": 73,
"styleRecalcDurationMs": 18.504,
"layouts": 60,
"layoutDurationMs": 15.575000000000001,
"taskDurationMs": 1293.0159999999998,
"heapDeltaBytes": -17201308,
"heapUsedBytes": 67867212,
"domNodes": -236,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 565.239,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3062.966999999958,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.412,
"layouts": 60,
"layoutDurationMs": 14.703000000000001,
"taskDurationMs": 1093.401,
"heapDeltaBytes": 2500196,
"heapUsedBytes": 93444488,
"domNodes": 42,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 519.317,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2351.1030000000233,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.779,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1332.6440000000002,
"heapDeltaBytes": -18097188,
"heapUsedBytes": 74946060,
"domNodes": 18,
"jsHeapTotalBytes": 6328320,
"scriptDurationMs": 702.623,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2323.3730000000605,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1258.342,
"heapDeltaBytes": -17554476,
"heapUsedBytes": 74949392,
"domNodes": 14,
"jsHeapTotalBytes": 6328320,
"scriptDurationMs": 681.1299999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2022.2650000000044,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.062000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 265.869,
"heapDeltaBytes": -17717488,
"heapUsedBytes": 73180760,
"domNodes": -237,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 27.365000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.7879999999623,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.555,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.22400000000005,
"heapDeltaBytes": -23882684,
"heapUsedBytes": 66560516,
"domNodes": -251,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 28.099,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 415.2740000000108,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.520000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 263.53799999999995,
"heapDeltaBytes": 13845596,
"heapUsedBytes": 83700632,
"domNodes": 23,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 100.78,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 427.3130000000265,
"styleRecalcs": 50,
"styleRecalcDurationMs": 10.335999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 268.78999999999996,
"heapDeltaBytes": 13248856,
"heapUsedBytes": 83768220,
"domNodes": 25,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 96.43599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.8710000000365,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.75,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 286.549,
"heapDeltaBytes": -6447060,
"heapUsedBytes": 57852108,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.143000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1989.847999999938,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.757999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 287.94300000000004,
"heapDeltaBytes": 371532,
"heapUsedBytes": 64663800,
"domNodes": -272,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 5.340000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.155999999964,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.511000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.301,
"heapDeltaBytes": -10046096,
"heapUsedBytes": 60339388,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 80.982,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.8770000000804,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.844000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.344,
"heapDeltaBytes": -6654188,
"heapUsedBytes": 57664732,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 78.639,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 816.0280000000739,
"styleRecalcs": 18,
"styleRecalcDurationMs": 19.503,
"layouts": 5,
"layoutDurationMs": 8.200000000000001,
"taskDurationMs": 568.7099999999998,
"heapDeltaBytes": 21611788,
"heapUsedBytes": 103137008,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 19.901000000000003,
"eventListeners": 2383,
"totalBlockingTimeMs": 66,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8221.265000000018,
"styleRecalcs": 251,
"styleRecalcDurationMs": 44.786,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4064.603,
"heapDeltaBytes": -4599356,
"heapUsedBytes": 84937524,
"domNodes": -242,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 2045.5639999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8135.987999999998,
"styleRecalcs": 251,
"styleRecalcDurationMs": 42.943000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3605.1549999999997,
"heapDeltaBytes": -4226240,
"heapUsedBytes": 84908264,
"domNodes": -243,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 1901.336,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12240.113999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11515.229,
"heapDeltaBytes": -49475672,
"heapUsedBytes": 176802140,
"domNodes": -8062,
"jsHeapTotalBytes": -11280384,
"scriptDurationMs": 161.28,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11261.932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10576.083999999999,
"heapDeltaBytes": -41452924,
"heapUsedBytes": 185097480,
"domNodes": -8062,
"jsHeapTotalBytes": -16523264,
"scriptDurationMs": 145.787,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14607.241000000045,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.404,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14424.009999999998,
"heapDeltaBytes": -49229204,
"heapUsedBytes": 170817800,
"domNodes": -8062,
"jsHeapTotalBytes": -17571840,
"scriptDurationMs": 644.8020000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14699.651000000016,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.967999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14575.712000000001,
"heapDeltaBytes": -27152300,
"heapUsedBytes": 192796696,
"domNodes": -8062,
"jsHeapTotalBytes": -19476480,
"scriptDurationMs": 643.127,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3783.4720000000743,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.49499999999999,
"layouts": 20,
"layoutDurationMs": 24.726,
"taskDurationMs": 3732.9339999999997,
"heapDeltaBytes": -32614072,
"heapUsedBytes": 187204444,
"domNodes": -8062,
"jsHeapTotalBytes": 20107264,
"scriptDurationMs": 67.914,
"eventListeners": -14928,
"totalBlockingTimeMs": 49,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4468.09200000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.412,
"layouts": 20,
"layoutDurationMs": 33.96500000000001,
"taskDurationMs": 4452.418,
"heapDeltaBytes": -34583320,
"heapUsedBytes": 185067152,
"domNodes": -8062,
"jsHeapTotalBytes": 9953280,
"scriptDurationMs": 71.525,
"eventListeners": -14928,
"totalBlockingTimeMs": 37,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6277.647000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5998.186000000001,
"heapDeltaBytes": -6572168,
"heapUsedBytes": 176027712,
"domNodes": 0,
"jsHeapTotalBytes": -18350080,
"scriptDurationMs": 91.12199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6459.337000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6365.735000000001,
"heapDeltaBytes": 832312,
"heapUsedBytes": 179576876,
"domNodes": 0,
"jsHeapTotalBytes": -24641536,
"scriptDurationMs": 88.781,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 94.90699999992103,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.938,
"layouts": 3,
"layoutDurationMs": 1.6769999999999998,
"taskDurationMs": 74.592,
"heapDeltaBytes": 3211228,
"heapUsedBytes": 69210216,
"domNodes": 109,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.275999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 438.78799999993134,
"styleRecalcs": 17,
"styleRecalcDurationMs": 19.544,
"layouts": 3,
"layoutDurationMs": 1.503,
"taskDurationMs": 93.278,
"heapDeltaBytes": 5112868,
"heapUsedBytes": 72180296,
"domNodes": 149,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.914999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
…t leaves it undefined (#20027) Follow-up to [#19738](#19738) (merged). Fixes a gap found while hand-backporting that PR to `cloud/1.55`: `cloud/1.55` had an independently-added test (`uses the store serialize flag when a projected widget leaves it undefined`) that `main`'s test suite never had, and it caught a real bug in `isValueWidget`'s precedence logic. ```ts const serialize = widget && 'serialize' in widget ? widget.serialize : stored?.serialize ``` `'serialize' in widget` is `true` whenever the property exists on the object, even when its value is `undefined`. So a widget whose `serialize` key is present-but-`undefined` (plausible from object-spread construction, a reactive proxy, or any code path that assigns `widget.serialize = undefined` rather than never setting it or deleting it) incorrectly short-circuits to `widget.serialize` (i.e. `undefined`), skipping the store fallback — rather than falling through to `stored?.serialize` the way an *absent* property correctly does. `main`'s test suite only ever exercised the absent-property case (`delete widget.serialize`); `cloud/1.55` had an extra test using `widget.serialize = undefined` that main lacked, which is how this surfaced. Plain nullish-coalescing treats "property absent" and "property present but undefined" identically, which is what `IBaseWidget`'s own `serialize?: boolean` already implies — there's no semantic difference meant between the two: ```ts const serialize = widget?.serialize ?? stored?.serialize ``` Added `uses the store serialize flag when a projected widget leaves it undefined` (mirrors the omits-it/delete case already in the suite, but via explicit `undefined` assignment). Full `docOpMinter.test.ts` suite passes (46/46). --------- (cherry picked from commit 8087274)
c09faf7 to
d01cc40
Compare
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Backport review at exact head d01cc40b59eebc6c36c36001e4029046f93f8172 under the standing 1.55 release authority:
- Source #20027 / merge
8087274262252ede1ce04756b1e88a0281b8c6eb: all five changed files are carried. - Target delta is limited to
cloud/1.55already containing the serialize fallback/test and using its older telemetry call shape. - Repaired the conflict artifact that removed
streamProgressbut left one call; exact-headtypecheck-auxnow passes. - Removed the copied AI co-author trailer via a message-only rewrite: old tree and rewritten tree both
e06aba0bcfec396861bfcb49e3a65f4ae540ea3c. - Local:
docOpMinter.test.ts46/46 andpnpm typecheck:browser. - Hosted: all five required contexts pass, affected cloud Playwright suite and
e2e-statuspass, 98 completed checks are success/neutral/skipped only. - Target-aware exact-head guard passes against
cloud/1.55@d8201ce96d443a2bbf38b5006b470563d4f896ce; no unresolved review threads or reviewer objections.
COMMENT rather than APPROVE because the authenticated account authored the carrier. This lane was instructed not to merge.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #20134 +/- ##
=============================================
Coverage ? 84.95%
=============================================
Files ? 2327
Lines ? 133486
Branches ? 36067
=============================================
Hits ? 113397
Misses ? 19727
Partials ? 362
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #20027.
Auto-backport failed on conflicts in
docOpMinter.tsanddocOpMinter.test.ts— resolved manually.Conflict resolution
cloud/1.55already carried a partial version of this fix forserializeonly (from the earlier hand-backport of #19738, #19889), but never got thetypeprecedence fix. #20027's incoming side unifies both fields into one destructuring-default construct that is a strict superset of what was already on this branch, so the resolution takes #20027's version ofisValueWidgetentirely:The test file conflict was a pure addition (the new
uses the store type when the live widget leaves it undefinedtest) with nothing to reconcile against on this branch.Verification
pnpm vitest run src/workbench/extensions/agent/crdt/docOpMinter.test.ts— 46/46 passpnpm typecheck— clean