Skip to content

[backport cloud/1.55] fix(dialog): keep modal size independent of the docked Agent panel - #20126

Merged
comfy-pr-bot merged 1 commit into
cloud/1.55from
backport-20002-to-cloud-1.55
Oct 4, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.55from
backport-20002-to-cloud-1.55

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #20002 to cloud/1.55

Automatically created by backport workflow.

…20002)

*PR Created by the Glary-Bot Agent*

---

## Summary

Dialogs no longer resize when the Agent panel is docked, and the panel
can no longer push them off the left edge of the screen
([PM-1865](https://linear.app/comfyorg/issue/PM-1865/test-forced-open-agent-panel-overlaps-the-template-pop-up-for-first)).

## Changes

- **What**: `dialogContentVariants` read `--workspace-inset-right` in
two places: every `size` variant subtracted it from `max-width`, and the
`maximized: false` variant shifted the box left by half of it. Large
dialogs pin their own `max-width`, so they got the shift without the
cap. At 1440px with a 420px panel, Templates rendered at `x = -138`,
clipped on the left and still over the panel.
- Size variants now resolve against the viewport alone (`sm:max-w-96 /
xl / 3xl / 5xl`, the same 24/36/48/64rem), and the four call sites that
only used the inset to shrink drop it.
- The shift is clamped:
`translate-x-[max(calc(min(0.5rem,100vw-100%)-50vw),calc(-50%-var(--workspace-inset-right,0px)/2))]`.
A dialog keeps its size. It centres beside the panel when it fits there;
otherwise it stops at the viewport gutter and covers the panel.
`min(0.5rem,100vw-100%)` lets a viewport-wide dialog sit at `x = 0`.
- The offset stays on `translate`: the `zoom-in-95` keyframes write
`transform`, so an offset there would animate in from off screen.
- `HUG_CONTENT_CLASS` and `SELF_STYLED_PANEL_CONTENT_CLASS` move next to
`dialogContentVariants`, because the asset browser's class became
identical to the latter. The share dialog drops a `sm:max-w-xl` that
repeated the default `md` size.
- **Breaking**: no API change; deliberate behaviour change below.

## Review Focus

1. Dialogs may now cover the docked panel instead of shrinking beside
it. Keeping a dialog's size and keeping it on screen cannot both clear
the panel once `dialogWidth > viewportWidth - panelWidth`. Stacking
holds today: the docked panel is `relative` with no z-index, and
`DialogContent` is `fixed z-1700`.
2. Two places keep the opposite policy. `load3dViewerDialog.ts` stays
inset-aware (#19729; `load3dAgentUpdate.spec.ts` asserts the viewer
clears the panel), and its own `max-w` keeps it on the centring branch
of the clamp. #19972 would make Settings inset-aware too, and its
centering unit test expects an inset-aware `left-*` class that this PR
replaces with `left-1/2`, so whichever merges second fails that test.
3. With no panel (inset 0) the clamp resolves to `-50%` for every width
the base `w-[calc(100vw-1rem)]` allows, so layout without a panel is
unchanged.

- Fixes PM-1865

## Testing

`browser_tests/tests/dialogs/dialogAgentPanelInset.spec.ts` opens real
dialogs, publishes a 420px inset (the seam `toastNotifications.spec.ts`
uses), and asserts that the box keeps its size and lands at a literal x:

| Dialog | Viewport | x | On `main` |
| --- | --- | --- | --- |
| Templates | 1440 | 8 (covers the panel from the gutter) | fails, x =
-138 |
| Templates | 1920 | 50 (centred beside the panel) | passes; fails if
the floor always wins |
| `md` confirm | 640 | 8, width kept at 576 | fails, width shrinks |

Real-dialog coverage for the entrance animation, the viewport-wide
survey dialog, and stacking over the real panel is tracked in
[FE-3198](https://linear.app/comfyorg/issue/FE-3198/playwright-coverage-of-real-dialogs-under-the-docked-agent-panel).

## Screenshots

Simulated 420px docked panel on the right.

![Before, 800px: the md confirm dialog shrinks to 364px beside the
panel](https://ampcode.com/user-content/artifacts/1feb3727405cf5cdee49c7a3fee573c63041b807be36abd3d15d423ed83f544e-file.png)

![After, 800px: the md confirm dialog keeps its 576px width and covers
the
panel](https://ampcode.com/user-content/artifacts/29918fc605682403bae96f34a7d7570b92179509024d5affed316a46876ffa9a-file.png)

![Before, 1440px: Templates is pushed off the left edge while still
overlapping the
panel](https://pub-1fd11710d4c8405b948c9edc4287a3f2.r2.dev/sessions/9b31e98ca7e309acb186c020df5f79286b2ad7800e7ff65a16b54c3b9b9a5647/pr-images/1791018575552-a0d8ecac-c906-4836-a59a-1f0ce6127b44.png)

![After, 1440px: Templates keeps its size, sits at the 8px gutter, and
covers the
panel](https://pub-1fd11710d4c8405b948c9edc4287a3f2.r2.dev/sessions/9b31e98ca7e309acb186c020df5f79286b2ad7800e7ff65a16b54c3b9b9a5647/pr-images/1791018575903-2fadafcf-5e68-409d-859e-bf4d98bbdabd.png)

![After, 1920px: Templates keeps its size and centres beside the
panel](https://pub-1fd11710d4c8405b948c9edc4287a3f2.r2.dev/sessions/9b31e98ca7e309acb186c020df5f79286b2ad7800e7ff65a16b54c3b9b9a5647/pr-images/1791018576205-5f41a1ee-bf6f-41c8-b753-a553eea441d6.png)

---------

Co-authored-by: Glary Bot <bot@comfy.org>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Oct 4, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) October 4, 2026 20:47
@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/04/2026, 08:49:38 PM UTC

Links

🎭 Playwright: ✅ 2153 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2132 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 8be57bd3feadd7356a28bfa0608c912dc3936729

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 588ms TBT · 96.6 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 225ms TBT · 87.3 MB heap
extension-clean-combined-draw: · 51.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1482ms TBT · 73.3 MB heap
extension-rgthree-prototype-draw: · 50.0 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1062ms TBT · 86.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 139ms TBT · 81.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.4 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 178.9 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 23ms TBT · 176.4 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 437ms TBT · 171.5 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 178.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 446ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 63.9 MB
canvas-idle: DOM nodes -261
canvas-idle: event listeners -152
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 0ms
canvas-mouse-sweep: style recalc duration 15ms
canvas-mouse-sweep: layout count 0
canvas-mouse-sweep: style recalc count 46
canvas-mouse-sweep: task duration 688ms
canvas-mouse-sweep: script duration 156ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.6 MB
canvas-mouse-sweep: DOM nodes -259
canvas-mouse-sweep: event listeners -152
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 328ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 68.5 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 449ms
dom-widget-clipping: script duration 168ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 70.5 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 851ms
dom-widget-order-dense-n200-w200-i120: script duration 66ms
dom-widget-order-dense-n200-w200-i120: TBT 588ms
dom-widget-order-dense-n200-w200-i120: heap used 96.6 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -295
dom-widget-order-dense-n200-w200-i120: event listeners -206
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 465ms
dom-widget-order-sparse-n1000-w20-i120: script duration 163ms
dom-widget-order-sparse-n1000-w20-i120: TBT 225ms
dom-widget-order-sparse-n1000-w20-i120: heap used 87.3 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 19ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9593ms
extension-clean-combined-draw: script duration 8166ms
extension-clean-combined-draw: TBT 1482ms
extension-clean-combined-draw: heap used 73.3 MB
extension-clean-combined-draw: DOM nodes -136
extension-clean-combined-draw: event listeners -87
extension-rgthree-prototype-draw: avg frame time 20ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 1
extension-rgthree-prototype-draw: task duration 9363ms
extension-rgthree-prototype-draw: script duration 7873ms
extension-rgthree-prototype-draw: TBT 1062ms
extension-rgthree-prototype-draw: heap used 86.8 MB
extension-rgthree-prototype-draw: DOM nodes -142
extension-rgthree-prototype-draw: event listeners -87
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 542ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 66.4 MB
large-graph-idle: DOM nodes -250
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1569ms
large-graph-pan: script duration 842ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 74.9 MB
large-graph-pan: DOM nodes -248
large-graph-pan: event listeners -163
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 69
large-graph-zoom: task duration 1632ms
large-graph-zoom: script duration 800ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 63.0 MB
large-graph-zoom: DOM nodes -97
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1881ms
legacy-node-drag: script duration 1000ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 72.7 MB
legacy-node-drag: DOM nodes -131
legacy-node-drag: event listeners 4
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 515ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 69.9 MB
minimap-idle: DOM nodes -247
minimap-idle: event listeners -152
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 394ms
subgraph-dom-widget-clipping: script duration 144ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 80.1 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 455ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.0 MB
subgraph-idle: DOM nodes -276
subgraph-idle: event listeners -209
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 0ms
subgraph-mouse-sweep: style recalc duration 14ms
subgraph-mouse-sweep: layout count 0
subgraph-mouse-sweep: style recalc count 46
subgraph-mouse-sweep: task duration 730ms
subgraph-mouse-sweep: script duration 104ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 71.9 MB
subgraph-mouse-sweep: DOM nodes -273
subgraph-mouse-sweep: event listeners -198
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 16
subgraph-transition-enter: task duration 896ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 139ms
subgraph-transition-enter: heap used 81.3 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 5308ms
viewport-pan-sweep: script duration 2809ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 86.4 MB
viewport-pan-sweep: DOM nodes -248
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16419ms
vue-large-graph-idle: script duration 269ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 178.9 MB
vue-large-graph-idle: DOM nodes -8061
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 14ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 122
vue-large-graph-pan: task duration 17558ms
vue-large-graph-pan: script duration 866ms
vue-large-graph-pan: TBT 23ms
vue-large-graph-pan: heap used 176.4 MB
vue-large-graph-pan: DOM nodes -8061
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 80ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5993ms
vue-node-resize-workload: script duration 108ms
vue-node-resize-workload: TBT 437ms
vue-node-resize-workload: heap used 171.5 MB
vue-node-resize-workload: DOM nodes -8061
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8192ms
vue-zoom-out-idle: script duration 137ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 178.6 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 4
workflow-execution: style recalc count 8
workflow-execution: task duration 87ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 66.5 MB
workflow-execution: DOM nodes 131
workflow-execution: event listeners 25
Raw data
{
  "timestamp": "2026-10-04T21:01:17.069Z",
  "gitSha": "bac04ddb52207a0c54b134e03a42dd509cbe314c",
  "branch": "backport-20002-to-cloud-1.55",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 1991.529000000014,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.001999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 440.264,
      "heapDeltaBytes": -8756280,
      "heapUsedBytes": 59996440,
      "domNodes": -259,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.28,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2020.9670000000415,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 451.891,
      "heapDeltaBytes": 4771700,
      "heapUsedBytes": 73942896,
      "domNodes": -262,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.567000000000002,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1700.9180000000015,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 15.388,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 691.691,
      "heapDeltaBytes": 2103948,
      "heapUsedBytes": 71188156,
      "domNodes": -258,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 155.408,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1708.8920000001053,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 14.465000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 684.3130000000001,
      "heapDeltaBytes": -8944528,
      "heapUsedBytes": 60038556,
      "domNodes": -260,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 157.17600000000002,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.0609999999729,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.436,
      "layouts": 6,
      "layoutDurationMs": 1.0880000000000003,
      "taskDurationMs": 332.83399999999995,
      "heapDeltaBytes": 2862876,
      "heapUsedBytes": 71739196,
      "domNodes": 79,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.551000000000002,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.7900000000318,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.293999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.136,
      "taskDurationMs": 323.541,
      "heapDeltaBytes": 2993644,
      "heapUsedBytes": 71885548,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.71,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 615.0099999999838,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 8.459000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 446.19100000000003,
      "heapDeltaBytes": -7901004,
      "heapUsedBytes": 61087860,
      "domNodes": 18,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 167.73000000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 624.3130000000292,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 7.535,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 451.712,
      "heapDeltaBytes": 17771744,
      "heapUsedBytes": 86695992,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 168.84799999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1209.8849999999857,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 826.6650000000001,
      "heapDeltaBytes": 30086284,
      "heapUsedBytes": 101356580,
      "domNodes": -296,
      "jsHeapTotalBytes": 16666624,
      "scriptDurationMs": 63.027999999999984,
      "eventListeners": -195,
      "totalBlockingTimeMs": 589,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1205.9850000000552,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 874.572,
      "heapDeltaBytes": 29930120,
      "heapUsedBytes": 101236260,
      "domNodes": -293,
      "jsHeapTotalBytes": 16404480,
      "scriptDurationMs": 69.29000000000002,
      "eventListeners": -217,
      "totalBlockingTimeMs": 586,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 845.045999999968,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.3659999999998,
      "heapDeltaBytes": 15248584,
      "heapUsedBytes": 92370092,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 158.49200000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 223,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 844.9990000000298,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 470.7340000000002,
      "heapDeltaBytes": 15217456,
      "heapUsedBytes": 90765852,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 166.727,
      "eventListeners": 0,
      "totalBlockingTimeMs": 226,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 11085.459000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10175.657,
      "heapDeltaBytes": 6029668,
      "heapUsedBytes": 84873596,
      "domNodes": -271,
      "jsHeapTotalBytes": 3923968,
      "scriptDurationMs": 8550.711,
      "eventListeners": -174,
      "totalBlockingTimeMs": 1656,
      "frameDurationMs": 18.890000000000025,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9982.008000000063,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9009.844,
      "heapDeltaBytes": -6253892,
      "heapUsedBytes": 68764944,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 7781.728,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1308,
      "frameDurationMs": 19.996666666666655,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10234.694999999989,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9351.555,
      "heapDeltaBytes": 3292200,
      "heapUsedBytes": 84706984,
      "domNodes": -16,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 7874.572,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1056,
      "frameDurationMs": 20,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10233.756000000085,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.12900000000000064,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9374.279,
      "heapDeltaBytes": 18269800,
      "heapUsedBytes": 97278700,
      "domNodes": -268,
      "jsHeapTotalBytes": -270336,
      "scriptDurationMs": 7870.664,
      "eventListeners": -174,
      "totalBlockingTimeMs": 1067,
      "frameDurationMs": 20,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.3070000000275,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 578.7760000000001,
      "heapDeltaBytes": -23226920,
      "heapUsedBytes": 66404476,
      "domNodes": -257,
      "jsHeapTotalBytes": 4222976,
      "scriptDurationMs": 35.758,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2023.1759999999213,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.287999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 505.62399999999997,
      "heapDeltaBytes": -16427648,
      "heapUsedBytes": 72908680,
      "domNodes": -242,
      "jsHeapTotalBytes": -1019904,
      "scriptDurationMs": 34.098000000000006,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2209.373000000028,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 11.606000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1546.348,
      "heapDeltaBytes": 1194212,
      "heapUsedBytes": 65300924,
      "domNodes": -247,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 842.113,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2191.2509999999656,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 13.921999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1591.4420000000002,
      "heapDeltaBytes": 1271244,
      "heapUsedBytes": 91752584,
      "domNodes": -248,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 840.98,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3513.787999999977,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.233,
      "layouts": 60,
      "layoutDurationMs": 12.999,
      "taskDurationMs": 1624.0769999999998,
      "heapDeltaBytes": -1119032,
      "heapUsedBytes": 65290152,
      "domNodes": 28,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 795.802,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3545.2660000000833,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 13.956,
      "layouts": 60,
      "layoutDurationMs": 12.828000000000001,
      "taskDurationMs": 1639.974,
      "heapDeltaBytes": 1719380,
      "heapUsedBytes": 66844584,
      "domNodes": -222,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 804.9,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3210.5250000000183,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.943,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1947.96,
      "heapDeltaBytes": -10440900,
      "heapUsedBytes": 82436476,
      "domNodes": -267,
      "jsHeapTotalBytes": 7786496,
      "scriptDurationMs": 1018.807,
      "eventListeners": -173,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2987.3770000000377,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 6.330000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1814.4360000000001,
      "heapDeltaBytes": 3964920,
      "heapUsedBytes": 70069128,
      "domNodes": 6,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 980.8350000000002,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2018.6499999999796,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.575,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 502.541,
      "heapDeltaBytes": -16247192,
      "heapUsedBytes": 74157740,
      "domNodes": -246,
      "jsHeapTotalBytes": -1544192,
      "scriptDurationMs": 33.69,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.0739999999423,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.300000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 526.782,
      "heapDeltaBytes": -18985324,
      "heapUsedBytes": 72449484,
      "domNodes": -248,
      "jsHeapTotalBytes": -1019904,
      "scriptDurationMs": 32.73499999999999,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 584.0039999999931,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.482000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 399.81500000000005,
      "heapDeltaBytes": 13218984,
      "heapUsedBytes": 83954448,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 145.91199999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 545.3630000000658,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.051000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 387.40900000000005,
      "heapDeltaBytes": 12945460,
      "heapUsedBytes": 83973536,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 141.132,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.3840000000255,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.788000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 447.291,
      "heapDeltaBytes": 8292156,
      "heapUsedBytes": 79219752,
      "domNodes": -278,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 6.887999999999998,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1993.0369999999584,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 10.034999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 462.058,
      "heapDeltaBytes": -9037140,
      "heapUsedBytes": 61388972,
      "domNodes": -273,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.115,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1721.8860000000404,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 14.186,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 730.758,
      "heapDeltaBytes": 5466064,
      "heapUsedBytes": 76156368,
      "domNodes": -274,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 103.43100000000001,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1719.5670000000973,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 14.798,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 728.7280000000001,
      "heapDeltaBytes": 3761360,
      "heapUsedBytes": 74701912,
      "domNodes": -272,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 104.66300000000001,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1368.0100000000266,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 29.008000000000006,
      "layouts": 5,
      "layoutDurationMs": 12.999,
      "taskDurationMs": 896.0659999999998,
      "heapDeltaBytes": -6485904,
      "heapUsedBytes": 85282808,
      "domNodes": 13667,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 32.973,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 139,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8378.22200000005,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 38.079,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5679.264,
      "heapDeltaBytes": 4005404,
      "heapUsedBytes": 92638812,
      "domNodes": -246,
      "jsHeapTotalBytes": 1531904,
      "scriptDurationMs": 2848.228,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8246.897999999986,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 38.9,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4936.15,
      "heapDeltaBytes": -837592,
      "heapUsedBytes": 88560884,
      "domNodes": -250,
      "jsHeapTotalBytes": 4939776,
      "scriptDurationMs": 2769.549,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16926.255000000026,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16439.93,
      "heapDeltaBytes": -62527452,
      "heapUsedBytes": 178755380,
      "domNodes": -8061,
      "jsHeapTotalBytes": -17764352,
      "scriptDurationMs": 252.03400000000005,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16888.147000000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16398.307000000004,
      "heapDeltaBytes": -44033568,
      "heapUsedBytes": 196331576,
      "domNodes": -8061,
      "jsHeapTotalBytes": -19116032,
      "scriptDurationMs": 285.003,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15819.77599999999,
      "styleRecalcs": 83,
      "styleRecalcDurationMs": 12.186999999999976,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15284.869,
      "heapDeltaBytes": -51196852,
      "heapUsedBytes": 188742296,
      "domNodes": -8061,
      "jsHeapTotalBytes": -16302080,
      "scriptDurationMs": 856.298,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 8,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20177.418999999987,
      "styleRecalcs": 160,
      "styleRecalcDurationMs": 15.842999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19831.843,
      "heapDeltaBytes": -46581076,
      "heapUsedBytes": 181185868,
      "domNodes": -8061,
      "jsHeapTotalBytes": -19337216,
      "scriptDurationMs": 875.761,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 37,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6021.853999999962,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.37500000000003,
      "layouts": 20,
      "layoutDurationMs": 23.544999999999998,
      "taskDurationMs": 5957.151,
      "heapDeltaBytes": -63871832,
      "heapUsedBytes": 176259316,
      "domNodes": -8061,
      "jsHeapTotalBytes": 12341248,
      "scriptDurationMs": 106.61499999999998,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 481,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6082.207000000039,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.60900000000001,
      "layouts": 20,
      "layoutDurationMs": 23.369,
      "taskDurationMs": 6029.177,
      "heapDeltaBytes": -50902708,
      "heapUsedBytes": 183436228,
      "domNodes": -8061,
      "jsHeapTotalBytes": 18075648,
      "scriptDurationMs": 108.523,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 393,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8344.079999999962,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8166.712,
      "heapDeltaBytes": -87512,
      "heapUsedBytes": 191327616,
      "domNodes": 0,
      "jsHeapTotalBytes": -12845056,
      "scriptDurationMs": 126.97999999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8476.020000000062,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8216.662000000002,
      "heapDeltaBytes": -10133764,
      "heapUsedBytes": 183122124,
      "domNodes": 0,
      "jsHeapTotalBytes": -25690112,
      "scriptDurationMs": 147.36700000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 128.16499999996722,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 19.244999999999997,
      "layouts": 4,
      "layoutDurationMs": 2.0300000000000002,
      "taskDurationMs": 97.463,
      "heapDeltaBytes": 3301692,
      "heapUsedBytes": 69779428,
      "domNodes": 136,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 12.313999999999998,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 104.6840000000202,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 15.033,
      "layouts": 3,
      "layoutDurationMs": 1.6160000000000003,
      "taskDurationMs": 75.701,
      "heapDeltaBytes": 3004376,
      "heapUsedBytes": 69635300,
      "domNodes": 126,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 6.201000000000001,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52824 79935 66.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.9% 1183
src/LGraphNode.ts 70.6% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/platform/workspace/stores/billingOperationStore.ts 8.0% 332
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/LGraph.ts 78.9% 273
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/scripts/app.ts 73.2% 254
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/pnginfo.ts 20.7% 222

@github-actions
github-actions Bot requested a review from ryan-di October 4, 2026 20:48
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 4, 2026
@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Playwright videos for new tests

Download the recorded videos and HTML report

Recorded projects: chromium

Recorded test titles:

  • all tests in browser_tests/tests/dialogs/dialogAgentPanelInset.spec.ts

@codecov

codecov Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.55   #20126   +/-   ##
=============================================
  Coverage              ?   84.94%           
=============================================
  Files                 ?     2327           
  Lines                 ?   133482           
  Branches              ?    36066           
=============================================
  Hits                  ?   113391           
  Misses                ?    19729           
  Partials              ?      362           
Flag Coverage Δ
e2e 66.12% <100.00%> (?)
unit 81.06% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/ui/dialog/dialog.variants.ts 100.00% <100.00%> (ø)
...atform/assets/composables/useAssetBrowserDialog.ts 100.00% <ø> (ø)
...orm/workflow/sharing/composables/useShareDialog.ts 0.00% <ø> (ø)
src/services/dialogService.ts 71.51% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head cf89f7d for cloud/1.55. The complete six-file patch has stable patch-id 39f5d763cc4e6ed366fed71caacbb1510d04b13f, identical to merged source squash 209054f (#20002). It preserves the black-box dialog/Agent-panel coverage, is conflict-free, and has no unresolved review threads or target-specific divergence.

@comfy-pr-bot
comfy-pr-bot merged commit 84b39e7 into cloud/1.55 Oct 4, 2026
144 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-20002-to-cloud-1.55 branch October 4, 2026 21:16

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 5 finding(s).

Severity Count
🟡 Medium 1
🟢 Low 2
⚪ Nit 2

Panel: 8/8 reviewers contributed findings.

md: 'sm:max-w-xl',
lg: 'sm:max-w-3xl',
xl: 'sm:max-w-5xl',
full: 'sm:max-w-[calc(100vw-1rem)]'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — Dropping the inset from the full cap means a full-size dialog is now 100vw - 1rem wide, which is wider than the space left of a docked panel, so the new translate-x clamps it to the 8px gutter and it renders straight over the panel instead of shrinking to fit beside it. The Load3D viewer is the concrete case: LOAD3D_VIEWER_CONTENT_CLASS carries only an unprefixed inset-aware max-w, so above sm this variant's sm:max-w-[calc(100vw-1rem)] wins and the viewer sits at a full 80vw overlapping the panel (≈140px at a 1440px viewport with a 420px panel); its guard test runs at 500px, below sm, so it stays green. Keep calc(100vw-var(--workspace-inset-right,0px)-1rem) for full, or clamp the width rather than only the offset. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

true: 'inset-2 top-2 left-2 size-auto max-h-none max-w-none sm:max-w-none',
false:
'top-1/2 left-[calc(50%-var(--workspace-inset-right,0px)/2)] max-h-[85vh] w-[calc(100vw-1rem)] -translate-1/2'
'top-1/2 left-1/2 max-h-[85vh] w-[calc(100vw-1rem)] translate-x-[max(calc(min(0.5rem,100vw-100%)-50vw),calc(-50%-var(--workspace-inset-right,0px)/2))] -translate-y-1/2'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — Moving the inset offset from left into translate-x turns the left-1/2 in four untouched call sites (src/services/hdrViewerService.ts, AssetsSidebarTab.vue, JobHistorySidebarTab.vue, ReplyAssetGroup.vue) into a no-op dedupe of the variant's own class — those classes only ever existed to override the old left-[calc(50%-var(--workspace-inset-right,0px)/2)]. Those media viewers now pick up the inset shift and gutter clamp they previously opted out of, and there is no longer any class a caller can pass to opt out. Either delete the dead left-1/2 overrides deliberately or keep an opt-out hook. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).


await page.evaluate(
({ property, panelWidth }) => {
document.documentElement.style.setProperty(property, `${panelWidth}px`)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — The fixture sets --workspace-inset-right directly on document.documentElement — the property publishCurrentInset() in src/composables/useWorkspaceInset.ts owns exclusively — and never restores it. Any publisher that mounts, updates, or disposes during the toHaveBounds retry window will setProperty/removeProperty over the simulated value and snap the dialog mid-assertion, and because the real publisher path is never exercised these tests stay green if DockedAgentPanel stops publishing or publishes a stale width. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

}

test.describe('at the sm breakpoint', () => {
test.use({ viewport: { width: 640, height: 800 } })

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Nit — A 640px viewport sits exactly on the sm breakpoint, and the assertion cannot tell whether the size variant applied: width/height/y come from the pre-change measurement and only x is checked against a literal, which is 8 either way. Pick a width comfortably above 640px so the test actually exercises the sm:max-w-* variant it is named for. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

lg: 'sm:max-w-[min(48rem,calc(100vw-var(--workspace-inset-right,0px)-1rem))]',
xl: 'sm:max-w-[min(64rem,calc(100vw-var(--workspace-inset-right,0px)-1rem))]',
full: 'sm:max-w-[calc(100vw-var(--workspace-inset-right,0px)-1rem)]'
sm: 'sm:max-w-96',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Nit — sm:max-w-96 is a numeric spacing token that tailwind-merge v2's max-w group does not recognise (it matches keywords, t-shirt sizes, and arbitrary values only), so a caller's conflicting sm:max-w-* will no longer be deduped against it and CSS source order picks the winner — the old arbitrary value merged correctly. sm:max-w-sm is the same 24rem and keeps the merge working; the other four sizes use t-shirt tokens and are fine. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants