Repository navigation
test(agent): pin queued node across tab switch - #20053
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (4)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThe browser test adds a pinned-catalog barrier node, holds human operations while adding a Note, and switches tabs before host acknowledgements. It checks the Note in live and serialized state, then verifies host delivery after the queued operations are released. ChangesHuman Add and Tab Switch
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk is identified; the change is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-04T01:28:22.020Z",
"gitSha": "691493581f9a295df64660bb96acc5343262b915",
"branch": "op406-fe20051-harnessadapt",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2014.6260000000211,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.051999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.923,
"heapDeltaBytes": 293656,
"heapUsedBytes": 67440848,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.924000000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2017.0209999999997,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.3240000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.683,
"heapDeltaBytes": 543352,
"heapUsedBytes": 68253120,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.165999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1874.9650000000315,
"styleRecalcs": 54,
"styleRecalcDurationMs": 18.021,
"layouts": 12,
"layoutDurationMs": 4.8469999999999995,
"taskDurationMs": 840.583,
"heapDeltaBytes": -30149288,
"heapUsedBytes": 72706400,
"domNodes": -232,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 144.558,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571424,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1792.1420000000126,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.559,
"layouts": 12,
"layoutDurationMs": 4.22,
"taskDurationMs": 810.0540000000001,
"heapDeltaBytes": -2579988,
"heapUsedBytes": 64728900,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 151.42600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1703.3729999999991,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.489,
"layouts": 6,
"layoutDurationMs": 1.4469999999999998,
"taskDurationMs": 365.213,
"heapDeltaBytes": 25635404,
"heapUsedBytes": 79068428,
"domNodes": -178,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.177999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1732.486999999992,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.334,
"layouts": 6,
"layoutDurationMs": 1.099,
"taskDurationMs": 423.538,
"heapDeltaBytes": -24877860,
"heapUsedBytes": 78857348,
"domNodes": -179,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 17.897,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 686.1099999999851,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.6619999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.408,
"heapDeltaBytes": 15266656,
"heapUsedBytes": 69599016,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.10800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66341463414634,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 708.7969999998904,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.5590000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.60699999999997,
"heapDeltaBytes": 13925956,
"heapUsedBytes": 67835660,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.11100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1144.4480000000112,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 813.729,
"heapDeltaBytes": 38714708,
"heapUsedBytes": 108879032,
"domNodes": 0,
"jsHeapTotalBytes": 6717440,
"scriptDurationMs": 64.68300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 524,
"frameDurationMs": 33.82058823529413,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1154.7140000000127,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 826.268,
"heapDeltaBytes": 15376744,
"heapUsedBytes": 84723564,
"domNodes": 0,
"jsHeapTotalBytes": 6455296,
"scriptDurationMs": 58.23299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 530,
"frameDurationMs": 34.84848484848485,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 812.3479999999859,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.75900000000024,
"heapDeltaBytes": 17389708,
"heapUsedBytes": 104823068,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 142.357,
"eventListeners": 0,
"totalBlockingTimeMs": 184,
"frameDurationMs": 24.017647058823513,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 814.734000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.6270000000002,
"heapDeltaBytes": 17098180,
"heapUsedBytes": 104345892,
"domNodes": 0,
"jsHeapTotalBytes": 1839104,
"scriptDurationMs": 134.49,
"eventListeners": 0,
"totalBlockingTimeMs": 184,
"frameDurationMs": 24.020588235294113,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9533.578000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8647.627,
"heapDeltaBytes": -12542000,
"heapUsedBytes": 68118356,
"domNodes": 0,
"jsHeapTotalBytes": -8388608,
"scriptDurationMs": 6963.83,
"eventListeners": 0,
"totalBlockingTimeMs": 728,
"frameDurationMs": 34.108602150537635,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8194.291000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7560.562,
"heapDeltaBytes": 4205896,
"heapUsedBytes": 83913468,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 5961.713,
"eventListeners": 0,
"totalBlockingTimeMs": 129,
"frameDurationMs": 31.114448669201522,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8530.408000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7783.1630000000005,
"heapDeltaBytes": -9302920,
"heapUsedBytes": 71914272,
"domNodes": 0,
"jsHeapTotalBytes": -9961472,
"scriptDurationMs": 6165.24,
"eventListeners": 0,
"totalBlockingTimeMs": 255,
"frameDurationMs": 32.381368821292774,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8163.4840000000395,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7531.399,
"heapDeltaBytes": -8752112,
"heapUsedBytes": 71074084,
"domNodes": 0,
"jsHeapTotalBytes": -17825792,
"scriptDurationMs": 5930.566,
"eventListeners": 0,
"totalBlockingTimeMs": 121,
"frameDurationMs": 30.70037593984962,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "large-graph-idle",
"durationMs": 2025.761999999986,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.032999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.006,
"heapDeltaBytes": -53557284,
"heapUsedBytes": 72521780,
"domNodes": -328,
"jsHeapTotalBytes": -4292608,
"scriptDurationMs": 30.385999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2052.371999999991,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.122,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.929,
"heapDeltaBytes": -52908260,
"heapUsedBytes": 72674488,
"domNodes": -328,
"jsHeapTotalBytes": -2457600,
"scriptDurationMs": 32.997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.80327868852459,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2838.4430000000407,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.034,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1639.6670000000001,
"heapDeltaBytes": -15790752,
"heapUsedBytes": 69916744,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 843.985,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665882352941175,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2833.219999999983,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.190999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1634.9619999999998,
"heapDeltaBytes": -18986840,
"heapUsedBytes": 70544216,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 830.555,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665882352941175,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3787.0770000000107,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.386,
"layouts": 60,
"layoutDurationMs": 14.284,
"taskDurationMs": 1682.9869999999999,
"heapDeltaBytes": -20601720,
"heapUsedBytes": 69739084,
"domNodes": 24,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 777.3520000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3976.953000000094,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.727,
"layouts": 60,
"layoutDurationMs": 14.681999999999999,
"taskDurationMs": 1734.893,
"heapDeltaBytes": -20547268,
"heapUsedBytes": 69260768,
"domNodes": 24,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 792.0390000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666108786610877,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3095.331999999985,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.768,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1930.7759999999998,
"heapDeltaBytes": 6106852,
"heapUsedBytes": 70451216,
"domNodes": -328,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 938.2869999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756521739130434,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3159.6009999999524,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.056,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1992.9370000000001,
"heapDeltaBytes": 9044000,
"heapUsedBytes": 77827472,
"domNodes": 0,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 1021.2280000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.754255319148935,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.435000000025,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.8759999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.3660000000001,
"heapDeltaBytes": -10493332,
"heapUsedBytes": 79333812,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 32.00699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2026.358000000073,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.3899999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.8009999999999,
"heapDeltaBytes": -26947828,
"heapUsedBytes": 72880820,
"domNodes": -328,
"jsHeapTotalBytes": -3805184,
"scriptDurationMs": 37.993,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 629.9070000000029,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.507999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.51200000000006,
"heapDeltaBytes": -11570368,
"heapUsedBytes": 57857696,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 139.26100000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 658.5469999999987,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.257999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.84900000000005,
"heapDeltaBytes": 8890480,
"heapUsedBytes": 63098180,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 147.06900000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2009.051999999997,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1489999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.77299999999997,
"heapDeltaBytes": 22008396,
"heapUsedBytes": 76603656,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.061999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2037.431999999967,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.81600000000003,
"heapDeltaBytes": -29186348,
"heapUsedBytes": 75472584,
"domNodes": -249,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 11.223,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66475409836066,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.4620000000227,
"styleRecalcs": 80,
"styleRecalcDurationMs": 17.636,
"layouts": 16,
"layoutDurationMs": 5.748,
"taskDurationMs": 814.986,
"heapDeltaBytes": -38108852,
"heapUsedBytes": 68848560,
"domNodes": -269,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 104.667,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.2739999999703,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.122,
"layouts": 16,
"layoutDurationMs": 6.188000000000001,
"taskDurationMs": 803.959,
"heapDeltaBytes": 15003520,
"heapUsedBytes": 69298376,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 107.12200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.5350000000085,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.64099999999999,
"layouts": 5,
"layoutDurationMs": 11.22,
"taskDurationMs": 870.1070000000002,
"heapDeltaBytes": 23894864,
"heapUsedBytes": 109317976,
"domNodes": 13747,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 27.846999999999998,
"eventListeners": 2383,
"totalBlockingTimeMs": 120,
"frameDurationMs": 18.949315068493142,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9021.074999999997,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.812,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5745.061,
"heapDeltaBytes": -60976212,
"heapUsedBytes": 64435812,
"domNodes": -328,
"jsHeapTotalBytes": -3244032,
"scriptDurationMs": 2693.146,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.727829313543598,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9350.904000000013,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.167,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5755.602000000001,
"heapDeltaBytes": -33608568,
"heapUsedBytes": 64130172,
"domNodes": -328,
"jsHeapTotalBytes": -2494464,
"scriptDurationMs": 2691.5209999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10559.078999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10143.827,
"heapDeltaBytes": -39187432,
"heapUsedBytes": 171878924,
"domNodes": -3045,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 176.112,
"eventListeners": -14914,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.064383561643833,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 15709.73700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15209.567,
"heapDeltaBytes": -43559428,
"heapUsedBytes": 184317124,
"domNodes": -3045,
"jsHeapTotalBytes": 4333568,
"scriptDurationMs": 252.68600000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.753479853479856,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 18560.562000000005,
"styleRecalcs": 136,
"styleRecalcDurationMs": 17.769999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18277.6,
"heapDeltaBytes": -9749388,
"heapUsedBytes": 193744336,
"domNodes": -3045,
"jsHeapTotalBytes": 8327168,
"scriptDurationMs": 880.1410000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 59,
"frameDurationMs": 35.332,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18585.146000000008,
"styleRecalcs": 132,
"styleRecalcDurationMs": 17.589999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18276.224000000002,
"heapDeltaBytes": -26975060,
"heapUsedBytes": 182624888,
"domNodes": -3045,
"jsHeapTotalBytes": 9228288,
"scriptDurationMs": 836.428,
"eventListeners": -14915,
"totalBlockingTimeMs": 8,
"frameDurationMs": 34.92951127819549,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5571.7080000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.528,
"layouts": 20,
"layoutDurationMs": 25.154999999999998,
"taskDurationMs": 5482.581999999999,
"heapDeltaBytes": 879728,
"heapUsedBytes": 209018468,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 96.051,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.36049382716049,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5587.2020000000475,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.39500000000002,
"layouts": 20,
"layoutDurationMs": 25.326999999999988,
"taskDurationMs": 5497.396,
"heapDeltaBytes": 7589328,
"heapUsedBytes": 211769160,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 101.231,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.2327380952381,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7981.019999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7689.423,
"heapDeltaBytes": -12086676,
"heapUsedBytes": 184410256,
"domNodes": -3045,
"jsHeapTotalBytes": 8728576,
"scriptDurationMs": 122.73699999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.510714285714286,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8136.7460000000165,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7752.442,
"heapDeltaBytes": -38788920,
"heapUsedBytes": 165337272,
"domNodes": -3045,
"jsHeapTotalBytes": 10756096,
"scriptDurationMs": 127.521,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.738515901060072,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 530.9589999999957,
"styleRecalcs": 20,
"styleRecalcDurationMs": 19.602,
"layouts": 3,
"layoutDurationMs": 2.217,
"taskDurationMs": 180.791,
"heapDeltaBytes": -41884836,
"heapUsedBytes": 58614716,
"domNodes": -104,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 14.309000000000001,
"eventListeners": -74,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 489.9809999999434,
"styleRecalcs": 12,
"styleRecalcDurationMs": 12.902,
"layouts": 3,
"layoutDurationMs": 0.9310000000000002,
"taskDurationMs": 135.49200000000002,
"heapDeltaBytes": 5716292,
"heapUsedBytes": 59250344,
"domNodes": -131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.704,
"eventListeners": -74,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 911.5039999999226,
"styleRecalcs": 78,
"styleRecalcDurationMs": 111.447,
"layouts": 76,
"layoutDurationMs": 26.692,
"taskDurationMs": 883.3639999999999,
"heapDeltaBytes": 17780016,
"heapUsedBytes": 83955552,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 350.687,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.97592592592592,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 960.2770000000191,
"styleRecalcs": 78,
"styleRecalcDurationMs": 106.834,
"layouts": 76,
"layoutDurationMs": 29.222,
"taskDurationMs": 937.666,
"heapDeltaBytes": 18105872,
"heapUsedBytes": 88798852,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 358.904,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1459.4079999999394,
"styleRecalcs": 78,
"styleRecalcDurationMs": 272.24199999999996,
"layouts": 76,
"layoutDurationMs": 29.872,
"taskDurationMs": 1435.752,
"heapDeltaBytes": -19461908,
"heapUsedBytes": 107642980,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 450.389,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.563291139240505,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1581.850999999915,
"styleRecalcs": 78,
"styleRecalcDurationMs": 295.01800000000003,
"layouts": 76,
"layoutDurationMs": 31.95,
"taskDurationMs": 1559.809,
"heapDeltaBytes": -18741504,
"heapUsedBytes": 110259736,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 494.913,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.308536585365843,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d348bddc595545719937913514cb386c0970a721
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2193 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20053 +/- ##
==========================================
+ Coverage 84.97% 85.70% +0.73%
==========================================
Files 3451 2423 -1028
Lines 165940 138452 -27488
Branches 43352 35523 -7829
==========================================
- Hits 141009 118662 -22347
+ Misses 22961 19414 -3547
+ Partials 1970 376 -1594
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Current-head review: no findings. I independently verified the new composition case at 182a04a4e81587e59f5e0317c131d2c52b08ad27: the full spec passed 7/7 locally, and the focused case passed after restoration. Mutation proof is non-vacuous: deleting the same-workflow inactive-tab holdOpsForInactiveTab(next) call makes the focused case fail during the tab-return subscription boundary (expected subscribe count 2, received 1). The case also observes the promised canvas state directly through the Vue node locator, live graph node set, and serialized graph both before host acceptance and after delivery, while separately asserting the host does not contain the queued node before release and does afterward. No branch changes needed; not merged.
Summary
Add black-box coverage for the visible behavior proposed by #20051: a human-added node queued behind an in-flight edit remains on the canvas across a workflow-tab switch and is eventually delivered to the host.
Changes
agentHumanAddTabSwitchspec instead of adding another follower spec. The case uses the real canvas, follower, minter, sender, held host, tab UI, and visible node assertions.Review Focus
The first widget edit is held by the fake host, so the added Note is demonstrably queued (only one
doc_opsframe). RemovingholdOpsForInactiveTabmakes the case fail because the queued node batch never resumes; restoring it makes the full 7-case spec pass.Tests:
PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_TEST_URL=http://127.0.0.1:6206 PLAYWRIGHT_SETUP_API_URL=http://127.0.0.1:8188 DISTRIBUTION=cloud pnpm exec playwright test browser_tests/tests/agent/agentHumanAddTabSwitch.spec.ts --project=cloud --retries=0